mirror of
https://github.com/ppy/osu.git
synced 2026-05-16 03:32:35 +08:00
18d4ba5874
Most of this is as everywhere else, but there's also interesting code inspection fixes from the InspectCode bump, so I'll talk about that a little. ## [Fix suspicious equality in `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d) Inspection: https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html Pretty annoying to fix, nullable array types are a pain. Does look legit though. ## [Fix `StarDifficulty` using inefficient struct equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545) Inspection: https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html This is a dodgy one because there's no real sane way to define equality on `StarDifficulty` now that it has difficulty and performance attributes jammed into it. So I just basically shut the inspection up with a `record` modifier and move on. Unclear where the equality is used precisely. It's from a global inspection. F12 is very unhelpful when trying to track down usages of `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and those do use equality. Maybe more than that. ## [Use `nameof` expressions to reference enum member names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Pretty quaint. ## [Prefer using concrete values over `default` or `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d) Inspection: https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html I could see this one going both ways, but I'm kinda sold on this inspection. Explicit is always better. Saves some allocations in the `CancellationToken` cases as well. ## [Explicitly call `.AsEnumerable()` in some realm usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401) Inspection: https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html Not fully sold on this one but it's quick and simple so might as well. ## [Simplify dictionary removal with single `.Remove()` call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Not much to say.
111 lines
4.7 KiB
C#
111 lines
4.7 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Diagnostics.CodeAnalysis;
|
|
|
|
namespace osu.Game.Rulesets.Objects.Pooling
|
|
{
|
|
/// <summary>
|
|
/// Manages a mapping between <see cref="HitObject"/> and <see cref="HitObjectLifetimeEntry"/>
|
|
/// </summary>
|
|
internal class HitObjectEntryManager
|
|
{
|
|
/// <summary>
|
|
/// All entries, including entries of the nested hit objects.
|
|
/// </summary>
|
|
public IEnumerable<HitObjectLifetimeEntry> AllEntries => entryMap.Values;
|
|
|
|
/// <summary>
|
|
/// Invoked when a new <see cref="HitObjectLifetimeEntry"/> is added to this <see cref="HitObjectEntryManager"/>..
|
|
/// The second parameter of the event is the parent hit object.
|
|
/// </summary>
|
|
public event Action<HitObjectLifetimeEntry, HitObject?>? OnEntryAdded;
|
|
|
|
/// <summary>
|
|
/// Invoked when a <see cref="HitObjectLifetimeEntry"/> is removed from this <see cref="HitObjectEntryManager"/>.
|
|
/// The second parameter of the event is the parent hit object.
|
|
/// </summary>
|
|
public event Action<HitObjectLifetimeEntry, HitObject?>? OnEntryRemoved;
|
|
|
|
/// <summary>
|
|
/// Provides the reverse mapping of <see cref="HitObjectLifetimeEntry.HitObject"/> for each entry.
|
|
/// </summary>
|
|
private readonly Dictionary<HitObject, HitObjectLifetimeEntry> entryMap = new Dictionary<HitObject, HitObjectLifetimeEntry>();
|
|
|
|
/// <summary>
|
|
/// Stores the parent hit object for entries of the nested hit objects.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The parent hit object of a pooled hit object may be non-pooled.
|
|
/// In that case, no corresponding <see cref="HitObjectLifetimeEntry"/> is stored in this <see cref="HitObjectEntryManager"/>.
|
|
/// </remarks>
|
|
private readonly Dictionary<HitObjectLifetimeEntry, HitObject> parentMap = new Dictionary<HitObjectLifetimeEntry, HitObject>();
|
|
|
|
public void Add(HitObjectLifetimeEntry entry, HitObject? parent)
|
|
{
|
|
HitObject hitObject = entry.HitObject;
|
|
|
|
if (!entryMap.TryAdd(hitObject, entry))
|
|
throw new InvalidOperationException($@"The {nameof(HitObjectLifetimeEntry)} is already added to this {nameof(HitObjectEntryManager)}.");
|
|
|
|
// If the entry has a parent, set it and add the entry to the parent's children.
|
|
if (parent != null)
|
|
{
|
|
parentMap[entry] = parent;
|
|
if (entryMap.TryGetValue(parent, out var parentEntry))
|
|
parentEntry.NestedEntries.Add(entry);
|
|
}
|
|
|
|
hitObject.DefaultsApplied += onDefaultsApplied;
|
|
OnEntryAdded?.Invoke(entry, parent);
|
|
}
|
|
|
|
public bool Remove(HitObjectLifetimeEntry entry)
|
|
{
|
|
if (entry is SyntheticHitObjectEntry)
|
|
return false;
|
|
|
|
HitObject hitObject = entry.HitObject;
|
|
|
|
if (!entryMap.Remove(hitObject))
|
|
throw new InvalidOperationException($@"The {nameof(HitObjectLifetimeEntry)} is not contained in this {nameof(HitObjectEntryManager)}.");
|
|
|
|
// If the entry has a parent, unset it and remove the entry from the parents' children.
|
|
if (parentMap.Remove(entry, out var parent) && entryMap.TryGetValue(parent, out var parentEntry))
|
|
parentEntry.NestedEntries.Remove(entry);
|
|
|
|
// Remove all the entries' children.
|
|
foreach (var childEntry in entry.NestedEntries)
|
|
Remove(childEntry);
|
|
|
|
hitObject.DefaultsApplied -= onDefaultsApplied;
|
|
OnEntryRemoved?.Invoke(entry, parent);
|
|
return true;
|
|
}
|
|
|
|
public bool TryGet(HitObject hitObject, [MaybeNullWhen(false)] out HitObjectLifetimeEntry entry)
|
|
{
|
|
return entryMap.TryGetValue(hitObject, out entry);
|
|
}
|
|
|
|
/// <summary>
|
|
/// As nested hit objects are recreated, remove entries of the old nested hit objects.
|
|
/// </summary>
|
|
private void onDefaultsApplied(HitObject hitObject)
|
|
{
|
|
if (!entryMap.TryGetValue(hitObject, out var entry))
|
|
return;
|
|
|
|
// Replace the entire list rather than clearing to prevent circular traversal later.
|
|
var previousEntries = entry.NestedEntries;
|
|
entry.NestedEntries = new List<HitObjectLifetimeEntry>();
|
|
|
|
// Remove all the entries' children. At this point the parents' (this entries') children list has been reconstructed, so this does not cause upwards traversal.
|
|
foreach (var nested in previousEntries)
|
|
Remove(nested);
|
|
}
|
|
}
|
|
}
|