mirror of
https://github.com/ppy/osu.git
synced 2026-05-13 20:33:35 +08:00
Bartłomiej Dach
1c4ecba950
This is in response to https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user is having a problem with joining multiplayer, but I have basically no diagnosing capabilities, because the logs are all 2025-03-26 18:57:57 [error]: Failed to join multiplayer room: 2025-03-26 18:58:40 [error]: Failed to join multiplayer room: 2025-03-26 18:58:41 [error]: Failed to join multiplayer room: 2025-03-26 18:58:41 [error]: Failed to join multiplayer room: which appears to originate from https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91 Now, as far as I can tell, there are two possibilities here: 1. The exception's `Message` is null or empty. That's not exactly great or typical, but sure, this could possibly happen - in which case the error logging is silently eating whatever little relevant detail there is left to use. 2. The exception is *actually* `null` itself, and we're in the X Files. This PR is intending to defend against (1). In examining the logging further, I also spotted the following issues: - In the single path that specifies a custom failure handler (which is `DrawableLoungeRoom` which handles joining a passworded room), the custom failure handler being present means that the error would be presented to the user, but it would not be logged. At all. - In playlists, if the exception for whatever reason had an empty message, an empty notification would get posted. And in general to me it feels a bit dodgy to be directly presenting exception notifications to users without any preamble, hence the added "Failed to open playlist" prefix.
33 lines
1.2 KiB
C#
33 lines
1.2 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using osu.Game.Online.Rooms;
|
|
|
|
namespace osu.Game.Screens.OnlinePlay.Lounge
|
|
{
|
|
public interface IOnlinePlayLounge
|
|
{
|
|
/// <summary>
|
|
/// Attempts to join the given room.
|
|
/// </summary>
|
|
/// <param name="room">The room to join.</param>
|
|
/// <param name="password">The password.</param>
|
|
/// <param name="onSuccess">A delegate to invoke if the user joined the room.</param>
|
|
/// <param name="onFailure">A delegate to invoke if the user is not able to join the room.</param>
|
|
void Join(Room room, string? password, Action<Room>? onSuccess = null, Action<string, Exception?>? onFailure = null);
|
|
|
|
/// <summary>
|
|
/// Copies the given room and opens it as a fresh (not-yet-created) one.
|
|
/// </summary>
|
|
/// <param name="room">The room to copy.</param>
|
|
void OpenCopy(Room room);
|
|
|
|
/// <summary>
|
|
/// Closes the given room.
|
|
/// </summary>
|
|
/// <param name="room">The room to close.</param>
|
|
void Close(Room room);
|
|
}
|
|
}
|