mirror of
https://github.com/ppy/osu.git
synced 2026-06-02 20:20:23 +08:00
1c4ecba950
This is in response to https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user is having a problem with joining multiplayer, but I have basically no diagnosing capabilities, because the logs are all 2025-03-26 18:57:57 [error]: Failed to join multiplayer room: 2025-03-26 18:58:40 [error]: Failed to join multiplayer room: 2025-03-26 18:58:41 [error]: Failed to join multiplayer room: 2025-03-26 18:58:41 [error]: Failed to join multiplayer room: which appears to originate from https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91 Now, as far as I can tell, there are two possibilities here: 1. The exception's `Message` is null or empty. That's not exactly great or typical, but sure, this could possibly happen - in which case the error logging is silently eating whatever little relevant detail there is left to use. 2. The exception is *actually* `null` itself, and we're in the X Files. This PR is intending to defend against (1). In examining the logging further, I also spotted the following issues: - In the single path that specifies a custom failure handler (which is `DrawableLoungeRoom` which handles joining a passworded room), the custom failure handler being present means that the error would be presented to the user, but it would not be logged. At all. - In playlists, if the exception for whatever reason had an empty message, an empty notification would get posted. And in general to me it feels a bit dodgy to be directly presenting exception notifications to users without any preamble, hence the added "Failed to open playlist" prefix.
110 lines
3.3 KiB
C#
110 lines
3.3 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.ComponentModel;
|
|
using System.Diagnostics;
|
|
using System.Linq;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Graphics;
|
|
using osu.Framework.Graphics.UserInterface;
|
|
using osu.Game.Graphics.UserInterface;
|
|
using osu.Game.Online.API;
|
|
using osu.Game.Online.API.Requests;
|
|
using osu.Game.Online.Rooms;
|
|
using osu.Game.Screens.OnlinePlay.Lounge;
|
|
using osu.Game.Screens.OnlinePlay.Lounge.Components;
|
|
|
|
namespace osu.Game.Screens.OnlinePlay.Playlists
|
|
{
|
|
public partial class PlaylistsLoungeSubScreen : LoungeSubScreen
|
|
{
|
|
[Resolved]
|
|
private IAPIProvider api { get; set; } = null!;
|
|
|
|
private Dropdown<PlaylistsCategory> categoryDropdown = null!;
|
|
|
|
protected override IEnumerable<Drawable> CreateFilterControls()
|
|
{
|
|
categoryDropdown = new SlimEnumDropdown<PlaylistsCategory>
|
|
{
|
|
RelativeSizeAxes = Axes.None,
|
|
Width = 160,
|
|
};
|
|
|
|
categoryDropdown.Current.BindValueChanged(_ => UpdateFilter());
|
|
|
|
return base.CreateFilterControls().Append(categoryDropdown);
|
|
}
|
|
|
|
protected override FilterCriteria CreateFilterCriteria()
|
|
{
|
|
var criteria = base.CreateFilterCriteria();
|
|
|
|
switch (categoryDropdown.Current.Value)
|
|
{
|
|
case PlaylistsCategory.Normal:
|
|
criteria.Category = @"normal";
|
|
break;
|
|
|
|
case PlaylistsCategory.Spotlight:
|
|
criteria.Category = @"spotlight";
|
|
break;
|
|
|
|
case PlaylistsCategory.FeaturedArtist:
|
|
criteria.Category = @"featured_artist";
|
|
break;
|
|
}
|
|
|
|
return criteria;
|
|
}
|
|
|
|
protected override void JoinInternal(Room room, string? password, Action<Room> onSuccess, Action<string, Exception?> onFailure)
|
|
{
|
|
var joinRoomRequest = new JoinRoomRequest(room, password);
|
|
|
|
joinRoomRequest.Success += r => onSuccess(r);
|
|
joinRoomRequest.Failure += exception =>
|
|
{
|
|
if (exception is not OperationCanceledException)
|
|
onFailure($"Failed to open playlist. {exception.Message}", exception);
|
|
};
|
|
|
|
api.Queue(joinRoomRequest);
|
|
}
|
|
|
|
public override void Close(Room room)
|
|
{
|
|
Debug.Assert(room.RoomID != null);
|
|
|
|
var request = new ClosePlaylistRequest(room.RoomID.Value);
|
|
request.Success += RefreshRooms;
|
|
api.Queue(request);
|
|
}
|
|
|
|
protected override OsuButton CreateNewRoomButton() => new CreatePlaylistsRoomButton();
|
|
|
|
protected override Room CreateNewRoom()
|
|
{
|
|
return new Room
|
|
{
|
|
Name = $"{api.LocalUser}'s awesome playlist",
|
|
Type = MatchType.Playlists
|
|
};
|
|
}
|
|
|
|
protected override OnlinePlaySubScreen CreateRoomSubScreen(Room room) => new PlaylistsRoomSubScreen(room);
|
|
|
|
private enum PlaylistsCategory
|
|
{
|
|
Any,
|
|
Normal,
|
|
Spotlight,
|
|
|
|
[Description("Featured Artist")]
|
|
FeaturedArtist,
|
|
}
|
|
}
|
|
}
|