osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-16 02:52:35 +08:00

Files

T

Bartłomiej Dach eab02a2aa5 Fix lack of slider encode-decode stability due to truncating control point coordinates

Mostly closes https://github.com/ppy/osu/issues/33505.

Compare

	https://github.com/ppy/osu/blob/97e6187f0d7c3dbee896596a623e34627135bf0e/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs#L56-L59

I say "mostly" here because I'm rather skeptical that this is 100% rock
solid still, for one reason - namely that the game stores path control
point coordinates relative to the head, then turns them into absolute
coordinates when encoding, and then on decoding turns them back into
coordinates relative to the head, which in floating-point world is a Bad
Idea because of round-off error. But I'm not fixing that without
introducing a completely new beatmap format or rewriting half the
editor to address that, so I'll just pretend that I don't know any
of this until someone notices.

eab02a2aa5 · 2025-06-10 14:09:13 +02:00

History

ConvertHitCircle.cs

Merge implementations of ConvertHitObjectParser

2024-11-11 15:09:13 +09:00

ConvertHitObject.cs

Add setters to hitobject coordinate interfaces

2024-12-27 11:01:47 +01:00

ConvertHitObjectParser.cs

Fix lack of slider encode-decode stability due to truncating control point coordinates

2025-06-10 14:09:13 +02:00

ConvertHold.cs