Bartłomiej Dach 70c6ddbe30 Fix editor player sometimes crashing because of instantiating wrong judgement result type for object ...

Closes https://github.com/ppy/osu/issues/33231.

I'm not sure how to reproduce the instances of this reported to sentry
with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
just start gameplay test while editor is seeked to a time instant where
a hold note is mid-hold.

There's possibly an argument here that `CreateResult()` should live on
`HitObject` and not `DrawableHitObject`, and I'd even be partial to such
an argument, but doing that would be a rather hard ruleset API break
(albeit trivial one to resolve), and also may dredge up past
conversations about `Judgement` and `JudgementResult` (cf.
https://github.com/ppy/osu/pull/26563) that I would rather not get into
again.

Notably this is not source-breaking for rulesets. It may be
binary-breaking, I haven't tested.

70c6ddbe30 · 2025-05-22 10:20:39 +02:00

History

..

ArmedState.cs

Remove redundant nullable suppression directives

2023-06-07 08:20:41 +03:00

DrawableHitObject.cs

Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

2025-05-22 10:20:39 +02:00