1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 08:22:56 +08:00
osu-lazer/osu.Game.Tests
Bartłomiej Dach e45d456324
Fix TestFriendScore intermittently failing due to randomness
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.

`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.

Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
..
Audio Remove the nullable disable annotation in the test project. 2022-07-31 22:02:07 +08:00
Beatmaps Merge pull request #24800 from sw1tchbl4d3r/invalid_bank 2023-09-19 22:28:34 +09:00
Chat Add failing test case for fake (but still incorrectly allowed) protocol 2023-09-18 09:19:12 +02:00
Collections/IO Automated pass 2023-06-24 01:00:03 +09:00
Database Rename new flag and update xmldoc to match 2023-08-21 19:36:22 +09:00
Editing Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity 2023-09-06 19:01:08 +09:00
Extensions Add own fixed copy of defective Humanizer methods 2022-07-18 21:37:31 +02:00
Gameplay Add test coverage of Judged state 2023-07-05 18:44:27 +09:00
Input Automated pass 2023-06-24 01:00:03 +09:00
Localisation Automated pass 2023-06-24 01:00:03 +09:00
Models Make ScoreInfo.BeatmapInfo nullable 2023-07-04 14:50:34 +09:00
Mods Add test coverage for mod equality with multiple settings 2023-05-04 20:46:27 +02:00
NonVisual Add test cases covering full phrase case insensitivity 2023-06-27 21:50:39 +02:00
Online Automated pass 2023-06-24 01:00:03 +09:00
OnlinePlay Automated pass 2023-06-24 01:00:03 +09:00
Resources Merge pull request #24800 from sw1tchbl4d3r/invalid_bank 2023-09-19 22:28:34 +09:00
Rulesets Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
Scores/IO Automated pass 2023-06-24 01:00:03 +09:00
ScrollAlgorithms Automated #nullable processing 2022-06-17 16:37:17 +09:00
Skins Merge branch 'master' into hud/kc-skinnable 2023-06-25 15:42:08 +02:00
Testing Add missing ruleset shader tests 2023-05-02 11:55:05 +03:00
Utils add tests for GetNextBestFilename() 2022-12-01 18:48:25 +01:00
Visual Fix TestFriendScore intermittently failing due to randomness 2023-09-21 21:12:44 +02:00
ImportTest.cs Automated pass 2023-06-24 01:00:03 +09:00
osu.Game.Tests.csproj Update all dependencies (except for Moq) 2023-09-16 15:37:31 +09:00
tests.ruleset Exclude tests from ConfigureAwait rule 2021-03-08 14:36:35 +09:00
WaveformTestBeatmap.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00