osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-17 01:03:15 +08:00

Files

T

StanR fadb1c3f2c Calculate clock time when creating difficulty hit objects (#36962 )

This change removes `clockRate` precalculation from
`DifficultyCalculator`.

The idea is that clock rate should be calculated in-place (ideally for
every object) since we store and access it using DHOs. This also
prevents anyone from accidentally passing clock rate to skills

Unfortunately osu uses clock rate to calculate OD for the whole map in
`CreateDifficultyAttributes` so we can't make it completely DHO-based,
but I think one single in-place call to `ModUtils.CalculateRateWithMods`
in `CreateDifficultyAttributes` is fine

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

fadb1c3f2c · 2026-03-16 21:17:49 +00:00

History