Merge pull request #8336 from peppy/fix-perfect-display

Fix perfect display showing when misses are present
Merge branch 'master' into fix-perfect-display
2024-12-05 10:23:20 +08:00 · 2020-03-18 18:00:11 +09:00 · 2020-03-18 17:04:52 +09:00 · 2020-03-18 15:49:24 +09:00 · 2020-03-18 15:03:01 +09:00
1 changed files with 2 additions and 1 deletions
--- a/osu.Game/Screens/Ranking/Expanded/ExpandedPanelMiddleContent.cs
+++ b/osu.Game/Screens/Ranking/Expanded/ExpandedPanelMiddleContent.cs
@ -14,6 +14,7 @@ using osu.Game.Graphics;
 using osu.Game.Graphics.Containers;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Graphics.UserInterface;
+using osu.Game.Rulesets.Scoring;
 using osu.Game.Scoring;
 using osu.Game.Screens.Play.HUD;
 using osu.Game.Screens.Ranking.Expanded.Accuracy;
@ -56,7 +57,7 @@ namespace osu.Game.Screens.Ranking.Expanded
            var topStatistics = new List<StatisticDisplay>
            {
                new AccuracyStatistic(score.Accuracy),
-                new ComboStatistic(score.MaxCombo, true),
+                new ComboStatistic(score.MaxCombo, !score.Statistics.TryGetValue(HitResult.Miss, out var missCount) || missCount == 0),
                new CounterStatistic("pp", (int)(score.PP ?? 0)),
            };
Author	SHA1	Message	Date
Dan Balasescu	97f5537713	Merge pull request #8336 from peppy/fix-perfect-display Fix perfect display showing when misses are present	2020-03-18 18:00:11 +09:00
Dan Balasescu	e1e0c40020	Merge branch 'master' into fix-perfect-display	2020-03-18 17:04:52 +09:00
Dean Herbert	fdcb60706b	Use TryGetValue to make tests happy	2020-03-18 15:49:24 +09:00
Dean Herbert	44cfed8af1	Fix perfect display showing when misses are present	2020-03-18 15:03:01 +09:00