Merge efcdb268d2 into ce4aac4184

Merge pull request #30917 from bdach/fix-incorrect-taiko-legacy-combo
Fix strong drum rolls being counted for double the combo in legacy scoring attributes
2024-12-05 09:42:54 +08:00 · 2024-12-03 13:52:56 +08:00 · 2024-12-02 20:08:49 -08:00 · 2024-11-29 10:54:32 +01:00
1 changed files with 7 additions and 0 deletions
--- a/osu.Game.Rulesets.Taiko/Difficulty/TaikoLegacyScoreSimulator.cs
+++ b/osu.Game.Rulesets.Taiko/Difficulty/TaikoLegacyScoreSimulator.cs
@ -144,6 +144,13 @@ namespace osu.Game.Rulesets.Taiko.Difficulty
                    foreach (var nested in hitObject.NestedHitObjects)
                        simulateHit(nested, ref attributes);
                    return;
+
+                case StrongNestedHitObject:
+                    // we never need to deal with these directly.
+                    // the only thing strong hits do in terms of scoring is double their object's score increase,
+                    // which is already handled at the parent object level via the `strongable.IsStrong` check lower down in this method.
+                    // not handling these here can lead to them falsely being counted as combo-increasing when handling strong drum rolls!
+                    return;
            }

            if (hitObject is DrumRollTick tick)
Author	SHA1	Message	Date
smallketchup82	da74dc9963	Merge `efcdb268d2` into `ce4aac4184`	2024-12-03 13:52:56 +08:00
Dean Herbert	ce4aac4184	Merge pull request #30917 from bdach/fix-incorrect-taiko-legacy-combo Fix strong drum rolls being counted for double the combo in legacy scoring attributes	2024-12-02 20:08:49 -08:00
Bartłomiej Dach	3cfa455369	Fix strong drum rolls being counted for double the combo in legacy scoring attributes	2024-11-29 10:54:32 +01:00