Dean Herbert
3b9e1e8a94
Ensure editor selection buttons remain on screen when selection is near edge
...
Addresses https://github.com/ppy/osu/discussions/23599 .
2023-05-24 19:16:53 +09:00
Stéén
dcfc99a092
Merge branch 'master' into make_pause_menu_translatable
2023-05-24 12:13:34 +02:00
Dean Herbert
79c9a48ff7
Show song progress at pause/fail screen
2023-05-24 18:36:37 +09:00
Dean Herbert
456f3005d6
Apply nullability to GameplayMenuOverlay and use TextFlowContainer for text
2023-05-24 18:28:04 +09:00
Dean Herbert
8ada8b1c8c
Remove description line from pause/fail screen
...
These were in the designs but read pretty bad / evil. I can't think of
any text to go in their place that makes sense, so let's just nuke it.
2023-05-24 17:48:35 +09:00
Dean Herbert
3a05dffa50
Add "auto" bank selection during placement
2023-05-24 17:11:12 +09:00
Dean Herbert
fc22c75464
Don't use switch for single case statement
2023-05-24 16:14:05 +09:00
Dean Herbert
a22ad98cb7
Fix hotkeys not actually working
2023-05-24 14:56:11 +09:00
Dean Herbert
a9ba16a2be
Update to support non-control-point sample changes
2023-05-24 14:20:38 +09:00
Dean Herbert
298989ffd2
Merge branch 'master' into sample-set-controls
2023-05-24 14:03:04 +09:00
Dean Herbert
561b759bf9
Tidy up implementation and ensure non-solid ticks start at zero alpha
2023-05-24 13:49:29 +09:00
Dean Herbert
8f1f1955df
Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements
...
Add ghost ticks to exhibit current divisor on `BeatDivisorControl`
2023-05-24 13:41:48 +09:00
Dean Herbert
e5451d1d79
Centralise definition of overlay shadow opacity and reduce slightly
2023-05-24 12:40:35 +09:00
Joseph Madamba
067328233c
Remove OsuScreen.ApplyLogoArrivingDefaults()
2023-05-23 13:17:43 -07:00
Robin Oger
d852883421
Merge remote-tracking branch 'origin/make_pause_menu_translatable' into make_pause_menu_translatable
2023-05-23 21:37:20 +02:00
Robin Oger
a24da89908
Change to sentence casing
...
See: https://github.com/ppy/osu/pull/23640#discussion_r1202879352
2023-05-23 21:37:12 +02:00
Stéén
b9b97069b3
Merge branch 'master' into make_pause_menu_translatable
2023-05-23 21:28:00 +02:00
Robin Oger
0ea3eea8d6
Make GameplayMenuOverlay translatable
...
This allows translator to translate the pause and failed in game menus
2023-05-23 19:21:44 +02:00
Gyoshi
7fe19d1992
Last instead of Max divisor to match code elsewhere
2023-05-23 18:45:49 +02:00
Gyoshi
c5ef3ae181
Code styling
2023-05-23 18:44:20 +02:00
Gyoshi
b5f8093941
Use RangePadding to align mouse with slider
2023-05-23 18:16:14 +02:00
Gyoshi
7b1e8ede54
Small format
2023-05-23 15:11:27 +02:00
Gyoshi
1b32370c6a
Remove duplicate code by making GetDivisorForBeatIndex method more general
2023-05-23 15:05:38 +02:00
Gyoshi
37a796306d
Small format & comment
2023-05-23 14:30:35 +02:00
Johannes vd Berg
ebda35c3c9
Add ghost ticks to exhibit current divisor on BeatDivisorControl
2023-05-23 12:57:25 +02:00
Dan Balasescu
7658536b5a
Fix CI issues
2023-05-23 19:32:19 +09:00
Dan Balasescu
fee3d43596
Merge branch 'master' into scorev2
2023-05-23 19:07:54 +09:00
Dean Herbert
02d8e3a11e
Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead
2023-05-23 18:50:14 +09:00
Dean Herbert
6f4e2b37ed
Add shadow to notifications and settings overlays to better distinguish from other overlays
2023-05-23 18:50:14 +09:00
Dan Balasescu
d45b54399b
Add back minimum/maximum accuracy
2023-05-23 18:15:32 +09:00
Dan Balasescu
3598ca9125
Adjust xmldoc
2023-05-23 18:05:10 +09:00
Dean Herbert
adf9a596b5
Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
...
Closes https://github.com/ppy/osu/issues/23626 .
2023-05-23 17:58:44 +09:00
Dan Balasescu
8570f825ed
Consider all accuracy judgements in accuracy progress
2023-05-23 17:47:35 +09:00
Dan Balasescu
f8101fbbc7
Rename variables
2023-05-23 17:44:17 +09:00
Dean Herbert
ff5dde0ebe
Merge pull request #23575 from Joehuu/fix-inverted-video-only-check
...
Fix old widescreen videos with black bars not correctly filling screen (again)
2023-05-23 16:47:52 +09:00
Dean Herbert
7c039b0b67
Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent
...
Fix hitsounds not playing before and during taiko drum rolls and swells
2023-05-23 16:44:04 +09:00
Dan Balasescu
62d504af92
Fix base implementation of ComputeTotalScore
2023-05-23 15:59:24 +09:00
Dan Balasescu
e1feeded12
Change statistics type, remove overridability
2023-05-23 15:36:34 +09:00
Bartłomiej Dach
38b4bd8aef
Fix undo not behaving as expected sometimes
2023-05-22 22:45:39 +02:00
Bartłomiej Dach
e0b7539c2a
Fix sample changes not being applied in patcher
2023-05-22 22:45:23 +02:00
Bartłomiej Dach
f253d17a7f
Fix slider velocity changes not being applied in patcher
2023-05-22 22:19:10 +02:00
Dean Herbert
7742904d2a
Merge pull request #23593 from Dimmitsaras/unfocused-notifications
...
Always show chat message notifications if window is unfocused
2023-05-22 14:17:20 +09:00
Dean Herbert
09c66bea8f
Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area
...
Fix clicking area of news sidebar post links
2023-05-22 14:17:08 +09:00
Joseph Madamba
7392109bce
Apply same behavioral changes to NewsCard
2023-05-21 19:28:12 -07:00
Joseph Madamba
2279aad360
Apply NRT to NewsCard
2023-05-21 19:27:20 -07:00
Dean Herbert
b3527b92b6
Handle case in tests where current display becomes null
2023-05-22 09:25:44 +09:00
Bartłomiej Dach
19816ae013
Update framework
2023-05-21 20:38:27 +02:00
Bartłomiej Dach
6df1d29862
Merge branch 'master' into use-atomic-ReplaceRange
2023-05-21 20:32:59 +02:00
Joseph Madamba
88c112612f
Remove hardcoded website url
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-21 10:35:22 -07:00
Bartłomiej Dach
5229cf7343
Add failing test cases for drum roll/swell sample playback
2023-05-21 18:57:01 +02:00
timiimit
9d14ea9d27
Merge branch 'ppy:master' into update-multiplayer-room-diff-range
2023-05-21 16:37:00 +02:00
timiimit
4441718437
Merge branch 'ppy:master' into organize-room-pills
2023-05-21 16:36:53 +02:00
Joseph Madamba
8aefb62532
Rename PostButton to PostLink
2023-05-20 16:38:56 -07:00
Joseph Madamba
ec5f0bbf42
Fix clicking area of news sidebar post links
...
Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).
2023-05-20 16:32:04 -07:00
Bartłomiej Dach
de5917b645
Merge branch 'master' into unfocused-notifications
2023-05-20 19:32:52 +02:00
Bartłomiej Dach
a677d87d39
Touch up inline comments
2023-05-20 19:29:59 +02:00
Bartłomiej Dach
8e0a97ca49
Remove usage of HasSubmenu
...
Property has been removed in the appropriate framework-side PR and
instead folded into `IsActionable`.
See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647
2023-05-20 18:02:12 +02:00
Bartłomiej Dach
67c044773b
Merge branch 'master' into fix-menu-state-display
2023-05-20 17:57:00 +02:00
Bartłomiej Dach
afdddb0195
Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes
...
Fix timeline blueprint display not showing correct combo number / colour during placement
2023-05-20 15:02:55 +02:00
Bartłomiej Dach
0e11adaaac
Merge pull request #23564 from peppy/fix-missing-sample-additions
...
Fix sample banks not transferring when adjusting via editor
2023-05-20 14:36:45 +02:00
Dan Balasescu
25d72d370e
Always add non-bonus change to combo portion
2023-05-20 00:24:43 +09:00
Dan Balasescu
30a296bd09
Rename parameters
2023-05-19 17:27:02 +09:00
Dan Balasescu
6c6f8621c1
Add score processor statistics to replay header
2023-05-19 16:29:24 +09:00
Dan Balasescu
d74bf2a096
Refactor for safety
2023-05-19 14:37:26 +09:00
Dan Balasescu
2ae34530f7
Avoid NaN values during ApplyBeatmap processing()
2023-05-19 14:14:34 +09:00
Dan Balasescu
7cbf48ffcf
Fix TestSceneScoring and incorrect combo calculations
2023-05-19 14:09:19 +09:00
Dan Balasescu
035d0d5c9c
Fix multiplayer leaderboard not working
2023-05-19 13:16:57 +09:00
Dan Balasescu
8b56a3f87d
Remove ClassicScoreMultiplier and DefaultScoreProcessor
2023-05-19 12:24:52 +09:00
Dan Balasescu
00e0411369
Fix/rework ModAccuracyChallenge calculation
2023-05-18 20:45:02 +09:00
Dan Balasescu
ef86be6d21
Fix base score added for non-accuracy-affecting objects
2023-05-18 20:32:50 +09:00
Dan Balasescu
c33e4fe75e
Remove unnecessary override
2023-05-18 20:10:28 +09:00
Dan Balasescu
808818768b
Add TotalScore to replay frame headers
2023-05-18 20:08:49 +09:00
Dan Balasescu
f3591f83a2
Remove ScoreManager.GetTotalScore()
2023-05-18 20:08:49 +09:00
Dan Balasescu
510b8e4c78
Remove ScoreManager.Mode, handle per-use
2023-05-18 20:08:49 +09:00
Dan Balasescu
829e47d30b
Add MaxTotalScore for performance breakdown calculator
2023-05-18 17:47:25 +09:00
Dan Balasescu
f2483a1cf8
Add some helper methods, fix precision differences
...
Introduces some error at all times, but if we're to store scores everywhere as
`long`, then the same precision should be applied to the "during
gameplay" path as well.
2023-05-18 17:44:31 +09:00
Dean Herbert
ee522253cb
Remove a couple of unnecessary volume declarations
2023-05-18 14:12:57 +09:00
Bartłomiej Dach
9ca1c7f7b7
Merge pull request #23580 from peppy/fix-profile-button-depth
...
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 21:23:46 +02:00
Dimmitsaras
7ac6688a0f
Chat message notifications always play on unfocused window
2023-05-17 18:34:39 +03:00
Dean Herbert
b58ab28765
Make EditorClock non-nullable in PlacementBlueprint
2023-05-17 21:40:52 +09:00
Dean Herbert
214d7e07fa
Add TODO regarding failing stack display code
2023-05-17 17:52:17 +09:00
Dean Herbert
0b25818bd2
Update combo information on placement blueprint
2023-05-17 17:26:19 +09:00
Dean Herbert
9563d4f730
Fix weird purple tint on placement object in timeline
2023-05-17 17:26:19 +09:00
Dean Herbert
8d925c8a8a
Move combo information updating to an interface level helper method
2023-05-17 17:26:19 +09:00
Dean Herbert
e43f2c2c43
Improve previous hitobject lookup efficient and correctness
2023-05-17 17:19:29 +09:00
Dean Herbert
7d7d402d4e
Apply NRT to PlacementBlueprint
2023-05-17 17:19:29 +09:00
Dean Herbert
87ff28b022
Update beat divisor control to show ticks in more visually correct locations
...
As proposed in https://github.com/ppy/osu/discussions/23527 .
2023-05-17 16:34:12 +09:00
Dean Herbert
730bc3a961
Apply NRT and simplify some remaining code
2023-05-17 16:18:13 +09:00
Dean Herbert
e97d027230
Make OnlinePlayPill class abstract
2023-05-17 16:13:03 +09:00
Dean Herbert
79e1d978e7
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 15:42:38 +09:00
Dean Herbert
764f0323f4
Show "rewind" text on random button when beginning a right mouse press
2023-05-17 14:51:40 +09:00
Dean Herbert
94b184712d
Fix random button hover state not correctly being reset on right click
2023-05-17 14:51:40 +09:00
Dean Herbert
dc421bd2af
Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"
...
This reverts commit ab2bd123e7267e63320f
2023-05-17 14:49:47 +09:00
Dean Herbert
510ebe1f23
Fix weird optional usage in HitSampleInfo.With
2023-05-17 14:11:52 +09:00
Dean Herbert
dc51d5ecf3
Rename GetSampleInfo to better describe what method does
...
Also add full xmldoc
2023-05-17 14:07:48 +09:00
Dean Herbert
a8bc337006
Change default volume when constructing a HitSampleInfo to non-zero
2023-05-17 14:06:02 +09:00
Susko3
fec47fa690
Merge branch 'master' into use-atomic-ReplaceRange
...
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Joseph Madamba
d6fa44240d
Fix storyboard video-only check being inverted
2023-05-16 21:51:32 -07:00
Dean Herbert
0d3c64dc32
Merge pull request #23572 from bdach/avoid-display-settings-feedback
...
Work around issues with bindable/event feedback in layout settings
2023-05-17 12:03:45 +09:00
Susko3
2d7fe68311
Prevent feedback by using atomic .ReplaceRange()
...
`display.NewValue` will never be null, checked on SDL + osuTK/Android.
On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays
2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution
2023-05-16 21:02:23 +02:00
Huo Yaoyuan
ddfdd712bd
Update InspectCode to 2022.3.3 and enable C# 11
2023-05-17 00:07:06 +08:00
Dean Herbert
d9ae822966
Fix bank not correctly being assigned when adding sample additions in editor
2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
timiimit
cc6e4df93e
Remove wrongly added back namepspace
2023-05-16 10:27:46 +02:00
timiimit
4ef74eb3f9
Fix RoomStatusPill text colour
2023-05-16 10:22:52 +02:00
timiimit
81b7737660
Fix text colour of RoomSpecialCategoryPill
2023-05-16 10:20:16 +02:00
timiimit
a9991d9dd4
Remove another unused namespace
2023-05-16 10:14:14 +02:00
timiimit
40daa41a52
Fix naming & namespaces
2023-05-16 10:06:48 +02:00
timiimit
04893064f0
Make used pills inherit from a common one
2023-05-16 09:53:11 +02:00
timiimit
10d6f9ea5a
Create common online play pill
2023-05-16 09:52:26 +02:00
timiimit
0fd718478a
Merge branch 'master' into update-multiplayer-room-diff-range
2023-05-15 07:36:43 +02:00
timiimit
83ceb3457f
Add xmldoc comment
2023-05-15 07:36:15 +02:00
timiimit
cb8d5f459f
Remove bad comment
2023-05-15 07:36:15 +02:00
Bartłomiej Dach
592fcafcd4
Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping
...
Fix default progress graph not updating after flip
2023-05-14 19:19:10 +02:00
timiimit
f7a2321175
Merge branch 'master' into update-multiplayer-room-diff-range
2023-05-14 12:28:58 +02:00
Bartłomiej Dach
cc2dfc8371
Merge branch 'master' into editor-slider-placement-tool-change
2023-05-14 12:26:37 +02:00
timiimit
86a834fb56
Fix TODO comment
2023-05-14 12:20:16 +02:00
timiimit
fd80ffd52b
Fix display update condition
2023-05-14 12:09:15 +02:00
timiimit
5d68701321
Copy StarRange when creating PlaylistItem
2023-05-14 12:08:37 +02:00
timiimit
f1f30b94a6
Add StarRating Property
2023-05-14 11:05:47 +02:00
Bartłomiej Dach
e6786e0244
Merge branch 'master' into editor-slider-placement-input
2023-05-14 10:52:22 +02:00
Bartłomiej Dach
325de2dc22
Merge pull request #23507 from peppy/editor-blueprint-end-placement
...
Move blueprint validity conditions to allow more correct external usage of `EndPlacement`
2023-05-14 10:24:04 +02:00
Bartłomiej Dach
58410c6fc0
Merge pull request #23506 from peppy/tablet-settings-keywords
...
Fix some tablet settings being hidden when searching using "area" keyword
2023-05-14 09:44:55 +02:00
Bartłomiej Dach
732bd7812b
Merge pull request #23529 from peppy/no-hold-during-gameplay
...
Fix hold-for-right-click showing during gameplay
2023-05-13 15:33:13 +02:00
Dean Herbert
8c542c6c51
Fix hold-for-right-click showing during gameplay
2023-05-13 21:32:30 +09:00
Dean Herbert
2e6fd4b321
Update framework
2023-05-13 20:54:22 +09:00
timiimit
18efdb0e4c
Make layout readonly
2023-05-13 11:37:56 +02:00
timiimit
d81cdacb0d
Undo stupid changes
2023-05-13 11:28:05 +02:00
timiimit
4b544903cb
Optimize recalculateValues
2023-05-13 10:13:09 +02:00
timiimit
2cfc4eb515
Fix unconsidered height change
2023-05-13 10:12:46 +02:00
timiimit
80b6e014f1
More code style
2023-05-13 01:47:44 +02:00
timiimit
8cc0c5ad1c
Fix code style
2023-05-13 01:39:01 +02:00
timiimit
04f7def798
Remove useless comment
2023-05-13 01:31:12 +02:00
timiimit
21d7c62f30
Add optimized UpdateGraph
2023-05-13 01:29:11 +02:00
timiimit
159cacf9c7
Fix logic in recalculateValues()
2023-05-13 01:27:28 +02:00
timiimit
6180d0d620
Remove cached frame buffer
2023-05-12 15:00:46 +02:00
Dean Herbert
0c1959ef2f
Allow commiting / undoing placement of blueprints using back / select bindings
2023-05-12 16:06:20 +09:00
Dean Herbert
70e248b927
Force placement of in-progress object when changing tools in the editor
2023-05-12 16:06:01 +09:00
Dean Herbert
f443cfb93e
Move blueprint validity conditions to allow more correct external usage of EndPlacement
...
Until now, these were haphazardly enforce inline in blueprint
implementations. The only thing stopping complete breakage is that
`EndPlacement` wasn't called (too much) from outside the blueprint,
leaving them responsible for their own placement.
By moving this conditional out of the provided paramters to
`EndPlacement`, it allows more flexible usage of that method externally.
Coming in a future PR.
2023-05-12 16:02:22 +09:00
Dean Herbert
c0f869e685
Fix some tablet settings being hidden when searching using "area" keyword
...
As discussed in https://github.com/ppy/osu/discussions/23504 .
2023-05-12 14:57:56 +09:00
tsrk
2d45d602a5
feat(settings): more keyword for first run setup
2023-05-11 15:03:42 +01:00
tsrk
c1a85658b7
feat(settings): add "import" as keywords for first run setup
2023-05-11 14:58:17 +01:00
Dean Herbert
3fc19553b4
Update resources
2023-05-10 15:19:46 +09:00
Dean Herbert
4aa241daea
Update framework
2023-05-10 15:19:43 +09:00
Dean Herbert
bdf8a78b42
Add the ability to adjust the beatmap tick rate in the editor
2023-05-09 20:53:20 +09:00
Dean Herbert
ca5e8b290f
Add clamping to SliderMultiplier and SliderTickRate at parsing time
2023-05-09 20:53:20 +09:00
Dean Herbert
d10dd6d5ae
Merge branch 'master' into base-s-v
2023-05-09 20:52:11 +09:00
Dan Balasescu
a7b623f52a
Reimplement classic scoring mode
2023-05-09 20:21:38 +09:00
Dan Balasescu
3c3c812ed6
Initial implementation of ScoreV2
2023-05-09 19:33:33 +09:00
Dean Herbert
2085833a84
Fix missing delegate unsubscribe
2023-05-09 17:08:03 +09:00
Dean Herbert
944da06c10
Rename slider multiplier variable back for now
2023-05-09 16:58:19 +09:00
Bartłomiej Dach
1d162d1d15
Merge pull request #23440 from peppy/drawable-hit-object-sync-animations
...
Fix hit object animations not being played back in sync
2023-05-08 23:44:37 +02:00
Bartłomiej Dach
30ce86a582
Merge pull request #23437 from peppy/fix-hold-note-input-test
...
Fix `TestSceneHoldNoteInput` not displaying correctly
2023-05-08 22:22:33 +02:00
Bartłomiej Dach
2177dbf42a
Merge pull request #23436 from peppy/fix-wiki-error-return-to-main
...
Fix "Return to main page" link not working on wiki after error
2023-05-08 21:56:29 +02:00
Dean Herbert
64498e95a4
Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations
2023-05-08 18:56:29 +09:00
Dan Balasescu
d2380bd840
Remove usages of [ExcludeFromDynamicCompile]
2023-05-08 18:12:56 +09:00
Dean Herbert
d6ce56e6b1
Fix GetMostCommonBeatLength returning zero in case of not timing points
2023-05-08 17:09:08 +09:00
Dean Herbert
1b7dd32eb1
Apply nullability in related classes and remove unused variable
2023-05-08 17:09:08 +09:00
Dean Herbert
715b735131
Fix "Return to main page" link not working on wiki after error
2023-05-08 15:29:05 +09:00
Dean Herbert
8c44d528e9
Use min/max values from stable
2023-05-08 13:52:16 +09:00
Dean Herbert
a6cb1f90e4
Change difficulty popover inspector display (yet again)
...
I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.
2023-05-08 13:43:23 +09:00
Dean Herbert
a91edd68d9
Show post-multiplied velocity in main hit object inspector
2023-05-08 13:42:25 +09:00
Dean Herbert
451af9d1b5
Fix beatmap values not being updated due to a varying data type
2023-05-08 13:23:13 +09:00
Dean Herbert
d9dd35c020
Show base velocity in slider adjustment popover
2023-05-08 13:13:09 +09:00
Dean Herbert
31de4de720
Remove median/mode slider velocity display
...
The intention was to give an idea of what the most common velocity of
the beatmap is, but in hindsight, because the "base" velocity is being
set elsewhere this doesn't make sense. It will/should be 1.0x.
Showing this range is still valuable, though.
2023-05-08 13:13:09 +09:00
Dean Herbert
b109ee74a6
Add "base velocity" adjustment to difficulty setup screen
2023-05-08 13:13:09 +09:00
Dean Herbert
f7d44c3013
Rename SliderMultiplier to BaseSliderVelocity
2023-05-08 13:13:09 +09:00
Bartłomiej Dach
65b4b198a4
Merge branch 'master' into export
2023-05-06 20:12:53 +02:00
tsrk
e9d7cd7a79
feat(ArgonKeyCounter): flash key name
2023-05-06 19:08:30 +01:00
Bartłomiej Dach
510484011c
Mark exporter extensions as untranslatable
2023-05-06 19:42:28 +02:00
Bartłomiej Dach
3f63fd7f4d
Reorder increment to make progress update less weird
2023-05-06 19:39:52 +02:00
Bartłomiej Dach
bb17b684b0
Rename flag
2023-05-06 19:38:41 +02:00
Bartłomiej Dach
a56a5d563c
Unify error message wording
2023-05-06 19:38:05 +02:00
Bartłomiej Dach
3afe198d1d
Remove weird single-use private method
2023-05-06 19:34:22 +02:00
Bartłomiej Dach
e0823ffd03
Move lower and xmldoc GetFilename(TModel)
2023-05-06 19:29:08 +02:00
Bartłomiej Dach
5e64d25b2a
Make UserFileStorage readonly again
2023-05-06 19:26:51 +02:00
Dean Herbert
64d7e0d896
Rename outputStream variable to match base class
2023-05-07 00:24:30 +09:00
Dean Herbert
d2591368a6
More xmldoc fixes
2023-05-06 23:53:35 +09:00
Bartłomiej Dach
e2410c00e2
Merge branch 'master' into update-framework
2023-05-06 16:25:44 +02:00
Bartłomiej Dach
38ebce8ee9
Update framework again
2023-05-06 16:21:48 +02:00
Dean Herbert
0d095c4bb7
Remove non-Live pathway
2023-05-06 23:10:18 +09:00
Dean Herbert
e75ff33d62
Remove redundant xmldoc and reword some remaining
2023-05-06 23:10:09 +09:00
Bartłomiej Dach
3942281d13
Fix back-to-front logic
2023-05-06 15:34:55 +02:00
Bartłomiej Dach
80ac8abaa6
Merge branch 'master' into chat-report
2023-05-06 15:30:44 +02:00
Bartłomiej Dach
1da5e69d5a
Fix API success callback scheduling to dead drawable
2023-05-06 15:27:27 +02:00
Bartłomiej Dach
6b4050ea52
Remove invalid report reason (and add osu-web references)
2023-05-06 15:01:57 +02:00
Bartłomiej Dach
52e5835be6
Document and retouch ReportPopover
2023-05-06 14:52:38 +02:00
Bartłomiej Dach
e808a47811
Fix delegate leak
2023-05-05 20:33:27 +02:00
Bartłomiej Dach
f536238554
Use shorter copy
2023-05-05 20:30:50 +02:00
Bartłomiej Dach
34b19dd6f4
Merge branch 'master' into slider-velocity-inspector
2023-05-05 20:20:16 +02:00
Bartłomiej Dach
4ca80cf6be
Merge pull request #23404 from peppy/show-sv-in-inspector
...
Show slider velocity in hit object inspector
2023-05-05 20:19:50 +02:00
Bartłomiej Dach
3b37a421e6
Merge pull request #23401 from peppy/fix-break-overlay-glow-cutoff
...
Fix break overlay arrows' glow getting cut off at lower resolutions
2023-05-05 20:12:34 +02:00
cdwcgt
71864fbb93
remove meanless comment
2023-05-05 21:29:06 +09:00
cdwcgt
4393e53b43
ExportToStream should be public
2023-05-05 21:28:43 +09:00
Dean Herbert
490df8073c
Fix one incorrect namespace syntax file
2023-05-05 21:15:26 +09:00
Dean Herbert
747f912af5
Fix incorrect cancellation logic
2023-05-05 21:08:01 +09:00
Dean Herbert
5d78561aa3
Remove weird catch logic
2023-05-05 21:05:57 +09:00
Dean Herbert
2a3e03695c
Simplify ExportAsync, remove weird dedupe logic and unnecessary return success code
2023-05-05 21:05:52 +09:00
Dean Herbert
4ccfebc02b
Simplify ExportToStreamAsync implementation
2023-05-05 21:01:10 +09:00
Dean Herbert
fc2d2de34c
Fix notification text not including export filename
2023-05-05 16:53:27 +09:00
Dean Herbert
9cafb20fcb
Move file missing logging to a better location, and log actual filenames to logs
2023-05-05 16:53:16 +09:00
Dean Herbert
4ec98b0578
Improve xmldoc and fix silly progress text in LegacyArchiveExporter
2023-05-05 16:45:45 +09:00
Dean Herbert
0158102467
Rename class back to original name so I can read the diff
2023-05-05 16:19:10 +09:00
Dean Herbert
b7a287869a
Add display of beatmap slider velocity when adjusting
2023-05-05 15:57:38 +09:00
Dean Herbert
cc70d89bf9
Move editor inspector classes out of ruleset namespace
2023-05-05 15:57:38 +09:00
Dean Herbert
4663057060
Split out EditorInspector implementation for reuse
2023-05-05 15:54:15 +09:00
Dean Herbert
76b2f0e6dd
Show slider velocity in hit object inspector
2023-05-05 15:15:18 +09:00
Dean Herbert
560f71ef53
Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions
...
Closes https://github.com/ppy/osu/issues/23210 .
Ballparked the fix to work down to the lowest resolution we support. The
previous number (`2.5f`) was also likely ballparked so the fix seems in
line with expectations.
I don't want to put too much thought into this because the design of
this screen is likely going to change in the mean time anyway.
2023-05-05 14:29:04 +09:00
Dean Herbert
8391e2a538
Move reporting code out of DrawableChatUsername into more correct locations
2023-05-05 14:03:42 +09:00
tsrk
74e7a958bb
feat(ArgonKeyCounter): make animation
...
Currently WIP. Do not consider this final.
2023-05-05 05:31:06 +01:00
Dean Herbert
698baa78bf
Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
...
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
Bartłomiej Dach
485b7282dc
Clarify type check
2023-05-04 19:06:07 +02:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset
2023-05-04 18:59:47 +02:00
Bartłomiej Dach
1f1342b099
Reword xmldoc
2023-05-04 18:33:49 +02:00
Bartłomiej Dach
88e77ad390
Rename Settings{-> Map}
2023-05-04 18:30:41 +02:00
Bartłomiej Dach
26337dbcd8
Do not rely on unspecified Dictionary.Values ordering
2023-05-04 18:29:01 +02:00
Bartłomiej Dach
0d2396c557
Rename method to better indicate directionality
2023-05-04 18:15:12 +02:00
Dean Herbert
95b541ab39
Update framework
2023-05-04 11:27:18 +09:00
Dean Herbert
0034124d79
Remove unnecessary content clear
2023-05-04 11:25:10 +09:00
Dean Herbert
26b8c5b852
Fix mod list display not updating after clicking "use current"
...
This is not a regression from my changes. It was broken before them.
2023-05-04 11:23:51 +09:00
Dean Herbert
49fb5da1a2
Stop passing preset panel to popover
2023-05-04 11:19:09 +09:00
Dean Herbert
b12d139317
Remove dead code
2023-05-04 11:16:52 +09:00
Dean Herbert
99d2616c34
Move drawable construction to load for simplicity
2023-05-04 11:14:51 +09:00
Dean Herbert
be995f1359
Add localisation support for new button string
2023-05-04 11:11:19 +09:00
Dean Herbert
b7abab6d8a
More variable improvements
2023-05-04 11:10:05 +09:00
Dean Herbert
0a584f0652
Simplify check logic and improve variable naming
2023-05-04 11:07:09 +09:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
Bartłomiej Dach
1d4d31e35c
Trim comments
...
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
Bartłomiej Dach
27fabd99fb
Rename variables for legibility
...
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00
Terochi
d1d4b54c64
Simplified
2023-05-03 18:31:35 +02:00
Bartłomiej Dach
fa3f42ba75
Merge pull request #23386 from peppy/fix-osu-logo-input-handling
...
Extend input handling of osu! logo to full border area
2023-05-03 17:48:51 +02:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
cdwcgt
967e801f9c
code inspect
2023-05-03 23:26:58 +09:00
cdwcgt
debbd376bd
move scrollContent update logic to updateActiveState()
2023-05-03 23:24:14 +09:00
cdwcgt
f4b1264cc9
use button Enable status to ensure preset name is not null
2023-05-03 23:22:46 +09:00
cdwcgt
aa5a026c67
remove local button handle
2023-05-03 23:14:24 +09:00
cdwcgt
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
Dean Herbert
be15d07b17
Tidy up various implementation details
2023-05-03 18:59:39 +09:00
Dean Herbert
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
Dean Herbert
b28d7b1a92
Fix non-block namespace
2023-05-03 18:51:02 +09:00
Dean Herbert
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
Dean Herbert
444f66b0ee
Move to base class for added safety
2023-05-03 18:46:30 +09:00
Dean Herbert
cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
Dean Herbert
5757eb7529
Update a few more instances of 0.96f scale constants
2023-05-03 18:20:12 +09:00
Bartłomiej Dach
88135a3be8
Merge pull request #23384 from peppy/fix-incorrect-transform-thread
...
Fix potentially incorrect thread access in `OsuTabControlCheckbox`
2023-05-03 10:37:27 +02:00
Dean Herbert
ff28d941b3
Merge pull request #23385 from Joehuu/scroll-back-button-block-hover
...
Fix overlay scroll back button not absorbing hover from behind
2023-05-03 16:28:05 +09:00
Bartłomiej Dach
de1b28bcb2
Fix incorrect initial state of checkbox
...
This only ever barely used to work without the `(..., true)`
in `master` because of haphazard operation ordering.
2023-05-03 09:27:23 +02:00
Bartłomiej Dach
5f781bd6de
Move callback to LoadComplete()
...
Is the more correct place for `BindValueChanged()` callbacks.
2023-05-03 09:26:54 +02:00
Dean Herbert
453143813f
Extend input handling of osu! logo to full border area
...
This is the easiest way to make this happen. It does mean the pink area
is being drawn behind the white border, but I haven't found a scenario
where this is noticeable.
Closes #4217 .
2023-05-03 14:57:57 +09:00
Joseph Madamba
1c74f6e8ea
Fix regressed button hover fade in
2023-05-02 22:54:42 -07:00
Joseph Madamba
bede1292de
Fix overlay scroll back button not absorbing hover from behind
2023-05-02 22:40:37 -07:00
Dean Herbert
a3efae3690
Fix potentially incorrect thread access in OsuTabControlCheckbox
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829 .
2023-05-03 14:33:32 +09:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
f930c4bd0a
Move struct to bottom of file
2023-05-03 13:33:31 +09:00
Dean Herbert
48fd99818e
Split out default and sample application
2023-05-03 13:30:45 +09:00
Dean Herbert
cca15f930c
Refactor applyLegacyInfoAndDefaults for legibility
2023-05-03 13:26:50 +09:00
Dean Herbert
588a4e6196
Move pragma disable to top of LegacyBeatmapDecoder
...
Makes more sense as it's used multiple times in the class.
2023-05-03 13:19:14 +09:00
Dean Herbert
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
Dean Herbert
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
Bartłomiej Dach
ec8362c6fc
Merge pull request #23367 from peppy/fix-uo-tooltip
...
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
Bartłomiej Dach
48dd42407b
Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
...
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
Dean Herbert
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
Dean Herbert
414b80d44e
Change flashlight depth in a more standard way
2023-05-02 17:00:54 +09:00
Dean Herbert
b2b9f2a036
Merge branch 'master' into bubble_mod_implementation_clean
2023-05-02 16:59:55 +09:00
OliBomby
2e018c8b06
Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:47 +02:00
OliBomby
c2ad8c2320
Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-05-02 08:41:30 +02:00
Dean Herbert
67f83f246b
Add more padding around playfield in editor to avoid overlap with tool areas
...
Closes #23130 .
2023-05-02 15:37:02 +09:00
Dean Herbert
4a97c2c105
Merge pull request #23038 from cdwcgt/scale-background-dim
...
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
Dean Herbert
ce4a6c38a0
Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
...
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
Dean Herbert
8a536c1cdb
Fix non-block namespace usage
2023-05-02 15:09:24 +09:00
Dean Herbert
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
Dean Herbert
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
Dean Herbert
57f48e0703
Start colour black to ensure initial appear transition doesn't look silly
2023-05-02 14:33:57 +09:00
Dean Herbert
ab4f66fad3
Minor readability refactors
2023-05-02 14:31:39 +09:00
Dean Herbert
7a840e1d82
Remove unnecessary TransferValue spec
2023-05-02 14:29:26 +09:00
Dean Herbert
7efaa299bd
Merge branch 'master' into scale-background-dim
2023-05-02 14:24:54 +09:00
Dean Herbert
736be6a73b
Refactor slightly for readability
2023-05-02 14:11:16 +09:00
Dean Herbert
ad40099e32
Ensure negative sign is only applied when the post-rounded result is negative
2023-05-02 14:00:52 +09:00
Dean Herbert
37a5dde859
Fix BeatmapAttributeText not supporting unicode artist/title
2023-05-02 13:47:49 +09:00
Dean Herbert
e808e7316b
Mark delegate value unused and add comment to avoid future regression
2023-05-02 13:29:30 +09:00
Dean Herbert
63890ef6fe
Fix audio offset tooltip potentially showing "-0 ms"
...
Closes https://github.com/ppy/osu/issues/23339 .
2023-05-02 13:24:22 +09:00
Dean Herbert
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
Dean Herbert
5da78098ad
Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id
...
Reset online ID on locally modifying beatmap
2023-05-02 12:41:23 +09:00
Bartłomiej Dach
436ebdcfcb
Fix beatmap leaderboard test failure
...
Because the online info reset (which includes online ID reset) was
happening after encoding,
`TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
started failing, as the hash no longer matched expectations after the
first save of the map.
2023-05-01 19:44:15 +02:00
OliBomby
cf5211aec9
Enable current distance snap when exactly on a hit object
2023-05-01 19:22:52 +02:00
Bartłomiej Dach
f470b2c9cc
Always reset online info when saving local beatmap
2023-05-01 18:17:45 +02:00
Bartłomiej Dach
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3e72f103c17
2023-05-01 18:17:35 +02:00
OliBomby
8c21fddb5e
remove all redundancies from encoded control points
2023-05-01 16:53:38 +02:00
OliBomby
1dc34ee25d
fix infinite repeat count when adjusting length of 0 length slider
2023-05-01 15:48:54 +02:00
OliBomby
8302bb1f37
dont encode custom sample bank for objects without legacy samples
2023-05-01 14:56:29 +02:00
OliBomby
27cfadca16
add sample info to Banana and SpinnerBonusTick
2023-05-01 14:54:06 +02:00
Terochi
4d52ce769b
Revert SaveState() calling on initialization
2023-05-01 12:53:58 +02:00
OliBomby
cef9f73d34
dont assign custom sample bank and volume to hitobjects in non-mania gamemodes
...
this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject
2023-05-01 12:31:27 +02:00
Bartłomiej Dach
d98aa60efc
Merge branch 'master' into cursor-ripples
2023-05-01 09:37:50 +02:00
OliBomby
2a94757154
Make sure the first object you place has bank and volume
2023-05-01 00:49:01 +02:00
OliBomby
608fa3cc73
Merge remote-tracking branch 'upstream/master' into sample-control-points
2023-04-30 19:47:03 +02:00
OliBomby
139a1d7e6d
fix legacy encoder writing sample info while not writing node samples
2023-04-30 17:46:47 +02:00
Bartłomiej Dach
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod
2023-04-30 17:36:00 +02:00
