Dean Herbert
|
b6fa50c312
|
Reduce allocation overheads in SliderInputManager
|
2024-01-26 17:49:20 +09:00 |
|
Bartłomiej Dach
|
7e557152fb
|
Fix relax mod not considering full follow area radius when automatically holding sliders
Closes https://github.com/ppy/osu/issues/25947.
Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.
I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:
7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58)
Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:
7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116)
which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.
|
2023-12-22 12:50:42 +01:00 |
|
Dan Balasescu
|
2b33aec124
|
Require slider head to be judged before ticks
|
2023-12-17 21:26:48 +09:00 |
|
Dan Balasescu
|
fddfa33e49
|
Fix 1-frame issues due to referencing external value
|
2023-12-17 20:19:25 +09:00 |
|
Dan Balasescu
|
9b02bd712b
|
Only track if in slider ball after any ticks missed
|
2023-12-17 20:12:02 +09:00 |
|
Dan Balasescu
|
fbe48d7be8
|
Fix tail being missed too early
|
2023-12-17 20:11:15 +09:00 |
|
Dan Balasescu
|
f77884b62f
|
Only hit passed-through ticks if none were missed
|
2023-12-17 19:57:48 +09:00 |
|
Dan Balasescu
|
12210017e4
|
Use the cursor position to test nested object validity
|
2023-12-15 17:05:14 +09:00 |
|
Dan Balasescu
|
6bd190c55d
|
Refactor all slider input into SliderInputManager
|
2023-12-15 16:13:32 +09:00 |
|