sw1tchbl4d3
|
f8036658c7
|
Move clamps directly to the usages in the conversion algorithm
|
2022-10-10 09:36:18 +02:00 |
|
Dan Balasescu
|
15a7fb044d
|
Merge pull request #20600 from peppy/fix-mania-rewinding
Fix osu!mania key / stage lighting / explosions not working well with rewind
|
2022-10-07 21:42:39 +09:00 |
|
Dean Herbert
|
e1e12f41e9
|
Add more comprehensive inline comment
|
2022-10-07 21:00:11 +09:00 |
|
Dan Balasescu
|
d63f196626
|
Merge branch 'master' into fix-mania-rewinding
|
2022-10-07 20:45:56 +09:00 |
|
Dean Herbert
|
588713497d
|
Attempt to make hold notes more legible at low background dims
|
2022-10-07 20:43:26 +09:00 |
|
Dean Herbert
|
589b764b77
|
Final tweaks because I don't know when to stop
|
2022-10-07 20:30:38 +09:00 |
|
Dean Herbert
|
d5490523ea
|
Adjust hold notes further
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
8101eea50d
|
Fix first glow of key area elements not working due to missing type
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
c518fbf44a
|
Adjust argon hold bodies to better define away from the stage background
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
08c3f3ae6d
|
Adjust lighting and timing of key area in general
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
551b7f0d1c
|
Fix corner radius visible below hit target line
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
e4657a7a3d
|
Fix argon key area lighting being hidden by other columns in one direction
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
12e9686092
|
Increase column spacing
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
f9b4f491a6
|
Increase overall corner radius slightly
|
2022-10-07 20:05:13 +09:00 |
|
Dean Herbert
|
58eaa18725
|
Add transparency to column backgrounds
|
2022-10-07 20:05:13 +09:00 |
|
Dan Balasescu
|
b5746f5f20
|
Merge pull request #20602 from peppy/mania-fix-object-colouring
Fix osu!mania not colours not always updating when switching skins
|
2022-10-07 19:22:55 +09:00 |
|
Dean Herbert
|
52ad766f86
|
Remove manual binding of nested objects in DrawableManiaHitObject
This is now handled by `Column` itself. Leaving the logic here as well
will cause a circular bindable flow and stack overflow.
|
2022-10-07 18:25:55 +09:00 |
|
Dean Herbert
|
4b772643e9
|
Use bindable flow for transfer of accent colour from columns to hit objects
This fixes the case where changing a skin during gameplay runtime does
not correctly convey colour information to off-screen `DrawableHitObject`s.
|
2022-10-07 18:25:08 +09:00 |
|
Dean Herbert
|
42afc8e568
|
Merge branch 'master' into fix-mania-rewinding
|
2022-10-07 18:17:19 +09:00 |
|
Dan Balasescu
|
721189b23a
|
Merge branch 'master' into argon-mania-note
|
2022-10-07 17:34:11 +09:00 |
|
Dean Herbert
|
c7405d1c1c
|
Add missing immediate application of AccentColour in DefaultKeyArea
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
|
2022-10-07 17:00:10 +09:00 |
|
Dean Herbert
|
98b578e8e6
|
Remove left-over incorrect fallback logic
This was moved to `ManiaClassicSkinTransformer`.
|
2022-10-07 16:12:27 +09:00 |
|
Dean Herbert
|
207c76bdec
|
Fix column lighting and key area not handling rewind correctly
|
2022-10-07 15:46:11 +09:00 |
|
Dean Herbert
|
e81f550150
|
Fix hit explosions not being cleaned up correctly when rewinding
|
2022-10-07 15:46:11 +09:00 |
|
Dean Herbert
|
6d14ccb8e0
|
Make special key slightly wider
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
e4e4c1b661
|
Add very temporary mania judgement display for argon skin
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
b95743092d
|
Add argon hit explosion
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
258c935574
|
Remove key area background (the column background is enough to work well)
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
f3e3ee81cb
|
Add column and stage background to argon skin
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
59bbbf1c08
|
Improve colours and hit metrics on key area
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
a543222a2b
|
Add ability to pad stage vertically
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
4cb07b8839
|
Specify column widths for argon
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
6c0923ec1a
|
Add argon hold note pieces
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
a10f9ebfa5
|
Update argon colours to roughly match design spec
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
c1cb62cc35
|
Add basic argon note piece
|
2022-10-07 15:45:35 +09:00 |
|
Dean Herbert
|
f1ea61b1a2
|
Remove unused colour code
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
9a92ff1681
|
Fix SourceChanged unbind directionality and add null check
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
dee01abab1
|
Add method to get stage from column index
|
2022-10-07 15:24:37 +09:00 |
|
Dean Herbert
|
eea3d5adb8
|
Standardise column index naming and xmldoc
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
0d21c0e49c
|
Remove StageDefinition from configuration lookups
I added this for future usage, but it turns out I can get the
definitions directly from `ManiaBeatmap`.
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
4a127f5d81
|
Fix classic skin colours sourcing from triangles defaults
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
6b79f16461
|
Make Column.AccentColour bindable
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
532d101080
|
Remove unused class
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
276395f1af
|
Fix column colour not updating on skin change
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
3947011baf
|
Fix regression in legacy dual stage handling logic
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
2ae1aef0be
|
Move column initialisation to ctor and fix remaining tests
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
5fe9b953a5
|
Add back triangles column colours via a transformer
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
1a0b953846
|
Remove unnecessary Beatmap parameter in ManiaLegacySkinTransformer
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
5c48d8931a
|
Add StageDefinition to ManiaSkinConfigurationLookup and make column background colour lookup work
|
2022-10-07 15:24:36 +09:00 |
|
Dean Herbert
|
9c979044dc
|
Move AccentColour assignment to inside Column
|
2022-10-07 15:24:36 +09:00 |
|