1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-23 23:27:28 +08:00
Commit Graph

37604 Commits

Author SHA1 Message Date
Dan Balasescu
dc7573f7c7
Merge pull request #11943 from peppy/remove-simple-finalizers
Remove easy to remove finalizers
2021-03-02 20:53:09 +09:00
Dan Balasescu
d5798533c4
Merge pull request #11944 from peppy/remove-working-beatmap-finalizer
Remove WorkingBeatmap's finalizer
2021-03-02 20:52:57 +09:00
Dan Balasescu
2aae9b6600
Merge branch 'master' into remove-working-beatmap-finalizer 2021-03-02 19:14:16 +09:00
Dan Balasescu
20825b4b78
Merge pull request #11945 from peppy/fix-confine-setting-disable-mode
Fix confine mode dropdown becoming visible again after filtering
2021-03-02 19:06:49 +09:00
smoogipoo
30ff0b83c1 Fix test failures due to unpopulated room 2021-03-02 19:06:21 +09:00
Dean Herbert
3af4c9e717
Merge pull request #11946 from peppy/update-framework
Update framework
2021-03-02 18:38:08 +09:00
Dean Herbert
0300a55447 Update framework 2021-03-02 18:00:50 +09:00
Dean Herbert
6372a0265a Fix confine mode dropdown becoming visible again after filtering
Changes from a hidden to a disabled state, with a tooltip explaining
why.

Closes #11851.
2021-03-02 17:44:58 +09:00
Dean Herbert
103dd4a6ce Remove WorkingBeatmap's finalizer 2021-03-02 16:14:43 +09:00
Dean Herbert
c4ba045df1 Add note about finalizers required for audio store clean-up 2021-03-02 16:07:51 +09:00
Dean Herbert
fa95929121 Remove easy to remove finalizers 2021-03-02 16:07:09 +09:00
Dean Herbert
a75537142d
Merge pull request #11939 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.1
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
2021-03-02 11:28:00 +09:00
Dean Herbert
424d4b909b
Merge pull request #11933 from ppy/dependabot/nuget/Moq-4.16.1
Bump Moq from 4.16.0 to 4.16.1
2021-03-02 11:27:51 +09:00
Dean Herbert
90e55d268c
Merge pull request #11936 from ppy/dependabot/nuget/Sentry-3.0.7
Bump Sentry from 3.0.1 to 3.0.7
2021-03-02 11:27:44 +09:00
dependabot-preview[bot]
7829a0636e
Bump Sentry from 3.0.1 to 3.0.7
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.0.1 to 3.0.7.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.0.1...3.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:47 +00:00
dependabot-preview[bot]
b03efd6940
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:45 +00:00
dependabot-preview[bot]
d6925d0960
Bump Moq from 4.16.0 to 4.16.1
Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/moq/moq4/releases)
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md)
- [Commits](https://github.com/moq/moq4/compare/v4.16.0...v4.16.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:44 +00:00
Dean Herbert
22da76c510
Merge pull request #11937 from ppy/dependabot/nuget/SharpCompress-0.28.1
Bump SharpCompress from 0.27.1 to 0.28.1
2021-03-02 09:42:53 +09:00
Dean Herbert
e29f6684ae
Merge pull request #11938 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.3
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack from 5.0.2 to 5.0.3
2021-03-02 09:42:25 +09:00
Salman Ahmed
2609b22d53 Replace usage of CurrentModeRank in line with API change 2021-03-01 23:07:25 +03:00
dependabot-preview[bot]
9db37e62d8
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.2...v5.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-01 20:05:53 +00:00
dependabot-preview[bot]
2d3c3c18d4
Bump SharpCompress from 0.27.1 to 0.28.1
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.27.1 to 0.28.1.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.27.1...0.28.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-01 20:05:35 +00:00
Salman Ahmed
51a5652666 Refetch tournament users on null country rank 2021-03-01 22:42:53 +03:00
Salman Ahmed
fe54a51b5a Remove UserRanks object and move to outer country_rank property 2021-03-01 22:42:20 +03:00
smoogipoo
5cfaf1de1b Fix duplicate ongoing operation tracker 2021-03-01 17:43:03 +09:00
smoogipoo
7adb33f40e Fix beatmap getting nulled due to failing web request 2021-03-01 17:24:54 +09:00
smoogipoo
f7e4cfa4d0 Fix initial room settings not being returned correctly 2021-03-01 17:24:32 +09:00
smoogipoo
97bb217830 Fix test room playlist items not getting ids 2021-03-01 17:24:05 +09:00
Salman Ahmed
d528ef426f Reposition legacy spinner components in-line with osu!stable 2021-02-28 22:59:22 +03:00
Salman Ahmed
41b43dd39a Add nested legacy-simulating coordinates container 2021-02-28 21:32:56 +03:00
Dean Herbert
3bb46cd8cc
Merge pull request #11916 from bdach/restore-default-transform-mutation
Fix restore default button potentially mutating transforms during load
2021-02-28 12:40:17 +09:00
Dean Herbert
af5cea6287
Merge pull request #11918 from bdach/fix-setting-source-multiple-enumeration
Fix multiple enumerations when ordering setting sources
2021-02-28 00:19:05 +09:00
Bartłomiej Dach
7e17c5ab71 Trim yet another array copy 2021-02-27 15:46:18 +01:00
Bartłomiej Dach
1e56d2cbba Make SettingSourceAttribute implement IComparable 2021-02-27 15:30:08 +01:00
Bartłomiej Dach
7b6e53680c Add coverage for the unordered case 2021-02-27 15:14:25 +01:00
Bartłomiej Dach
dd2f63f313 Add assertions to actually check order 2021-02-27 14:58:05 +01:00
Bartłomiej Dach
528de5869e Fix multiple enumerations when ordering setting sources
This was not spotted previously, because the base `Attribute` overrides
`Equals()` to have semantics similar to structs (per-field equality) by
using reflection. That masked the issue when strings were used, and
migrating to `LocalisableString` revealed it, as that struct's
implementation of equality currently uses instance checks.

Whether `LocalisableString.Equals()` is the correct implementation may
still be up for discussion, but allowing multiple enumeration is wrong
anyway, since the underlying enumerables are live (one especially is a
yield iterator, causing new object instances to be allocated).
2021-02-27 14:58:01 +01:00
Bartłomiej Dach
87b73da73e Add failing test case 2021-02-27 14:57:55 +01:00
Bartłomiej Dach
52e81385a6 Fix restore default button mutating transforms during load 2021-02-27 11:39:18 +01:00
Dean Herbert
46fa82e4a7
Merge pull request #11909 from peppy/update-framework
Update framework
2021-02-26 20:37:37 +09:00
Dean Herbert
4fd8501c86 Remove unnecessary using (underlying enumerator change) 2021-02-26 20:03:03 +09:00
Dean Herbert
98d525d1db Update framework 2021-02-26 19:56:10 +09:00
Dan Balasescu
6bf5df407d
Merge pull request #11908 from peppy/fix-drawings-flag-sizing
Fix tournament drawings screen flags being too big
2021-02-26 19:02:36 +09:00
Dan Balasescu
b1702273c8
Merge pull request #11904 from peppy/editor-centralise-selection-change-handling
Centralise cases of performing actions on the current selection
2021-02-26 19:01:30 +09:00
Dan Balasescu
e80db89def
Merge pull request #11903 from peppy/fix-chat-post-error-display
Show API human readable error message when chat posting fails
2021-02-26 19:00:17 +09:00
Dan Balasescu
d7f3519bd7
Merge pull request #11907 from peppy/fix-import-from-stable-no-beatmaps-message
Fix "failed to import" message showing when importing from a stable install with no beatmaps
2021-02-26 18:45:54 +09:00
Dean Herbert
1ac82af19a Adjust flag size to fit again 2021-02-26 17:58:23 +09:00
Dean Herbert
1ab449b73e Add test scene for drawings screen 2021-02-26 17:54:54 +09:00
Dan Balasescu
5558084b86
Merge pull request #11906 from peppy/reduce-notifications-alloc-overhead
Reduce allocation overhead when notification overlay has visible notifications
2021-02-26 17:54:12 +09:00
Dean Herbert
7e6bd0e995 Fix "failed to import" message showing when importing from a stable install with no beatmaps 2021-02-26 17:30:59 +09:00