Shivam
c94f95cc0d
Check if the file exists before reading
...
This is (also) to address the review from bdach about StorageManager initialising a default value that gets overwritten upon migration anyway.
2020-06-24 02:40:22 +02:00
Shivam
af11340849
Fix nullref exceptions and redundant explicit type
2020-06-24 02:13:28 +02:00
Shivam
c32ef5e718
Address formatting issues
2020-06-24 00:37:29 +02:00
Shivam
9d2392b6b1
Cache TournamentStorage as Storage and only cast when necessary
2020-06-24 00:14:44 +02:00
Shivam
e5851be9ad
change accessor from internal readonly to public get-only
...
Also changes the class accessor from internal to public
2020-06-24 00:06:27 +02:00
Shivam
0ca8c961c8
Remove string interpolation & unnecessary test setup
2020-06-24 00:05:30 +02:00
Shivam
7a3315dcf8
invert and early return
2020-06-24 00:00:21 +02:00
Shivam
8e8458ab8f
make migrate public abstract in base and override
2020-06-23 23:58:28 +02:00
Shivam
8b9cf6fc52
Remove default value in Storagemgr
2020-06-23 23:57:58 +02:00
Shivam
e0d5a9182e
make tournament migration private
2020-06-22 12:59:56 +02:00
Shivam
6b14079c0a
InspectCode changes
2020-06-22 12:43:01 +02:00
Shivam
08759da3a7
Move drawings.ini out of config subfolder
2020-06-22 12:41:43 +02:00
Shivam
291dadf0b2
Merge branch 'master' of https://github.com/ppy/osu into tourney-asset-refactor
2020-06-22 12:01:24 +02:00
Shivam
f878388d57
Fix TestMigrationToSeeminglyNestedTarget failing
2020-06-22 11:56:14 +02:00
Dean Herbert
fc31d49629
try-catch registry lookup to avoid crashes on non-windows platforms
2020-06-22 16:34:04 +09:00
Dean Herbert
2d121b4e3d
Simplify lookup fallback code
2020-06-22 16:32:27 +09:00
Dean Herbert
1df89c6a59
Merge branch 'master' into custom-ipc-location
2020-06-22 16:22:04 +09:00
Shivam
dd9697032c
Introduce new class MigratableStorage
2020-06-16 17:39:20 +02:00
Shivam
02d66c4856
Refactor moving (2/2)
2020-06-16 17:15:43 +02:00
Shivam
b75fd7bfa8
Refactor moving logic (1/2)
2020-06-16 17:14:54 +02:00
Shivam
29ae1c460a
TournamentStorage now takes in a parent storage
2020-06-16 17:00:20 +02:00
smoogipoo
d57b58a7dd
Add temporary fix for tournament song bar disappearance
2020-06-15 18:47:55 +09:00
Bartłomiej Dach
51bbd91373
Bring back initial directory behaviour
2020-06-13 19:28:21 +02:00
Bartłomiej Dach
eb92c3390d
Check for nulls when looking for ipc.txt
2020-06-13 17:17:58 +02:00
Bartłomiej Dach
2cadab8d29
Add xmldoc
2020-06-13 16:20:59 +02:00
Bartłomiej Dach
5dd47bf393
Remove unnecessary members
2020-06-13 16:03:34 +02:00
Bartłomiej Dach
e0518fd451
Fix silent failure
2020-06-13 15:38:29 +02:00
Bartłomiej Dach
34cd9f7a69
Streamline autodetect & manual set path
2020-06-13 15:32:30 +02:00
Bartłomiej Dach
992aa0041e
Allow auto-detect to work after choosing manually
2020-06-13 15:27:46 +02:00
Bartłomiej Dach
586d5791e0
Remove unused argument
2020-06-13 15:07:41 +02:00
Bartłomiej Dach
1cd96b8002
Rework StableInfo into a DI'd data structure
2020-06-13 15:06:07 +02:00
Bartłomiej Dach
5f79feaa8b
Merge branch 'master' into custom-ipc-location
2020-06-13 13:41:59 +02:00
Dean Herbert
5041c74c7a
Fix merge issue
2020-06-12 11:30:15 +09:00
Dean Herbert
5ef3a3f188
Merge branch 'master' into tourney-asset-refactor
2020-06-12 11:23:05 +09:00
Dean Herbert
80140842dc
Merge branch 'master' into headless-tournamentgamebase
2020-06-12 10:51:37 +09:00
Shivam
56a40e616b
Add drawings to the migration test
2020-06-11 20:11:44 +02:00
Shivam
592e3bf4c9
Implement migrations for the drawings config file
2020-06-11 18:21:56 +02:00
Shivam
32d86d6fab
Create storage for config files of a tournament
2020-06-11 18:07:24 +02:00
Shivam
327795ba99
Switch drawing storage to tournamentstorage
2020-06-11 18:00:47 +02:00
Shivam
c9dc17f3d8
Introduce migrations for drawings
2020-06-11 17:51:07 +02:00
Shivam
222ac86304
Add newlines at the end of the file
2020-06-11 15:52:14 +02:00
Shivam
af1bbe7857
move TournamentVideoResourceStore to separate file
2020-06-11 15:13:19 +02:00
Shivam
2964b457a0
Rename VideoStorage to VideoStore
2020-06-11 15:05:28 +02:00
Shivam
5d49b709b9
Change access modifier public -> internal
2020-06-11 14:09:21 +02:00
Shivam
a317b85fd8
Remove misleading log
2020-06-11 14:06:03 +02:00
Shivam
b69ff307d8
Fixed migration logic
2020-06-11 13:56:16 +02:00
Shivam
c2e01e198f
Rename tournamentStorage to storage
2020-06-11 13:55:29 +02:00
Shivam
a43e1a0ae3
Remove whitespace
2020-06-10 08:41:13 +02:00
Shivam
0f39558da2
Apply review comment
2020-06-10 08:04:34 +02:00
Shivam
aacacd75f0
Remove abstract from the class
2020-06-09 21:14:05 +02:00
Shivam
af05ee67cb
move base.loadcomplete to the bottom
2020-06-09 20:30:15 +02:00
Shivam
e57a229474
Move all the graphics related code to TournamentGame
2020-06-09 20:22:30 +02:00
Shivam
417919320c
change namespace to osu.Game.Tournament.IO
2020-06-09 17:28:42 +02:00
Dean Herbert
3ae1df07b0
Fix a couple more new formatting issues
2020-06-10 00:09:29 +09:00
Dean Herbert
7dc19220e5
Apply new resharper formatting fixes
2020-06-09 23:38:54 +09:00
smoogipoo
88aed1d504
Merge branch 'master' into update-inspectcode-version
2020-06-09 20:12:39 +09:00
Shivam
2f15d7fbac
Code styling fixes
2020-06-08 20:04:38 +02:00
Shivam
d2ae146c1f
Remove unnecessary parameters and implement delete
2020-06-08 19:51:44 +02:00
Shivam
ce66b72390
Refactor paths
2020-06-08 18:25:20 +02:00
Shivam
f01a86f5b1
Fix styling issues and move StorageManager to Configuration Folder
2020-06-08 03:12:37 +02:00
Shivam
ba5a747ac9
Implement migration for TournamentStorage
2020-06-08 03:03:57 +02:00
Shivam
9a20ffa8a3
Rename to TournamentStorage
2020-06-08 00:47:47 +02:00
Shivam
17cd9569ed
Introduce new storage class and manager
2020-06-08 00:46:40 +02:00
Dean Herbert
9920911390
Fix tournament displayed beatmap potentially being out of order on quick changes
2020-06-04 17:20:08 +09:00
Shivam
7e5db5e933
Apply review suggestions
2020-06-03 23:49:06 +02:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
Dean Herbert
78fddc8957
Make button match height
2020-06-02 19:29:59 +09:00
Dean Herbert
828180ad9b
Add default
2020-06-02 19:29:22 +09:00
Shivam
fea5c8460a
Fixed path is empty exception
...
Also converted method to property get, private set
2020-06-01 22:50:24 +02:00
Shivam
33d731644c
Fix test crashing: NullReferenceException
2020-05-31 17:35:53 +02:00
Shivam
ce360a960f
use GameHost's GetStorage instead of local storage
...
This will now get the IPC Path again as the default path if one is present, else it will fall back to osu! lazer's base path.
2020-05-31 16:50:13 +02:00
Shivam
0027f44bd0
Moved stableInfo read to FileBasedIPC
...
DI is also not needed anymore to access StableInfo, this goes through FileBasedIPC.
Note: directory selector now always navigates to the osu! lazer base path.
2020-05-31 16:27:05 +02:00
Shivam
3731e76b10
Move stable_config declaration, rename testscene
2020-05-28 15:28:27 +02:00
Shivam
7ae2383288
move stable config declaration and initial reading
2020-05-28 15:03:49 +02:00
Bartłomiej Dach
748f7fcd8b
Rename constants
2020-05-25 20:20:26 +02:00
Bartłomiej Dach
ca68d94cf7
Invert if to reduce nesting
2020-05-25 20:18:17 +02:00
Bartłomiej Dach
719da48922
Rename delegate argument
2020-05-25 20:11:00 +02:00
Shivam
4c3900cfc8
Remove unnecessary comments, simplify initialPath and clarified TestScene name
2020-05-25 17:16:40 +02:00
Olle Kelderman
a174117880
fix flowcontainer order properly and removed todo as its decided to do nothing there for now
2020-05-25 00:55:10 +02:00
Olle Kelderman
1062e07ec1
refactor and implemented feedback:
...
- button text change
- renamed ActionableInfoWithNumberBox to ResolutionSelector and moved the clamping logic inside it
- also removed the ugly right margin and added the FillFlowContainer
2020-05-24 22:24:46 +02:00
Shivam
c6345ba6c9
corrected styling issues
2020-05-22 20:01:26 +02:00
Shivam
0717dab8e4
Add StablePathSelectScreen visual test
2020-05-22 19:51:08 +02:00
Olle Kelderman
554be1c422
add the ability to set the size of the Tournament Client to an arbitrary value instead of a fixed 1080p option
2020-05-22 19:25:05 +02:00
Shivam
585100207c
make CheckExists static public and removed unnecessary code
2020-05-20 22:30:31 +02:00
Shivam
d2416ce30d
removed redundant code and use existing checkExists
2020-05-20 22:16:37 +02:00
Shivam
a5c2f97a76
use common const in TournamentGameBase
2020-05-20 22:15:51 +02:00
Shivam
b1c957c5e1
invert if-statement and early return + reuse of checkExists
2020-05-20 17:25:53 +02:00
Shivam
15ebe38303
Return null if path is not found, for clarity
2020-05-20 17:13:35 +02:00
Shivam
e018d07441
Use one constant for STABLE_CONFIG location string
2020-05-20 16:30:38 +02:00
Shivam
a0a54efd4e
Fix test crashing because of sceneManager not being nullable
2020-05-18 01:05:34 +02:00
Shivam
7a839c1486
Renamed Refresh button to Change source
2020-05-18 00:50:08 +02:00
Shivam
9bfdfbea43
Move stablestorage check to path selection screen
...
Also forced stablepath to be empty during auto detection so it checks other sources to load ipc from
2020-05-18 00:47:31 +02:00
Shivam
59b006f9ac
Make IPC error dialog reusable
...
and inspectcode fixes
2020-05-17 22:46:43 +02:00
Shivam
a97100216c
Changed behaviour of refresh button in SetupScreen
2020-05-17 22:28:54 +02:00
Shivam
fbbf51851e
Moved refresh button to directoryselector
2020-05-17 22:28:24 +02:00
Shivam
4bc858a215
Force a read of the location file during detection
2020-05-17 22:27:44 +02:00
Shivam
80d188ec91
Update xmldoc with accurate information about the model
2020-05-17 22:26:42 +02:00
Shivam
181cd67948
Merge remote-tracking branch 'upstream/master' into custom-ipc-location
2020-05-17 12:44:12 +02:00
Dean Herbert
13d4997c91
Remove custom back action logic (use receptor as intended)
2020-05-17 17:35:10 +09:00
Dean Herbert
864c1a73ae
Only add back button if required
2020-05-17 17:27:52 +09:00