Dean Herbert
|
d5239d550a
|
Add refetch for non-managed hide/restore attempts
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
46e92c3b60
|
Clean up BeatmapManager query methods
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
9beabad6a4
|
Remove hide/restore event flow
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
c06b5951fd
|
Fix multiple remaining warnings
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
7509a9ff8f
|
Update BeatmapModelManager.Save to work for editor scenarios
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
8c3dc4333d
|
Fix incorrect realm access after new beatmap import
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
2ce80cc030
|
Add back caching in WorkingBeatmapCache
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
286994a808
|
Fix BeatmapDifficulty cloning regression
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
f451560203
|
Update null allowances across beatmaps and scores
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
6033a825ed
|
Ensure BeatmapInfo Difficulty and Metadata is non-null
|
2022-01-12 17:49:11 +09:00 |
|
Dean Herbert
|
a0f8debafe
|
Add note about BeatmapMetadata.Author being weird
|
2022-01-12 17:49:10 +09:00 |
|
Dean Herbert
|
83ccbc1d13
|
Mention safety failures of Beatmap/Score constructors
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
c831e9107a
|
Fix BeatmapInfo.Clone potentially not cloning if already detached
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
e5af673b01
|
Fix incorrect BeatmapInfo.ToString implementation
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
e74a5022c9
|
Fix multiple tests via null checks and changing ToLive to Detach
flow
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
76670a8faa
|
Fix BeatmapDifficultyCache not working with detached beatmaps
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
aaefd72c69
|
Handle ignored mappings locally in Detach configuration
|
2022-01-12 17:00:17 +09:00 |
|
Dean Herbert
|
8461eaab46
|
BeatmapSetInfo detach support
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
3811bd8520
|
Fix some null inspections
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
33060990b7
|
Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
0793b0f0ab
|
Fix Max lookup methods not checking for zero beatmap count
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
dcd69e852e
|
Add back settable RulesetID for now
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
2a980cc474
|
Fix BeatmapInfo file lookup not handling the case where no files exist
Quite common for test scenes.
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
99e46cd26b
|
Fix missing BeatmapMetadata.ToString
This is relied on by a few usages.
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
fe8a5e867d
|
Remove updated/removed flow method mapping
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
1f9318265e
|
Update ToLive usages in line with recent changes
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
db05727ec4
|
Remove unused includeProtected parameter
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
b91f309879
|
Inline query methods from BeatmapModelManager to BeatmapManager where possible
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
1d536fd0bc
|
Start introducing ILive
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
8696f82627
|
Fix intro screen
Fix things
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
c4a9211179
|
Apply NRT to BeatmapManager and move Hide/Restore methods across
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
8d943b5709
|
Fix many shortcomings and compatibility issues with EF classes post-rename
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
d7fe3584cd
|
Don't persist Countdown to realm for now
It's another enum which is a pain to handle, and not actually being
consumed anywhere.
|
2022-01-12 17:00:16 +09:00 |
|
Dean Herbert
|
00e3af3366
|
Update model manager and many related classes to get things compiling again
|
2022-01-12 17:00:00 +09:00 |
|
Dean Herbert
|
a5df01ff47
|
Add score importer
|
2022-01-12 16:57:27 +09:00 |
|
Dean Herbert
|
8c0db79ec1
|
Remove BeatmapStore and update surrounding code
|
2022-01-12 16:57:27 +09:00 |
|
Dean Herbert
|
b8cd3cdbbc
|
Various updates to ruleset and primary key usages to move closer to realm support
|
2022-01-12 16:57:13 +09:00 |
|
Dean Herbert
|
b77bb2f12b
|
Switch BeatmapModelManager to use RealmArchiveModelManager base class
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
116f35c52a
|
Remove EF FileStore
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
89d6ffa7f3
|
Use RealmContextFactory instead of EF
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
df088f96f4
|
Fix incorrect Metadata-related null checks
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
6a671b0a52
|
Remove unnecessary assigns of BeatmapSetInfo.Metadata
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
fda529de26
|
Update usages of APIUser to RealmUser
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
213d89b479
|
Update null fallback cases involving OnlineID
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
c3df58e01c
|
Add required properties to make realm models backwards compatible
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
618903c217
|
Rename realm to become imposter classes
|
2022-01-12 16:39:36 +09:00 |
|
Dean Herbert
|
0b6c4497bd
|
Rename EF classes to allow for shit to hit the fan
|
2022-01-12 16:39:36 +09:00 |
|
Dan Balasescu
|
38a51b9ce0
|
Add comment
|
2022-01-11 13:54:12 +09:00 |
|
Dan Balasescu
|
81fed4c6bf
|
Use time=0 as for the first control point
|
2022-01-11 12:55:17 +09:00 |
|
Dean Herbert
|
3cd996eb4a
|
Merge branch 'master' into async-deadlock-safety
|
2022-01-07 17:28:59 +09:00 |
|
Dean Herbert
|
00177a3ae1
|
Update usages to new naming
|
2022-01-06 22:54:43 +09:00 |
|
Dean Herbert
|
3ea7588a91
|
Update continuation usages to use GetCompletedResult
|
2022-01-06 22:53:07 +09:00 |
|
Dean Herbert
|
374dac57f2
|
Change expanded card content height to 200
|
2022-01-04 13:22:00 +09:00 |
|
Dean Herbert
|
73b40e6833
|
Replace usage of .Result with .WaitSafelyForResult
|
2022-01-04 11:51:41 +09:00 |
|
Bartłomiej Dach
|
0ad555e9f7
|
Remove surplus blank line
|
2022-01-03 18:33:32 +01:00 |
|
Dean Herbert
|
b9851b278d
|
Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds
Closes https://github.com/ppy/osu/issues/16120.
|
2022-01-03 13:18:28 +09:00 |
|
Joseph Madamba
|
7de43e3aba
|
Fix most open compound words in identifiers being closed
|
2021-12-27 20:26:28 -08:00 |
|
Bartłomiej Dach
|
3ca238825b
|
Unify width of normal and extra card sizes
|
2021-12-24 09:17:07 +01:00 |
|
Bartłomiej Dach
|
a49a4329ee
|
Add capability to switch between card sizes
|
2021-12-23 15:55:37 +01:00 |
|
Bartłomiej Dach
|
cd4c1bc678
|
Add factory method for various card sizes
|
2021-12-23 15:55:36 +01:00 |
|
Dean Herbert
|
f179ff33c9
|
Remove all NRT changes
This reverts commit bb9877adab.
|
2021-12-22 21:02:06 +09:00 |
|
Dean Herbert
|
bb9877adab
|
Reapply IWorkingBeatmap nullability fixed
|
2021-12-22 20:48:48 +09:00 |
|
Dean Herbert
|
bc47801cbb
|
Revert "Apply NRT to WorkingBeatmap"
This reverts commit 9e17d7d4e3.
|
2021-12-22 19:14:18 +09:00 |
|
Dean Herbert
|
9e17d7d4e3
|
Apply NRT to WorkingBeatmap
|
2021-12-22 18:41:45 +09:00 |
|
Dean Herbert
|
53c0a6708f
|
Move public accessor properties to top of file
|
2021-12-22 18:25:09 +09:00 |
|
Dean Herbert
|
a5f77a86ef
|
Move load methods and rename loadedTrack to match other private fields
|
2021-12-22 18:24:51 +09:00 |
|
Dean Herbert
|
7344c87b16
|
Remove RecyclableLazy
|
2021-12-22 18:18:12 +09:00 |
|
Dean Herbert
|
f3f491374b
|
Remove unused load checks
|
2021-12-22 18:17:00 +09:00 |
|
Dean Herbert
|
3c95497ed7
|
Reorder methods to hopefully make more sense
|
2021-12-22 18:17:00 +09:00 |
|
Dean Herbert
|
e38e4c0adc
|
Enable NRT on IWorkingBeatmap
|
2021-12-22 18:17:00 +09:00 |
|
Dean Herbert
|
967419c9ac
|
Remove BeatmapSetInfo and Metadata from interface
There were very few accesses to this, and after realm they should all be
done via the `BeatmapInfo`, so let's remove this.
|
2021-12-22 18:17:00 +09:00 |
|
Dean Herbert
|
1b0af78831
|
Simplify WorkingBeatmap in multiple ways
Just a clean-up pass.
|
2021-12-22 18:17:00 +09:00 |
|
Dean Herbert
|
b38b300159
|
Convert BeatmapMetadata access to be via a computed property
|
2021-12-22 18:17:00 +09:00 |
|
Bartłomiej Dach
|
c7b9b176c6
|
Rename BeatmapCard{Base => }
|
2021-12-21 08:26:25 +01:00 |
|
Bartłomiej Dach
|
88d4e95ad8
|
Rename BeatmapCard{ => Normal}
|
2021-12-21 08:26:21 +01:00 |
|
Bartłomiej Dach
|
33e930f477
|
Move scale-on-expand logic to BeatmapCardContent
|
2021-12-17 13:29:20 +01:00 |
|
Bartłomiej Dach
|
d6f6039934
|
Extract base class for beatmap cards
|
2021-12-17 13:27:11 +01:00 |
|
Bartłomiej Dach
|
f052b47d87
|
Extract collapsible button container for card usage
|
2021-12-17 12:58:05 +01:00 |
|
Bartłomiej Dach
|
7aab12d4b0
|
Share extra row dropdown show/cancel show logic
|
2021-12-17 11:45:05 +01:00 |
|
Bartłomiej Dach
|
3fa45479b0
|
Share hype/nomination statistic show logic
|
2021-12-17 11:45:05 +01:00 |
|
Bartłomiej Dach
|
c6d0b5d200
|
Merge branch 'master' into beatmap-card/extra-wip
|
2021-12-17 11:11:36 +01:00 |
|
Bartłomiej Dach
|
54790bb758
|
Merge branch 'master' into fix-realm-post-storage-migration-failure
|
2021-12-17 00:19:46 +01:00 |
|
Dean Herbert
|
ad430a6277
|
Centralise hover state handling (and fix back-to-front conditionals)
|
2021-12-15 16:44:58 +09:00 |
|
Dean Herbert
|
6a1f535257
|
Refactor cancellation of expand to be more explicit
|
2021-12-15 16:38:19 +09:00 |
|
Dean Herbert
|
94d1a2aaca
|
Remove unnecessary collapse call from BeatmapCard
This is already handled at the `BeatmapCardContent` level. This call
actually causes the buggy behaviour reported in
https://github.com/ppy/osu/discussions/16085.
|
2021-12-15 16:37:47 +09:00 |
|
Dean Herbert
|
7a9db22c52
|
Tidy up method naming and structure for expanded state changes
|
2021-12-15 16:29:12 +09:00 |
|
Dean Herbert
|
ef4ab74565
|
Also only expose Expanded state of BeatmapCard as read-only
|
2021-12-15 16:26:19 +09:00 |
|
Dean Herbert
|
41e6c24dad
|
Expose Expanded state of BeatmapCardContent as read-only bindable
This is just to reduce complexity of these interactions by ensuring that
the expanded state can only be changed by the class itself.
|
2021-12-15 16:26:19 +09:00 |
|
Dean Herbert
|
f9a2db5ec6
|
Add accessibility to realm factory via IStorageResourceProvider
We might need to rename this class..
|
2021-12-14 14:19:49 +09:00 |
|
Bartłomiej Dach
|
083ee92dee
|
Adjust button vertical padding
|
2021-12-08 22:56:28 +01:00 |
|
Bartłomiej Dach
|
2d739c95ea
|
Lay out extra card statistics in grid as per design
|
2021-12-08 22:56:28 +01:00 |
|
Bartłomiej Dach
|
3ecfaa532c
|
Add source field to extra beatmap card
|
2021-12-08 22:56:28 +01:00 |
|
Bartłomiej Dach
|
419fee1380
|
Move mapper link to bottom content
|
2021-12-08 22:54:11 +01:00 |
|
Bartłomiej Dach
|
61e04f75cc
|
Resize extra card to design size
|
2021-12-08 22:54:10 +01:00 |
|
Bartłomiej Dach
|
a32492cdd5
|
Duplicate BeatmapCard{-> Extra} as blueprint for extra card size
|
2021-12-08 22:53:51 +01:00 |
|
Dean Herbert
|
8d9c37a825
|
Merge branch 'master' into primary-key-consistency
|
2021-12-08 21:34:38 +09:00 |
|
Dean Herbert
|
25a0505c97
|
Scale card when expanding to better distinguish hovered card from other cards in listing
|
2021-12-07 23:48:14 +09:00 |
|
Bartłomiej Dach
|
82ed8eae6b
|
Ensure hover handling container always calls base on hover events
|
2021-12-06 21:02:40 +01:00 |
|
Bartłomiej Dach
|
ccfc361626
|
Apply naming suggestions
|
2021-12-06 21:02:38 +01:00 |
|
Bartłomiej Dach
|
0f74389389
|
Add scrolling for long difficulty lists in beatmap card
|
2021-12-05 20:17:59 +01:00 |
|
Bartłomiej Dach
|
af35652b8b
|
Disable beatmap card expansion on solo spectator screen
|
2021-12-05 20:07:58 +01:00 |
|
Bartłomiej Dach
|
e451e43b90
|
Implement input handling behaviour of beatmap card dropdown
|
2021-12-05 16:31:45 +01:00 |
|
Bartłomiej Dach
|
250e5b47b7
|
Move "extra info" beatmap card row to separate component
|
2021-12-05 15:52:19 +01:00 |
|
Bartłomiej Dach
|
3fea8d5e62
|
Implement visual behaviour of expanded card state
|
2021-12-05 15:48:02 +01:00 |
|
Bartłomiej Dach
|
a07f8c74dc
|
Add basic structure for composable card dropdown
|
2021-12-05 15:26:37 +01:00 |
|
Bartłomiej Dach
|
38702beabf
|
Merge branch 'master' into i-ruleset-store
|
2021-12-04 15:05:39 +01:00 |
|
Dean Herbert
|
e75e209053
|
Cache and consume IRulesetStore where feasible
|
2021-12-03 18:16:01 +09:00 |
|
Dean Herbert
|
9c717ce7ec
|
Merge branch 'master' into diffcalc-cli-arg
|
2021-12-03 15:10:55 +09:00 |
|
Bartłomiej Dach
|
45656c3599
|
Fix difficulty spectrum display not ordering ruleset groups by ID
|
2021-11-29 22:06:11 +01:00 |
|
Bartłomiej Dach
|
0fc4d6dc2a
|
Implement beatmap card difficulty list
|
2021-11-29 22:04:09 +01:00 |
|
Dean Herbert
|
a7e4e7be3a
|
Remove the ability to specify a filename in ReplaceFile
|
2021-11-29 18:11:51 +09:00 |
|
Dan Balasescu
|
e5dcfc3113
|
Use console IPC
|
2021-11-28 14:03:21 +09:00 |
|
Bartłomiej Dach
|
05f7ea6b6d
|
Remove mentions of "panel" and "direct" from names of old download buttons
|
2021-11-27 15:08:03 +01:00 |
|
Bartłomiej Dach
|
a043d1e427
|
Move old beatmap download button to more general namespace
|
2021-11-27 15:06:57 +01:00 |
|
Bartłomiej Dach
|
7419682334
|
Move icon pill to beatmap card-specific namespace
|
2021-11-27 15:01:48 +01:00 |
|
Dean Herbert
|
f16ef1ee69
|
Reapply schedule workaround for PreviewTrack
|
2021-11-26 22:34:05 +09:00 |
|
Dean Herbert
|
bf443a5a7a
|
Switch unnecessary return to break instead
|
2021-11-26 15:36:16 +09:00 |
|
Dean Herbert
|
5de2f6211d
|
Show a spinner instead of the download button on the new card during beatmap download
|
2021-11-26 15:32:33 +09:00 |
|
Bartłomiej Dach
|
84a36ab4a9
|
Add integration with beatmap set overlay
|
2021-11-25 22:30:46 +01:00 |
|
Dan Balasescu
|
f712aeee01
|
Merge pull request #15795 from peppy/realm-integration/separate-download-flow
Split out download logic from main manager classes
|
2021-11-25 20:59:23 +09:00 |
|
Dan Balasescu
|
d7a960212f
|
Merge pull request #15794 from peppy/realm-integration/stable-export-flow
Split out legacy model export logic into `LegacyModelExporter` classes
|
2021-11-25 20:20:18 +09:00 |
|
Dan Balasescu
|
2b85738384
|
Merge pull request #15797 from peppy/remove-pointless-i-beatmap-model-manager
Remove pointless interface class for `IBeatmapModelManager`
|
2021-11-25 19:07:19 +09:00 |
|
Dean Herbert
|
a6ee0eec0d
|
Remove pointless interface class for IBeatmapModelManager
Was originally going to be used but serves no purpose any more.
|
2021-11-25 18:15:10 +09:00 |
|
Dean Herbert
|
eeccf836ec
|
Remove unnecessary GameHost parameter
|
2021-11-25 17:42:41 +09:00 |
|
Dean Herbert
|
716543b5b3
|
Move beatmap download logic out of BeatmapManager
|
2021-11-25 17:29:41 +09:00 |
|
Dean Herbert
|
cc1b91e4bd
|
Split out legacy model export logic into LegacyModelExporter classes
|
2021-11-25 16:41:12 +09:00 |
|
Dean Herbert
|
7488ccd5fe
|
Update all models to implement IHasNamedFiles
|
2021-11-25 16:41:12 +09:00 |
|
Dean Herbert
|
416ee2447a
|
Move archive filename helper method to extension method
|
2021-11-25 16:35:54 +09:00 |
|
Dean Herbert
|
6cab7b877d
|
Move stable import handling into its own class
|
2021-11-25 15:36:58 +09:00 |
|
Dean Herbert
|
1533e245de
|
Merge pull request #15767 from bdach/beatmap-card/track-preview
Add preview track playback function to beatmap card
|
2021-11-25 12:08:03 +09:00 |
|
Dan Balasescu
|
ce8500a732
|
Merge branch 'master' into remove-model-file-list-inits
|
2021-11-24 19:46:42 +09:00 |
|
Dean Herbert
|
b739b6a725
|
Merge branch 'master' into beatmap-card/track-preview
|
2021-11-24 18:54:25 +09:00 |
|
Dean Herbert
|
183b95cbc2
|
Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus
This variable is used at more than just a set level.
|
2021-11-24 18:42:49 +09:00 |
|
Dean Herbert
|
ddbd4f9473
|
Merge branch 'master' into remove-model-file-list-inits
|
2021-11-24 18:39:01 +09:00 |
|
Dan Balasescu
|
5ff62a8e04
|
Merge pull request #15779 from peppy/remaining-misc-fixes
Apply some various code quality fixes that don't fit elsewhere
|
2021-11-24 16:59:49 +09:00 |
|
Dan Balasescu
|
74b6c33fab
|
Merge pull request #15778 from peppy/ruleset-info-id-usage
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
|
2021-11-24 16:55:28 +09:00 |
|
Dan Balasescu
|
834bdd8e5c
|
Merge pull request #15776 from peppy/non-null-beatmapset-metadata
Make `BeatmapSet.Metadata` non-null
|
2021-11-24 16:48:28 +09:00 |
|
Dan Balasescu
|
8ce5324c8b
|
Merge pull request #15772 from peppy/remove-model-list-inits
Initialise `BeatmapSet.Beatmaps` list at construction time
|
2021-11-24 16:41:19 +09:00 |
|
Dean Herbert
|
3e0e01abdb
|
Move bookmark parsing logic into LegacyBeatmapDecoder
|
2021-11-24 16:29:51 +09:00 |
|
Dean Herbert
|
9c61ec217b
|
Remove unnecessary mainTrackMixer parameter from BeatmapManager
|
2021-11-24 16:27:17 +09:00 |
|
Dean Herbert
|
bbd3ea5b77
|
Update all actual usages of RulesetInfo.ID to use OnlineID instead
|
2021-11-24 15:50:26 +09:00 |
|
Dean Herbert
|
3946a39b65
|
Make BeatmapSet.Metadata non-null
|
2021-11-24 15:03:34 +09:00 |
|
Dean Herbert
|
a7853fc9cc
|
Fix cases of known-non-null
|
2021-11-24 14:26:25 +09:00 |
|
Dean Herbert
|
99a139dc98
|
Initialise all file lists at construction time (and remove setter)
|
2021-11-24 13:56:21 +09:00 |
|
Dan Balasescu
|
6183d1cd46
|
Merge pull request #15769 from peppy/model-equality-consistency
Update cases where equality can be used instead of primary key equality
|
2021-11-24 13:45:57 +09:00 |
|
Dean Herbert
|
a3fdab34d5
|
Avoid json serialisation of aggregate helper properties
Also avoids `throw`ing when there are no beatmaps available. Until now
this wasn't an issue due to the `Beatmaps` list being null instead of empty.
|
2021-11-24 13:36:34 +09:00 |
|
Dean Herbert
|
8c60f37508
|
Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
|
2021-11-24 13:27:37 +09:00 |
|
Dean Herbert
|
49c2cb9125
|
Initialise BeatmapSet.Beatmaps list to line up with realm expectations
|
2021-11-24 13:25:55 +09:00 |
|
Dean Herbert
|
729f681938
|
Update cases where equality can be used instead of primary key equality
|
2021-11-24 12:49:57 +09:00 |
|
Dean Herbert
|
0eea026afb
|
Remove null checks on CreateInstance() calls
|
2021-11-24 12:23:09 +09:00 |
|