10500 Commits

• Assert expected behaviour in test
  Bartłomiej Dach · 2025-10-24 10:23:36 +02:00
  f0bfb4becc
• Merge pull request #35400 from bdach/leaderboard-sometimes-incorrectly-partial

  Fix solo leaderboard sometimes not showing user position while it technically could

  Dean Herbert · 2025-10-24 14:36:14 +09:00
  4f478db056
• Merge pull request #35415 from bdach/local-user-state-refactor

  Extract all pieces of local user-related state to `APIAccess` subcomponent

  Dean Herbert · 2025-10-24 14:32:43 +09:00
  646cb71b77
• Extract all pieces of local user-related state to APIAccess subcomponent

  Something I've asked to be done for a long time. Relevant because I've
  complained about this on every addition of a new piece of user-local
  state: friends, blocks, and now favourite beatmaps.
  
  It's just so messy managing all this inside `APIAccess` next to
  everything else, IMO.

  Bartłomiej Dach · 2025-10-23 10:53:58 +02:00
  5eda9a0fd7
• Fix solo leaderboard sometimes not showing user position while it technically could

  The "partial" leaderboard logic in `SoloGameplayLeaderboardProvider`
  always assumed the online fetch would request 50 scores, which is no
  longer the case after https://github.com/ppy/osu/pull/33100.

  Bartłomiej Dach · 2025-10-23 08:53:29 +02:00
  ca8fc81a7e
• Fix AllowSelection blocking all input
  Dan Balasescu · 2025-10-22 19:55:43 +09:00
  5fc8cde0f7
• Add pool names to quick play pool selector (#35394)
  Dean Herbert · 2025-10-22 17:54:49 +09:00
  dcb30ed5b3
• Fix intermittent footer test failures

  See:
  https://github.com/ppy/osu/pull/35367/checks?check_run_id=53269836615
  
  Can be reproed via a `Thread.Sleep(1000)` in a `TestScreenOne` BDL load.
  Code here is similar to `OsuGameTestScene.PushAndConfirm()`.

  Dan Balasescu · 2025-10-22 16:40:20 +09:00
  62599de649
• Merge pull request #35366 from bdach/carousel-collapsing-broke

  Fix beatmap set not expanding post-filter if grouping was turned off after manually collapsing active group

  Dean Herbert · 2025-10-20 20:22:56 +09:00
  3120871298
• Merge pull request #35313 from smoogipoo/subscreen-footer

  Make `ScreenFooter` support subscreens

  Bartłomiej Dach · 2025-10-20 10:00:36 +02:00
  0af3f15c7c
• Add failing test
  Bartłomiej Dach · 2025-10-20 09:23:06 +02:00
  0269257287
• Fix quick play player panels being hard to see against bright user backgrounds
  Dean Herbert · 2025-10-18 23:18:57 +09:00
  70188d4fab
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Add footer tests involving subscreens
  Dan Balasescu · 2025-10-16 17:38:51 +09:00
  81a529200d
• Merge pull request #35236 from tadatomix/song-select/coloured-group-ranked-status

  Colour Ranked Status panel to the related status

  Dean Herbert · 2025-10-15 16:56:45 +09:00
  b8ceb91a78
• Improve design of quick play endgame results (#35267)
  Dean Herbert · 2025-10-13 22:07:21 +09:00
  f488974d39
• Quick play forward design work (#35253)

  * Remove unnecessary information from matchmaking beatmap panel
  
  * Move avatar overlay inside card for better layout
  
  * Allow higher jumping when jumping in succession
  
  * Exclude player panel avatars from masking
  
  * Adjust player panel animations a bit further
  
  * Add avatar-only display mode
  
  * Fix round warmup test not working
  
  * Remove dead test scenes
  
  * Fix edge case where users are added to not-yet-loaded card
  
  * Decouple `PlayerPanel` from `UserPanel`
  
  * Fix remaining test failure (and rename test to match new naming)

  Dean Herbert · 2025-10-13 13:28:09 +09:00
  8e36533f65
• Merge branch 'master' into song-select/coloured-group-ranked-status
  Bartłomiej Dach · 2025-10-10 12:37:10 +02:00
  60544bf595
• Adjust test

  - Don't hardcode numerical enum bounds
  - Exclude `Approved` as it doesn't show in real contexts

  Bartłomiej Dach · 2025-10-10 12:34:51 +02:00
  8f0b8153eb
• Merge pull request #35252 from bdach/song-select-present-sometimes-fails

  Fix wrong beatmap shown when presenting a beatmap from results screen

  Dean Herbert · 2025-10-10 14:54:50 +09:00
  1f2928bf2f
• Fix weird xmldoc issue

  Rider was fine with it...

  Bartłomiej Dach · 2025-10-09 10:17:55 +02:00
  3fc3a53521
• Add test demonstrating failure scenario
  Bartłomiej Dach · 2025-10-09 09:46:32 +02:00
  e33de9b658
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing test
  Bartłomiej Dach · 2025-10-08 13:42:31 +02:00
  f1ec04114f
• Add a test for the new group
  tadatomix · 2025-10-07 01:21:01 +03:00
  97c95de94a
• Merge pull request #35221 from bdach/adjust-tag-threshold

  Adjust display tag threshold to match web

  Dean Herbert · 2025-10-06 20:57:26 +09:00
  19718c706a
• Add failing test scene covering song select left hover action not always activating
  Dean Herbert · 2025-10-06 18:21:10 +09:00
  d08b5a72b7
• Adjust display tag threshold to match web

  Follow-up to https://github.com/ppy/osu-web/pull/12381 - tags will glow
  green starting from 5 votes rather than 10 to match the new threshold
  web-side.

  Bartłomiej Dach · 2025-10-06 11:09:54 +02:00
  b286f05c78
• Merge branch 'master' into song-select-reselect-group-for-selection-when-moving-left
  Dean Herbert · 2025-10-06 16:57:57 +09:00
  8a450563fd
• Merge pull request #35176 from bdach/local-modified-beatmap-regressions

  Fix a few issues regarding incorrect treatment of locally-modified beatmaps

  Dean Herbert · 2025-10-06 16:22:09 +09:00
  dd846dcc52
• Add failing test scene
  Bartłomiej Dach · 2025-10-03 09:24:37 +02:00
  ae4e015352
• Add failing test case
  Bartłomiej Dach · 2025-10-02 13:24:24 +02:00
  e7076b9582
• Add failing test coverage for no score submission attempt on known locally modified beatmap
  Bartłomiej Dach · 2025-10-02 09:16:17 +02:00
  44a1a5ffc7
• Merge pull request #35154 from smoogipoo/matchmaking-events

  Add structure and support for jumping in quick play rooms

  Dean Herbert · 2025-10-02 13:57:00 +09:00
  37a11b5592
• Add failing test case
  Bartłomiej Dach · 2025-10-01 14:17:16 +02:00
  0230a27de6
• Merge pull request #35126 from Joehuu/song-select-silver-terminology

  Use silver S/SS terminology when grouping by rank/grade in song select

  Bartłomiej Dach · 2025-10-01 13:30:50 +02:00
  b980183e98
• Merge pull request #35163 from bdach/carousel-stop-re-expanding-group

  Do not forcibly re-expand carousel groups on refilters if the user manually collapsed them

  Dean Herbert · 2025-10-01 16:33:59 +09:00
  345ae29770
• Merge branch 'master' into song-select-silver-terminology
  Bartłomiej Dach · 2025-10-01 08:32:07 +02:00
  03455ba683
• Add tests covering desired UX
  Bartłomiej Dach · 2025-09-30 15:24:35 +02:00
  4b2f3efcbd
• Demonstrate failure in test
  Bartłomiej Dach · 2025-09-30 13:19:03 +02:00
  ac2df49c35
• Merge pull request #35149 from smoogipoo/qp-fix-nullref

  Fix nullref when users leave quick-play rooms

  Dean Herbert · 2025-09-30 19:23:05 +09:00
  a078d4bdb4
• Add ability to jump in quick play
  Dan Balasescu · 2025-09-30 18:38:30 +09:00
  e636a09e0f
• Merge branch 'master' into qp-fix-nullref
  Dean Herbert · 2025-09-30 17:46:53 +09:00
  9860bba2f3
• Merge pull request #35151 from bdach/maybe-fix-bss-clicking

  Ensure submission progress sample is stopped when transitioning into a final state

  Dean Herbert · 2025-09-30 17:29:21 +09:00
  bb9b4a2827
• Merge pull request #35145 from tadatomix/song-select/coloured-group-ranks

  Colour Rank Achieved panels to the related rank

  Dean Herbert · 2025-09-29 23:40:28 +09:00
  838b8d3013
• Ensure submission progress sample is stopped when transitioning into a final state

  Probably closes https://github.com/ppy/osu/issues/35138. I'm not sure. I
  only got the issue to reproduce once, on dev, using a very large
  archive that was uploading really slowly, and then never again.
  
  The working theory is that basically handling of `progressSampleChannel`
  is quite dodgy and it could possibly, in circumstances unknown, be
  allowed to play forevermore after transitioning to failed / canceled
  state. Success state does not get this treatment because it has special
  logic to set progress to 1.

  Bartłomiej Dach · 2025-09-29 15:30:45 +02:00
  2c39e1e9db
• Add failing test
  Dan Balasescu · 2025-09-29 16:55:54 +09:00
  82beeec730
• Avoid passing the same thing three times
  Bartłomiej Dach · 2025-09-29 09:42:33 +02:00
  9dc79e6f0d
• Add a new test for Rank Achieved panels
  tadatomix · 2025-09-28 23:10:32 +03:00
  6ac4f482ee
• Remove pointless TestSceneMatchmakingScreenStack

  Should always be using `TestSceneMatchmakingScreen` right?

  Dean Herbert · 2025-09-26 15:48:29 +09:00
  3af4edf051