137 Commits

• Fix android build again

  Another month, another freak android build failure.
  
  From what I can tell, this time the build is broken because the second-
  -to-last workaround applied to fix it, namely explicitly specifying
  the version of workloads to install, stopped working, presumably because
  github pushed a new .NET SDK version to runners, and microsoft didn't
  actually put up a set of workload packages whose version matches the
  .NET SDK version 1:1.
  
  Thankfully, the fix to the *last* android build breakage (which caused
  the workload installation to completely and irrecoverably fail), appears
  to be rolling out this week, and *also* fix that same second-last issue,
  so both workarounds of specifying the workload version and pinning the
  image to `windows-2019` appear to no longer be required.
  
  Note that the newest image version, 20250209.1.0, is still not fully
  rolled out yet, thus rather than just fix all builds, this will fix like
  20% of builds until the newest image is fully rolled out. But I guess
  a 20% passing build is better than a 0% passing build, in a sense...?

  Bartłomiej Dach · 2025-02-12 14:18:03 +01:00
  ee6dcbd808
• Roll back windows build image to 2019 on android build job

  Per workaround suggested in
  https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501.
  
  Applying this now as my hopes for a swift resolution without changes on
  our side are slim to none (read thread linked above in full to learn
  why).

  Bartłomiej Dach · 2025-01-23 10:12:30 +01:00
  b4e8a17f03
• Allow tsunyoku and stanriders to trigger diffcalc spreadsheet generator
  Dan Balasescu · 2024-12-11 09:59:18 +09:00
  315a9dba9b
• Fix android workflow not installing .NET 8 version
  Salman Alshamrani · 2024-11-27 23:46:21 -05:00
  19e396f878
• Make android build on non-maui workflow
  Dan Balasescu · 2024-11-18 17:20:11 +09:00
  02deb39335
• Adjust job name
  Dan Balasescu · 2024-11-11 13:44:11 +09:00
  91d9c0a7e8
• Enforce concurrency by using single job

  I've yet again re-confirmed by doubts about using concurrency groups.
  It's just not flexible enough. In this case, it cancels any _future_
  jobs.

  Dan Balasescu · 2024-11-11 13:40:17 +09:00
  0b570c4e15
• Fix empty JSON sent on non-workflow_dispatch events
  Dan Balasescu · 2024-11-11 13:11:21 +09:00
  394ff88a62
• Don't fail grep if no matches
  Dan Balasescu · 2024-11-11 13:02:26 +09:00
  c1686fb687
• Fix wrong cleaned up directory
  Dan Balasescu · 2024-11-11 12:49:23 +09:00
  a3b8c4d127
• Set -euo pipefail in diffcalc workflows
  Dan Balasescu · 2024-11-11 12:49:23 +09:00
  2767054286
• Rename workflow
  Dan Balasescu · 2024-11-09 23:49:30 +09:00
  5e8df623d4
• Split diffcalc workflow to add concurrency group
  Dan Balasescu · 2024-11-09 19:59:20 +09:00
  6183daa95f
• Merge pull request #30543 from smoogipoo/fix-ci-report

  Fix up + improve CI test reporting workflow

  Bartłomiej Dach · 2024-11-08 08:37:22 +01:00
  ce9c74af85
• Fix CI test report workflow
  Dan Balasescu · 2024-11-08 11:55:24 +09:00
  233560b867
• Skip diffcalc job if target is not valid

  Same as all other jobs... Just so that it doesn't appear as "completed"
  in the workflow list.

  Dan Balasescu · 2024-11-07 19:15:58 +09:00
  cb2e5ac2c4
• Update GHA
  Dan Balasescu · 2024-11-06 14:02:01 +09:00
  4b9f9b9be5
• Fix argument order in diffcalc workflow
  Dan Balasescu · 2024-10-17 16:57:00 +09:00
  1536a9886c
• Improve diffcalc workflow with explicit wait + logs
  Dan Balasescu · 2024-10-17 13:44:00 +09:00
  135b85a55a
• Overwrite downloaded data packages

  In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002, I cancelled the run during the download from `data.ppy.sh`.
  
  In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857, `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download.
  
  The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process.
  
  Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...

  Dan Balasescu · 2024-10-13 18:43:02 +09:00
  9681e3ac46
• Save master state in workflow
  Dan Balasescu · 2024-10-07 18:52:13 +09:00
  639caf167d
• Make diffcalc workflow recreate comment on completion
  Dan Balasescu · 2024-10-07 15:50:59 +09:00
  c7f2564c0a
• Rollback iOS workload to last known working version
  Dan Balasescu · 2024-10-05 23:00:04 +09:00
  232381c9fb
• Fix iOS CI build
  Dan Balasescu · 2024-09-27 16:26:11 +09:00
  cb51e12d13
• Remove macOS/Xcode version pinning in iOS workflow
  Salman Ahmed · 2024-08-08 13:03:09 +03:00
  e12dba24ae
• Disable macOS test runs for now

  We are seeing update frames run as little as [once per
  second](https://github.com/ppy/osu/blob/aa4d16bdb873d7296b899cee7b7491ffdf5cd6ab/osu.Game/Overlays/BeatmapListingOverlay.cs#L141).
  Until we can ascertain why this is happening, let's reduce developer
  stress by not running macOS tests for now.

  Dean Herbert · 2024-07-25 09:05:58 +09:00
  4cc07badbd
• Raise workflow timeout time

  https://github.com/ppy/osu/actions/runs/9985890747/job/27597500883

  Dan Balasescu · 2024-07-18 16:26:40 +09:00
  7bb680a8a4
• Add frenzibyte to users that can use diffcalc workflow
  Dan Balasescu · 2024-07-08 13:58:42 +09:00
  9375f79879
• Update action versions in diffcalc workflow
  Dan Balasescu · 2024-03-29 00:25:32 +09:00
  cbbb46cad8
• Update diffcalc workflow
  Dan Balasescu · 2024-03-27 13:37:47 +09:00
  4490dbf896
• Update github actions to resolve most node deprecation warnings

  As is github tradition, workflows started yelling about running on a
  node version that was getting sunset, so here we go again.
  
  Relevant bumps:
  
  - https://github.com/actions/checkout/releases/tag/v4.0.0
  - https://github.com/actions/setup-dotnet/releases/tag/v4.0.0
  - https://github.com/actions/cache/releases/tag/v4.0.0
  - https://github.com/actions/setup-java/releases/tag/v4.0.0
  - https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0
  - https://github.com/dorny/test-reporter/releases/tag/v1.8.0
  
  Notably, `actions/upload-artifact` is _not_ bumped to v4, although it
  should be to resolve the node deprecation warnings, because it has more
  breaking changes and bumping would break `dorny/test-reporter`
  (see https://github.com/dorny/test-reporter/issues/363).

  Bartłomiej Dach · 2024-02-22 17:18:10 +01:00
  99bbbf810b
• Use Xcode 15.2
  Dan Balasescu · 2024-02-02 21:28:52 +09:00
  ec4f3577c0
• Adjust CI workflows
  Dan Balasescu · 2024-02-02 21:28:51 +09:00
  a217a7f8cf
• Wrap echo in double quotes
  Dan Balasescu · 2023-11-28 22:12:23 +09:00
  979bbf0d81
• Remove manual changes to Xcode versions in CI
  Rowe Wilson Frederisk Holme · 2023-11-23 01:18:55 +08:00
  9fd0641238
• Fix android compile failures due to invalid java version

  See https://github.com/ppy/osu-framework/pull/6057.

  Bartłomiej Dach · 2023-11-22 07:55:41 +09:00
  aa72407065
• Attempt to support quotes in handling of GH comment body
  Dan Balasescu · 2023-11-10 14:52:20 +09:00
  93ff82bc80
• Only run cleanup if directory was created
  Dan Balasescu · 2023-10-20 18:58:32 +09:00
  3c3b0a15a6
• Cleanup in a step
  Dan Balasescu · 2023-10-20 11:35:31 +09:00
  6c61894514
• Add cleanup step
  Dan Balasescu · 2023-10-20 11:34:08 +09:00
  e3bbf29333
• Remove repo checkout step
  Dan Balasescu · 2023-10-20 11:32:11 +09:00
  6cf0cbf3a9
• Fix wrong variable
  Dan Balasescu · 2023-10-20 11:24:16 +09:00
  634323e71e
• Isolate diffcalc workflow runs
  Dan Balasescu · 2023-10-20 09:44:10 +09:00
  d73650331d
• Fix incorrect PR url in diffcalc workflow
  Dan Balasescu · 2023-10-19 15:19:51 +09:00
  832ba861bb
• Pin third-party actions
  Dan Balasescu · 2023-10-19 02:39:34 +09:00
  14cadd1eeb
• Run timeout job on self-hosted runner
  Dan Balasescu · 2023-10-17 21:01:23 +09:00
  4946b437c9
• Delete comment on cancellation

  - Add always() pre-condition to force evaluation.
  
  - Message is set as it's required by the action for a non-error status code.

  Dan Balasescu · 2023-10-17 20:51:28 +09:00
  566b09ff20
• Use action for GHA diffcalc workflow permissions check
  Dan Balasescu · 2023-10-17 20:28:04 +09:00
  08845ec1c6
• Remove duplicated usage instructions
  Dan Balasescu · 2023-10-05 14:09:58 +09:00
  2e0ca45773
• Add description
  Dan Balasescu · 2023-10-05 13:32:20 +09:00
  bca257eeda