Salman Ahmed
caa90bccc6
Fix default skin potentially added twice in RulesetSkinProvidingContainer
2021-06-22 03:45:43 +03:00
Salman Ahmed
627c857da8
Propagate SourceChanged
events from SkinManager
down in the ruleset skin container
2021-06-22 03:45:24 +03:00
Salman Ahmed
9e5bb146d3
Add xmldoc to SkinManager
...
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
2021-06-22 03:07:31 +03:00
Salman Ahmed
97dbc7f20e
Add back SkinManager.DefaultSkin
to the ruleset skin lookup sources
2021-06-22 02:54:34 +03:00
Salman Ahmed
d53a43cf3c
Isolate RulesetSkinProvidingContainer
from falling back to parent skin sources
...
For simplicity of lookup order, and which sources are used for the lookup.
2021-06-22 02:53:22 +03:00
Salman Ahmed
ebe0d43790
Add ability to disallow falling back to parent skins
2021-06-22 02:51:17 +03:00
aitani9
36e459e97e
Use margin instead of padding
2021-06-21 13:42:15 -07:00
Naxess
629c98e6a0
Add time distance equality tests
2021-06-21 15:34:11 +02:00
Naxess
e11139eadf
Add low difficulty overlap tests
...
Moq is introduced to mock sliders' end time/position. This is already used similarly in `osu.Game.Tests`.
2021-06-21 15:33:50 +02:00
Naxess
2f3f4f3e4b
Add new checks to verifier
2021-06-21 15:30:45 +02:00
Naxess
fcb918d0e1
Add time distance equality check
2021-06-21 15:30:23 +02:00
Naxess
3eb088f89a
Add low difficulty overlaps check
2021-06-21 15:30:04 +02:00
Dean Herbert
5b9bf54f1f
Merge pull request #13545 from frenzibyte/legacy-spinner-approach-circle
...
Add support for legacy spinner approach circles
2021-06-21 18:52:06 +09:00
Salman Ahmed
999bf27eae
Remove unnecessary abstraction of ApproachCircle
property
2021-06-21 12:07:00 +03:00
JimmyC7834
b162da5ee0
minor code change
2021-06-21 15:47:47 +08:00
Salman Ahmed
ba15f7c19b
Move ApproachCircle
out of the scale container and revert relevant changes
2021-06-21 10:47:38 +03:00
JimmyC7834
22cc1e1452
fixed code style base on code analysis
2021-06-21 15:31:47 +08:00
JimmyC7834
b42aedeb81
fixed code style
2021-06-21 14:43:54 +08:00
JimmyC7834
3367456304
fixed SupporterRequiredDrawable style
2021-06-21 14:30:54 +08:00
JimmyC7834
044c2aa99d
Merge branch 'master' of https://github.com/JimmyC7834/osu into supporter-only-filter-content
2021-06-21 14:27:54 +08:00
JimmyC7834
0707642b76
fixed SupporterRequiredDrawable
2021-06-21 14:25:20 +08:00
Dan Balasescu
7d31943ff5
Merge pull request #13597 from Joehuu/fix-beatmap-discussion-links
...
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-21 14:52:55 +09:00
Salman Ahmed
036b745425
Remove no longer needed LegacySpinnerApproachCircle
2021-06-21 08:41:10 +03:00
Salman Ahmed
42edbe4fb9
Move ApproachCircle
implementation into per-style
2021-06-21 08:40:38 +03:00
Joseph Madamba
6fda5e569a
Fix beatmap discussion links wrongly leading to beatmap page
2021-06-20 21:37:00 -07:00
Joseph Madamba
8b2110c048
Add failing discussion links test
2021-06-20 21:36:08 -07:00
Salman Ahmed
68e28f4903
Implement IHasApproachCircle
in DrawableHitCircle
as well
2021-06-21 07:35:07 +03:00
Salman Ahmed
11b78ad849
Make TestPlayer
skin assigning logic not flaky
2021-06-21 06:46:00 +03:00
Dean Herbert
2d1794f7d8
Merge pull request #13596 from Joehuu/update-rulesets-link
...
Update custom rulesets directory link in readme
2021-06-21 12:09:34 +09:00
Joseph Madamba
e4705abee2
Update custom rulesets directory link in readme
2021-06-20 20:07:46 -07:00
Salman Ahmed
5cfd0e3223
Remove implicit LegacySkin
check and refactor anything using it
2021-06-21 04:16:58 +03:00
Salman Ahmed
01478d780d
Generalize IHasSpinnerApproachCircle
from being spinner-specifc
2021-06-21 03:43:11 +03:00
Salman Ahmed
72155a7c52
Replace if pattern-matching check with switch cases instead
2021-06-21 03:37:50 +03:00
JimmyC7834
d0a8b74823
fixed filter text order
2021-06-20 21:28:57 +08:00
JimmyC7834
996503eb2d
fixed filter text display, added visual tests
2021-06-20 21:23:54 +08:00
Dean Herbert
c624ec79b1
Merge pull request #13575 from bdach/realm-on-xamarin
...
Add direct references to Realm from Xamarin projects
2021-06-20 21:51:25 +09:00
Dean Herbert
70d3a882f8
Merge pull request #13591 from smoogipoo/revert-gc-change
...
Remove high performance GC setting
2021-06-20 21:11:11 +09:00
JimmyC7834
e7aeba8d03
added more visual tests
2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1
added visual tests
2021-06-20 17:17:07 +08:00
smoogipoo
32bd3107e1
Remove high performance GC setting
2021-06-20 17:07:41 +09:00
Bartłomiej Dach
1f383532f2
Move FodyWeavers configuration to solution root
2021-06-20 10:05:49 +02:00
Bartłomiej Dach
46b9fd9ac8
Remove and ignore FodyWeavers schema files
2021-06-20 10:05:42 +02:00
Salman Ahmed
c3217fd8b1
Remove leftover approach circle skin component
2021-06-19 20:10:32 +03:00
Salman Ahmed
c04b09520d
Replace spinner approach circle proxying logic with hooking up to OnSkinChange
in mod
2021-06-19 20:06:28 +03:00
JimmyC7834
27da3dc75a
added supporter-only-filter content
2021-06-19 20:54:24 +08:00
Bartłomiej Dach
fa87aa6be5
Add autogenerated FodyWeavers files to Xamarin projects
2021-06-19 11:11:30 +02:00
Bartłomiej Dach
805e6cca75
Add direct references to Realm from Xamarin projects
...
Fixes crashes on launch due to missing `realm-wrapper` transitive
dependency.
2021-06-19 11:07:13 +02:00
Dean Herbert
b6e07ff59c
Merge pull request #13572 from bdach/fix-unsupported-locales
...
Fix game crashes due to attempting localisation load for unsupported locales
2021-06-19 17:09:39 +09:00
Dean Herbert
afcc3e14f4
m
2021-06-19 16:16:29 +09:00
Bartłomiej Dach
b47774b55a
Remove Tagalog language for now
...
Rationale given in inline comment.
2021-06-19 08:07:37 +02:00