Dan Balasescu
746862dcb1
Merge pull request #12750 from peppy/skin-serialisation
...
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
Naxess
94538b3842
Remove accidental whitespace
2021-05-13 12:56:36 +02:00
Dan Balasescu
a3869c02f4
Merge branch 'master' into fix-two-hovered-handles
2021-05-13 19:24:42 +09:00
Dean Herbert
c8b7cfc753
Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
2021-05-13 19:05:08 +09:00
Naxess
19800f5f7f
Move IBeatmap
arg into context
2021-05-13 11:24:22 +02:00
Dean Herbert
e0e9106921
Enable autoplay in skin editor tests
2021-05-13 14:55:11 +09:00
Naxess
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
Dean Herbert
8b9ac86d4b
Merge branch 'master' into skin-serialisation
2021-05-13 12:35:06 +09:00
smoogipoo
5b03092968
Fix possible test failure
2021-05-13 11:53:50 +09:00
Andrei Zavatski
13a956f6fc
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-12 20:08:17 +03:00
Dean Herbert
55e1f97f59
Remove unused using statement
2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15
Remove remaining test usage of SkinnableXXX
HUD components
2021-05-12 18:53:25 +09:00
Salman Ahmed
80e231d90a
Add failing test case
2021-05-12 11:42:55 +03:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
...
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
smoogipoo
273cd18b8a
Use test streaming client in gameplay leaderboard test
2021-05-12 14:19:36 +09:00
smoogipoo
21fc0ba43b
Combine test spectator streaming client implementations
2021-05-12 13:05:02 +09:00
Naxess
c13b93e6f1
Replace IWorkingBeatmap
arg with BeatmapVerifierContext
in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
Andrei Zavatski
085c3d067f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 23:41:45 +03:00
Andrei Zavatski
b0297c6324
Fix incorrect no posts handling and add corresponding test
2021-05-11 20:52:11 +03:00
Andrei Zavatski
822d99e69f
Remove pointless test scenes
2021-05-11 20:42:13 +03:00
Dean Herbert
048677846b
Change HealthDisplay
to be a CompositeDrawable
2021-05-11 23:10:30 +09:00
Andrei Zavatski
b79a0237a3
Fix TestSceneNewsYearsPanel error
2021-05-11 16:54:19 +03:00
Andrei Zavatski
c2ba16f977
Use relative sizing for MonthDropdown
2021-05-11 16:51:59 +03:00
Andrei Zavatski
208224cc0d
CI fixes
2021-05-11 16:08:09 +03:00
Andrei Zavatski
705aad262a
Rename MonthPanel to MonthDropdown
2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413
Move metadata change logic to it's own method
2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1
Cache metadata in NewsSideBar
2021-05-11 15:33:27 +03:00
Andrei Zavatski
82436334b2
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 13:52:51 +03:00
smoogipoo
f5bc389998
Fix flaky tests
2021-05-11 19:31:32 +09:00
smoogipoo
bc4213eea1
Add test for changing back to idle on deletion
2021-05-11 19:26:58 +09:00
smoogipoo
7fe8737d94
Add failing tests
2021-05-11 19:21:44 +09:00
smoogipoo
811282a975
Add failing test
2021-05-11 19:01:41 +09:00
Dean Herbert
61ea3f2e64
Remove unnecessary test step creating needless skins
2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6
Change HealthDisplay
to be a CompositeDrawable
2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb
Merge branch 'master' into multiplayer-spectator-screen
2021-05-11 17:33:09 +09:00
Dan Balasescu
7d9cdd3bc2
Merge branch 'master' into skin-components-list
2021-05-11 17:27:48 +09:00
Salman Ahmed
004ce95f33
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-11 09:53:10 +03:00
smoogipoo
7c8dd91674
Rename test to better match tested class
2021-05-11 09:29:15 +09:00
Dean Herbert
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls
...
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
Andrei Zavatski
220eef0351
Remove overcomplicated date logic in MonthPanel
2021-05-10 17:00:18 +03:00
Andrei Zavatski
fbf8b198cd
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-10 16:47:15 +03:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown
2021-05-10 20:02:04 +09:00
Dean Herbert
2ecd638f7f
Merge branch 'master' into skin-components-list
2021-05-10 18:13:10 +09:00
Andrei Zavatski
0d243be457
CI fixes
2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932
Implement NewsSideBar component
2021-05-10 09:53:52 +03:00
Dean Herbert
97e72849af
Fix regressed HitErrorDisplay
behaviour (and localise binding to meter implementations)
2021-05-10 15:24:13 +09:00
Salman Ahmed
ca772b60b1
Use regular test steps rather than one-time set up and scheduling
2021-05-10 08:56:30 +03:00
Salman Ahmed
301dab1ce8
Refactor StarRatingDisplay
to be mutable with a current bindable
2021-05-10 08:56:30 +03:00
Andrei Zavatski
7971a2ef48
Implement MonthPanel component
2021-05-10 08:47:00 +03:00
Andrei Zavatski
7ca3e13712
Implement basic years panel
2021-05-10 07:43:01 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating
2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e
Add the osu! logo to the test scene
...
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52
Make test work without manually clicking things
2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f
Remove unnecessary ruleset switching steps
2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53
Tidy up test scene
2021-05-10 12:34:21 +09:00
Dean Herbert
3c3500d070
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5
Remove unused using statement
2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor
caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Joseph Madamba
8964d51de9
Add ability to sort by source in song select
2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-09 12:13:18 +02:00
Andrei Zavatski
879c08e666
Use UntilStep instead of Assert to check button visibility
2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05
Use FirstOrDefault instead of First
2021-05-09 09:12:37 +03:00
Swords
1a465c60ca
Rename Tests
2021-05-09 16:07:18 +10:00
Ibby
075350e125
Adding a reset button to individual keybinds
2021-05-09 15:51:17 +10:00
Andrei Zavatski
8868439ce4
Another approach to fix test scene failure
2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17
Fix potential test scene failure due to showMoreButton not being loaded in time
2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Andrei Zavatski
342c5a5938
Add tests to indicate the issue
2021-05-09 04:49:40 +03:00
Salman Ahmed
8fba655d2e
Allow changing ruleset during test
2021-05-08 23:02:38 +03:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Salman Ahmed
f701c331f2
Add initial fade in to the metadata display
...
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
2021-05-08 21:19:46 +03:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Salman Ahmed
ca55287dd0
Pass empty facade and replace random property with method instead
2021-05-08 18:43:45 +03:00
Salman Ahmed
3575d9847c
Use regular test steps rather than one-time set up and scheduling
2021-05-08 18:21:29 +03:00
Salman Ahmed
d9605e8070
Remove test scene description
2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6
Fix test not handling 0 beatmap sets
2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a
Remove no longer necessary ruleset info requirement
2021-05-08 13:00:39 +03:00
Salman Ahmed
0410edecaf
Refactor StarRatingDisplay
to be mutable with a current bindable
2021-05-08 12:55:34 +03:00
Salman Ahmed
b4801faf32
Pass ruleset info to constructor instead
...
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402
Add visual test scene
2021-05-08 11:47:18 +03:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor
cached as derived type in test
2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e
Update HealthDisplay
components to use DI to attach data source
2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2
Update AccuracyCounter
components to use DI to attach data source
2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter
components to bind outwards
2021-05-07 16:16:48 +09:00
Dean Herbert
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-07 13:19:17 +09:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown
2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
91283d41ce
add paragraph test
2021-05-06 15:13:43 +07:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
Dean Herbert
cb8bda2248
Merge pull request #12503 from Denrage/split-BufferedWedgeInfo
2021-05-06 03:16:16 +09:00
Dean Herbert
fe9ade6754
Rename Container to DisplayedContent
2021-05-06 02:14:04 +09:00
Denrage
b6b9a69601
Removed unnecessary class for wrapping
2021-05-05 18:50:49 +02:00
Dean Herbert
4ef901d08d
Remove unnecessary redirection property to Container.Info
2021-05-05 21:07:49 +09:00
Dean Herbert
805ef621e9
Merge branch 'master' into play-storyboard-outro
2021-05-05 17:51:16 +09:00
Dean Herbert
3cc9bad979
Actually check for correct state of fade content in rewind test
2021-05-05 17:49:33 +09:00
Dean Herbert
62fa638515
Merge pull request #12665 from frenzibyte/stable-frame-sort
2021-05-05 14:35:25 +09:00
Christine Chen
1d4a8bc0ae
Add visual test for rewinding
2021-05-04 22:23:36 -04:00
Salman Ahmed
12c1ded7a8
Fix test scene broken on master
2021-05-05 00:28:49 +03:00
Bartłomiej Dach
f7d9fb094e
Reword & clarify comments
2021-05-04 22:59:10 +02:00
Salman Ahmed
1ac80d42f9
Merge branch 'master' into corner-rotation-controls
2021-05-04 23:53:23 +03:00
Bartłomiej Dach
9734758237
Simplify test case further
2021-05-04 22:48:57 +02:00
Salman Ahmed
45c0b74151
Use LINQ select for data assigning for simplicity
...
To avoid having to read through all of frames and ensure nothing is failing there
2021-05-04 23:41:50 +03:00
Salman Ahmed
4ceb9b1562
Avoid randomizing and overestimating logic with simple hardcoding
...
Not sure what was in my mind while I was pushing that..
2021-05-04 23:36:50 +03:00
Bartłomiej Dach
2fd596d53c
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-04 21:14:48 +02:00
Bartłomiej Dach
040d393dd4
Add visual test case for crossfade behaviour
2021-05-04 21:12:25 +02:00
ekrctb
39bccc5048
Revert "Adopt HitObjectContainer change in a test"
...
This reverts commit f55aa016
2021-05-04 16:45:24 +09:00
Salman Ahmed
e00af3e71d
Add test coverage
2021-05-04 09:45:59 +03:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro
2021-05-04 14:01:34 +09:00
Salman Ahmed
8abff4881b
Hide the corresponding rotation handle when holding scale handle
2021-05-04 07:31:55 +03:00
Dean Herbert
4f12ae2711
Merge branch 'master' into split-BufferedWedgeInfo
2021-05-04 13:28:42 +09:00
Gagah Pangeran Rosfatiputra
356b1e9a2d
add emphases test
2021-05-04 05:43:59 +07:00
Bartłomiej Dach
f52375eed2
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-03 15:58:13 +02:00
Bartłomiej Dach
b9220d4dc7
Fix possible multiple enumeration
2021-05-03 15:57:57 +02:00
Dean Herbert
4f8240f19a
Merge branch 'master' into corner-rotation-controls
2021-05-03 18:02:23 +09:00
Dean Herbert
625890381f
Update ComboCounter
components to use DI to attach data source
2021-05-03 17:43:00 +09:00
Dean Herbert
fdd0713988
Merge branch 'fix-selection-handler-visibility' into skin-bindables
2021-05-03 17:40:03 +09:00
Dean Herbert
3268a75f05
Remove intermediate container to fix tests
2021-05-03 17:35:56 +09:00
Dean Herbert
6da4105da6
Remove Sync namespace (feels unnecessary)
2021-05-03 13:38:53 +09:00
Dean Herbert
e0c129ca85
Merge branch 'master' into multiplayer-spectator-screen
2021-05-03 13:08:14 +09:00
Gagah Pangeran Rosfatiputra
b97d3f2af1
add heading test scene
2021-05-03 09:35:26 +07:00
Gagah Pangeran Rosfatiputra
88aaa9b332
add inline code colour
...
Reference : 31579d45aa/resources/assets/less/bem/osu-md.less (L12-L17)
2021-05-02 22:35:30 +07:00
Gagah Pangeran Rosfatiputra
6585dd3a3e
add image test
2021-05-23 16:30:41 +07:00
Gagah Pangeran Rosfatiputra
8f1b48d766
add test for notice box
2021-05-23 17:29:48 +07:00
Gagah Pangeran Rosfatiputra
5c1c43dea3
add link assert
2021-05-25 10:44:22 +07:00
Gagah Pangeran Rosfatiputra
98af998978
add test markdown class
2021-05-25 09:56:26 +07:00
Gagah Pangeran Rosfatiputra
a38c33841a
add test scene wiki container
2021-05-23 16:30:41 +07:00
Salman Ahmed
b145f46a0a
Merge branch 'master' into skin-components-list
2021-04-30 21:10:55 +03:00
Dan Balasescu
e6eea73b8b
Merge branch 'master' into basic-compose-checks
2021-04-30 23:41:46 +09:00
Dean Herbert
a1e64f4e3c
Use the existing toolbox design
2021-04-30 14:41:06 +09:00
Gagah Pangeran Rosfatiputra
3681db491c
add long mixed list test
...
Copied from https://github.com/ppy/osu-wiki/blob/master/wiki/Tournaments/OWC/2020/en.md#tournament-rules
2021-04-30 11:21:20 +07:00
Dean Herbert
ae9d1dc40b
Add component list to main editor interface and enable basic placement
2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f
Split out component from test scene and fix SongProgress
2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709
Add proof of concept components list
2021-04-30 13:10:42 +09:00
Gagah Pangeran Rosfatiputra
1582b0da88
add ordered list test
2021-04-30 10:43:19 +07:00
Dean Herbert
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover
2021-04-30 08:14:33 +09:00
Dean Herbert
de73ac7cec
Allow skin editor to be invoked from any context
...
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.
This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8
Add DrawableRuleset
to the skin editor test to get a hit error meter to display
2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff
Replace abstract class with interface, attached to the actual components (not skinnable wrapper)
2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7
Set defaults on SkinnableHUDComponent to cancel out relative size default
...
Specifying locally on each HUD component looks to make more sense.
2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24
Extract editor classes out of test namespace and add anchor support
2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180
Extract storable attributes to bindables
2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b
Add very basic skin editor test
2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a
Refactor editor selection/blueprint components to be generic
2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f
Setup basic test and classes for scale adjustment
2021-04-29 16:12:14 +09:00
Dean Herbert
5b009c21bb
Merge branch 'master' into abstract-blueprint-handling
2021-04-29 16:10:22 +09:00
Gagah Pangeran Rosfatiputra
171e954e89
add unordered list test
2021-04-29 13:48:00 +07:00
ekrctb
5aa522b1c2
Completely delegate DHO lifetime to Entry lifetime
...
A downside is lifetime update is not caught by LifetimeManagementContainer if used.
2021-04-29 14:38:01 +09:00
ekrctb
b88e5a31ea
Add failing test showing lifetime not recomputed with pooled objects
2021-04-29 14:38:01 +09:00
ekrctb
f55aa016be
Adopt HitObjectContainer change in a test
...
Non-pooled objects are attached as children only while alive
2021-04-29 14:38:01 +09:00
dependabot[bot]
1b3b07d6a9
Bump NUnit from 3.13.1 to 3.13.2
...
Bumps [NUnit](https://github.com/nunit/nunit ) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases )
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md )
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:12 +00:00
Dean Herbert
6cadbd48dc
Merge pull request #12603 from smoogipoo/fix-score-processor-base-score
...
Fix bonus-only maps having only 700K base score
2021-04-28 17:30:58 +09:00
Dean Herbert
f3c7694eeb
Rename methods to match generally how these find-methods are named elsewhere
2021-04-28 16:57:52 +09:00
Dan Balasescu
53d93fecd1
Merge branch 'master' into fix-download-button-import-cancel-state
2021-04-28 16:51:31 +09:00
Dean Herbert
48d6c9ac4b
Move snap/divisor helper methods to inside ControlPointInfo
2021-04-28 16:47:30 +09:00
Dean Herbert
74bf4323d1
Merge pull request #12602 from smoogipoo/setting-source-custom-control
...
Add support for custom controls to SettingSourceAttribute
2021-04-28 16:39:17 +09:00
Dean Herbert
e71dbfd730
Add inline comment regarding remaining issues with classic scoring
2021-04-28 16:37:48 +09:00
Dean Herbert
8598a0968f
Update calculations in comments to match new logic
...
Mostly look to be errors that existed before this PR.
Co-authored-by: Endrik <enduslittlecomputer@gmail.com>
2021-04-28 16:29:23 +09:00
Dean Herbert
ac1534cda2
Add test covering existing button actually changing to LocallyAvailable
state
2021-04-28 15:54:40 +09:00
Gagah Pangeran Rosfatiputra
4e691ce4b0
add test link with inline text markdown
2021-04-28 11:01:54 +07:00
Gagah Pangeran Rosfatiputra
c09067c3d5
add OsuMarkdownTable
2021-04-28 10:53:12 +07:00
Gagah Pangeran Rosfatiputra
736eace00a
add OsuMarkdownQuoteBlock
...
Reference:
d56352aeef/resources/assets/less/base.less (L7-L10)
2021-04-28 10:11:29 +07:00
Gagah Pangeran Rosfatiputra
6a921af085
add OsuMarkdownSeparator
...
Reference
d56352aeef/resources/assets/less/bem/osu-md.less (L19-L21)
2021-04-28 09:23:05 +07:00
smoogipoo
61b7dc1e06
Fix bonus-only maps having 700K base score
2021-04-28 03:42:29 +09:00
smoogipoo
4e3ee77396
Add support for custom controls to SettingSourceAttribute
2021-04-28 02:51:24 +09:00
Dan Balasescu
5fc731967b
Merge pull request #12592 from ekrctb/fix-entry-lifetime
...
Fix Setting DHO's lifetime doesn't update its entry lifetime
2021-04-28 01:38:19 +09:00
Naxess
b8b6d0e861
Add tests for ClosestBeatDivisor
...
Used https://github.com/ppy/osu/pull/12558/files#diff-5c1f04c5b262ca3abbaf867aa91b62a60b66691323c286ad5aa0b75c153cc6ca as reference.
2021-04-27 16:54:47 +02:00
smoogipoo
baa6e845aa
Change to fluent assertions
2021-04-27 22:43:52 +09:00
smoogipoo
3b04aed491
Add failing test
2021-04-27 22:42:58 +09:00
Naxess
200352b750
Rename unsnap check templates
2021-04-27 13:56:05 +02:00
Dean Herbert
f2e56bd306
Refactor editor selection/blueprint components to be generic
2021-04-27 19:01:29 +09:00
ekrctb
003553aba3
Add test of HitObjectLifetimeEntry.KeepAlive behavior
2021-04-27 18:10:44 +09:00
Gagah Pangeran Rosfatiputra
6959f2a8cc
add OsuMarkdownFencedCodeBlock
...
Reference :
d56352aeef/resources/assets/less/bem/osu-md.less (L41-L45)
2021-04-27 16:01:32 +07:00
Gagah Pangeran Rosfatiputra
65aa01866e
add test scene for OsuMarkdownContainer
2021-04-27 14:38:21 +07:00
ekrctb
7980d16b4c
Add failing test showing the issue of DHO lifetime
2021-04-27 14:26:12 +09:00
Naxess
0f0870c8b8
Sort objects by time in concurrent check test
2021-04-27 00:36:26 +02:00
Naxess
ce258febf6
Rename CheckUnsnaps
-> CheckUnsnappedObjects
...
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0
Add concurrent object check tests
2021-04-26 20:22:24 +02:00
Naxess
71f880aa94
Fix duplicate code in unsnap test
2021-04-26 17:44:46 +02:00
smoogipoo
94d0b06493
Expose mute adjustment instead
2021-04-26 19:01:30 +09:00
smoogipoo
4c5a5c449a
Merge branch 'multiplayer-spectator-screen' of https://github.com/smoogipoo/osu into multiplayer-spectator-screen
2021-04-26 17:35:37 +09:00
smoogipoo
6626e70c95
Pass in master clock instead of slave clock
2021-04-26 17:30:27 +09:00
Dean Herbert
120fb8974d
Combine more instances of test player IDs
2021-04-26 17:22:16 +09:00
smoogipoo
5b4cb71cc7
Change terminology from "slave" to "player clock"
2021-04-26 17:19:44 +09:00
Dean Herbert
737a15c2d4
Extract out test player IDs to constants
2021-04-26 17:04:39 +09:00
Dean Herbert
55f383c71e
Rename test to match new MultiSpectatorLeaderboard
class name
2021-04-26 16:48:40 +09:00
Dean Herbert
6d30a1a80f
Reference constant for test startup delay
2021-04-26 16:45:20 +09:00
Naxess
9178aa1d7d
Add unsnap check tests
2021-04-26 04:48:56 +02:00
Salman Ahmed
beee318acc
Add more distance between each hit object in editor selection test
...
To avoid potentially hovering over the rotation control instead of wherever the test desired to move the mouse to.
2021-04-26 01:45:52 +03:00
Salman Ahmed
334927ed35
Remove leftover step
2021-04-25 20:13:01 +03:00
Salman Ahmed
7490511ebf
Instantiate selection box on SetUp
2021-04-25 20:03:15 +03:00
Salman Ahmed
11318fd9fc
Add test coverage
2021-04-25 10:17:36 +03:00
smoogipoo
b41897fd9b
Rename testscene to match class
2021-04-23 19:23:52 +09:00
smoogipoo
b18635341e
Rename file
2021-04-23 19:12:30 +09:00
smoogipoo
63a9484255
Expose WaitingOnFrames as mutable bindable
2021-04-23 19:11:47 +09:00
smoogipoo
b25340653d
Fix failing tests
2021-04-23 00:49:14 +09:00
smoogipoo
4f0857f946
Xmldocs and general refactorings
2021-04-22 23:52:22 +09:00
smoogipoo
ee25949751
Rename classes
2021-04-22 23:39:02 +09:00
smoogipoo
f8f9cf9412
Merge branch 'fix-initial-playingusers' into multiplayer-spectator-screen
2021-04-22 23:25:25 +09:00
smoogipoo
0ee73b8e53
Add failing test
2021-04-22 23:22:44 +09:00
smoogipoo
64579d50ac
Use only single PlayerInstance for hit sample playback
2021-04-22 22:59:47 +09:00
Dan Balasescu
be8fe47f2c
Merge branch 'master' into editor-add-nudge-shortcuts
2021-04-22 20:38:34 +09:00
smoogipoo
6df23f1301
Merge branch 'master' into multiplayer-spectator-screen
2021-04-22 20:29:24 +09:00
Dan Balasescu
b774f5b72b
Merge pull request #12526 from peppy/fix-system-message-ordering
...
Fix system messages always being displayed above standard messages
2021-04-22 18:51:25 +09:00
Dan Balasescu
0e24f2eb59
Merge pull request #12529 from peppy/editor-placement-right-click-delete
...
Allow shift+right-click deletion when in placement mode
2021-04-22 18:50:20 +09:00
Dean Herbert
a5364b224f
Add simple key based time nudging support to editor
2021-04-22 18:47:04 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-22 16:22:04 +09:00
Dean Herbert
cf1e3ea988
Add failing test covering quick shift-rightclick deletion in placement mode
2021-04-22 15:44:12 +09:00
Dean Herbert
ea3bb07924
Add test that fails on incorrect system/info message ordering
2021-04-22 14:51:14 +09:00
smoogipoo
2bea625613
Fix initial playback states not being correct
2021-04-21 23:22:11 +09:00
Denrage
0dfd0bb59d
Refactored background of BeatmapInfoWedge
2021-04-21 15:46:11 +02:00
Denrage
9fba87f67a
Moved Info and Background into own container
2021-04-21 15:43:29 +02:00
Gagah Pangeran Rosfatiputra
416e08ae7a
add dummy response API in TestSceneWikiOverlay
...
`TestSceneNewsOverlay` is used as example for this test.
2021-04-21 17:25:13 +07:00
smoogipoo
e78ef05fcf
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-21 17:11:14 +09:00
smoogipoo
31c5fb350f
Merge branch 'master' into gcc-abstraction
2021-04-21 16:33:36 +09:00
Bartłomiej Dach
a2afa38a3f
Merge branch 'master' into fix-mod-customisation-input-blocking-padding
2021-04-20 19:41:25 +02:00
Bartłomiej Dach
881043bc5d
Fix failing test after mod settings layout changes
...
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.
Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
Dean Herbert
26430e3cb5
Merge pull request #12492 from Naxesss/bg-audio-quality-checks
...
Add background and audio checks
2021-04-21 00:10:32 +09:00
smoogipoo
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
Naxess
c0318a4d3e
Fix usage of _ in Moq lambdas
2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f
Add file hash to file presence test
...
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
smoogipoo
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
smoogipoo
f144661c31
Fix storyboard sample test scene
2021-04-20 18:26:30 +09:00
Gagah Pangeran Rosfatiputra
460d656a0e
initial wiki overlay
2021-04-21 16:21:07 +07:00
Denrage
505a117862
splitted updateable part of wedge
2021-04-20 10:37:52 +02:00
smoogipoo
5da18c51a4
Fix compile error
2021-04-20 17:27:37 +09:00
smoogipoo
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
smoogipoo
281c2041b2
Add failing test
2021-04-20 16:51:00 +09:00
smoogipoo
88ded95e75
Ensure clock is set in GCC.Start()
2021-04-20 13:56:13 +09:00
Naxess
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
Naxess
2bb079ea14
Add audio quality check tests
2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e
Simplify background quality test names
2021-04-20 01:32:22 +02:00
Naxess
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Denrage
c73bbf0aa7
Fixed Tests
2021-04-19 19:24:58 +02:00
Bartłomiej Dach
97573fb11d
Merge branch 'master' into combo-colours-display
2021-04-19 18:21:57 +02:00
Dean Herbert
fc41ad65f8
Merge pull request #12447 from smoogipoo/fix-non-60fps-recording
...
Record every 60fps interval
2021-04-19 23:26:58 +09:00
Gagah Pangeran Rosfatiputra
5117c51105
initial wiki header
2021-04-19 16:24:47 +07:00
smoogipoo
c12848ce4d
Apply fixes to tests
2021-04-19 17:02:59 +09:00
smoogipoo
5397f4faba
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-19 16:49:06 +09:00
jvyden
a854ce429a
add blank line between method
2021-04-18 23:49:13 -04:00
jvyden
999f2d810c
Fix accidentally removed code
2021-04-18 23:30:07 -04:00
Christine Chen
fd1241cc85
Added tests
...
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
jvyden
e44d11667c
Merge remote-tracking branch 'upstream'
2021-04-18 23:04:35 -04:00
jvyden
c39ab2c692
Add SessionStaticsTest
2021-04-18 23:04:28 -04:00
jvyden
b727faace3
Revert changes to IdleTracker
2021-04-18 23:03:43 -04:00
Christine Chen
98460c8feb
Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
2021-04-18 20:20:14 -04:00
Bartłomiej Dach
577755ee19
Add placeholder when no colours are visible
...
Will be removed once combo colours are mutable.
2021-04-18 20:46:42 +02:00
Bartłomiej Dach
0cd1aa8c1c
Add support for custom colour prefixes
2021-04-18 20:44:55 +02:00
Bartłomiej Dach
67c19df000
Add test coverage for adding/removing colours
2021-04-18 19:35:42 +02:00
Bartłomiej Dach
1b2c43b92c
Add basic structure of colour palette
2021-04-18 19:29:04 +02:00
Dean Herbert
2678089e0b
Add test case failing on selection after paste
2021-04-18 20:28:39 +09:00
Salman Ahmed
2847dd7e05
Merge branch 'master' into play-storyboard-outro
2021-04-18 06:40:22 +03:00
Christine Chen
7b1d40db7d
Remove redundant string interpolation
2021-04-17 22:13:28 -04:00
Christine Chen
e9f8fa64b8
Added a test for toggling the storyboard after the map is loaded
2021-04-17 21:49:29 -04:00
Naxess
010720de74
Factor out general file presence checking
...
This allows us to use the same method of checking for other files that should exist, for example the audio file.
By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
Naxess
0502fbb429
Add background quality check tests
2021-04-18 01:21:51 +02:00
Christine Chen
7f5b1e84a1
Update TestSceneStoryboardWithOutro.cs
...
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
2021-04-17 13:57:32 -04:00
Naxess
400f8b3938
Add GetStream
to IWorkingBeatmap
...
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
Naxess
448574e7e6
Use WorkingBeatmap
instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
jvyden
1e56f14f5b
Merge remote-tracking branch 'upstream'
2021-04-17 09:35:24 -04:00
Bartłomiej Dach
f3ea51eeed
Adjust tests to not rely on invalid assumption
2021-04-17 14:23:32 +02:00
smoogipoo
d5b26b0ab5
Fix incorrect test spectator client implementation
2021-04-16 23:01:34 +09:00
smoogipoo
4c5d4752b1
Rename classes to reduce redundant naming
2021-04-16 22:47:52 +09:00
smoogipoo
44e13a91ad
Rename test scene to match class
2021-04-16 20:51:42 +09:00
smoogipoo
a7aa3cb263
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-16 20:16:26 +09:00
smoogipoo
5e82f40d67
Merge branch 'master' into gcc-abstraction
2021-04-16 20:14:53 +09:00
jvyden
8d6c30c73b
Fix lint
2021-04-16 05:57:36 -04:00
jvyden
ec0211809f
Apply peppy's suggestions
2021-04-16 05:53:27 -04:00
smoogipoo
65a6f9f8a4
Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen
2021-04-16 18:26:46 +09:00
jvyden
d760e81a91
Fix lint
2021-04-16 05:22:41 -04:00
smoogipoo
46d2181d42
Remove now unnecessary (duplicating) test
2021-04-16 18:21:56 +09:00
smoogipoo
377e5ce6b3
Fix test incorrect sending state too often
2021-04-16 18:21:35 +09:00
jvyden
471b8e3c74
Merge branch 'master' of https://github.com/ppy/osu
2021-04-16 05:02:40 -04:00
jvyden
7d23973ef8
Reset SessionStatics on activity
...
Closes #12424
2021-04-16 05:01:58 -04:00
smoogipoo
ca74f413cd
Change to explicit method instead
2021-04-16 17:31:02 +09:00
smoogipoo
25f0f17766
Attempt to fix match subscreen test failure
2021-04-16 16:16:28 +09:00
smoogipoo
5652490d61
Fix OnUserBeganPlaying not being invoked if already watching
2021-04-16 14:11:55 +09:00
Christine Chen
b15838b220
Move storyboard outro logic to DrawableStoryboard
2021-04-16 00:59:10 -04:00
smoogipoo
5ac0eb02cd
Always add player instances at first, populate later
2021-04-16 12:25:29 +09:00
Christine Chen
45c2b72a25
Merge branch 'master' into play-storyboard-outro
2021-04-15 15:11:35 -04:00