14 Commits

• Remove usages of null-forgiving operator
  smoogipoo · 2020-06-09 22:13:48 +09:00
  ab10732a78
• Resolve NREs
  smoogipoo · 2020-06-03 16:59:37 +09:00
  8aa8d2c880
• Change containment check to overlap

  Due to scenarios wherein a formatted link ended up as part of a larger
  raw link after parsing, change the containment check to an overlap check
  and add appropriate tests for these edge cases.

  Bartłomiej Dach · 2019-10-25 00:42:58 +02:00
  661dfbefaf
• Resolve link-in-link edge case

  Testing with #6542 surfaced a crash scenario, caused by formatted links
  that had URLs in the display text, for example
  
      [mean example - https://osu.ppy.sh](https://osu.ppy.sh)
  
  In that case the outer Markdown link would get picked up once, and then
  reduced to the link text when looking for other links, leading to it
  being picked up again the second time when the raw link is found.
  
  Add a check in the raw link parsing path that ensures that the found
  URL is not a part of a bigger, pre-existing link.

  Bartłomiej Dach · 2019-10-24 15:52:55 +02:00
  cbd99cc767
• Add extended testing for Markdown links

  While reviewing #6542 it became apparent that there was another Markdown
  link format variant, used in comments that came from the web API, called
  the "inline link" style. It allows to specify the tooltip title within
  the actual URL portion, as such:
  
      [link text](https://osu.ppy.sh "tooltip text")
  
  Add tests with a couple of easy and trickier examples of such a format.
  Moreover, add a new edge case of a Markdown link with a link inside
  the display text, which during tests was detected to be problematic.

  Bartłomiej Dach · 2019-10-24 15:52:55 +02:00
  a89ea78a7a
• Add parenthesis handling to old link format

  Allow users to put both balanced round parentheses, as well as
  unbalanced escaped ones, in old style link text. The implementation
  is the same as for Markdown and new style links, except for swapping
  all instances of
  
      \[\]
  
  to
  
      \(\)
  
  for obvious reasons (different type of parenthesis requiring escaping).
  Tests also included.

  Bartłomiej Dach · 2019-09-04 00:21:27 +02:00
  08350a1aca
• Add bracket handling to Markdown link format

  Allow users to put both balanced brackets, as well as unbalanced
  escaped ones, in Markdown link text. The implementation is the exact
  same as in the case of new format links.
  
  For completion's sake, tests also included.

  Bartłomiej Dach · 2019-09-04 00:07:00 +02:00
  f04add6d9e
• Add backslash escaping to new link format

  For users to be able to add square brackets inside of links using
  the new format, the regular expression used for parsing those links
  contained a balancing group, which can be used for matching pairs
  of tokens (in this case, opening and closing brackets, in that order).
  However, this means that users could not post links with unmatched
  brackets inside of them (ie. ones that contain single brackets, or
  a closing bracket and then an opening one). Allow for escaping opening
  and closing brackets using the backslash character.
  
  The change substitutes this old fragment of the regex in the display
  text group:
  
      [^\[\]]*        // any character other than closing/opening bracket
  
  for this one:
  
      (((?<=\\)[\[\]])|[^\[\]])*
  
  The second pattern in the alternative remains the same; the first one
  performs the escaping, as follows:
  
      (
          (?<=\\)     // positive lookbehind expression:
                      // this match will succeed, if the next expression
                      // is preceded by a single backslash
          [\[\]]      // either an opening or closing brace
      )
  
  Since the entire display group is matched, unfortunately the lookbehind
  expression does not actually strip the backslashes, so they are
  manually stripped in handleMatches.
  
  As demonstrated in the unit tests attached, this also allows balanced
  brackets to be mixed with escaped ones.

  Bartłomiej Dach · 2019-09-03 23:18:39 +02:00
  a8f16503e2
• Fix some missed instances of TestCase
  Dean Herbert · 2019-05-15 18:32:29 +09:00
  1ccef61f7b
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Improve clarity and coverage of unit tests
  Dean Herbert · 2018-01-30 18:57:42 +09:00
  2ffe16d3d2
• Add many more tests
  Dean Herbert · 2018-01-30 16:38:18 +09:00
  1dbaf9b7a7
• Add back old non-visual tests
  Dean Herbert · 2018-01-29 18:37:11 +09:00
  f996acd7e6