Dao Heng Liu
e67253ed1e
remove unused code
2023-07-20 22:52:02 +01:00
Dao Heng Liu
e3a7b6969a
add confirmation dialog for Clear All button in TournamentEditorScreen
2023-07-20 22:52:02 +01:00
Dao Heng Liu
41638ff4b7
move LadderResetTeamsDialog.cs into editor screens components
2023-07-20 22:52:02 +01:00
Dao Heng Liu
8cd81681b2
reorder LadderEditorScreen tests
2023-07-20 22:52:02 +01:00
Dao Heng Liu
3510394699
add ladder editor reset teams confirmation dialog test
2023-07-20 22:52:02 +01:00
Dao Heng Liu
e7795296e2
refactor LadderResetTeamsDialog.cs
2023-07-20 22:52:02 +01:00
Dao Heng Liu
2833497e5b
add dialogoverlay to tournament client, confirmation dialog for resetting bracket teams
2023-07-20 22:52:00 +01:00
Bartłomiej Dach
c77d3cd6bd
Merge pull request #24294 from peppy/toggle-all-freemods
...
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-20 22:32:53 +02:00
Bartłomiej Dach
fedf830b82
Merge pull request #24308 from peppy/tournament-ladder-improvements
...
General improvements to tournament client ladder editor
2023-07-20 21:40:57 +02:00
Bartłomiej Dach
166efd1aa8
Merge pull request #24291 from peppy/editor-cyclic-selection
...
Add support for cyclic selection in beatmap editor
2023-07-20 21:31:08 +02:00
Bartłomiej Dach
07e0a703d7
Adjust inline comment
2023-07-20 20:51:39 +02:00
Bartłomiej Dach
48024cd17f
Add test coverage of double click behaviour
2023-07-20 20:51:17 +02:00
Bartłomiej Dach
f60a6e9893
Fix test step descriptions
2023-07-20 20:47:33 +02:00
Dean Herbert
97e572d4da
Make dragging ladder more snappy
2023-07-21 03:34:41 +09:00
Dean Herbert
fb4eaaeae9
Add grid snapping to ladder editor
2023-07-21 03:34:41 +09:00
Dean Herbert
ca14b4a35f
Move ladder editor controls to control panel
2023-07-21 03:34:41 +09:00
Dean Herbert
ac6a103721
Add masking around ladder view
2023-07-21 03:34:41 +09:00
Bartłomiej Dach
708dd355cd
Merge branch 'master' into editor-cyclic-selection
2023-07-20 20:19:46 +02:00
Bartłomiej Dach
2f772abea6
Merge pull request #24289 from peppy/editor-prefer-closest
...
Change beatmap editor to always select the closest object in time
2023-07-20 19:54:17 +02:00
Bartłomiej Dach
210e114f7d
Merge branch 'master' into editor-prefer-closest
2023-07-20 19:16:09 +02:00
Bartłomiej Dach
511948ba56
Add xmldoc to ApplySelectionOrder()
2023-07-20 19:16:04 +02:00
Dean Herbert
8dfe93cbb9
Merge pull request #24303 from peppy/update-framework
...
Update framework
2023-07-20 23:39:41 +09:00
Dan Balasescu
733ce4c382
Fix incorrect dependency caching
...
These are tested framework-side to throw exceptions, but the
test is ignored for the source generated version because it quietly
allows this scenario.
The source gen project should eventually have an analyser for these
unsupported cases, or we could consider relaxing this particular case.
2023-07-20 22:30:49 +09:00
Dean Herbert
71a643d640
Update inspection rules in line with source generation change
2023-07-20 20:05:38 +09:00
Dean Herbert
f791f21dcb
Update framework
2023-07-20 20:05:38 +09:00
Dean Herbert
d9d055361a
More realm analytic disables
2023-07-20 17:51:33 +09:00
Dean Herbert
c93d6a4008
Invert text colour when freemods is enabled for better contrast
2023-07-20 13:04:26 +09:00
Dean Herbert
18c5fc689f
Don't expose such specific information from ModSelectOverlay
2023-07-20 12:58:13 +09:00
Dean Herbert
4057fcd70e
Merge branch 'master' into toggle-all-freemods
2023-07-20 12:56:46 +09:00
Bartłomiej Dach
285a232cc2
Merge pull request #24290 from peppy/beatmap-offset-all-difficulties
...
Change offset calibration control to adjust for all difficulties of the current beatmap set
2023-07-19 22:31:38 +02:00
Bartłomiej Dach
7800ea9841
Merge pull request #24295 from peppy/fix-multiplayer-deadlock
...
Fix deadlock when logging out while at the create match screen
2023-07-19 20:04:13 +02:00
Bartłomiej Dach
764029bde1
Fix nullability inspection
2023-07-19 19:23:08 +02:00
Dean Herbert
e47722565a
Clarify guard condition in RoomSubScreen
2023-07-19 19:39:10 +09:00
Dean Herbert
18aace177a
Fix deadlock when logging out while at the create match screen
...
Closes https://github.com/ppy/osu/issues/24275 .
2023-07-19 19:37:38 +09:00
Dean Herbert
eb149942e5
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-19 19:08:32 +09:00
Dean Herbert
94c5b8ed32
Apply NRT to TestSceneComposerSelection
2023-07-19 17:22:25 +09:00
Dean Herbert
cf3949c9e2
Fix double-click handling when cyclic selection is enabled
...
Removes the limitations of cyclic selection as a result.
2023-07-19 17:21:20 +09:00
Dean Herbert
d33b174243
Add test coverage of beatmap editor cyclic selection
2023-07-19 17:21:20 +09:00
Dean Herbert
5ec9cd84b2
Change offset calibration control to adjust for all difficulties of the current beatmap set
2023-07-19 17:13:19 +09:00
Dean Herbert
9d46d00294
Update skin editor cyclic test to match expectations better
2023-07-19 16:56:16 +09:00
Dean Herbert
5ade093c5a
Change editor to always perform selection of closest object
2023-07-19 16:56:16 +09:00
Dean Herbert
4e4dcc9846
Add test coverage of selection preferring closest objects
2023-07-19 16:56:16 +09:00
Bartłomiej Dach
88ac53557a
Merge pull request #24236 from Joehuu/remove-android-manifest-overlay
...
Remove android manifest overlay
2023-07-17 22:12:11 +02:00
Bartłomiej Dach
551c243945
Merge pull request #24189 from peppy/discord-rpc-reconnect-fix
...
Re-enable connection retrying on discord connector
2023-07-17 19:58:37 +02:00
Bartłomiej Dach
17aac0694e
Re-enable connection retrying on discord connector
2023-07-17 19:19:03 +02:00
Dean Herbert
66269be189
Merge pull request #24256 from tybug/update-download-icon
...
Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`
2023-07-17 12:25:04 +09:00
Liam DeVoe
6200e207d2
use fa_download for updates instead of fa_upload
2023-07-16 15:21:15 -04:00
Dean Herbert
a472fe6789
Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb
...
Fix several issues in multiplayer exit-on-disconnection flow
2023-07-17 04:04:38 +09:00
Bartłomiej Dach
7fbd47e9ee
Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure
...
If `IAPIProvider.State` changes from `Online` at any point when being on
an `OnlinePlayScreen`, it will be forcefully exited from. However,
`MultiplayerMatchSubScreen` had local logic that suppressed the exit in
order to show a confirmation dialog.
The problem is, that in the suppression logic,
`MultiplayerMatchSubScreen` was checking
`MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
checking `IAPIAccess.State`, which is maintained separately. Due to
differing timeouts and failure thresholds, it is not impossible to have
`MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
APIState.Online`.
In such a case, the match subscreen would wrongly consider itself to be
still online and due to that, push useless confirmation dialogs, while
being in the process of being forcefully exited. This then caused the
dialog to cause a crash, as it was calling `.Exit()` on the screen which
would already have been exited by that point, by the force-exit flow.
2023-07-16 19:56:22 +02:00
Bartłomiej Dach
cd02a8a9ca
Fix PopupDialog potentially accumulating schedules during load
2023-07-16 19:43:37 +02:00
