129 Commits

• Replace usages of Mod.ScoreMultiplier with new score multiplier API (#37845)

  - Part of https://github.com/ppy/osu/issues/37818
  
  During review, I would like to direct particular attention to the
  following changes:
  
  ## [Migrate song select to new score multiplier
  API](https://github.com/ppy/osu/commit/945fd78539da3ae57d1550a5bbfb0f859d153cc4)
  
  This was a confusing change to write because of the way song selects
  hook their mod overlays up to global bindables. In particular different
  things happen in different circumstances.
  
  - When going through `SongSelect.CreateModOverlay()`, which is called by
  the base `SongSelect`, the mod overlay is automatically bound to global
  bindables via `SongSelect.on{ArrivingAt,Leaving}Screen()`.
  - For multiplayer user mod select overlays, which are bolted on by
  subclasses of `SongSelect`, manual hook-up is required.
  - As for free mod select overlays, they don't show mod multipliers at
  all, and don't have easy access to the ruleset, and thus the hookup is
  skipped entirely as redundant.
  
  ## [Fix score multiplier registrations being shared between
  implementations via superclass static
  fields](https://github.com/ppy/osu/commit/ba0a7ad421e0c84c2d8162b6bbdd3a0683f5a6a6)
  
  Revealed by `ScoreMultiplierCalculatorTest` starting to fail due to
  interference from `OsuScoreMultiplierCalculator`.
  
  It's not ideal from a performance standpoint but it's the simplest
  choice for now. Tricks could be pulled to salvage the static. One is
  
  ```csharp
  public class ScoreMultiplierCalculator<T>
  	where T : ScoreMultiplierCalculator<T>
  {
  }
  ```
  
  This works because of generics internals; static instance members are
  not shared between different specialisations of a generic class. It is
  also very unintuitive, so I would rather not. (It trips a ReSharper
  inspection too, which would have to be silenced.)
  
  From a performance standpoint this is not ideal, but a significant chunk
  of migrated usages already precede the construction of the calculator
  via the known-expensive `RulesetInfo.CreateInstance()`, and the paths
  that actually construct the calculator do not appear to be that hot. If
  need be, this can be handled by actually caching ruleset instances and
  their derivative subcomponents.
  
  ## [Introduce passing of context to score multiplier
  calculator](https://github.com/ppy/osu/pull/37845/changes/9e9242b3221dddacd226f4b3b9c5632d7350e998)
  
  This is required for two reasons:
  
  - The upcoming mod rebalance will require out-of-band supplementary
  information that is not available for reading from the mod instances
  themselves for calculating the multiplier.
  - This context, namely passing of `ScoreInfo`, will be used for
  implementing backwards compatibility with old scores and their score
  multipliers. This is required because it has turned out under inspection
  that all server-side lazer replays recorded until now are missing
  `TotalScoreWithoutMods` due to an omission of not sending it across the
  wire to spectator server.
  
  Because the score import flow uses replays, filtered through
  `LegacyScoreDecoder`, to populate total score in the realm database, it
  is basically impossible to ignore scores that are missing
  `TotalScoreWithoutMods`, because that will result in bug reports that
  the scores do not have the new score multipliers applied.
  
  Thus, passing of `ScoreInfo` will facilitate implementation of
  versioning score multipliers, which should result in less breakage than
  not doing so.
  
  An example of this is added in 341b2d6e55,
  which should handle the case of mania mod multipliers having been
  changed without any attempt to facilitate for it in
  https://github.com/ppy/osu/pull/30506.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-05-26 18:02:15 +09:00
  9727d95ad9
• Fix "Deselect all" mods button becoming enabled when system mods are applied (#36913)

  Closes https://github.com/ppy/osu/issues/36906.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-10 12:40:54 +01:00
  14743a14eb
• Migrate sheared overlay tests to ScreenTestScene (#36736)

  Part of the screen footer refactor.
  
  Once footer content is being managed by `OsuScreen`, the current tests
  which simply create the tested overlay and `ScreenFooter` in a container
  will no longer work.
  
  This PR refactors them to use `ScreenTestScene` with the setup being
  creating a dedicated testing `OsuScreen` which does the bare minimum to
  create the tested overlay and necessary components (eg.
  `FooterButtonFreeModsV2` for `TestSceneFreeModsOverlay`).
  
  Most of the changes here can be described as
  `%s/<...>Overlay/screen.Overlay/g`, with some minor touchups as
  necessary, given that we're now testing a more complete flow which
  checks more things that were previously not handled by the tests.
  
  ## [Move footer to front in
  ScreenTestScene](https://github.com/ppy/osu/commit/f8740e0403b3c0badd60d394c737f2aa912a9ed6)
  
  Self-explanatory. Without it the footer would show below the actual
  overlay, breaking tests depending on manual input. For the sake of tests
  not breaking in CI, both #36718 and this have this included - would
  prefer the former to be merged first since it was already reviewed
  there.
  
  ## `TestSceneModSelectOverlay`
  
  There were a few tests (`TestColumnHidingOnIsValidChange`,
  `TestColumnHidingOnTextFilterChange`, and
  `TestHidingOverlayClearsTextSearch`) that would create a custom overlay
  instance instead of the globally provided one. I've tested both and the
  tests run fine with the default overlay, so they're now using that
  instead.
  
  ## `TestSceneFreeModSelectOverlay`
  
  Updated to use footer v2.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-02-28 04:22:58 +09:00
  105342e5bf
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing test
  Dan Balasescu · 2025-03-27 19:05:11 +09:00
  8c244134d5
• Fix intermittent mod customisation panel test
  Dan Balasescu · 2025-03-19 16:13:56 +09:00
  9272ada859
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Adjust tests further to match new UX
  Bartłomiej Dach · 2024-09-02 14:46:40 +02:00
  16c2c14037
• Remove weird Expanded / ExpandedState duality
  Bartłomiej Dach · 2024-08-07 14:01:30 +02:00
  518c1aa5a0
• Update ModCustomisationPanel to use ExpandedState enum
  Caiyi Shyu · 2024-08-01 19:25:45 +08:00
  051d52c23f
• fix TestPreexistingSelection failing
  Caiyi Shyu · 2024-07-26 23:58:52 +08:00
  bd017aea38
• Merge branch 'master' into footer-v2-integration
  Salman Ahmed · 2024-07-09 13:48:40 +03:00
  ed1f3a1eb4
• Display customisation header in disabled state when no customisable mod selected
  Salman Ahmed · 2024-07-02 14:40:16 +03:00
  1d94c96a8e
• Fix test failure
  Salman Ahmed · 2024-06-30 11:00:00 +03:00
  901663b3ff
• Migrate mod select overlay footer content
  Salman Ahmed · 2024-06-30 06:50:36 +03:00
  48bf3f1385
• Add test coverage for the issues that were pointed out recently
  Salman Ahmed · 2024-06-28 11:23:52 +03:00
  f462aa59df
• Remove stale comment
  Salman Ahmed · 2024-06-23 08:46:55 +03:00
  2efafcaf5b
• Update test coverage
  Salman Ahmed · 2024-06-23 08:22:54 +03:00
  1298b98534
• Cast remaining test usages to IFocusManager to remove obsolete notice
  Dean Herbert · 2024-05-22 21:55:53 +08:00
  093be3d723
• Add failing test case
  Bartłomiej Dach · 2024-04-19 11:04:05 +02:00
  9d04b44a88
• Fix mod select overlay settings order not always matching panels order
  Salman Ahmed · 2024-03-04 23:36:45 +03:00
  9543908c7a
• Adjust tests to new behaviour
  Bartłomiej Dach · 2024-02-22 11:02:49 +01:00
  b08fcbd4e9
• Transform score multiplier display to also show ranked state
  Bartłomiej Dach · 2024-02-01 21:32:37 +01:00
  966093f7ce
• Add test coverage of select-all-text-in-search when nothing matched
  Bartłomiej Dach · 2024-01-15 19:07:52 +01:00
  c0d4ed4789
• Add test coverage
  Bartłomiej Dach · 2024-01-15 19:05:33 +01:00
  e8394e6f74
• Add test coverage of desired input handling behaviour
  Bartłomiej Dach · 2023-12-19 14:52:16 +01:00
  d793d1cea1
• Add test coverage for desired mod overlay search box behaviour
  Bartłomiej Dach · 2023-12-14 09:52:38 +01:00
  839a080247
• Update test assertions in line with half time mod multiplier changes
  Bartłomiej Dach · 2023-12-13 09:25:56 +01:00
  e865de7a6b
• Fix mod tests not waiting for presets to finish loading

  See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850.

  Dean Herbert · 2023-10-31 14:53:07 +09:00
  8c067dc584
• Change display text from "difficulty" to "score" multiplier
  Dean Herbert · 2023-09-13 20:01:19 +09:00
  32946413de
• Fix data flow being sometimes incorrect
  Bartłomiej Dach · 2023-09-11 09:53:58 +02:00
  53c30dca64
• Revert failing test to prior assertions too
  Bartłomiej Dach · 2023-07-26 21:51:32 +02:00
  f66093d3cf
• Merge pull request #24199 from peppy/revert-to-default-design-change

  Update design of "revert to default" button

  Bartłomiej Dach · 2023-07-13 23:44:24 +02:00
  cdbb6f90be
• Don't hide mod select overlay when pressing select binding with no search
  Dean Herbert · 2023-07-13 17:50:07 +09:00
  f5c472c0fe
• Rename RestoreDefaultValueButton to RevertToDefaultButton

  Because I can't find it every time I search.

  Dean Herbert · 2023-07-13 13:46:50 +09:00
  1bfe5a18cb
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Apply required nullability changes
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  3585c3f1d5
• Switch search box to initially unfocused

  Done primarily to keep mod hotkeys working without any behavioural
  changes when mod select is opened.

  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  75300ca229
• Reword/rename some stuff in test
  Bartłomiej Dach · 2023-06-18 14:24:35 +02:00
  b9156b1df3
• Add hotkey for switching search bar focus
  Cootz · 2023-06-05 15:54:19 +03:00
  71e6f80c40
• Move (de)select all mods hotkeys handling to ModSelectOverlay
  Cootz · 2023-06-05 13:49:07 +03:00
  3ebc801484
• Update tests
  Cootz · 2023-06-04 17:11:04 +03:00
  fd554033db
• Rename IsValid to Visible
  Cootz · 2023-06-02 11:33:38 +03:00
  4c7cca101e
• Merge branch 'master' into add-mod-search-option
  Cootz · 2023-05-23 08:55:57 +03:00
  c3f06ad2db
• Select/deselect first visible mod when GlobalAction.Select is triggered
  Cootz · 2023-05-21 11:05:01 +03:00
  67bf1b4dfe
• Kill search focus when clicking on ModColumn
  Cootz · 2023-05-14 18:32:16 +03:00
  6647d95ea7
• Block deselect all short key when using the search box
  Cootz · 2023-05-09 16:14:42 +03:00
  2467813d81
• Add test coverage for deselect all with filtered mods selected
  Cootz · 2023-05-07 15:50:21 +03:00
  4c3af6ecfe
• Add basic tests for external search
  Cootz · 2023-05-06 12:21:32 +03:00
  5aca3a78da
• Fix wrong filtering in testing
  Cootz · 2023-05-05 22:41:30 +03:00
  7422b5285c