75491 Commits

This Branch

This Branch

All Branches

• Make edits based on reviews
  Denis Titovets · 2025-10-11 11:03:53 +03:00
  e183e6bb88
• Add some localisation to Play screen
  Denis Titovets · 2025-10-11 11:03:40 +03:00
  5dc44fbdf9
• Merge pull request #35255 from dnfd1/rotate

  Fix default origin in skin editor when rotating multiple objects

  Bartłomiej Dach · 2025-10-10 12:19:53 +02:00
  9ebc5b0a35
• Merge pull request #35252 from bdach/song-select-present-sometimes-fails

  Fix wrong beatmap shown when presenting a beatmap from results screen

  Dean Herbert · 2025-10-10 14:54:50 +09:00
  1f2928bf2f
• Add some logging when FindWithRefresh triggers a slow realm refresh
  Dean Herbert · 2025-10-10 13:36:28 +09:00
  94c7489c1c
• Merge branch 'ppy:master' into rotate
  dnfd1 · 2025-10-09 08:52:21 -07:00
  3bb6685e75
• convert origin of rotation to screen space for selections multiple objects in skin editor
  dnfd1 · 2025-10-09 08:36:01 -07:00
  e3459eccf2
• Merge pull request #35240 from bdach/song-select-preserve-selection-on-update-attempt-3

  Fix song select V2 not preserving selection after an update operation

  Dean Herbert · 2025-10-09 17:30:28 +09:00
  52f82c7e56
• Fix weird xmldoc issue

  Rider was fine with it...

  Bartłomiej Dach · 2025-10-09 10:17:55 +02:00
  3fc3a53521
• Merge pull request #35251 from smoogipoo/fix-broken-tests

  Fix test failures during individual runs

  Dean Herbert · 2025-10-09 17:09:01 +09:00
  2136d95087
• Merge pull request #35250 from smoogipoo/fix-test-leaks

  Fix test scene leaks through RealmRulesetStore/RealmAccess

  Dean Herbert · 2025-10-09 17:08:07 +09:00
  c58d13b802
• Fix wrong beatmap shown when presenting a beatmap from results screen

  - Closes https://github.com/ppy/osu/issues/35023.
  - Supersedes / closes https://github.com/ppy/osu/pull/35107.

  Bartłomiej Dach · 2025-10-09 09:52:22 +02:00
  b477790d3e
• Add test demonstrating failure scenario
  Bartłomiej Dach · 2025-10-09 09:46:32 +02:00
  e33de9b658
• Fix test failures during individual runs
  Dan Balasescu · 2025-10-09 16:34:55 +09:00
  6eaf91d31a
• Fix shift-clicking not working on extra size beatmap cards

  Was broken due to double assignment to `Action`.

  Bartłomiej Dach · 2025-10-09 08:59:26 +02:00
  6da6edd1d1
• Fix undisposed Realm subscription
  Dan Balasescu · 2025-10-09 15:56:34 +09:00
  6af5158bb4
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Merge pull request #35241 from bdach/song-select-crash-on-missing-group

  Fix carousel sometimes crashing when attempting to select next random set

  Dean Herbert · 2025-10-09 06:20:22 +09:00
  91019dcdf7
• Update framework
  Dean Herbert · 2025-10-08 23:18:35 +09:00
  422392233b
• Fix carousel sometimes crashing when attempting to select next random set

  I'm not exactly sure on the reproduction scenario here, but I have had
  switching ruleset with converts disabled crash on me a few times
  today. It appears to happen sometimes when after the switch the expanded
  group no longer exists in the set mapping, because a filter just ran and
  removed that group from set of possible groups because there'd be no
  beatmaps under it.
  
  I tried to manufacture a quick test but it's not a quick one to test
  because filtering intereference is required to reproduce, I think.
  I will try again on request but I mostly just want to get this fix out
  ASAP before I finish up for the day.

  Bartłomiej Dach · 2025-10-08 15:13:00 +02:00
  7b1e3cd537
• Fix song select V2 not preserving selection after an update operation

  Because the detached store exists and has a chance to actually
  semi-reliably intercept a beatmap update operation, I decided to try
  this. It still uses a bit of a heuristic in that it checks for
  transactions that delete and insert one beatmap each, but probably the
  best effort thus far?
  
  Notably old song select that was already doing the same thing locally to
  itself got a bit broken by this, but with some tweaking that *looks* to
  be more or less harmless I managed to get it unbroken. I'm not too
  concerned about old song select, mind, mostly just want to keep it
  *vaguely* working if I can help it.

  Bartłomiej Dach · 2025-10-08 14:42:26 +02:00
  30412ba3f2
• Merge pull request #35233 from diquoks/quick-fix/sfx-mute-on-restart

  Mute SFX when holding restart beatmap bind

  Dean Herbert · 2025-10-08 21:39:07 +09:00
  4622d39f41
• Merge pull request #35234 from diquoks/quick-fix/spinner-rpm-layering

  Fix `spinner-rpm` being layered above `spinner-spin` / `spinner-clear`

  Dean Herbert · 2025-10-08 21:21:21 +09:00
  0d5c041cac
• Merge pull request #35239 from bdach/song-select-weirdness

  Fix current beatmap set being incorrectly expanded after collapsing group with current selection

  Dean Herbert · 2025-10-08 21:19:08 +09:00
  ffe8b9f4c3
• Fix current beatmap set being incorrectly expanded after collapsing group with current selection

  Noticed in passing. See preceding commit for failure scenario.
  
  Regressed in https://github.com/ppy/osu/pull/35163.

  Bartłomiej Dach · 2025-10-08 13:42:43 +02:00
  9ba9966078
• Add failing test
  Bartłomiej Dach · 2025-10-08 13:42:31 +02:00
  f1ec04114f
• Add test assets covering correct layering of spinner SPM metre
  Bartłomiej Dach · 2025-10-08 12:39:48 +02:00
  4337046680
• Disallow zero-length sliders from specifying a non-zero number of repeats (#35220)
  Bartłomiej Dach · 2025-10-08 16:01:04 +09:00
  1a522a19f1
• Fix spinner-rpm layering
  Denis Titovets · 2025-10-07 19:01:50 +03:00
  568ddc2d2d
• Mute SFX when holding restart beatmap bind
  Denis Titovets · 2025-10-07 18:42:42 +03:00
  0ebc90462d
• Merge pull request #35029 from ppy/pp-dev

  Q3 SR & PP release

  Dean Herbert · 2025-10-07 19:07:58 +09:00
  2025.1007.0 a08f7327b1
• Merge pull request #35216 from diquoks/quick-fix/mods-deselection-diff

  Fix mods deselection difference

  Dean Herbert · 2025-10-07 18:38:40 +09:00
  533c61e719
• Invert conditional to read a bit better
  Dean Herbert · 2025-10-07 18:07:58 +09:00
  64fba9470d
• Re-remove duplicate error functions
  Dean Herbert · 2025-10-07 16:30:40 +09:00
  743a94bd22
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-10-07 16:11:54 +09:00
  bda5737135
• Merge pull request #35221 from bdach/adjust-tag-threshold

  Adjust display tag threshold to match web

  Dean Herbert · 2025-10-06 20:57:26 +09:00
  19718c706a
• Merge pull request #35222 from peppy/fix-left-hover-not-always

  Fix hovering left area in song select not always activating reset action

  Bartłomiej Dach · 2025-10-06 12:17:56 +02:00
  4b3d2b0c57
• Fix hovering left area in song select not always activating reset action
  Dean Herbert · 2025-10-06 18:23:33 +09:00
  df58dc0ca2
• Add failing test scene covering song select left hover action not always activating
  Dean Herbert · 2025-10-06 18:21:10 +09:00
  d08b5a72b7
• Adjust display tag threshold to match web

  Follow-up to https://github.com/ppy/osu-web/pull/12381 - tags will glow
  green starting from 5 votes rather than 10 to match the new threshold
  web-side.

  Bartłomiej Dach · 2025-10-06 11:09:54 +02:00
  b286f05c78
• Merge pull request #35185 from nekodex/matchmaking-more-sfx

  Yet more matchmaking SFX work

  Dean Herbert · 2025-10-06 18:04:22 +09:00
  b3ed7717a8
• Delay round increment sound to match animation better
  Dean Herbert · 2025-10-06 18:03:53 +09:00
  bc7e02c30b
• Merge pull request #35184 from bdach/song-select-reselect-group-for-selection-when-moving-left

  Expand group that current selection resides in when moving mouse to left side of song select

  Dean Herbert · 2025-10-06 17:47:20 +09:00
  557df19bf4
• Merge branch 'master' into song-select-reselect-group-for-selection-when-moving-left
  Dean Herbert · 2025-10-06 16:57:57 +09:00
  8a450563fd
• Merge pull request #35189 from bdach/catcher-fail-state-on-tiny-droplet-miss

  Fix missing tiny droplets not changing catcher animation state to fail

  Dean Herbert · 2025-10-06 16:42:10 +09:00
  f9a226d68e
• Merge pull request #35176 from bdach/local-modified-beatmap-regressions

  Fix a few issues regarding incorrect treatment of locally-modified beatmaps

  Dean Herbert · 2025-10-06 16:22:09 +09:00
  dd846dcc52
• Merge pull request #35178 from bdach/song-select-loses-selection-if-convert

  Fix selection being changed on re-entering song select when a converted beatmap is selected

  Dean Herbert · 2025-10-06 15:53:42 +09:00
  71ae1d34cd
• Merge pull request #35199 from peppy/editor-timing-panel-current-row-visibility

  Adjust colouring to make current row in timing visualisation more obvious

  Bartłomiej Dach · 2025-10-06 08:39:05 +02:00
  dd8dfc04b3
• Update resources
  Dean Herbert · 2025-10-06 14:49:42 +09:00
  2f6bd6605f
• Merge pull request #35188 from bdach/song-select-do-not-flash-wrong-leaderboard

  Fix wrong leaderboard flashing briefly when quickly changing beatmaps

  Dean Herbert · 2025-10-06 14:43:33 +09:00
  e76d1ae619