Bartłomiej Dach
93d34e4115
Enable NRT in ScreenWarning
2024-02-02 07:24:32 +01:00
Bartłomiej Dach
b58ac7950b
Make game dependency in ScreenEntry
optional to unbreak tests
2024-02-02 07:24:32 +01:00
Bartłomiej Dach
bb6387bea0
Enable NRT in ScreenEntry
2024-02-02 07:24:32 +01:00
Bartłomiej Dach
5260b8cae0
Merge pull request #26920 from peppy/2fa-visibility
...
Give better visibility when the game is pending 2FA
2024-02-02 07:10:45 +01:00
Bartłomiej Dach
2ff46daf5e
Also change icon and tooltip text when pending 2FA
2024-02-02 06:40:56 +01:00
Andrei Zavatski
53c5483eba
Reduce allocation in Playfield
2024-02-02 04:53:48 +03:00
Loreos7
8dce158a13
localise update-related strings
2024-02-02 04:49:22 +03:00
Loreos7
7884e5808a
localise remaining strings
2024-02-02 04:47:13 +03:00
Andrei Zavatski
e00e583bb4
Fix DrawableManiaRuleset performing skin lookup every frame
2024-02-02 03:56:38 +03:00
Salman Ahmed
4dbcb41dd1
Remove unused parameter
2024-02-02 00:44:51 +03:00
Bartłomiej Dach
ea76f7a5d8
Allow pp for Double/Half Time's "adjust pitch" setting
2024-02-01 22:33:49 +01:00
Bartłomiej Dach
96f66aaa2e
Allow pp for Accuracy Challenge
...
Addresses https://github.com/ppy/osu/discussions/26919 .
2024-02-01 22:30:26 +01:00
Bartłomiej Dach
c114fd8f89
Allow pp for Sudden Death and Perfect regardless of "restart on fail" setting
...
Closes https://github.com/ppy/osu/issues/26844 .
2024-02-01 22:28:49 +01:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too
2024-02-01 21:51:41 +01:00
Bartłomiej Dach
f87ab19731
Apply NRT to FooterButtonMods
2024-02-01 21:32:38 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state
2024-02-01 21:32:37 +01:00
Andrei Zavatski
66350fd148
Refactor UserRankPanel layout
2024-02-01 16:33:54 +03:00
Andrei Zavatski
2bd9dcf646
Rework UserGridPanel to reduce containers nesting
2024-02-01 16:22:07 +03:00
Andrei Zavatski
b0f6a87a2b
Add stress test in TestSceneDashboardOverlay
2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc
Add step for toggling skins in results screen test scene
2024-02-01 16:08:48 +03:00
Salman Ahmed
5bbaeb6836
Play legacy applause sound only when rank is B or higher
2024-02-01 16:08:36 +03:00
Salman Ahmed
35c3f5e250
Merge branch 'master' into fix-results-f-rank
2024-02-01 15:29:07 +03:00
Dean Herbert
bf3746daa8
Show login overlay at main menu when 2FA is required
2024-02-01 21:10:53 +09:00
Dean Herbert
563f4a26b1
Show "failing" icon on user panel when 2FA prompt is present
...
This gives the user a chance to know it's required.
2024-02-01 21:10:37 +09:00
Bartłomiej Dach
f89923aeae
Annotate mods that give pp
2024-01-31 14:59:35 +01:00
Dan Balasescu
0642d74014
Expose as ReadOnlyDictionary
2024-01-31 22:52:57 +09:00
Bartłomiej Dach
e71c95f1fe
Reintroduce IMod.Ranked
...
What goes around, comes around.
2024-01-31 14:48:35 +01:00
Dean Herbert
7cdedfb6ca
Merge pull request #26889 from peppy/remove-cachebust-online-image
...
Fix menu banner not updating as often as we want it to
2024-01-31 22:44:39 +09:00
Dean Herbert
4248593289
Fix menu banner not updating as often as we want it to
2024-01-31 22:44:24 +09:00
Dean Herbert
89a5be13e2
Merge pull request #26885 from bdach/slider-end-flip-fail
...
Fix slider end judgements appearing at incorrect locations when mods that flip playfield are active
2024-01-31 22:39:37 +09:00
Bartłomiej Dach
dfea2ade6d
Revert incorrect end position optimisation
...
Closes https://github.com/ppy/osu/issues/26867 .
Reverts 882f490390
and ce643aa68f
.
The applied optimisation may have been valid as long as it was
constrained to `Slider`. But it is not, as `SliderTailCircle` stores a
local copy of the object position. And as the commit message of
ce643aa68f
states, this could be bypassed
by some pretty hacky delegation from `SliderTailCircle.Position` to the
slider, but it'd also be pretty hacky because it would make flows like
`PositionBindable` break down.
Long-term solution is to probably remove bindables from hitobjects.
2024-01-31 12:45:42 +01:00
Bartłomiej Dach
a934556bb8
Add failing assertions for head/tail positions after flip
2024-01-31 12:40:03 +01:00
Bartłomiej Dach
f927cb5928
Increase repeat count for better coverage of flip operations
2024-01-31 12:39:48 +01:00
Dean Herbert
56700d672b
Merge pull request #26837 from bdach/2fa-not-verifying-via-link
...
Fix 2FA verification via link not working correctly
2024-01-31 19:15:33 +09:00
Bartłomiej Dach
e7cfbd3c56
Merge pull request #26876 from peppy/slider-miss-last-longer
...
Adjust slider tick / end misses to show slightly longer
2024-01-31 10:43:58 +01:00
Dean Herbert
19fe3a15f3
Merge branch 'master' into 2fa-not-verifying-via-link
2024-01-31 18:32:55 +09:00
Dean Herbert
edab05672b
Merge pull request #26834 from bdach/2fa-cancel-crash
...
Fix crash when logging out during 2FA email verification
2024-01-31 18:32:33 +09:00
Dan Balasescu
66aa41e001
Fix tests
2024-01-31 18:04:32 +09:00
Dan Balasescu
0642a0ee11
Adjust default min result of SliderTailHit, remove override
2024-01-31 18:01:29 +09:00
Dean Herbert
fbc923b47e
Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"
...
This reverts commit 1acff746ee
, reversing
changes made to 696ecda398
.
2024-01-31 17:51:38 +09:00
Dean Herbert
1acff746ee
Merge pull request #26870 from smoogipoo/adjust-default-minresult
...
Adjust default min result of SliderTailHit, remove override
2024-01-31 17:49:58 +09:00
Dean Herbert
ebf637bd3c
Adjust slider tick / end misses to show slightly longer
2024-01-31 17:41:26 +09:00
Dean Herbert
696ecda398
Merge pull request #26871 from peppy/show-better-expired-message
...
Show a better message when score submission fails due to system clock being set wrong
2024-01-31 17:32:18 +09:00
Dean Herbert
a7f9f50ce5
Show a better message when score submission fails due to system clock being set wrong
2024-01-31 16:52:50 +09:00
Dean Herbert
3f527081bd
Update framework
2024-01-31 16:12:46 +09:00
Dan Balasescu
9b1bbe5f48
Adjust default min result of SliderTailHit, remove override
2024-01-31 16:12:05 +09:00
Andrei Zavatski
6b1de5446a
Reduce allocaations in ScrollingHitObjectContainer
2024-01-31 07:54:28 +03:00
Andrei Zavatski
3aefc91967
Make AliveDrawableMap public
2024-01-31 07:54:07 +03:00
Dean Herbert
012039ff90
Merge pull request #26839 from bdach/fix-judgement-fade
2024-01-31 09:14:05 +09:00
Bartłomiej Dach
c5e118bd10
Revert "Move fade more local to avoid fading twice"
...
This reverts commit d0421fe206
and fixes https://github.com/ppy/osu/issues/26801 .
https://github.com/ppy/osu/pull/26703#discussion_r1469409667
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe206
broke that.
2024-01-30 22:16:46 +01:00