64420 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	6e7e243e70	Allow new common cases when a user is locating a stable osu! install directory for import	2023-12-15 16:05:29 +09:00
Dean Herbert	4357bb1040	Change LeftContent autosize duration to match main content to reduce visual awkwards	2023-12-15 16:01:07 +09:00
Dean Herbert	dc5c9837ed	Fix StarRatingDisplay's display width to avoid text making slight autosize changes	2023-12-15 16:00:03 +09:00
Dean Herbert	b86f387fd3	Fix the width of vertical attribute display numbers ... Not necessarily required to fix the issue at hand, but probably good practice here.	2023-12-15 15:04:22 +09:00
Dan Balasescu	599fdb0128	Add lenience for late-hit of slider heads	2023-12-15 14:14:58 +09:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dean Herbert	27296c59de	Show back button when spectating ... Avoids getting stuck at some screens. It's a bit ugly having the back button visible like this, but is the best approach we have for now.	2023-12-15 11:26:17 +09:00
Dean Herbert	8a52c4f176	Merge pull request #25768 from smoogipoo/reduce-song-select-allocs ... Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:08:56 +09:00
Dean Herbert	23fbc75bee	Merge pull request #25762 from bdach/if-i-speak-i-am-in-big-trouble-pt-2 ... Fix `GetRateAdjustedDisplayDifficulty()` (partially incorrectly) locally reimplementing difficulty range calculations	2023-12-15 11:03:23 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	0f4d054bfe	Use HitWindows data directly for computing effective OD	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	605269f65f	Extract preempt durations to shared constants	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	c0e68df20f	Fix InverseDifficultyRange() not working correctly in both directions	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	fd1c72bf74	Use IBeatmapDifficultyInfo.(Inverse)DifficultyRange() instead of local reimplementations ... Also adds explicit references to places from where the magic constants were lifted.	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	24e31f7d91	Implement inverse of IBeatmapDifficultyInfo.DifficultyRange()	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	555559c5c1	Add testing for GetRateAdjustedDisplayDifficulty() implementations	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Bartłomiej Dach	73c0a0ecb4	Merge pull request #25759 from Givikap120/arod_rate_adjust ... Fix adjusted attributes tooltip not updating without mods	2023-12-14 16:09:34 +01:00
Bartłomiej Dach	67a5e01c49	Update assertions in test	2023-12-14 15:19:29 +01:00
Givikap120	23c427cd3e	Update AdjustedAttributesTooltip.cs	2023-12-14 14:38:01 +02:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Bartłomiej Dach	3e06bc35e4	Merge pull request #25757 from peppy/more-dropdown-search ... Show search bar by default in language and collection dropdowns	2023-12-14 12:39:37 +01:00
Dean Herbert	c3d881caee	Merge branch 'master' into more-dropdown-search	2023-12-14 18:44:57 +09:00
Dean Herbert	76653e61cb	Merge pull request #25575 from frenzibyte/collection-dropdown-improve-ux ... Improve handling of beatmap collection changes in `CollectionDropdown`	2023-12-14 18:39:36 +09:00
Dean Herbert	59355dc0c8	Merge pull request #25756 from bdach/mod-select-search-by-default ... Add setting for mod select search box focusing by default	2023-12-14 18:34:48 +09:00
Dean Herbert	d77972a39b	Show search bar by default in language and collection dropdowns	2023-12-14 18:26:13 +09:00
Bartłomiej Dach	b3a7c7a7c9	Add control to adjust mod select search text box behaviour	2023-12-14 10:04:37 +01:00
Bartłomiej Dach	0ab6e18792	Automatically focus search text box on open depending on setting	2023-12-14 09:52:55 +01:00
Bartłomiej Dach	839a080247	Add test coverage for desired mod overlay search box behaviour	2023-12-14 09:52:38 +01:00
Bartłomiej Dach	70a546b23c	Add setting for adjusting whether text search is active by default	2023-12-14 09:52:23 +01:00
Dean Herbert	33d3766918	Merge pull request #25748 from smoogipoo/slider-early-hit-lenience ... Allow sliders to track if hit early	2023-12-14 16:40:12 +09:00
Dan Balasescu	38e7c03500	Update tests to not miss the head	2023-12-14 12:00:01 +09:00
Salman Ahmed	31c9489cb9	Fix failing tests	2023-12-13 23:38:19 +03:00
Bartłomiej Dach	15ce45ac71	Merge pull request #25726 from smoogipoo/fix-catch-clamping ... Fix catch applying positional clamping too early	2023-12-13 18:47:05 +01:00
Dean Herbert	e296730b37	Merge pull request #24642 from Givikap120/arod_rate_adjust ... Show adjusted AR/OD when using DT/HT	2023-12-13 22:17:10 +09:00
Dean Herbert	76c4931f3a	Merge pull request #25673 from frenzibyte/fix-argon-initial-display ... Fix `ArgonHealthDisplay` not displaying miss correctly during initial transition	2023-12-13 22:16:34 +09:00
Dean Herbert	c6b1a5f1ee	Merge pull request #25691 from bdach/fix-skin-editor-crash-again ... Fix skin editor crashing in some circumstances when opened in main menu	2023-12-13 22:15:42 +09:00
Bartłomiej Dach	ffab87fe48	Merge branch 'master' into fix-catch-clamping	2023-12-13 13:27:25 +01:00
Bartłomiej Dach	a6bf4cdb98	Remove dead clamping code ... `EffectiveX` is already defined as clamped to `[0, CatchPlayfield.WIDTH]`.	2023-12-13 13:22:12 +01:00
Dan Balasescu	27e55def64	Make animation start at the slider's start time	2023-12-13 20:27:14 +09:00
Bartłomiej Dach	3daa39864e	Merge pull request #25588 from peppy/export-log-archive ... Add button to compress log files for bug submission	2023-12-13 12:18:42 +01:00
Dan Balasescu	683ac6f63a	Add some more tests	2023-12-13 20:03:20 +09:00
Bartłomiej Dach	084474ef79	Merge branch 'master' into export-log-archive	2023-12-13 11:08:33 +01:00
Bartłomiej Dach	7a4ea90bda	Fix test failures due to dependency becoming required	2023-12-13 11:01:07 +01:00
Dean Herbert	8d55b3f34d	Merge pull request #25749 from smoogipoo/move-counts-to-beatmapinfo ... Move object counts to BeatmapInfo	2023-12-13 17:58:13 +09:00
Dan Balasescu	8c7570525a	Merge pull request #25744 from peppy/adjust-mod-multipliers ... Adjust some mod multipliers for initial leaderboard sanity	2023-12-13 17:56:13 +09:00
Dan Balasescu	812f52e793	Bump version number	2023-12-13 17:38:59 +09:00
Dean Herbert	9235f3d935	Merge pull request #25747 from peppy/fix-hit-error-clear ... Fix hit error displays not clearing on seek	2023-12-13 17:36:24 +09:00