40879 Commits

Author	SHA1	Message	Date
Dean Herbert	c556475c2c	Revert to using a more manual approach to holding focus	2023-12-19 19:46:30 +09:00
Dean Herbert	51f4c7254c	Fix mod search textbox having focus while settings are visible ... Stopped arrow key adjust on slider bars from working. Also just felt wrong that you could type into an off-screen textbox.	2023-12-19 01:32:34 +09:00
Dean Herbert	c466775f78	Merge pull request #25821 from bdach/fix-collection-dropdown-crash ... Fix collections dropdown crashing during storage migration	2023-12-19 01:01:23 +09:00
Dean Herbert	c88c25e77f	Merge pull request #25848 from 65-7a/dropdown-search-padding ... Fix padding on dropdown search bar	2023-12-19 00:36:14 +09:00
65-7a	17f1f8bb43	Fix padding on dropdown search bar	2023-12-19 00:28:23 +11:00
Bartłomiej Dach	eeeb5aa3d4	Fix crash when creating collections named "All beatmaps" or "Manage collections..." ... Closes https://github.com/ppy/osu/issues/25834 The name fallback that was there previously since https://github.com/ppy/osu/pull/11892 was half broken. This way should be a lot less prone to failure.	2023-12-18 12:52:39 +01:00
Dean Herbert	62444c3d04	Fix song select's carousel scroll position getting reset on background processing ... This only happened for users using absolute right-click scroll.	2023-12-18 19:17:59 +09:00
Bartłomiej Dach	ef230884a8	Fix collections dropdown crashing during storage migration ... Closes https://github.com/ppy/osu/issues/25815. `CollectionDropdown.collectionsChanged()` was assuming that if it received `null` changes, then it must mean that the change subscription is being initialised and the `filters` list will not contain any items. However, that is not the only circumstance wherein a realm subscription can fire with `null` changes; that can also happen after the main realm instance gets recycled via the notification registration flow: 2f28a92f0a/osu.Game/Database/RealmAccess.cs (L545-L549) 2f28a92f0a/osu.Game/Database/RealmAccess.cs (L1228-L1251) Therefore, to fix the crash, just ensure that the list is cleared every time.	2023-12-18 09:11:00 +01:00
Dan Balasescu	4b9aefa6f2	Change osu ruleset to use new HP algorithm by default	2023-12-17 19:33:04 +09:00
Dan Balasescu	d7aca2f641	Add IApplicableHealthProcessor	2023-12-17 19:27:03 +09:00
Bartłomiej Dach	285284eb34	Merge branch 'master' into more-import-lenience	2023-12-15 16:02:44 +01:00
Bartłomiej Dach	91f4123aa7	Fix first run locator stable locator directory desyncing between display & popover	2023-12-15 16:00:34 +01:00
Bartłomiej Dach	b384c9f938	Extract common method for determining stable import usability of directory	2023-12-15 15:42:19 +01:00
Dean Herbert	94f63d6044	Update resources	2023-12-15 19:18:53 +09:00
Dean Herbert	4ad312ef5b	Update xmldoc for LegacyComboIncrease	2023-12-15 19:12:45 +09:00
Dan Balasescu	9e3b1dbb59	Fix CI inspection	2023-12-15 17:41:22 +09:00
Bartłomiej Dach	49f2adde25	Merge pull request #25774 from peppy/fix-star-rating-wobble ... Fix star rating display changing width depending on number displayed	2023-12-15 09:33:51 +01:00
Bartłomiej Dach	b3c6e80f5c	Merge pull request #25770 from peppy/show-back-button-spectator ... Show back button when spectating	2023-12-15 09:08:24 +01:00
Dean Herbert	6e7e243e70	Allow new common cases when a user is locating a stable osu! install directory for import	2023-12-15 16:05:29 +09:00
Dean Herbert	4357bb1040	Change LeftContent autosize duration to match main content to reduce visual awkwards	2023-12-15 16:01:07 +09:00
Dean Herbert	dc5c9837ed	Fix StarRatingDisplay's display width to avoid text making slight autosize changes	2023-12-15 16:00:03 +09:00
Dean Herbert	b86f387fd3	Fix the width of vertical attribute display numbers ... Not necessarily required to fix the issue at hand, but probably good practice here.	2023-12-15 15:04:22 +09:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dean Herbert	27296c59de	Show back button when spectating ... Avoids getting stuck at some screens. It's a bit ugly having the back button visible like this, but is the best approach we have for now.	2023-12-15 11:26:17 +09:00
Dean Herbert	8a52c4f176	Merge pull request #25768 from smoogipoo/reduce-song-select-allocs ... Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:08:56 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	c0e68df20f	Fix InverseDifficultyRange() not working correctly in both directions	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	24e31f7d91	Implement inverse of IBeatmapDifficultyInfo.DifficultyRange()	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Bartłomiej Dach	73c0a0ecb4	Merge pull request #25759 from Givikap120/arod_rate_adjust ... Fix adjusted attributes tooltip not updating without mods	2023-12-14 16:09:34 +01:00
Givikap120	23c427cd3e	Update AdjustedAttributesTooltip.cs	2023-12-14 14:38:01 +02:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Dean Herbert	c3d881caee	Merge branch 'master' into more-dropdown-search	2023-12-14 18:44:57 +09:00
Dean Herbert	76653e61cb	Merge pull request #25575 from frenzibyte/collection-dropdown-improve-ux ... Improve handling of beatmap collection changes in `CollectionDropdown`	2023-12-14 18:39:36 +09:00
Dean Herbert	d77972a39b	Show search bar by default in language and collection dropdowns	2023-12-14 18:26:13 +09:00
Bartłomiej Dach	b3a7c7a7c9	Add control to adjust mod select search text box behaviour	2023-12-14 10:04:37 +01:00
Bartłomiej Dach	0ab6e18792	Automatically focus search text box on open depending on setting	2023-12-14 09:52:55 +01:00
Bartłomiej Dach	70a546b23c	Add setting for adjusting whether text search is active by default	2023-12-14 09:52:23 +01:00
Dean Herbert	e296730b37	Merge pull request #24642 from Givikap120/arod_rate_adjust ... Show adjusted AR/OD when using DT/HT	2023-12-13 22:17:10 +09:00
Dean Herbert	76c4931f3a	Merge pull request #25673 from frenzibyte/fix-argon-initial-display ... Fix `ArgonHealthDisplay` not displaying miss correctly during initial transition	2023-12-13 22:16:34 +09:00
Dean Herbert	c6b1a5f1ee	Merge pull request #25691 from bdach/fix-skin-editor-crash-again ... Fix skin editor crashing in some circumstances when opened in main menu	2023-12-13 22:15:42 +09:00
Bartłomiej Dach	084474ef79	Merge branch 'master' into export-log-archive	2023-12-13 11:08:33 +01:00
Bartłomiej Dach	7a4ea90bda	Fix test failures due to dependency becoming required	2023-12-13 11:01:07 +01:00
Dean Herbert	8d55b3f34d	Merge pull request #25749 from smoogipoo/move-counts-to-beatmapinfo ... Move object counts to BeatmapInfo	2023-12-13 17:58:13 +09:00
Dan Balasescu	8c7570525a	Merge pull request #25744 from peppy/adjust-mod-multipliers ... Adjust some mod multipliers for initial leaderboard sanity	2023-12-13 17:56:13 +09:00
Dan Balasescu	812f52e793	Bump version number	2023-12-13 17:38:59 +09:00
Dean Herbert	9235f3d935	Merge pull request #25747 from peppy/fix-hit-error-clear ... Fix hit error displays not clearing on seek	2023-12-13 17:36:24 +09:00
Dean Herbert	5062c53e36	Refactor everything for sanity	2023-12-13 17:33:39 +09:00