Bartłomiej Dach
04f9a354c3
Convert SoloResultsScreen to NRT
2022-12-28 07:54:36 +01:00
Bartłomiej Dach
a0a26b1e8c
Ignore statistics update subscriptions with invalid score ID
...
If score submission fails, the score will not receive a correct online
ID from web, but will still be passed on to the solo statistics watcher
on the results screen. This could lead to the watcher subscribing to
changes with score ID equal to the default of -1. If this happened more
than once, that would cause a crash due to duplicate keys in the
`callbacks` dictionary.
Closes #21837 .
2022-12-28 07:54:01 +01:00
Bartłomiej Dach
e9d32fca18
Fix various failures in initial statistics fetch
...
- If the local user is restricted, then attempting to fetch their data
from the `/users` endpoint would result in an empty response.
- Even if the user was successfully fetched, their `RulesetsStatistics`
may not be populated (and instead be `null`). Curiously this was not
picked up by static analysis until the first issue was fixed.
Closes #21839 .
2022-12-28 07:31:36 +01:00
Dean Herbert
0d78bc2248
Fix osu.ppy.sh links no longer opening in-game
...
Addresses https://github.com/ppy/osu/discussions/21838 .
2022-12-28 06:42:35 +08:00
Dean Herbert
5e8ca11ded
Merge pull request #21819 from bdach/fix-global-ranking-accuracy-display
...
Fix incorrect accuracy display on overall ranking view
2022-12-28 04:47:15 +08:00
Bartłomiej Dach
e90619244d
Fix incorrect accuracy display on overall ranking view
2022-12-27 19:51:51 +01:00
Bartłomiej Dach
e2703bba18
Fix invalid data in test scene
2022-12-27 19:49:08 +01:00
Bartłomiej Dach
b4a3f872ee
Merge pull request #21809 from turbedi/split_trimentries
...
Use StringSplitOptions.TrimEntries in string.Split() when possible
2022-12-27 18:42:48 +01:00
Bartłomiej Dach
ae2058b55e
Merge branch 'master' into split_trimentries
2022-12-27 18:07:36 +01:00
Dean Herbert
080790d352
Merge pull request #21812 from frenzibyte/fix-publish
...
Move system packages version pinning workaround to game project
2022-12-27 20:31:35 +08:00
Salman Ahmed
1a4489edb2
Move version pinning of system packages to osu.Game
2022-12-27 14:58:18 +03:00
Dean Herbert
9be1689e04
Merge pull request #21811 from peppy/add-hard-link-faq
...
Add link to hard link explanation wiki page
2022-12-27 18:25:56 +08:00
Dean Herbert
61029b126d
Add link to hard link explanation wiki page
2022-12-27 17:56:23 +08:00
Dean Herbert
42c1d410b4
Merge pull request #21810 from peppy/api-switch
...
Use new lazer API endpoint
2022-12-27 17:56:20 +08:00
Dean Herbert
b3e44f20bc
Use new lazer API endpoint
...
This is a temporary change to target the new experimental/next deploy.
The main change that should result from this is having the user profile
show the pp^next values from the new domain.
2022-12-27 17:20:40 +08:00
Berkan Diler
182f36c434
Use StringSplitOptions.TrimEntries for string.Split() when possible
2022-12-27 09:41:58 +01:00
Dean Herbert
df6f2ad0a1
Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores
...
Only show global rankings on solo results screen when progressing from gameplay
2022-12-27 16:39:26 +08:00
Dean Herbert
38a674cd84
Merge pull request #21807 from Joehuu/external-link-open-highlight
...
Highlight "open" option on external link button context menu
2022-12-27 16:09:06 +08:00
Joseph Madamba
777ffcf805
Highlight "open" option on external link button context menu
2022-12-26 20:47:24 -08:00
Joseph Madamba
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
Salman Ahmed
bcaff37851
Merge pull request #21802 from turbedi/generic_enum
...
Use generic Enum methods
2022-12-27 02:42:12 +03:00
Joseph Madamba
8bc8b0d0af
Remove redundant context menu container
2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86
Move context menu / popover container one level to account for header
2022-12-26 15:37:46 -08:00
Bartłomiej Dach
01cf96e240
Only show global rankings on results screen when progressing from gameplay
2022-12-26 23:35:45 +01:00
Bartłomiej Dach
cb2b0d4178
Remove redundant type specs
2022-12-26 23:12:53 +01:00
Berkan Diler
335cb0205f
Remove now unnecessary using
2022-12-26 22:50:36 +01:00
Berkan Diler
fcbb21c75e
Fix typo
2022-12-26 20:38:35 +01:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Bartłomiej Dach
2470991aaa
Merge pull request #21800 from mk56-spn/remove_obsolete_star_colours
...
Remove obsoleted "ForDifficultyRating" method
2022-12-26 17:39:25 +01:00
Bartłomiej Dach
e416bdd06b
Merge branch 'master' into remove_obsolete_star_colours
2022-12-26 16:35:47 +01:00
mk56-spn
fbff5d8d69
Remove obsoleted "ForDifficultyRating" method
2022-12-26 16:16:52 +01:00
Dean Herbert
6b5059285b
Merge pull request #21798 from peppy/update-framework
...
Update framework
2022-12-26 22:44:47 +08:00
Dean Herbert
5dd03c6c60
Update framework
2022-12-26 21:53:52 +08:00
Dan Balasescu
786d94c149
Merge pull request #21792 from Joehuu/fix-parameters-inspection
...
Fix parameters with the same default value inspection
2022-12-26 15:41:54 +09:00
Dean Herbert
0761fa54c5
Merge pull request #21778 from bdach/score-stats-on-results
...
Add overall ranking display to solo results screen
2022-12-26 14:14:53 +08:00
Dean Herbert
09cc41604f
Merge branch 'master' into score-stats-on-results
2022-12-26 13:37:36 +08:00
Joseph Madamba
144144c40c
Revert removing redundant font parameter
2022-12-25 20:47:05 -08:00
Joseph Madamba
a10628e270
Change severity of RedundantArgumentDefaultValue to hint
2022-12-25 20:47:05 -08:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection
2022-12-26 05:17:40 +03:00
Dean Herbert
97d3b7bd63
Merge pull request #21781 from Joehuu/link-title-and-artist
...
Link beatmap set title and artist to listing search
2022-12-26 10:13:16 +08:00
Salman Ahmed
2d57ea6f15
Merge branch 'master' into link-title-and-artist
2022-12-26 03:23:05 +03:00
Joseph Madamba
973fd90af2
Fix parameters with the same default value inspection
2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8
Use empty drawables for spacing badges instead
2022-12-25 16:05:59 -08:00
Joseph Madamba
8e899c2e92
Use localisation parameters to find preferred string instead
2022-12-25 16:03:44 -08:00
Joseph Madamba
1a571e1c7f
Remove nullable disable on user panel
2022-12-25 15:03:08 -08:00
Bartłomiej Dach
b1ca38685d
Merge branch 'master' into score-stats-on-results
2022-12-25 21:44:42 +01:00
Joseph Madamba
b9dfb8b602
Add localisation for context menu strings
2022-12-25 10:12:02 -08:00
Joseph Madamba
2c2f347e25
Add context menus to overlay panels/cards
2022-12-25 09:57:42 -08:00
Dean Herbert
e6f9d6202c
Update appveyor deploy image
2022-12-25 23:40:01 +08:00
Dean Herbert
831c7420b7
Merge pull request #21776 from bdach/score-stats-display
...
Implement overall ranking display for solo results screen
2022-12-25 21:43:12 +08:00
