2600 Commits

• Fix tutorial download state not matching correctly when already available locally

  Closes https://github.com/ppy/osu/issues/18468.
  
  This doesn't stop the tutorial from downloading a second time, but at
  least displays the correct status afterwards. Avoiding the download is a
  bit more involved and requires a change to the flow. Probably not worth
  it just yet.
  
  To test, recommend switching to production environment, as dev server
  doesn't have correct metadata for tutorial resulting in weirdness.

  Dean Herbert · 2022-06-02 16:34:24 +09:00
  5bd9d88219
• Don't output beatmap parse failures in a visible manner

  The user can't do much about this. When a user reports a beatmap issue,
  the logs will still contain this useful information. Should be fine I
  think.
  
  As mentioned in
  
  https://github.com/ppy/osu/discussions/18426
  https://github.com/ppy/osu/issues/750
  https://github.com/ppy/osu/issues/18372
  
  etc.

  Dean Herbert · 2022-05-27 19:18:38 +09:00
  e53c8518de
• Add initial waveform comparison display
  Dean Herbert · 2022-05-24 14:36:44 +09:00
  588c5d1583
• Merge pull request #18339 from peppy/editor-timing

  Add first pieces of editor timing UI

  Dan Balasescu · 2022-05-23 11:12:22 +09:00
  f111d33b25
• Remove unnecessary cache type specification

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-05-23 02:00:04 +09:00
  267bef959f
• Move interface to more appropriate namespace
  Dean Herbert · 2022-05-22 22:49:24 +09:00
  3a7233bd6e
• Use Track to ensure its loaded before transferring
  Salman Ahmed · 2022-05-21 16:52:16 +03:00
  a17eed64f9
• Bring back virtual track condition given its cheapness

  Will still keep the override in `ClockBackedTestWorkingBeatmap` because
  it still relies on a local track store and will fail the moment it uses
  a non-virtual track.

  Salman Ahmed · 2022-05-21 16:51:56 +03:00
  a42f5ea34e
• Fix wrong return xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2022-05-21 16:43:31 +03:00
  466ed3c791
• Refactor track transferring logic for ability to override and disallow
  Salman Ahmed · 2022-05-20 14:43:07 +03:00
  c78d90ccbd
• Merge pull request #18321 from smoogipoo/legacy-catmull

  Fix compatibility issues with legacy Catmull sliders

  Dean Herbert · 2022-05-19 15:42:21 +09:00
  16075d2a2f
• Don't merge adjacent legacy Catmull segments
  Dan Balasescu · 2022-05-18 17:16:24 +09:00
  731f0960ec
• Assert that downloads are queued early enough to work
  Dean Herbert · 2022-05-17 17:33:54 +09:00
  8112416335
• Replace Pill with Badge everywhere
  Salman Ahmed · 2022-05-14 20:52:38 +03:00
  88ba84ac9c
• Integrate spotlight beatmap badge in listing cards
  Salman Ahmed · 2022-05-14 19:47:31 +03:00
  9bac33ec9f
• Prevent throwing exceptions on first run without internet
  Dan Balasescu · 2022-05-09 12:15:54 +09:00
  3b4fdf20f9
• Fix slider velocity wrongly decoded as scrolling speed in osu!catch
  ekrctb · 2022-05-08 21:49:42 +09:00
  dcf0d5a9d5
• Fix per-hit object slider velocity ignored in osu!catch
  ekrctb · 2022-05-08 13:45:21 +09:00
  3eeedd8024
• Merge branch 'master' into snapping-tidy-distance
  Dan Balasescu · 2022-05-05 19:55:55 +09:00
  39d10487b9
• Wrap BeatmapOnlineLookupQueue cache request in a task
  Salman Ahmed · 2022-05-05 12:40:02 +03:00
  67341db0e7
• Add comprehensive documentation of BeatmapInfo.DistanceSpacing
  Dean Herbert · 2022-05-05 16:25:45 +09:00
  6227e3f876
• Merge pull request #16576 from frenzibyte/osu-distance-spacing

  Add "distance spacing" support in editor for osu! ruleset

  Dean Herbert · 2022-05-03 12:15:18 +09:00
  faeefc5e18
• Revert "Convert data type of DistanceSpacing to float"

  This reverts commit 7aaa88cac2.

  Salman Ahmed · 2022-04-29 08:02:07 +03:00
  fef94d49f4
• Add "always bundled" beatmaps
  Dean Herbert · 2022-04-29 11:45:18 +09:00
  92d4463e55
• Allow bundled downloader to not post notifications
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  804848c9fb
• Update bundle logic to match stable
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  3c9e520188
• Remove explicit dependency on INotificationOverlay
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  d056465742
• Add tutorial download support and improve the visuals "slightly"
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  58399a5113
• Add initial flow for download button / progress display
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  973dd4bfa9
• Add very basic implementation of bundled beatmap downloader
  Dean Herbert · 2022-04-28 19:01:21 +09:00
  99d2d7b805
• Convert data type of DistanceSpacing to float
  Salman Ahmed · 2022-04-28 10:24:36 +03:00
  7aaa88cac2
• Set default value of DistanceSpacing to 1
  Salman Ahmed · 2022-04-28 07:14:43 +03:00
  dacca73838
• Remove weird code
  Dean Herbert · 2022-04-27 19:20:08 +09:00
  e9ec406046
• Fix high star ratings not being easily visible on tooltips

  Resolves issue mentioned in https://github.com/ppy/osu/discussions/17920.

  Dean Herbert · 2022-04-22 15:59:52 +09:00
  c44f7d9f93
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Handle virtual track string to avoid throwing later in lookup
  Dean Herbert · 2022-04-14 17:33:42 +09:00
  e010dfb150
• Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo

  A lot of tests are using test resources that populate the length field,
  but do not populate hitobjects. The general expectation is that
  components should be using the cached length in cases where hitobjects
  are not relevant, but `GetVirtualTrack` was doing its own local
  calculation.
  
  This could cause tests to fail due to `MusicController` changing track
  in the background.

  Dean Herbert · 2022-04-06 14:51:15 +09:00
  552ec5282f
• Merge branch 'master' into osu-diff-calc-max-combo
  Dan Balasescu · 2022-03-31 15:08:08 +09:00
  32e55e7d78
• Merge pull request #17416 from peppy/skin-fuck

  Refactor skin construction

  Dan Balasescu · 2022-03-25 15:36:06 +09:00
  478174dd58
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Make providing a custom ResourceStore to LegacyBeatmapSkin optional (for tests only)
  Dean Herbert · 2022-03-23 14:57:42 +09:00
  a7f63fb034
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Remove unnecessary MaxCombo migration between unmapped database fields
  Salman Ahmed · 2022-03-20 16:27:54 +03:00
  c2063f415d
• Add explicit todo about removing BeatmapInfo.MaxCombo

  Using that property is a trap basically.

  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  c5cc7eec79
• Merge branch 'master' into ruleset-leaderboard-unavailable
  Bartłomiej Dach · 2022-03-03 22:52:20 +01:00
  e1610b5d32
• Convert to extension method to avoid recursive calls
  Dean Herbert · 2022-03-03 14:15:37 +09:00
  42e07b7308
• Replace all legacy ruleset checks with a helper property call
  Dean Herbert · 2022-03-03 14:08:48 +09:00
  fab9323707
• Store user settings to realm
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  acf8db13ac
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Update FlatFileWorkingBeatmap to not require a ruleset store
  Dean Herbert · 2022-02-19 20:53:04 +09:00
  c869be87d1