62004 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	71f6e5731d	Fix potential null reference if no frames found ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:58:19 +09:00
Dean Herbert	f38b21110f	Add missing parenthesis to comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:57:43 +09:00
Bartłomiej Dach	e475a74a3a	Merge pull request #24443 from peppy/fix-transparent-player-background ... Fix storyboard being see-through in some contexts	2023-08-03 01:20:28 +02:00
Bartłomiej Dach	f48b1ebdbf	Merge branch 'master' into fix-transparent-player-background	2023-08-03 00:41:42 +02:00
Bartłomiej Dach	9da1de84b5	Merge pull request #24449 from peppy/fix-fucked-everything-fucking-clock-fuckkkkkkkkkkkk ... Fix global beatmap clock potentially getting into bad state	2023-08-02 22:39:41 +02:00
Joseph Madamba	aab462fd95	Fix valueText being replaced even if current is not binding to anything	2023-08-02 09:40:22 -07:00
Dean Herbert	87fee001c7	Fix multiplayer spectator potentially taking too long to start ... When watching from the middle of gameplay, due to a series of failures, `SpectatorClock` would not get seeked to the current time, causing all clients to look like they were out of sync. This is a hotfix for the issue. A better fix will require framework changes or considerable restructuring. I'd recommend testing this works in practice and agreeing that while it is a hack, it's likely not going to cause issues and is something we want to see fixed sooner rather than later.	2023-08-02 19:05:43 +09:00
Dean Herbert	75c1d5ad7f	Add lenience to FramedBeatmapClock workaround	2023-08-02 18:49:24 +09:00
Dean Herbert	14d87e49c7	Improve choice of where to start playback of multiplayer spectator	2023-08-02 18:46:35 +09:00
Dean Herbert	0e510088f9	Ensure background of gameplay is black when storyboard is overriding background display	2023-08-02 15:50:15 +09:00
Dean Herbert	a618ed140e	Move StoryboardReplacesBackground bindable more local to usage	2023-08-02 15:29:18 +09:00
QuantumSno	5443f89dca	Assuming its still set to tab, removes binding for toggle chat so itll be set to the new default	2023-08-01 16:58:52 -04:00
QuantumSno	426bc52fd5	Updated schema_version number and added braces around some migration cases to help with re-using variable names	2023-08-01 14:27:37 -04:00
Bartłomiej Dach	dc9c68b642	Merge pull request #24438 from peppy/multi-spectator-flow-fixes ... Fix issues switching to new beatmap in multiplayer spectator	2023-08-01 19:38:37 +02:00
Bartłomiej Dach	5b6c3321cf	Merge branch 'master' into multi-spectator-flow-fixes	2023-08-01 19:03:48 +02:00
Bartłomiej Dach	cecb3845e7	Merge pull request #24439 from peppy/multi-spectator-extended-results ... Show extended statistics in multiplayer spectator automatically	2023-08-01 19:00:28 +02:00
Bartłomiej Dach	a75f42f5a9	Merge branch 'master' into multi-spectator-extended-results	2023-08-01 18:25:41 +02:00
Bartłomiej Dach	d65f08a048	Merge pull request #24427 from peppy/fix-skin-editor-crash-multi-spectator ... Fix game crashing when entering skin editor in multiplayer spectator	2023-08-01 18:25:11 +02:00
Bartłomiej Dach	e591c7273b	Merge pull request #24440 from peppy/multi-spectator-animation-fix ... Fix centred player not animating correctly	2023-08-01 18:19:15 +02:00
Bartłomiej Dach	f7d5ac9f92	Privatise setter	2023-08-01 18:09:48 +02:00
Bartłomiej Dach	bcfc76b469	Add visual-only test coverage for centred player case	2023-08-01 17:41:07 +02:00
QuantumSno	054ca5e59c	Merge branch 'master' into leaderboard-toggle	2023-08-01 10:06:03 -04:00
Dean Herbert	70bd1d3cf4	Fix centred player not animating correctly	2023-08-01 20:18:21 +09:00
Dean Herbert	df504e1fc2	Show extended statistics in multiplayer spectator automatically	2023-08-01 20:02:36 +09:00
Dean Herbert	fe47dc291b	Fix onLoadRequested getting early-exited too early in spectator scenarios ... In some scenarios, multiplayer spectator would not tick over to the next beatmap. Here's an example: - Room has two items queued - Local user starts download of both - First beatmap starts and download is complete - First beatmap ends (spectating is active) - Second beatmap starts but download is not complete In this scenario, the local client will get stuck at the spectator screen due to the `onLoadRequested`-invoked screen change being early exited. It would require manual recovery (clicking back button) to return to a sane state.	2023-08-01 19:22:41 +09:00
Dean Herbert	9fe9ea2c90	Fix potential crash on multiple StartGameplay calls in multiplayer spectator	2023-08-01 19:22:41 +09:00
Dean Herbert	ed0c7e8880	Add failing test coverage showing crash on multiple StartGameplay invocations	2023-08-01 19:21:58 +09:00
Bartłomiej Dach	52730f7cd6	Merge pull request #24430 from peppy/update-framework ... Update framework	2023-08-01 01:05:49 +02:00
Bartłomiej Dach	049215f2dc	Add test coverage for invalid input scenarios	2023-08-01 01:02:16 +02:00
Bartłomiej Dach	4fb0ff8800	Implement instantaneous SliderWithTextBoxInput mode	2023-08-01 01:02:16 +02:00
Bartłomiej Dach	0b019f1d45	Add test covering desired instantaneous behaviour	2023-08-01 01:01:37 +02:00
Bartłomiej Dach	ca81f23356	Add test covering non-instantaneous behaviour	2023-08-01 01:01:37 +02:00
Bartłomiej Dach	2e2b0c4e41	Move SliderWithTextBoxInput to more general namespace	2023-08-01 01:01:36 +02:00
Dean Herbert	528298bc39	Update test in line with framework changes	2023-08-01 07:17:12 +09:00
Dean Herbert	d78cc60851	Update framework	2023-08-01 07:12:40 +09:00
Dean Herbert	a3afb198a1	Merge pull request #24341 from bdach/selection-operations-refactor ... Refactor rotation handling in editor to facilitate reuse	2023-07-31 17:18:05 +09:00
Dean Herbert	0e59cdc771	Merge pull request #24424 from bdach/exit-logo-hide ... Fix osu! logo suddenly disappearing during rapid exit	2023-07-31 17:10:49 +09:00
Dean Herbert	72005bef7c	Fix skin editor crashing if the same component is provided twice	2023-07-31 15:10:58 +09:00
Bartłomiej Dach	ebe5dd2ac9	Interface with SelectionRotationHandler via DI rather than explicit passing	2023-07-30 20:21:41 +02:00
Bartłomiej Dach	262f25dce8	Make SelectionRotationHandler a Component	2023-07-30 20:18:33 +02:00
Bartłomiej Dach	821cd08f34	Merge branch 'master' into selection-operations-refactor	2023-07-30 19:29:06 +02:00
Bartłomiej Dach	7763f3dd40	Fix osu! logo suddenly disappearing during rapid exit	2023-07-30 19:05:37 +02:00
Dean Herbert	a6343a669c	Merge pull request #24422 from bdach/multiplayer-exit-reliability ... Fix multiplayer match screen being exited from when not current	2023-07-30 23:33:32 +09:00
Bartłomiej Dach	d3435483eb	Fix multiplayer match screen being exited from when not current ... This was supposed to be fixed by #24255, but has popped up as a regression on Sentry since: https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email On a fifteen-minute check I cannot figure out how to reproduce, so rather than spending further brain cycles on this, just apply the same explicit guard that like fifteen other places do.	2023-07-30 15:50:10 +02:00
Bartłomiej Dach	3e801d8696	Merge pull request #24419 from peppy/fix-replay-export-queued-op ... Fix replay being unexpected exported at results screen after score switch	2023-07-30 15:31:17 +02:00
Bartłomiej Dach	1f7f336fd5	Merge branch 'master' into fix-replay-export-queued-op	2023-07-30 14:58:14 +02:00
Dean Herbert	15b5b481aa	Merge pull request #24421 from bdach/fix-nrt	2023-07-30 21:43:08 +09:00
Bartłomiej Dach	1981e49a40	Fix nullability inspection	2023-07-30 14:28:16 +02:00
Bartłomiej Dach	b51e577239	Merge pull request #24418 from peppy/now-playing-async-fix ... Fix now playing overlay background occasionally showing incorrect background	2023-07-30 14:05:49 +02:00
Bartłomiej Dach	898913f32a	Merge pull request #24415 from peppy/multi-spectator-improvements ... General visual improvements to mutliplayer spectatator screen	2023-07-30 12:43:26 +02:00