1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 02:33:02 +08:00
Commit Graph

49080 Commits

Author SHA1 Message Date
Dan Balasescu
43f1044987
Merge pull request #16850 from frenzibyte/readonly-pinned-scores
Add read-only pinned scores view in user profile overlay
2022-02-11 16:15:46 +09:00
Dean Herbert
6005daeba8 Fix fire-and-forget async calls to use WaitSafely 2022-02-11 16:02:42 +09:00
Dean Herbert
908c31c687 Update stream read operations to use new helper methods 2022-02-11 16:02:25 +09:00
Dean Herbert
beb3731c0b Standardise and combine base implementation of score submission requests
These share too much yet have very different constructor signatures and
property exposure. Just a clean-up pass as I begin to look at replay
submission.
2022-02-11 15:53:47 +09:00
Dean Herbert
09d29892c9
Merge pull request #16852 from frenzibyte/ruleset-grouping-order
Standardise grouping and ordering of `IRulesetInfo`/`RulesetInfo`s
2022-02-11 15:43:43 +09:00
Salman Ahmed
ccd6648961 Update pinned score container header to use localised title 2022-02-11 09:22:09 +03:00
Dean Herbert
f012f64fd1 Add test coverage checking carousel panel visual state after ruleset filter change 2022-02-11 15:21:01 +09:00
Dean Herbert
f049f175d5 Revert "Fix failing test case"
This reverts commit c29cc78853.
2022-02-11 15:19:55 +09:00
Salman Ahmed
b06caf2bf7 Update resources 2022-02-11 09:12:02 +03:00
Salman Ahmed
92e22c57a7 Introduce private APIRuleset for online ID equality comparison 2022-02-11 08:27:01 +03:00
Salman Ahmed
c29cc78853 Fix failing test case 2022-02-11 04:44:54 +03:00
Salman Ahmed
6f0e32826c Standardise ordering/grouping of IRulesetInfo/RulesetInfos 2022-02-11 04:27:11 +03:00
Salman Ahmed
26839f6ad8 Consider OnlineIDs during ruleset equality if available
Required for `APIBeatmap`s, which provide `Ruleset` instances with `OnlineID` available only.

Also consistent with the comparer implementation.
2022-02-11 04:26:58 +03:00
Salman Ahmed
1b729e891d Update pointless CompareTo implementation once again 2022-02-11 04:17:30 +03:00
Salman Ahmed
9574bc1382 Allow IRulesetInfos of same type to be comparable
At first I was planning on making `CompareTo` implemented at
`IRulesetInfo` itself and shared across classes, but turns out it only
implements it explicitly and not allow direct `IRulesetInfo.Equals`
calls.

It messed with my head enough that I decided to just let each class have
its own implementation and only allow same type.
2022-02-11 04:03:23 +03:00
Salman Ahmed
4f7003928a Add score container for pinned scores in ranks section 2022-02-10 21:32:18 +03:00
Salman Ahmed
9cd88ec2b8 Update API models with score pinning changes 2022-02-10 21:23:38 +03:00
Salman Ahmed
481003fe38
Merge pull request #16849 from peppy/update-resources 2022-02-10 20:34:44 +03:00
Dean Herbert
2939bc4644 Update resources 2022-02-11 01:49:52 +09:00
Dean Herbert
eda213e4de
Merge pull request #16827 from smoogipoo/spectator-state-rework
Add user state to SpectatorState, allowing multiplayer to continue to results
2022-02-11 01:48:47 +09:00
Dan Balasescu
015ec0b88a
Merge pull request #16844 from peppy/migration-delete-fail-gracefully
Allow game folder migration to fail gracefully when cleanup cannot completely succeed
2022-02-10 22:41:36 +09:00
Dean Herbert
19cb8cb03a Update tests 2022-02-10 19:35:28 +09:00
Dean Herbert
44f2d8a448 Allow game folder migration to fail gracefully when cleanup cannot completely succeed 2022-02-10 19:30:26 +09:00
Dean Herbert
176bb4a4e2 Update desktop projects to target .NET 6 2022-02-10 17:42:09 +09:00
Dan Balasescu
7081c418dd
Merge pull request #16842 from peppy/migration-error-output
Fix migration errors not outputting the call stack to logs
2022-02-10 16:31:14 +09:00
Dean Herbert
88bb9d4237 Fix migration errors not outputting the call stack to logs 2022-02-10 15:50:03 +09:00
Dan Balasescu
4dab42362e
Merge pull request #16838 from peppy/update-fastlane-souyuz
Update fastlane to latest release
2022-02-10 15:01:30 +09:00
Dan Balasescu
ebd105422f Remove unused using 2022-02-10 14:22:08 +09:00
Dan Balasescu
f7fb7825cc Simplify disposal 2022-02-10 14:21:51 +09:00
Dan Balasescu
a3896a8ebd Remove allowance of null dependency 2022-02-10 14:21:50 +09:00
Dean Herbert
f47748591a Update fastlane to latest release
This pulls in the fix from souyuz to allow us to bring things up-to-date
 again (see https://github.com/voydz/souyuz/pull/36#event-6033249116).

Have tested builds locally to work as expected.
2022-02-10 12:12:14 +09:00
Dean Herbert
b9655dd1d2
Merge pull request #16832 from hlysine/ruleset-templates-improvements 2022-02-10 01:38:08 +09:00
Henry Lin
036d17d9fd Remove licence headers 2022-02-09 20:48:14 +08:00
Henry Lin
d06d584867 Change assembly titles
So that they match the source name specified in template.json and can get replaced
2022-02-09 19:56:32 +08:00
Henry Lin
f1c6fdb2af Update .editorconfig, .gitignore and DotSettings
Basically just copied from root directory
2022-02-09 19:53:34 +08:00
Henry Lin
1b8ada087d Set NoDefaultExcludes to true
This allows files such as .editorconfig and .gitignore to be included in the nupkg
2022-02-09 19:25:51 +08:00
Dan Balasescu
18251c9285 Clean up SpectatorScreen based on suggestions 2022-02-09 12:20:07 +09:00
Dan Balasescu
ffc4c64f7e Unify namings across the board 2022-02-09 12:10:07 +09:00
Dan Balasescu
4966c4e974 Remove redundant parameter 2022-02-09 11:51:47 +09:00
Dan Balasescu
54b41181d6
Merge pull request #16830 from peppy/fix-playlist-selection-crash
Fix playlist overlay crash when pressing enter with no selection
2022-02-09 10:48:51 +09:00
Dean Herbert
c242a63b11 Fix playlist overlay null reference when attempting an empty selection
As reported at https://github.com/ppy/osu/discussions/16829.
2022-02-09 10:16:45 +09:00
Dan Balasescu
886d1d2df6 Refactorings 2022-02-08 21:29:43 +09:00
Dean Herbert
2dcb726581
Merge pull request #16826 from smoogipoo/fix-beatmap-availability-check
Fix comparison leading to incorrect beatmap availabilities
2022-02-08 21:01:13 +09:00
Dean Herbert
79d1d54e33 Rename parameter to match other usages 2022-02-08 20:35:38 +09:00
Dan Balasescu
c1766d8a41 Add paused state 2022-02-08 20:29:53 +09:00
Dan Balasescu
4c76027178 Rename completed state to passed 2022-02-08 20:29:49 +09:00
Dan Balasescu
0d99017178 Add state tests 2022-02-08 20:27:08 +09:00
Dan Balasescu
45b3f472ab Merge branch 'master' into spectator-state-rework 2022-02-08 19:51:50 +09:00
Dan Balasescu
b1a73996ba Fix incorrect check for beatmap availability 2022-02-08 19:36:42 +09:00
Dan Balasescu
9c2d57d707 Add failing test 2022-02-08 19:36:16 +09:00