Bartłomiej Dach
d4c9eb013e
Fix bugged initial state of matching filter flag
...
Was preventing mod preset panels from refiltering correctly on ruleset
change due to the `matchingFilter == value` guard.
2023-06-18 14:51:52 +02:00
Bartłomiej Dach
0b6c0592e4
Add failing test case for mod preset filtering not working after ruleset change
2023-06-18 14:51:16 +02:00
Bartłomiej Dach
a49af06e88
Reword comments in ModSelectOverlay
2023-06-18 14:34:33 +02:00
Bartłomiej Dach
28f929dc4d
Remove yet another redundant guard
2023-06-18 14:28:26 +02:00
Bartłomiej Dach
b9156b1df3
Reword/rename some stuff in test
2023-06-18 14:24:35 +02:00
Bartłomiej Dach
76f509a1db
Do not use ?? true pattern
...
Universally disliked. `!= false` is preferred.
2023-06-18 14:19:38 +02:00
Bartłomiej Dach
9758e5f840
Fix utterly broken test
...
- Was on wrong ruleset, so the mod/free mod sets did literally nothing
- `assertHasFreeModButton` had a param that did nothing
- Was checking `MatchingFilter` rather than `Visible`
2023-06-18 14:16:38 +02:00
Bartłomiej Dach
4c78144d10
Remove obvious comment
2023-06-18 14:04:00 +02:00
Bartłomiej Dach
64e96c6d82
Fix duplicate linq and reword comment
2023-06-18 14:03:26 +02:00
Bartłomiej Dach
a1015b4145
Remove duplicated xmldoc and move into relevant region
2023-06-18 13:59:36 +02:00
Bartłomiej Dach
1b4d7db1e6
Remove redundant guard
...
`Bindable` has one of those already.
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
c7e8990576
Remove unused property
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
62f01e4f40
Rename ModState members to better convey what's what
2023-06-18 13:58:25 +02:00
Dean Herbert
d9c00fc4be
Update framework
2023-06-18 20:57:43 +09:00
Dean Herbert
eb31fdecee
Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
...
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Dean Herbert
ba8ca3facf
Merge pull request #23954 from Joehuu/fix-drain-length-tooltip
...
Fix beatmap info length tooltip not showing actual drain length
2023-06-18 15:20:45 +09:00
Dean Herbert
66f33b4f8c
Merge pull request #23952 from frenzibyte/ios-file-import-support
...
Add back support for importing beatmaps/skins/replays on iOS via "Files" app
2023-06-18 15:14:50 +09:00
Joseph Madamba
9ae864c219
Fix beatmap info length tooltip not showing actual drain length
2023-06-17 15:00:32 -07:00
Joseph Madamba
fdebf93ae4
Fix incorrect xmldoc of IBeatmapInfo.Length
2023-06-17 14:55:27 -07:00
Bartłomiej Dach
fc07705809
Merge pull request #23951 from peppy/avoid-humanizer-song-select-overhead
...
Avoid humanizer regex compilation overhead when opening song select for the first time
2023-06-17 20:39:40 +02:00
Bartłomiej Dach
eafd774044
Bring back old formatting spec
2023-06-17 20:03:24 +02:00
Salman Ahmed
25fa4a2eb5
Move DragDrop handling to base game implementation for iOS support
2023-06-17 20:30:22 +03:00
Dean Herbert
4919069ea6
Avoid humanizer regex compilation overhead when opening song select for the first time
2023-06-18 02:19:03 +09:00
Bartłomiej Dach
822c556c5a
Merge pull request #23946 from FrBst/mania-triangles-fix
...
Fix column colours not being correctly applied on Triangles skin with Dual Stages mod active
2023-06-17 11:11:04 +02:00
Bartłomiej Dach
688e65475d
Add better test coverage of dual stages in skinnable tests
2023-06-17 10:27:43 +02:00
Maksim Kan
f70342bd67
Fix Triangle skin colors with Dual Stage mod
2023-06-17 10:12:26 +03:00
Bartłomiej Dach
2976145150
Merge pull request #23937 from peppy/order-by-total-score-extension
...
Move `OrderByTotalScore()` to an extension method
2023-06-16 22:18:27 +02:00
Bartłomiej Dach
b36ded0ba9
Merge pull request #23936 from peppy/fix-mania-hold-note-rewind-visuals
...
Fix osu!mania hold notes sometimes looking incorrect after rewind
2023-06-16 20:45:40 +02:00
Bartłomiej Dach
26a36a023e
Merge pull request #23837 from peppy/limited-distance-spacing
...
Add setting to limit distance snapping to current time
2023-06-16 20:36:08 +02:00
Salman Ahmed
e77cbc395c
Merge pull request #23943 from peppy/fps-nan
...
Attempt to fix rare NaN fps display
2023-06-16 21:00:13 +03:00
tsrk
61101335cc
test: fix KeyCounterController not provided as a dependency
2023-06-16 19:00:09 +02:00
tsrk
b960741ff7
test: adapt touch input test to changes
2023-06-16 18:54:19 +02:00
Dean Herbert
3b1f92d8b8
Fix fix logic causing further regression on release
2023-06-17 01:37:09 +09:00
Dean Herbert
a62b11606e
Attempt to fix NaN fps display
...
The only thing I can see which could cause this is reading from the `drawClock.ElapsedFrameTime` after the `isSpike` read causing a div-by-zero. Reading the values once at the start should avoid this.
2023-06-17 01:32:45 +09:00
tsrk
b9d6ba1934
test: add skin deserialisation test resource
2023-06-16 18:26:30 +02:00
Ruki
66f44452d2
Merge branch 'master' into hud/kc-skinnable
2023-06-16 17:30:33 +02:00
tsrk
f9321a24d9
test: change hideTarget drawable and testing logic
...
Doesn't change what it needs to test conceptually
2023-06-16 17:24:40 +02:00
Bartłomiej Dach
0ee9bcfea1
Merge pull request #23922 from smoogipoo/optimise-mania-density-calc
...
Optimise mania density calculation during beatmap conversion
2023-06-16 16:56:24 +02:00
Bartłomiej Dach
28696f595f
Privatise setter
2023-06-16 16:24:07 +02:00
Bartłomiej Dach
f79c9d711d
Merge pull request #23934 from peppy/fix-score-conversion-failures
...
Fix score migration not migrating all scores properly
2023-06-16 16:16:09 +02:00
Dean Herbert
d965d39c44
Fix distance snap grid circles not correctly being centered on snap point
2023-06-16 17:21:32 +09:00
Dean Herbert
36954e55ad
Fix incorrect mapping when distance spacing is not 1.0x
2023-06-16 17:15:45 +09:00
Dean Herbert
003949ac4e
Merge branch 'master' into limited-distance-spacing
2023-06-16 16:56:22 +09:00
Dean Herbert
362aa4b376
Also move GetMaxAchievableCombo
2023-06-16 15:26:13 +09:00
Dean Herbert
ce41ef6e5d
Move OrderByTotalScore() to an extension method
2023-06-16 15:24:30 +09:00
Dean Herbert
b5de109cb3
Fix osu!mania hold notes sometimes looking incorrect after rewind
2023-06-16 14:54:19 +09:00
Dean Herbert
1f17f416a4
Force migration of old-new standardised scores to run once more
2023-06-16 14:04:18 +09:00
Dean Herbert
94b7de4b3f
Fix old-new standardised score conversion missing some scores due to not rounding correctly
2023-06-16 14:01:56 +09:00
Dean Herbert
f5eb629709
Merge pull request #23930 from bdach/fix-old-lazer-score-reimport
...
Fix reimporting old lazer scores undoing standardised score recalculation
2023-06-16 12:47:55 +09:00
Bartłomiej Dach
51b5a0863f
Apply migration to new standardised score on normal reimport too
2023-06-15 21:53:15 +02:00
