Dean Herbert
693b7c9906
Reorganise resolved fields in MainMenu
2023-06-23 15:19:47 +09:00
Dean Herbert
7fa07805b0
Expose all notifications from INotificationOverlay
...
Also fixes `HasOngoingOperations` not actually working.
2023-06-23 15:19:21 +09:00
Dean Herbert
d86424467e
Merge pull request #23971 from tybug/comment-logged-out
...
Disable posting comments when logged out
2023-06-23 15:15:27 +09:00
Dean Herbert
20aedc82ac
Remove unused code
2023-06-23 14:47:32 +09:00
Dean Herbert
6df617d536
Rename ExitConfirmOverlay to be more explicit about purpose
2023-06-23 14:46:38 +09:00
Dean Herbert
11a97e1bb8
Move confirmation bypass implementation to MainMenu to allow for more correct logic
2023-06-23 14:42:56 +09:00
Dean Herbert
08b3c0cce0
Change "floating fruits" mod to only apply adjustments to the playfield
...
Avoids things like touch screen inputs also being flipped.
Note that these adjustments can't be applied directly to the playfield
due to how playfields are used in various rulesets (basically relying on
the `PlayfieldAdjustContainer` to get things in the right place).
Closes #24000 .
2023-06-23 14:18:43 +09:00
Dean Herbert
343271751a
Add Schedule to ensure correct thread for UI code
2023-06-23 14:07:33 +09:00
Dean Herbert
ce1579f2fe
Bind to API.State instead of API.User
2023-06-23 14:05:02 +09:00
Dean Herbert
d53996336c
Add note about swells and their ticks
2023-06-23 14:01:10 +09:00
Dean Herbert
64b726d5ec
Fix nested logic not being completely correct (favouring already-passed rather than near-future)
2023-06-23 13:48:13 +09:00
Bartłomiej Dach
c06b825d9b
Merge branch 'master' into comment-logged-out
2023-06-22 23:19:00 +02:00
Bartłomiej Dach
2c1c20e0a7
Rename test helpers
2023-06-22 23:10:16 +02:00
Bartłomiej Dach
1672608a87
Document why things were done in DummyAPIAccess
2023-06-22 23:08:30 +02:00
Bartłomiej Dach
786deec296
Rename and xmldoc members
2023-06-22 23:00:52 +02:00
Bartłomiej Dach
361ae15824
Merge pull request #23999 from peppy/fix-catch-legacy-combo-floating
...
Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active
2023-06-22 22:49:31 +02:00
Bartłomiej Dach
0ce4d17e30
Merge pull request #23888 from peppy/fix-intro-playing-twice
...
Fix music sometimes restarting twice if exiting song select with no beatmap selected
2023-06-22 22:49:15 +02:00
Bartłomiej Dach
a753c89dea
Merge pull request #23974 from peppy/fix-multiplayer-present-beatmap
...
Fix presenting beatmaps while in a multiplayer room not working
2023-06-22 22:48:48 +02:00
Bartłomiej Dach
bede12a3e8
Merge pull request #23975 from peppy/skin-editor-beatmap-skin-disable
...
Disable beatmap skinning support when entering the skin editor
2023-06-22 22:45:44 +02:00
Liam DeVoe
21bed336c6
adjust DummyAPIAccess to more closely match APIAccess
...
wrt logging in and out
2023-06-22 16:01:12 -04:00
Bartłomiej Dach
a11b3a67fb
Merge branch 'master' into skin-editor-beatmap-skin-disable
2023-06-22 20:30:51 +02:00
Bartłomiej Dach
aea5eb37dc
Remove unused using directive
2023-06-22 20:24:44 +02:00
Bartłomiej Dach
79606317ab
Remove redundant parentheses
2023-06-22 20:02:10 +02:00
Bartłomiej Dach
2b9cbaa4da
Merge pull request #23967 from peppy/save-replay-hotkey
...
Add hotkey to save replay
2023-06-22 19:50:57 +02:00
Bartłomiej Dach
65d4506ef2
Merge branch 'master' into save-replay-hotkey
2023-06-22 18:51:30 +02:00
Bartłomiej Dach
28dc5640a3
Merge pull request #23972 from peppy/notifications-during-pause
...
Allow notifications while the game is paused (or in break time)
2023-06-22 18:31:39 +02:00
Dean Herbert
4be8eede88
Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active
...
Closes #23989 .
2023-06-22 18:46:43 +09:00
Dean Herbert
07a00e8afd
Fix typo in comment
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-06-22 00:02:02 +09:00
Dean Herbert
7b4cbea362
Allow nullable to fix test usages
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-06-22 00:01:48 +09:00
Dean Herbert
59b1f08d53
Don't require exit confirmation when there are no ongoing operations that could be interrupted
2023-06-21 19:06:28 +09:00
Dean Herbert
c3f772f0da
Add method to queue a restart after app is exited (when supported)
2023-06-21 19:06:28 +09:00
Dean Herbert
655491ae2d
Fix potential null ref in ResultsScreen
2023-06-21 17:50:06 +09:00
Dean Herbert
1907beb0c9
Add FireAndForget to stray Task.Run
2023-06-21 17:48:55 +09:00
Dean Herbert
9ca772421d
Improve and combine logic that exists in two classes
2023-06-21 17:48:12 +09:00
Dean Herbert
4ff5275208
Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing
2023-06-21 17:33:42 +09:00
Dean Herbert
cb0f642ad7
Change skin editor flow to always save on toggle
...
This also moves the beatmap skin disable toggle to on toggle, in line
with review feedback.
I've decided to always apply the disable, not just on the `Player`
screen. It should be assumed that if a user is in the skin editor they
are never going to need access to this anyway.
2023-06-21 16:14:47 +09:00
Dean Herbert
366dd96875
Use bindable lease instead of reimplementing the same thing locally
2023-06-21 16:09:54 +09:00
Liam DeVoe
6de7328fef
add test for comment when logging in and out
2023-06-21 02:17:51 -04:00
Liam DeVoe
dd4f271158
fix cancel test for new button layout
2023-06-21 02:15:02 -04:00
Liam DeVoe
cc764afe3e
use two separate buttons for posting / login
2023-06-21 00:58:43 -04:00
Liam DeVoe
8460873e61
move commitButton.Text update to appropriate method
2023-06-21 00:37:54 -04:00
Bartłomiej Dach
a7172e7469
Fix one remaining seek
2023-06-20 23:32:38 +02:00
Bartłomiej Dach
29697d4999
Fix taiko test scene failing due to missing gameplay clock dependency
...
`GameplayClock` is inscrutable.
`TestManualClock` is lifted from another test scene because of
`FramedBeatmapClock`'s intensely confusing tendency to not work if it is
given a non-adjustable `ManuelClock` instead.
2023-06-20 23:30:52 +02:00
Bartłomiej Dach
2f77675fe7
Fix errors in tests due to mismatching NRT annotations
2023-06-20 21:57:32 +02:00
Dean Herbert
cb07f2399f
Apply NRT to GameplaySampleTriggerSource
2023-06-20 21:03:55 +09:00
Dean Herbert
92e89c7df7
Update test expectations
2023-06-20 21:02:34 +09:00
Dean Herbert
04dad6c6e8
Use IGameplayClock to ensure our clock source is correct
2023-06-20 20:47:56 +09:00
Dean Herbert
0e86102681
Fix nested lookups
2023-06-20 20:45:02 +09:00
Dean Herbert
786d5a394b
Add back optimisation and increase time allowance slightly
2023-06-20 20:30:07 +09:00
Dean Herbert
555ce7684b
Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object
...
Closes #23963 .
To simplify things, I've removed the optimisation of using
`AliveObject`s because it would break the way this whole lookup works.
2023-06-20 20:06:07 +09:00
