osu-lazer

Fix song select local ranks disappearing on beatmap downloads (#37711 )

Rather than a complete regression from
https://github.com/ppy/osu/pull/37666, the change I made to hide stale
ranks revealed that this subscription was being reinitialised *way* too
often.

Relevant call stack:

<img width="3324" height="1276" alt="2026-05-12 02 15 58@2x"
src="https://github.com/user-attachments/assets/a139a36b-9faa-495a-ab01-bba05cef02d4"
/>

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-05-12 12:11:07 +02:00

6687cc062d

Fix crash when fetching top local rank in song select (#37722 )

Closes https://github.com/ppy/osu/issues/37715.

The user's database contains several scores in which `ScoreInfo.Ruleset`
is null. How this happened, I'm not sure, it's probably custom rulesets.

The proper way to handle this would be to mark `ScoreInfo.Ruleset` as
nullable and deal with the hundred files of fallout, and also the fact
that `ScoreInfo` is an overloaded mess of a model that is sometimes a
database model and sometimes a post-converted online structure with
things backfilled to fit and I'm just not wanting to waste a week here,
so I'm choosing to look away.

Sidebar: You can't just put a null-propagating operator in the previous
conditional too because analysers will scream that `Ruleset` can't
*possibly* be null! So this uses `RulesetInfo.Equals(RulesetInfo?)`
because that can sorta-kinda handle nulls.

Bartłomiej Dach · 2026-05-12 15:39:00 +09:00

c2b96eb0f2

Fix song select scrolling performance when user has many beatmaps loaded (#37666 )

Also fixes wrong rank showing briefly in some scenarios.

---

I'm quite confused why the overhead is in the post-async-filter
collection access, but it is. It occurs when using `MaxBy` (realm
snapshot creation), but also when calling `.Count` on the collection, or
even just accessing `sender[0]`. I tried everything, and ended up
settling on simplifying the realm part enough that we can do
post-filtering without much sweat or mess.

Before:


https://github.com/user-attachments/assets/59aed895-03ed-4923-9515-9a5426156f7e

After:


https://github.com/user-attachments/assets/9a37f34a-c955-45bf-877f-89f248d8ea72

Tested using [this realm](https://screvillshot.s-ul.eu/YJUJ4SR1).

- Closes https://github.com/ppy/osu/issues/37574.
- Closes https://github.com/ppy/osu/issues/37661.

Dean Herbert · 2026-05-08 13:25:55 +02:00

08c02e29b9

Move v2 files to final location

This contains only renames and namespace updates.

Dean Herbert · 2026-03-03 16:45:15 +09:00

c28c64940a

4 Commits