osu-lazer

Fix some numeric settings not working correct in some languages when attempting to set negative value (#37667 )

Closes https://github.com/ppy/osu/issues/37553.

You can probably tell by the title that this is going to be a good one.

As previously mentioned in https://github.com/ppy/osu/pull/35395,
framework-side `TextBox` uses a bunch of `NumberFormat` properties from
`CurrentCulture` to contextually allow decimal points or minus signs in
a textbox.

In some languages, namely (of the ones we support): Finnish, Croatian,
Lithuanian, Norsk, Slovenian, and Swedish, `NumberFormat.NegativeSign`
is not `U+002D HYPHEN MINUS`, but instead `U+2212 MINUS SIGN`.
Therefore, in `FormSliderBar`, when `ToStandardFormattedString()` is
attempted to be used to set the textbox value, the hardcoded `U+002D
HYPHEN MINUS` is rejected on cultures that expect `U+2212 MINUS SIGN`,
and thus due to a feedback loop, all negative values are no longer
settable.

This applies the obvious fix of applying `NumberFormat.NegativeSign`.

Bartłomiej Dach · 2026-05-08 15:45:57 +09:00

7f5f368dea

Always use current culture in ToStandardFormattedString()

Bartłomiej Dach · 2025-10-24 08:26:01 +02:00

ae7ba034a7

Allow NumberFormattingExtensions.ToStandardFormattedString() to accept culture

I had previously made it invariant in
https://github.com/ppy/osu/pull/32837, and in another instance of past
me being an asshole, I can't actually find the reasoning for this at
this time.

That said, you'd be excused for thinking "why does this matter"? Well,
this will fix https://github.com/ppy/osu/issues/35381, because that
failure only occurs when the user's culture is set to one that doesn't
use a decimal point (.) but rather a decimal comma (,). This messes with
framework, which uses the *current* culture to check for decimal
separator rather than invariant:

https://github.com/ppy/osu-framework/blob/d3226a7842487de43a0d989e1bb59a9ebbc479af/osu.Framework/Graphics/UserInterface/TextBox.cs#L106-L111

An alternative would be to change framework instead to always accept the
invariant decimal separator.

God I hate this culture crap.

Bartłomiej Dach · 2025-10-22 10:31:12 +02:00

a29a5ab7e6

Remove redundant double string invariance

Bartłomiej Dach · 2025-09-29 08:33:18 +02:00

d1cf248b9a

Fix testdouble failure.