238 Commits

• Fix storyboard video-only check being inverted
  Joseph Madamba · 2023-05-16 21:51:32 -07:00
  d6fa44240d
• Actually use new end time property when setting lifetimes
  Dean Herbert · 2023-04-26 13:28:51 +09:00
  1efc78c0f8
• Add second definition of EndTime for storyboard elements to account for loops in lifetime
  Dean Herbert · 2023-04-25 15:22:11 +09:00
  e330052852
• Apply NRT to some storyboard classes
  Dean Herbert · 2023-04-25 14:30:01 +09:00
  3919400be2
• Fix storyboard videos not fading out on completion

  Closes https://github.com/ppy/osu/issues/22802.
  
  Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've
  stuck with 500ms (what lazer was already using for the fade-in) because
  I think it feels better.
  
  Tested using the beatmap linked in the issue thread.

  Dean Herbert · 2023-03-07 15:54:35 +09:00
  2cce785fa5
• Remove unused Duration property to avoid any misunderstandings
  Dean Herbert · 2023-02-06 16:42:39 +09:00
  eabd1a0cc1
• Fix storyboard outro time potentially running too long
  Dean Herbert · 2023-02-06 16:39:44 +09:00
  679ec986d5
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge pull request #21144 from peppy/fix-storyboard-end-start-time

  Fix incorrect handling of storyboard events with `end_time` before `start_time`

  Dan Balasescu · 2022-11-10 22:53:45 +09:00
  fd88c92d5a
• Fix sprites not displaying in storyboard if filename extension is missing in script
  Dean Herbert · 2022-11-08 14:34:28 +09:00
  0b34340447
• Fix incorrect handling of storyboard events with end_time before start_time
  Dean Herbert · 2022-11-07 12:25:36 +09:00
  6085120dc5
• Add support for weird storyboards which have backwards events

  Closes https://github.com/ppy/osu/issues/20632.
  Not adding test coverage because this is just weird.

  Dean Herbert · 2022-10-10 16:51:55 +09:00
  28185178d6
• Remove null conditional
  Salman Ahmed · 2022-09-23 17:06:55 +03:00
  835cae3087
• Fix crash when storyboard attempts to play at main menu
  Dean Herbert · 2022-09-23 20:10:57 +09:00
  4e9053b099
• Remove unnecessary virtual spec
  Dean Herbert · 2022-09-12 14:20:48 +09:00
  bbf906ee06
• Fix storyboard animations not starting their animation playback from the correct point in time
  Dean Herbert · 2022-09-12 14:05:16 +09:00
  24138b65a7
• Fix VectorScale set to 0 still showing some sprites in storyboard

  This implementation was matching the [framework side implementation of
  scale](https://github.com/ppy/osu-framework/blob/16d1c2d3356b0f59271fb49cff5fe8373ae9cdf3/osu.Framework/Graphics/Drawable.cs#L973-L976)
  but I don't think it's required here.
  
  I'm still not sure if the framework implementation is correct, but
  removing it locally does seem to fix broken storyboard cases.
  
  Closes https://github.com/ppy/osu/issues/20155.

  Dean Herbert · 2022-09-07 15:39:19 +09:00
  824e68dab3
• Fix typo in LoopStartTime addition
  Dean Herbert · 2022-09-06 17:46:03 +09:00
  a3de5f808e
• Rewrite logic using a list
  Dean Herbert · 2022-09-06 16:58:51 +09:00
  677708c5e4
• Refactor alpha check to not overwrite sourced overrides with values from later commands
  Dean Herbert · 2022-09-06 16:41:32 +09:00
  d667f46830
• Handle earliest-alpha-start-time logic in StoryboardSprite itself
  Dean Herbert · 2022-09-06 16:16:58 +09:00
  bea42d2862
• Remove EarliestDisplayTime's input to CommandStartTime
  Dean Herbert · 2022-09-06 16:16:58 +09:00
  a5e57b083c
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Apply IRenderer changes
  Dan Balasescu · 2022-08-02 19:50:57 +09:00
  b4e55f7309
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Remove unnecessary null casts
  Dean Herbert · 2022-06-24 14:50:11 +09:00
  f71f6302fd
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc
• Add null check guards to unsubscriptions in Dispose()
  Bartłomiej Dach · 2022-04-07 21:37:42 +02:00
  71c0216c55
• Change DrawableStoryboardAnimation to derive from TextureAnimation
  Dean Herbert · 2022-04-07 17:35:59 +09:00
  040afff670
• Fix DrawableStoryboardAnimation to handle skin fallback frame count similar to stable

  Reasoning is explained in the inline comment (basically, stable doesn't
  care what the user specifies as the frame count when falling back to
  skin resources).
  
  This change also removes on to two layers of drawables, which should be
  a win in heavy storyboards.

  Dean Herbert · 2022-04-07 17:35:56 +09:00
  cbc4e5319d
• Fix DrawableStoryboardAnimation not specifying sizing correctly

  Usually this would be handled by `TextureAnimation`, but because we are
  inheriting from `DrawableAnimation` here for reasons, we needed to
  implement this ourselves. Follows the implementation in
  `TextureAnimation`.

  Dean Herbert · 2022-04-07 15:18:55 +09:00
  a7e262627f
• Update DrawableStoryboardSprite to use helper method
  Salman Ahmed · 2022-03-14 06:30:54 +03:00
  c1697c7621
• Share origin adjustment logic between storyboard sprite and animation
  Salman Ahmed · 2022-03-14 05:44:34 +03:00
  740a72e16d
• Simplify conditionals to one XOR operations with comments
  Salman Ahmed · 2022-03-14 04:40:35 +03:00
  9cf05080da
• Fix drawable storyboard sprites not flipping origin on negative scale
  Salman Ahmed · 2022-03-14 03:50:12 +03:00
  0b8c89bfa8
• Fix SkinnableSprites in storyboards not autosizing to their textures
  Salman Ahmed · 2022-03-14 03:46:13 +03:00
  c9d54834be
• Make mods argument optional for storyboard construction
  Dean Herbert · 2022-03-04 12:05:02 +09:00
  c38126ba9d
• Remove unnecessary nullability of storyboard mods list
  Salman Ahmed · 2022-03-03 00:09:12 +03:00
  3630ab2db2
• Fix storyboard samples rate not adjusted from actual gameplay mods
  Salman Ahmed · 2022-03-02 20:56:18 +03:00
  cbb8dc2891
• Fix storyboard background replacement logic not working for beatmaps with multiple backgrounds

  In the case where the background image of individual difficulties is
  different, querying the beatmap *set*'s metadata as we were will cause
  issues.
  
  I haven't added test coverage for this but can if required. Can be
  manually tested using https://osu.ppy.sh/beatmapsets/1595773#osu/3377474
  (specifically the highest difficulty).
  
  Closes https://github.com/ppy/osu/discussions/16873.

  Dean Herbert · 2022-02-18 16:24:19 +09:00
  e49da2948d
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Fix further warnings
  Dean Herbert · 2022-01-12 23:42:12 +09:00
  b2d09b7b10
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Fix invalid DI resolution of RealmFileStore
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  167c399e8a
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Miscellaneous fixes that don't fit elsewhere
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  e6fdd0e969