1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 07:33:20 +08:00
Commit Graph

9319 Commits

Author SHA1 Message Date
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:08:14 +09:00
clayton
48d9bc982f
Fix tests 2024-08-07 14:36:04 -07:00
Dean Herbert
b5a19707d0
Merge branch 'master' into additions 2024-08-08 03:31:11 +09:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter 2024-08-08 03:21:52 +09:00
Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise 2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality 2024-08-07 14:01:30 +02:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation 2024-08-07 19:07:45 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
Dean Herbert
b081b47714
Add test of daily challenge flow from main menu 2024-08-07 19:07:44 +09:00
Dean Herbert
b1488fd5b7
Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay
Add legacy key counter support
2024-08-07 17:48:30 +09:00
Dean Herbert
1aea8e911c
Add test coverage of chat mentions 2024-08-07 01:33:56 +09:00
Dean Herbert
f7b45a26de
Improve test coverage and segregation 2024-08-06 19:32:00 +09:00
Dean Herbert
9ccd8c906d
Merge branch 'master' into hover-open-mod-customise 2024-08-06 18:35:35 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden 2024-08-06 16:12:00 +09:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay 2024-08-06 14:05:33 +09:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
Dean Herbert
17eb134797
Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow 2024-08-05 17:01:20 +09:00
Dean Herbert
24a0ead62e
Make tests actually show what value they are testing 2024-08-05 17:01:00 +09:00
Dean Herbert
9c5e29b2c9
Fix test being disabled for cases which should pass 2024-08-05 16:58:00 +09:00
Dean Herbert
c0814c2749
Add test of existing slider placement behaviour for safety 2024-08-05 14:25:10 +09:00
Dean Herbert
9673985e2c
Add test coverage of right/middle click behaviours with placement blueprints 2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dean Herbert
419d5a76ce
Merge branch 'master' into fix-pause-in-osu-again 2024-08-05 12:00:21 +09:00
jkh675
273bd73a99 Fix unit test error 2024-08-04 19:50:57 +08:00
jkh675
6f9866d542 Add unit test for OsuTooltip 2024-08-04 18:56:19 +08:00
Caiyi Shyu
c85dc40f91
Merge branch 'master' into hover-open-mod-customise 2024-08-02 19:07:27 +08:00
Salman Ahmed
dc9f6a07cb Fix inspections 2024-08-02 11:16:32 +03:00
Salman Ahmed
c3b2d81066 Add failing test case 2024-08-02 10:19:44 +03:00
Dean Herbert
310def64f4
Merge branch 'master' into user-profile-daily-challenge-streak-display 2024-08-02 15:40:46 +09:00
Dean Herbert
816dee181a
Rename classes to remove "streak" terminology
Since the primary display isn't showing a streak.
2024-08-02 15:33:30 +09:00
Caiyi Shyu
051d52c23f Update ModCustomisationPanel to use ExpandedState enum 2024-08-01 19:25:45 +08:00
Dean Herbert
e9ed9ff58b
Merge pull request #29188 from bdach/daily-challenge/better-messaging
Add notification on daily challenge conclusion & start of new one
2024-07-31 13:35:25 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array 2024-07-31 02:53:10 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging 2024-07-30 19:04:48 +09:00
Dean Herbert
71649005bf
Elongate usernames in DrawableChannel test 2024-07-30 17:52:55 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally 2024-07-30 10:36:26 +02:00
Bartłomiej Dach
a05f810724
Attempt to fix tests more 2024-07-30 10:07:38 +02:00
Bartłomiej Dach
ae38e66036
Add failing test coverage 2024-07-30 08:39:01 +02:00
Salman Ahmed
91dfe4515b Fix daily challenge display showing incorrect statistic 2024-07-30 08:12:03 +03:00
Salman Ahmed
7c3d592a84 Fix user profile overlay test scene being broke 2024-07-30 07:06:59 +03:00
Bartłomiej Dach
b77a10b6db
Fix tests maybe 2024-07-29 15:28:52 +02:00
Dean Herbert
1daeb7ebd0
Rename typo in test naming 2024-07-29 22:19:38 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.

The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay 2024-07-29 20:58:42 +09:00
Dean Herbert
76cd2df699
Add ability to test daily challenge carousel items when hidden 2024-07-29 20:43:47 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals 2024-07-29 20:24:51 +09:00
normalid
e58bdbb8a9 Improve unit test 2024-07-28 15:08:36 +08:00
Salman Ahmed
82fbd5b045 Rename file 2024-07-28 06:40:16 +03:00
Salman Ahmed
e82c54a31c Integrate daily challenge streak display with user profile overlay 2024-07-28 05:58:30 +03:00
Salman Ahmed
17f5d58be2 Add daily challenge streak display and tooltip 2024-07-28 05:58:27 +03:00
Joseph Madamba
bc25e5d706 Remove unnecessary depth and padding set 2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a Merge remote-tracking branch 'upstream/master' into pr/28991 2024-07-27 19:09:02 -07:00
Joseph Madamba
b4ca07300a Use same size button for everything 2024-07-27 18:43:54 -07:00
normalid
4e44a6e7f8 Clean up code 2024-07-27 18:55:17 +08:00
normalid
73a98b45e9 FIx code quality 2024-07-27 18:48:45 +08:00
normalid
7f4bfb25a9 Implement unit test 2024-07-27 18:24:32 +08:00
Caiyi Shyu
bd017aea38
fix TestPreexistingSelection failing 2024-07-26 23:58:52 +08:00
Caiyi Shyu
a3576a55c2 add test for hovering ModCustomisationPanel 2024-07-26 22:45:12 +08:00
Dean Herbert
4fa6a19409
Merge pull request #29108 from bdach/daily-challenge/better-breakdown
Improve score breakdown on daily challenge
2024-07-26 23:12:04 +09:00
Dean Herbert
1607075e0c
Merge pull request #29099 from bdach/daily-challenge/totals-display
Implement component for displaying running totals in daily challenge
2024-07-26 21:44:58 +09:00
Bartłomiej Dach
fc0ade2c61
Highlight where local user's best is on the breakdown 2024-07-26 14:32:01 +02:00
Bartłomiej Dach
174dc91f4b
Implement component for displaying running totals in daily challenge
Total pass count and cumulative total score, to be more precise.
2024-07-26 09:51:39 +02:00
Bartłomiej Dach
e489ae8f72
Merge pull request #29055 from peppy/event-feed-improvements
Improve daily challenge event feed
2024-07-26 08:37:47 +02:00
Bartłomiej Dach
09a1fd2cd1
Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button
Fix daily challenge not showing a replay button in results screen
2024-07-26 08:03:17 +02:00
Salman Ahmed
3e8917cadb Add test case against resetting score in download button 2024-07-26 05:08:13 +03:00
Salman Ahmed
f3dd1facf1 Add failing test case 2024-07-25 09:16:09 +03:00
Salman Ahmed
e1ccf68801 Revert "Add failing test case"
This reverts commit 0182f3d7c3.
2024-07-25 08:51:48 +03:00
Dean Herbert
f1dda4ab1e
Fix too many event rows displaying after spending a long time in gameplay/results 2024-07-25 14:31:22 +09:00
Dean Herbert
bba151a776
Make event feed test show more realistic content automatically 2024-07-25 14:31:21 +09:00
Salman Ahmed
0182f3d7c3 Add failing test case 2024-07-25 07:39:58 +03:00
Salman Ahmed
b3e3bf7cec Add lenience to avoid floating point errors 2024-07-24 23:26:23 +03:00
Salman Ahmed
6645dac71d Fix dragging number boxes overwritten by select-all-on-focus feature 2024-07-24 23:19:04 +03:00
Bartłomiej Dach
12a9086aa3
Fix test failure
After the legacy key counter was moved to ruleset-specific component
containers, `TestSceneSkinnableHUDOverlay` no longer had a key counter,
because it wasn't creating a ruleset-specific HUD component container
due to

    4983e5f33e/osu.Game/Screens/Play/HUDOverlay.cs (L131-L133)

Therefore, to fix, do just enough persuading to make it create one.
2024-07-24 18:30:18 +02:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.

Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
ace5071d88
Add better test scene 2024-07-24 14:25:51 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour 2024-07-24 12:08:13 +02:00
normalid
95f287104e Add visual test seane 2024-07-24 12:24:58 +08:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Bartłomiej Dach
088b8aff11
Merge pull request #28881 from smoogipoo/fix-judgement-cut
Fix judgement animation getting cut early
2024-07-22 09:24:57 +02:00
Layendan
6a4872faa8 Remove nullable disable 2024-07-21 23:56:47 -07:00
Layendan
e4cccb5e31
Fix lint errors 2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests 2024-07-22 12:22:51 +09:00
Salman Ahmed
d7651ef387 Add extensive test cases for correct input handling while paused in osu! & non-osu! 2024-07-19 18:48:35 +03:00
Dean Herbert
d9297438ba
Merge pull request #28900 from smoogipoo/fix-more-tests
Fix more test failures
2024-07-19 19:38:52 +09:00
Dan Balasescu
7a4758d8cc
Attempt to fix TestSelectableMouseHandling test failure
https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871

This is an attempt. Going frame-by-frame I noticed that there's one
frame in which the text is loaded but the
FillFlowContainer/GridContainer haven't properly validated so the text
is not positioned correctly (it's overflowing the panel to the left). If
the cursor is moved at this exact time, then it may not be properly
positioned for the following assertion, even though it is _somewhere_ on
the panel.

If the above is the case, then this is a known o!f issue, but not a
simple one to solve.

I haven't reproed this locally.
2024-07-19 17:49:16 +09:00
Dan Balasescu
d7ae9505b2
Fix TestCancelNavigationToEditor test failure
https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709

The editor could be pushed before the exit actually
occurs.
2024-07-19 15:04:21 +09:00
Bartłomiej Dach
79cf644b8d
Enable NRT while we're here 2024-07-19 07:34:00 +02:00
Bartłomiej Dach
73edb32440
Add failing test coverage 2024-07-19 07:30:57 +02:00
Dan Balasescu
3f4e56be3c
Fix TestPostAsOwner test failure
https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309

Comments are loaded asynchronously, both from the initial request and
the following message-post request. By sheer timing luck, these could be
out of order and the assertion on the posted message could fail.
2024-07-18 20:54:05 +09:00
Dan Balasescu
33a81d8181
Use constraint to improve assertion message 2024-07-18 18:34:08 +09:00
Dan Balasescu
f3cd3d7d3b
Fix TestAllSamplesStopDuringSeek test failure
https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263

This is a bit of a workaround, likely timing related. I don't foresee an
until step in this case to cause false-passes.
2024-07-18 16:26:42 +09:00
Dan Balasescu
1906c2f725
Fix TestTouchScreenDetectionAtSongSelect test failure
https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295

In this case, the settings overlay is taking a very long time to load
(on a background thread), and pops in when it finishes loading because
it's been requested to open.

The opens the settings overlay, closes it (by pressing escape, this does
not actually close it because it's not loaded yet), and then enters song
select by pressing 'P' 3 times. The settings overlay finishes loading at
just the right opportune moment to eat one of the 'P' key presses.
2024-07-18 16:26:16 +09:00
Salman Ahmed
7a39435017 Fix intermitent test failure in TestSceneArgonHealthDisplay 2024-07-18 01:20:50 +03:00
Bartłomiej Dach
76d016df34
Fix code inspection 2024-07-16 11:31:16 +02:00
Dan Balasescu
d4ea604ad0
Add test 2024-07-16 18:19:00 +09:00
OliBomby
e5bc359b88 fix test 2024-07-14 23:39:19 +02:00
OliBomby
29c2e821ea extend tests 2024-07-14 22:50:25 +02:00
Salman Ahmed
be1d3c0ea4 Add test coverage 2024-07-13 11:58:54 +03:00
Dean Herbert
eb3f480a2a
Merge pull request #28683 from frenzibyte/footer-v2-integration
Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`
2024-07-12 22:45:06 +09:00
Bartłomiej Dach
518dc17518
Merge pull request #28788 from bdach/timeline-redesign
Redesign editor timelines to address most frequent user complaints
2024-07-12 10:58:59 +02:00
Bartłomiej Dach
452fbed681
Merge pull request #28808 from frenzibyte/fix-all-notifications
Fix confirm exit dialog potentially showing incorrect number of ongoing operations
2024-07-12 10:56:29 +02:00
Dean Herbert
43addc8400
Fix test regression 2024-07-12 16:29:41 +09:00
Salman Ahmed
3ea0f58daa Update TestSceneFreeModSelectOverlay to work again 2024-07-11 15:31:23 +03:00
Salman Ahmed
7a5624fd0e Add screen footer to ScreenTestScene 2024-07-11 15:30:07 +03:00
Bartłomiej Dach
f1fa34e5d5
Merge pull request #28800 from peppy/file-mounting-v3
Add ability to edit beatmap content externally
2024-07-11 10:47:36 +02:00
Dean Herbert
c139478aa2
Merge pull request #28805 from frenzibyte/select-all-on-focus
Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)
2024-07-11 17:33:30 +09:00
Bartłomiej Dach
a859978efd
Add failing test steps for locally modified state not being set 2024-07-11 09:43:00 +02:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3 2024-07-11 15:54:54 +09:00
Salman Ahmed
8ca8648a09 Add failing test case 2024-07-10 16:14:12 +03:00
Salman Ahmed
7d667ac46b Fix confirm exit dialog overflowing from too many ongoing operations 2024-07-10 16:06:53 +03:00
Salman Ahmed
94f51c92e0 Select all text when focusing a number box 2024-07-10 15:16:10 +03:00
Dean Herbert
106d558147
Add test coverage of difficulty being retained 2024-07-10 18:34:47 +09:00
Dean Herbert
aa16c72e06
Add test coverage of external editing 2024-07-10 18:34:47 +09:00
Dean Herbert
72091b43df
Simplify editor navigation tests 2024-07-10 18:34:47 +09:00
Salman Ahmed
f0a7a3f856 Add failing test case for edge case 2024-07-10 11:51:49 +03:00
Salman Ahmed
002679ebb0 Ask for VisibilityContainer explicitly 2024-07-10 11:14:22 +03:00
Bartłomiej Dach
95783bd6c2
Merge pull request #28789 from peppy/fix-deletes-reappearing
Fix deleted beatmap sets potentially reappearing due to pending update requests
2024-07-10 09:14:10 +02:00
Dean Herbert
9a88281ab0
Merge branch 'master' into footer-v2-integration 2024-07-10 15:33:05 +09:00
Dean Herbert
4fe3f39d22
Merge pull request #28682 from frenzibyte/footer-v2-overlay-content
Add implementation for `ScreenFooter` to house footer content of sheared overlays
2024-07-10 15:08:00 +09:00
Dean Herbert
cd9973b6f9
Merge pull request #28740 from bdach/daily-challenge/better-results
Improve results displays in daily challenge screen
2024-07-10 14:17:21 +09:00
Dean Herbert
0e2e44a2f5
Add failing test case showing editor save then delete failure 2024-07-09 20:41:22 +09:00
Salman Ahmed
ed1f3a1eb4 Merge branch 'master' into footer-v2-integration 2024-07-09 13:48:40 +03:00
Salman Ahmed
b17af86491 Merge branch 'master' into footer-v2-overlay-content 2024-07-09 13:41:44 +03:00
Dean Herbert
c100d1ab65
Merge pull request #28769 from peppy/carousel-realm-simplification
Simplify realm model tracking in `BeatmapCarousel` (and fix hard delete handling)
2024-07-09 01:40:10 +09:00
Bartłomiej Dach
877b5768fc
Merge branch 'master' into sorted-breaks 2024-07-08 15:59:32 +02:00
Salman Ahmed
da4067d059 Add failing test case 2024-07-08 16:06:34 +03:00
Bartłomiej Dach
2cad8d3684
Merge branch 'master' into time-accurate 2024-07-08 14:19:57 +02:00
OliBomby
2822ba2377 Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active 2024-07-08 13:30:11 +02:00
Bartłomiej Dach
6433f29651
Add failing test case 2024-07-08 13:21:38 +02:00
Dean Herbert
c0a1696538
Merge pull request #28762 from frenzibyte/change-chevron-display
Change display of "expanded" chevrons in many UI components to use scale instead of rotation
2024-07-08 20:05:59 +09:00
Dean Herbert
e51d510ea3
Add failing test for beatmap set hard deletion 2024-07-08 20:05:17 +09:00
Salman Ahmed
2fcc61edfa
Merge branch 'master' into audio-ducking-fx 2024-07-08 12:50:46 +03:00
Bartłomiej Dach
14a93bfc1a
Merge pull request #28553 from frenzibyte/mod-select-customisation-panel
Detach mod customisation area from the footer and replace with an overlay panel display
2024-07-08 11:26:21 +02:00
Salman Ahmed
784a9ae743
Merge branch 'master' into audio-ducking-fx 2024-07-08 12:26:10 +03:00
Joseph Madamba
257de9d08b Fix arrow direction test 2024-07-08 01:00:36 -07:00
Dean Herbert
3650f3c479
Allow multiple ducks with same parameters 2024-07-08 13:52:40 +09:00
Dean Herbert
aa36a844be
Reduce precision requirement for tests 2024-07-08 13:49:25 +09:00
Dean Herbert
0067450b22
Change volume parameter to double 2024-07-08 13:47:57 +09:00
Salman Ahmed
2bfa03c6d8 Rename test scene file 2024-07-08 07:37:42 +03:00
OliBomby
9013c119ab update tests 2024-07-05 14:33:15 +02:00
Dean Herbert
5907e0d1eb
Make DuckDuration non-zero by default 2024-07-05 18:39:13 +09:00
Dean Herbert
7efb4ce30a
Fix multiple disposals resulting in assert being hit 2024-07-05 18:39:12 +09:00
Dean Herbert
65418aca1a
Add basic test coverage 2024-07-05 18:35:54 +09:00
Bartłomiej Dach
d6c1b5d399
Add failing test coverage 2024-07-05 08:54:47 +02:00
Bartłomiej Dach
6907d3d3b5
Merge branch 'master' into nodesample-inherit 2024-07-05 08:12:47 +02:00
Bartłomiej Dach
ab8623ec48
Merge pull request #28727 from OliBomby/inherit-addition
Allow inheriting addition bank from previous hitobject when using auto bank assignment
2024-07-05 08:12:30 +02:00
Dean Herbert
f0ad7a97cb
Merge branch 'master' into daily-challenge/better-results 2024-07-04 23:56:09 +09:00
Dean Herbert
aa72c09c3a
Merge pull request #28659 from bdach/daily-challenge/integration
Use room watching functionality to receive realtime daily challenge updates
2024-07-04 23:55:46 +09:00
OliBomby
00f7a34139 Add test coverage 2024-07-04 15:25:43 +02:00
Bartłomiej Dach
c524c23db6
Merge branch 'master' into inherit-addition 2024-07-04 15:24:59 +02:00
Bartłomiej Dach
ea9dd841c0
Merge pull request #28728 from OliBomby/inherit-volume
Always inherit the volume from the previous hit object on placement
2024-07-04 15:24:34 +02:00
Bartłomiej Dach
e005b46df9
Extend test coverage 2024-07-04 15:19:28 +02:00
Bartłomiej Dach
08a77bfe38
Extend test coverage 2024-07-04 15:10:49 +02:00
Bartłomiej Dach
ea4e6cf1d7
Add test coverage 2024-07-04 14:39:11 +02:00
Bartłomiej Dach
5fa586848d
Replace old bad daily challenge leaderboard with new implementation
- Actually shows scores rather than playlist aggregates (which are
  useful... in playlists, where there is more than one item)
- Actually allows scores to be shown by clicking on them
- Doesn't completely break down visually on smaller window sizes

The general appearance is not as polished as the old one in details but
I wanted something quick that we can get out by next weekend.

Also includes the naive method of refetching scores once a new top 50
score is detected. I can add a stagger if required.
2024-07-04 13:52:08 +02:00
Bartłomiej Dach
b29e535ca5
Add results screen for displaying arbitrary daily challenge scores
At this point its primary usage is the daily challenge event feed, but
the leaderboard will be using this too shortly.

Because the playlists results screen that exists in `master` is
hard-coupled to showing the *local user's* best result on a given
playlist by way of hard-coupling itself to the relevant API request,
allowing show of *arbitrary* score by ID requires a whole bunch of
subclassery as things stand. Oh well.

Class naming is... best effort, due to the above.
2024-07-04 13:45:24 +02:00
Salman Ahmed
7a0a5620e1 Add failing test case 2024-07-04 14:06:18 +03:00
OliBomby
d0715c5f12 scale along rotated axis 2024-07-03 16:23:19 +02:00
Bartłomiej Dach
e73faaefd2
Merge branch 'master' into editor-test-play 2024-07-03 13:54:47 +02:00
Bartłomiej Dach
6fda0db9ba
Fix test 2024-07-03 11:03:52 +02:00
Bartłomiej Dach
17ce9cd162
Merge branch 'master' into grids-2 2024-07-03 10:57:05 +02:00
Dean Herbert
824a00b018
Merge pull request #28707 from bdach/remove-breaks
Add option to remove breaks via timeline context menu
2024-07-03 16:29:25 +09:00
Salman Ahmed
f1012070c4
Merge branch 'master' into mod-select-customisation-panel 2024-07-03 07:36:52 +03:00
Salman Ahmed
abfdf90b54 Remove unused using directive 2024-07-03 07:11:35 +03:00
Bartłomiej Dach
6453522b34
Add failing test coverage for changing banks/samples not working on node samples 2024-07-02 16:21:56 +02:00
Bartłomiej Dach
3f08605277
Add test coverage 2024-07-02 15:02:09 +02:00
Bartłomiej Dach
3d61a217ec
Add test coverage 2024-07-02 14:34:36 +02:00
Salman Ahmed
1d94c96a8e Display customisation header in disabled state when no customisable mod selected 2024-07-02 14:40:16 +03:00
Salman Ahmed
dce1b4ec6c Merge branch 'master' into ruleset-specific-combo-counter 2024-07-01 08:31:40 +03:00
Salman Ahmed
0c34e7bebb Store layout version in SkinLayoutVersion instead and refactor migration code 2024-07-01 08:30:37 +03:00
Salman Ahmed
d1d1f93c43 Merge branch 'mod-select-customisation-panel' into footer-v2-overlay-content 2024-06-30 11:48:23 +03:00
Salman Ahmed
901663b3ff Fix test failure 2024-06-30 11:00:00 +03:00
Salman Ahmed
e57a0029f1 Remove local footer from ShearedOverlayContainer 2024-06-30 06:50:36 +03:00
Salman Ahmed
5dd822ea38 Migrate first-run setup overlay footer content 2024-06-30 06:50:36 +03:00
Salman Ahmed
48bf3f1385 Migrate mod select overlay footer content 2024-06-30 06:50:36 +03:00
Salman Ahmed
467d7c4f54 Refactor game-wide layout order of footer to fix depth issues with overlays and improve UX
With this new order, the logo can be easily moved to display in front of the footer in `SongSelectV2` without breaking experience when footer-based overlays are present. Such overlays (i.e. mod select overlay) will also be dimmed alongside the current screen when a game-wide overlay is open (e.g. settings).
2024-06-30 06:50:36 +03:00
Salman Ahmed
900d15e777 Add test coverage 2024-06-30 06:50:22 +03:00
Salman Ahmed
c6c75ae48d Merge branch 'master' into footer-v2-side-buttons 2024-06-29 08:19:49 +03:00
Bartłomiej Dach
df97215298
Use room watching functionality to receive realtime daily challenge updates 2024-06-28 13:35:16 +02:00
Salman Ahmed
f462aa59df Add test coverage for the issues that were pointed out recently 2024-06-28 11:23:52 +03:00
Bartłomiej Dach
ace6427d40
Expand test coverage
- Covers fail case that wasn't covered before
- Removes arbitrary wait step that was inevitably going to cause
  intermittent test failures
2024-06-28 09:30:28 +02:00
Bartłomiej Dach
b36e0f0875
Merge branch 'master' into fix/editor-test-exit 2024-06-28 09:17:40 +02:00
Salman Ahmed
86b8357b8b Improve UX & input handling when customisation panel is open 2024-06-28 08:53:31 +03:00
Bartłomiej Dach
e35744118c
Merge pull request #28638 from OliBomby/beat-divisor
Fix editor not loading arbitrary beat divisors
2024-06-27 13:31:44 +02:00
Bartłomiej Dach
772a68cb3e
Add test coverage for correct beat divisor save 2024-06-27 12:38:29 +02:00
Salman Ahmed
e4335a543e Add failing test case
Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.
2024-06-27 06:41:44 +03:00
Dean Herbert
ac235cb506
Remove unused local variable 2024-06-26 16:22:25 +09:00
Bartłomiej Dach
006184ed2f
Implement carousel container for daily challenge screen 2024-06-26 08:49:00 +02:00
Dean Herbert
0c8279c5df
Remove unused using statements 2024-06-26 14:50:53 +09:00
Salman Ahmed
fa46d8e6c9 Fix intermittent failure in online menu banner tests 2024-06-26 08:39:55 +03:00
Dean Herbert
aadb104851
Merge pull request #28589 from bdach/scale-handling-crash
Fix crashes when opening scale/rotation popovers during selection box operations
2024-06-26 00:11:03 +09:00
Dean Herbert
d722be16e3
Add missing base calls for safety 2024-06-25 23:41:43 +09:00
Salman Ahmed
dc1fb4fdca Add test coverage 2024-06-25 05:55:05 +03:00
Bartłomiej Dach
66b093b17e
Implement score breakdown display for daily challenge screen 2024-06-24 10:09:10 +02:00
Salman Ahmed
2efafcaf5b Remove stale comment 2024-06-23 08:46:55 +03:00
Salman Ahmed
1298b98534 Update test coverage 2024-06-23 08:22:54 +03:00
Salman Ahmed
04efa61156 Add different display for mod customisation 2024-06-23 08:22:13 +03:00
Dean Herbert
14104e57d4
Merge branch 'master' into timeline-drag-selection-crash 2024-06-20 15:16:10 +09:00
Dean Herbert
00443403b6
Merge branch 'master' into break-autogeneration 2024-06-19 21:49:17 +09:00
Bartłomiej Dach
8757e08c2c
Fix test failures due to automatic break generation kicking in 2024-06-19 11:32:08 +02:00
Bartłomiej Dach
659505f711
Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
Dean Herbert
316125d47a
Merge pull request #23443 from OliBomby/edit-nodesample
Make NodeSamples editable
2024-06-18 11:12:02 +09:00
Dean Herbert
a6f09bc626
Merge pull request #28468 from bdach/daily-challenge/event-feed
Implement event feed view for daily challenge screen
2024-06-17 20:16:48 +09:00
Dean Herbert
15fbad0097
Merge pull request #28480 from bdach/storyboard-pass-fail-show
Implement toggling visibility of pass and fail storyboard layers
2024-06-16 11:08:00 +09:00
Dean Herbert
6bd633f8ce
Apply NRT to test scene 2024-06-15 17:26:57 +08:00
Bartłomiej Dach
67ca7e4135
Implement toggling visibility of pass and fail storyboard layers
Closes https://github.com/ppy/osu/issues/6842.

This is a rather barebones implementation, just to get this in place
somehow at least. The logic is simple - 50% health or above shows pass
layer, anything below shows fail layer.

This does not match stable logic all across the board because I have
no idea how to package that. Stable defines "passing" in like fifty
ways:

- in mania it's >80% HP
  (bb57924c15/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
- in taiko it's >80% *accuracy*
  (bb57924c15/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
- there's also the part where "geki additions" will unconditionally set
  passing state
  (bb57924c15/osu!/GameModes/Play/Player.cs#L3561-L3564)
- and also the part where at the end of the map, the final passing state
  is determined by checking whether the user passed more sections than
  failed
  (bb57924c15/osu!/GameModes/Play/Player.cs#L3320)

The biggest issues of these are probably the first two, and they can
*probably* be fixed, but would require a new member on `Ruleset` and I'm
not sure how to make one look, so I'm not doing that at this time
pending collection of ideas on how to do that.
2024-06-14 13:59:02 +02:00
Shiumano
bfca64a98e Add failing test 2024-06-14 20:07:27 +09:00
Bartłomiej Dach
8b6385f7d0
Add failing test case demonstrating crash 2024-06-14 09:24:53 +02:00
Bartłomiej Dach
8c4aa84037
Implement event feed view for daily challenge screen 2024-06-13 09:05:45 +02:00
Bartłomiej Dach
2be6b29f21
Implement time remaining display for daily challenge screen 2024-06-12 11:43:24 +02:00
Bartłomiej Dach
2321e408cb
Add test scene for daily challenge screen 2024-06-10 13:12:20 +02:00
Bartłomiej Dach
dd6e9308b3
Extract user mod select button for reuse 2024-06-10 12:45:27 +02:00
Salman Ahmed
6201220994
Merge branch 'master' into footer-v2-become-global 2024-06-08 14:13:05 +03:00
Dean Herbert
daf85c320a
Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean
New leaderboard score card design implementation
2024-06-08 20:06:17 +09:00
Dean Herbert
7fc6ad5340
Merge pull request #28184 from frenzibyte/footer-v2-transitions
Add basic animation to new footer and buttons
2024-06-08 19:43:23 +09:00
Salman Ahmed
5f8f6caedd Use OsuGame.SHEAR 2024-06-07 22:45:22 +03:00
Salman Ahmed
6f729be573 Merge branch 'master' into LeaderBoardScore_clean 2024-06-07 22:42:49 +03:00
Bartłomiej Dach
199d31c0f4
Fix test not compiling
A little ugly but maybe it'll do...
2024-06-07 09:54:00 +02:00
Bartłomiej Dach
4cd1ccc4d4
Merge branch 'master' into add-rank-display 2024-06-07 09:33:03 +02:00
Bartłomiej Dach
dd9c77d248
Fix obsoletion warning 2024-06-06 13:50:31 +02:00
Bartłomiej Dach
86b13074a0
Merge branch 'master' into edit-nodesample 2024-06-06 13:42:25 +02:00
OliBomby
d8994786f6 Merge remote-tracking branch 'upstream/master' into grids-2 2024-06-05 17:18:48 +02:00
Bartłomiej Dach
5fcea01c13
Merge branch 'master' into ruleset-specific-combo-counter 2024-06-04 15:44:11 +02:00
Bartłomiej Dach
4fcb902341
Merge branch 'master' into grids-1 2024-06-03 12:33:51 +02:00
Dean Herbert
53b7c29488
Add test coverage of menu banner link opening 2024-05-31 03:15:26 +09:00
Dean Herbert
16e2fa2c6a
Merge branch 'master' into fix/editor-test-exit 2024-05-29 21:08:36 +09:00
Bartłomiej Dach
7b7e439d03
Merge branch 'master' into scale-tool 2024-05-29 10:15:48 +02:00
Bartłomiej Dach
4c881b5633
Use better name if we're renaming 2024-05-29 09:40:29 +02:00
OliBomby
a89ba33b47 rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled 2024-05-28 16:14:16 +02:00
Dean Herbert
8c4931eeec
Merge branch 'master' into footer-v2-transitions 2024-05-28 18:49:39 +09:00
Dean Herbert
4408039b3e
Merge branch 'master' into footer-v2-back-button 2024-05-28 15:50:34 +09:00
Dean Herbert
75d961e6f2
Pass the same thing in twice for better maybe 2024-05-27 20:30:01 +09:00
Bartłomiej Dach
1f41261fc7
Fix test failure 2024-05-27 12:01:02 +02:00
Dean Herbert
740a3377fa
Merge branch 'master' into LeaderBoardScore_clean 2024-05-27 17:18:41 +09:00
Joseph Madamba
8e14c24ee3 Follow slanted flow logic precedent in test
See `ModSelectOverlay` components.
2024-05-26 00:24:03 -07:00
Salman Ahmed
91fb5ed749 Move toggle step to SetUpSteps 2024-05-25 17:28:03 +03:00
Salman Ahmed
2c18c10ac8 Move to SelectV2 namespace 2024-05-25 17:20:10 +03:00
Salman Ahmed
d395c85418 Adjust right content width based on scoring mode 2024-05-25 17:16:41 +03:00
Salman Ahmed
5955378004 Replace "X mods" text with a pill indicator 2024-05-25 16:11:24 +03:00
Salman Ahmed
35af518fdb Remove expanded/contracted states and limit to 5 mods
Also adjusts right content width to contain those 5 mods. Not sure how to handle the extra space in the score though...to be dealt with later.
2024-05-25 12:52:48 +03:00
Salman Ahmed
1f01293783 Make scores slanted in test scene 2024-05-25 12:36:09 +03:00
Dean Herbert
2134ff7a1b
Merge pull request #28071 from Fabiano1337/lazer-speedkeys
Make ctrl-up/down change speed modifier of mods
2024-05-24 23:20:04 +09:00
Bartłomiej Dach
9f19ab092d
Merge branch 'master' into grids-1 2024-05-24 14:39:55 +02:00
Bartłomiej Dach
c800bb5339
Merge branch 'master' into lazer-speedkeys 2024-05-24 13:19:26 +02:00
Bartłomiej Dach
63406b6feb
Rewrite implementation 2024-05-24 13:03:42 +02:00
Bartłomiej Dach
9045ec24ab
Rewrite test 2024-05-24 12:04:09 +02:00
Bartłomiej Dach
a80dbba9d0
Update to not use obsoleted method 2024-05-24 10:35:31 +02:00
Bartłomiej Dach
4089071299
Merge branch 'master' into fix-editor-didnt-save 2024-05-24 10:16:46 +02:00
Bartłomiej Dach
8a2dd4d816
Merge branch 'master' into scaling 2024-05-23 15:10:40 +02:00