osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-22 19:00:07 +08:00

Fix replay files potentially getting misclassified as zip archives

Resolves https://github.com/ppy/osu/discussions/36107.

The replay linked in the aforementioned discussion happens to contain
the magic sequence for ZIP headers in the binary stream (50 4b 05 06)
which led to it getting classified as a ZIP with no entries and
completely bogus everything in the header at

	https://github.com/ppy/osu/blob/c8b18acd4dd1d98170a069240b6666cea3d5da07/osu.Game/Database/ImportTask.cs#L51-L56

and then finally dying of

	2025-12-23 07:26:45 [error]: [?????] Model creation of replay-osu_2040232_4828629841.osr failed.
	2025-12-23 07:26:45 [error]: System.InvalidOperationException: Sequence contains no matching element
	2025-12-23 07:26:45 [error]: at System.Linq.ThrowHelper.ThrowNoMatchException()
	2025-12-23 07:26:45 [error]: at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
	2025-12-23 07:26:45 [error]: at osu.Game.Scoring.ScoreImporter.CreateModel(ArchiveReader archive, ImportParameters parameters)
	2025-12-23 07:26:45 [error]: at osu.Game.Database.RealmArchiveModelImporter`1.importFromArchive(ArchiveReader archive, ImportParameters parameters, CancellationToken cancellationToken)

at

	https://github.com/ppy/osu/blob/554961036e23615b35eb6b66b341b10924664c4d/osu.Game/Scoring/ScoreImporter.cs#L46

Bartłomiej Dach · 2025-12-23 08:23:23 +01:00

95233fc638

Remove the nullable disable annotate.

andy840119 · 2022-06-30 23:05:09 +08:00

e50e0f7339
Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850
Limit new IsZipArchive method to MemoryStream for now
```
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
```
Dean Herbert · 2021-11-12 19:16:22 +09:00

f02b57c371
Add pathway to correctly handle stream-based imports which are not zip archives

Dean Herbert · 2021-11-12 16:42:07 +09:00

adf81d7fcd
Shortcut checking for whether directories are files

smoogipoo · 2019-06-26 17:10:22 +09:00

15b140b2ee
Update licence header (and remove year)

Dean Herbert · 2019-01-24 17:43:03 +09:00

8617aaa2a7
Normalize all the line endings

Dean Herbert · 2018-04-13 18:26:38 +09:00

32a74f95a5
Fix license header

smoogipoo · 2018-02-09 12:48:22 +09:00

0dab70cc05
Fix incorrect license

smoogipoo · 2017-11-21 16:42:54 +09:00

44168b1654
Make osu.Game + rulesets compile with netstandard

smoogipoo · 2017-11-19 13:46:51 +09:00

d2ab0621f3

11 Commits