3 Commits

• Disable presenting scores in online song selects (#36826)

  RFC. Closes https://github.com/ppy/osu/issues/36815 I guess.
  
  Song select V1 completely disabled the ability to view a score outside
  of solo play in ways that are very easy to let fly under the radar:
  
  
  https://github.com/ppy/osu/blob/5fc836d1f09cebf983313c9b91a5c252890c607a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs#L26
  https://github.com/ppy/osu/blob/46db3ad96d0e1cd6ba4176b9b474cb79a338965d/osu.Game/Screens/Select/PlaySongSelect.cs#L47-L53
  
  therefore the issue this is trying to close would never even manifest
  there.
  
  The direct cause of the issue is that the results screen is pushed to
  the relevant online screen's *substack* of screens rather than the
  game-global parent stack. That means that when the back button is
  pressed, the following logic fires:
  
  
  https://github.com/ppy/osu/blob/6fa4a7152f144ed2524f20ecf7cfd26492bbe61d/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs#L174-L189
  
  This logic fires *on the parent screen* even though *the child screen*
  is the one the user is attempting to back out of. And none of the
  exemptions for the screen substack inside of the above method fire
  because the subscreen is not an `IOnlinePlaySubScreen` (it's
  `SoloResultsScreen` in this case).
  
  Now the direct cause here is probably fixable, although possibly not
  without some significant pulling of footer-shaped teeth. *However*, I
  kind of question as to why viewing scores should be permitted on online
  song selects in the first place - it kind of distracts from the primary
  purpose of the screens which is to *just pick a map already*.

  Bartłomiej Dach · 2026-03-06 00:19:10 +09:00
  6b10ef8709
• Merge branch 'master' into song-select-v1-salute
  Bartłomiej Dach · 2026-03-04 08:39:58 +01:00
  f74a21c1e1
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a