224 Commits

• Remove V2 suffix from migrated classes
  Dean Herbert · 2026-02-24 20:23:29 +09:00
  fabce18552
• Migrate multiplayer freestyle select screen to use SongSelectV2
  Dean Herbert · 2026-02-18 20:50:17 +09:00
  48544733c3
• Reduce code duplication

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-12-24 19:30:04 +09:00
  81f03957d8
• Ensure all invocations of spectator server hub methods have their errors observed (#35488)

  Fell out when attempting
  https://github.com/ppy/osu-server-spectator/pull/346.
  
  Functionally, if a true non-`HubException` is produced via an invocation
  of a spectator server hub method, this doesn't really do much - the
  error will still log as 'unobserved' due to the default handler, it will
  still show up on sentry, etc. The only difference is that it'll get
  handled via the continuation installed in `FireAndForget()` rather than
  the `TaskScheduler.UnobservedTaskException` event.
  
  The only real case where this is relevant is when the server throws
  `HubException`s, which will now instead bubble up to a more
  human-readable form. Which is relevant to the aforementioned PR because
  that one makes any hub method potentially throw a `HubException` if the
  client version is too old.
  
  Obviously this does nothing for the existing old clients.

  Bartłomiej Dach · 2025-10-29 12:18:23 +09:00
  050c10cec2
• Adjust sizing of room panels and other elements to make things fit better on mobile layouts
  Dean Herbert · 2025-09-01 19:52:29 +09:00
  659480fa3f
• Refactor order of operations
  Dan Balasescu · 2025-07-14 21:16:15 +09:00
  bd922e2888
• Exit user style selection when beatmap set changes
  Dan Balasescu · 2025-07-14 18:02:18 +09:00
  3401706e7e
• Hide user style edit button when not downloaded
  Dan Balasescu · 2025-07-14 18:02:18 +09:00
  9d2ba06287
• Add failing tests
  Dan Balasescu · 2025-07-14 17:57:41 +09:00
  e36c590315
• Keep multiplayer settings open during room updates
  Dan Balasescu · 2025-04-23 16:05:35 +09:00
  5ea408f3a1
• Fix multiplayer background changing in results screen
  Dan Balasescu · 2025-04-17 03:30:55 +09:00
  6052fbb4f9
• Merge branch 'master' into mp-history-results
  Dan Balasescu · 2025-04-08 19:58:44 +09:00
  0b51cec77c
• Fix crash when trying to start countdown
  Dan Balasescu · 2025-04-08 18:35:51 +09:00
  5769292daf
• Validate state with lesser magic
  Dan Balasescu · 2025-04-07 20:56:54 +09:00
  71af50f675
• Add back removed hash check
  Dan Balasescu · 2025-04-07 20:10:27 +09:00
  aa8ebf989b
• Allow viewing results of historical multiplayer items
  Dan Balasescu · 2025-04-04 21:04:46 +09:00
  40e792b558
• Remove unnecessary using
  Dan Balasescu · 2025-04-04 10:50:34 +09:00
  bb1cfdca84
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Isolate operation of multiplayer mod overlay
  Dan Balasescu · 2025-04-01 16:25:10 +09:00
  8de9620156
• Refactor MultiplayerPlaylist to not have a selected item bindable
  Dan Balasescu · 2025-03-28 22:01:07 +09:00
  b93e21c666
• Add multiplayer user mod display
  Dan Balasescu · 2025-03-25 16:17:54 +09:00
  6cd4a36c61
• Remove no-longer used bindable from footer
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  606bf1eb9f
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-27 14:14:19 +09:00
  a33aff9bbd
• Adjust some paddings and text

  Mostly trying to give more space to the queue as we add more vertical
  elements to the middle area of multiplayer / playerlists. This whole UI
  will likely change – this is just a stop-gap fix.

  Dean Herbert · 2025-02-12 17:43:49 +09:00
  9aef95c381
• Fix layout of user setting areas when aspect ratio is vertically tall
  Dean Herbert · 2025-02-12 17:31:55 +09:00
  b92e9f515b
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-11 21:19:32 +09:00
  38cd4fa56a
• Initial support for freemod+freestyle
  Dan Balasescu · 2025-02-06 13:29:16 +09:00
  84206e9ad8
• Rename freestyle select screen classes for better discoverability
  Dean Herbert · 2025-02-03 19:21:21 +09:00
  8bb7bea04e
• Combine more methods to simplify flow futher
  Dean Herbert · 2025-01-29 19:56:37 +09:00
  e8d0d2a1d9
• Remove new bindables from RoomSubScreen
  Dean Herbert · 2025-01-29 19:06:14 +09:00
  c70ff11085
• Join/Leave rooms via multiplayer server

  Relevant functionality has been removed from `RoomManager` in the
  process.

  Dan Balasescu · 2025-01-22 21:44:45 +09:00
  02369baec4
• Create multiplayer rooms via multiplayer server
  Dan Balasescu · 2025-01-17 21:44:40 +09:00
  ad28de8ae3
• Fix possible null reference
  Dan Balasescu · 2025-01-08 18:57:25 +09:00
  be33addae1
• Change to using a 'FreeStyle' boolean
  Dan Balasescu · 2025-01-08 18:47:01 +09:00
  9c05837b3a
• Rewrite everything to better support spectator server messaging
  Dan Balasescu · 2024-12-25 22:24:21 +09:00
  0093af8f55
• Initial support for free style selection
  Dan Balasescu · 2024-12-23 20:12:25 +09:00
  638d959c5c
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make Room.QueueMode non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  198681e644
• Make Room.Name non-bindable
  Dan Balasescu · 2024-11-15 14:29:15 +09:00
  6160df1586
• Make RoomID non-bindable

  Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.

  Dan Balasescu · 2024-11-13 16:28:54 +09:00
  99762da7b8
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Revert incorrect removal of exitConfirmed flag

  Removing it meant that it was _literally impossible_ to exit
  multiplayer.

  Bartłomiej Dach · 2024-01-22 15:35:03 +01:00
  9aa7c7f591
• Remove a couple more overrides
  Dean Herbert · 2024-01-22 17:00:35 +09:00
  3dd18c777a
• Fix multiplayer potentially selecting mods of wrong ruleset when starting match
  Salman Ahmed · 2024-01-13 11:17:08 +03:00
  c514550dfa
• update the current activity when the multiplayer room updates
  Lena · 2024-01-02 18:38:25 +01:00
  17656e9b9c
• Fix onLoadRequested getting early-exited too early in spectator scenarios

  In some scenarios, multiplayer spectator would not tick over to the next
  beatmap.
  
  Here's an example:
  
  - Room has two items queued
  - Local user starts download of both
  - First beatmap starts and download is complete
  - First beatmap ends (spectating is active)
  - Second beatmap starts but download is not complete
  
  In this scenario, the local client will get stuck at the spectator
  screen due to the `onLoadRequested`-invoked screen change being early
  exited.
  
  It would require manual recovery (clicking back button) to return to a
  sane state.

  Dean Herbert · 2023-08-01 19:22:41 +09:00
  fe47dc291b
• Fix multiplayer match screen being exited from when not current

  This was supposed to be fixed by #24255, but has popped up as a
  regression on Sentry since:
  
  	https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email
  
  On a fifteen-minute check I cannot figure out how to reproduce, so
  rather than spending further brain cycles on this, just apply the same
  explicit guard that like fifteen other places do.

  Bartłomiej Dach · 2023-07-30 15:50:10 +02:00
  d3435483eb
• Fix deadlock when logging out while at the create match screen

  Closes https://github.com/ppy/osu/issues/24275.

  Dean Herbert · 2023-07-19 19:37:38 +09:00
  18aace177a
• Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure

  If `IAPIProvider.State` changes from `Online` at any point when being on
  an `OnlinePlayScreen`, it will be forcefully exited from. However,
  `MultiplayerMatchSubScreen` had local logic that suppressed the exit in
  order to show a confirmation dialog.
  
  The problem is, that in the suppression logic,
  `MultiplayerMatchSubScreen` was checking
  `MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
  checking `IAPIAccess.State`, which is maintained separately. Due to
  differing timeouts and failure thresholds, it is not impossible to have
  `MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
  APIState.Online`.
  
  In such a case, the match subscreen would wrongly consider itself to be
  still online and due to that, push useless confirmation dialogs, while
  being in the process of being forcefully exited. This then caused the
  dialog to cause a crash, as it was calling `.Exit()` on the screen which
  would already have been exited by that point, by the force-exit flow.

  Bartłomiej Dach · 2023-07-16 19:56:22 +02:00
  7fbd47e9ee