828 Commits

• Use web localisation on LeaderboardScopeSelector to match osu-web (#36814)

  - regressed in
  https://github.com/ppy/osu/commit/1f052bb195bfc5a2681b1b324bf34764641a1c40
  - also see https://github.com/ppy/osu/pull/34074#discussion_r2211853662
  
  did it by analogy with
  https://github.com/ppy/osu/blob/a0ecbd7c8704d6beee3e5c54c2ccb5f735872fb0/osu.Game/Overlays/BeatmapSet/Scores/NoScoresPlaceholder.cs#L27-L49
  
  | master | pr | `osu-web` |
  |-|-|-|
  | <img width="1625" height="188" alt="osu_2026-03-04_18-26-44"
  src="https://github.com/user-attachments/assets/9bd2690a-2ddf-4f03-9ca6-22003efbd895"
  /> |
  ![osu_2026-03-04_18-36-12](https://github.com/user-attachments/assets/1498c4a9-7188-4e97-a6bd-3553b9befa5e)
  | <img width="990" height="139" alt="Снимок экрана 2026-03-04 182558"
  src="https://github.com/user-attachments/assets/1bf14bee-3097-478d-936b-6ecb7d912be2"
  /> |
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Denis Titovets · 2026-03-05 13:40:31 +09:00
  28a18f768c
• Merge branch 'master' into tags-broken
  Dean Herbert · 2026-03-04 19:50:33 +09:00
  459d5e8a45
• Only show user tags above threshold by default
  Bartłomiej Dach · 2026-03-04 10:34:35 +01:00
  9b55e1dfdb
• Merge branch 'master' into song-select-v1-salute
  Bartłomiej Dach · 2026-03-04 08:39:58 +01:00
  f74a21c1e1
• Add bool flag for checking tag vote threshold & utilise as required

  Closes https://github.com/ppy/osu/issues/36453.
  
  My omission was in assuming that web was going to start filtering out
  the tags below the threshold from API responses, which is not the case.
  
  Whether or not the consumers want or not to display tags below threshold
  is subjective. I figured that the matchmaking card tooltip might want to
  display below threshold but I dunno.

  Bartłomiej Dach · 2026-03-03 13:03:33 +01:00
  d9e182230d
• Fix beatmap set overlay not showing user tags at all

  Regressed in 60d9c358b8.
  
  In general an `APIBeatmap`'s `BeatmapSet` need not be present. In the
  usage site of `osu.Game.Overlays.BeatmapSet.Info`, `Beatmap` and
  `BeatmapSet` were actually two separate bindables. Moving the logic to a
  helper, and therefore implicitly moving `BeatmapSet` from tracking said
  separate bindable to instead refer to `Beatmap.BeatmapSet` broke this.

  Bartłomiej Dach · 2026-03-03 12:44:29 +01:00
  e64e0f0ca9
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Move components only used by beatmap set overlay local to namespace
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  ce542b03db
• Add tooltips to beatmap info overlay statistics
  Joseph Madamba · 2026-03-02 22:53:09 -08:00
  564b6ebd0c
• Add nominations statistic to beatmap info overlay

  See https://github.com/ppy/osu-web/blob/2198adfa68bf24709c3b0cc2e6d838e86be5b1d1/resources/js/beatmapsets-show/header.tsx#L116-L123.

  Joseph Madamba · 2026-03-02 22:47:10 -08:00
  7dfbab212e
• Rename Ruleset.GetHitResults{ -> ForDisplay}()
  Bartłomiej Dach · 2026-02-09 12:00:15 +01:00
  dbce8886f8
• Fix tests
  Dan Balasescu · 2025-12-29 19:13:39 +09:00
  8ff2329e22
• Show vote count in tag tooltip
  Dan Balasescu · 2025-12-29 17:47:35 +09:00
  2e324fe856
• Move top user tags enumeration to helper
  Dan Balasescu · 2025-12-29 15:43:43 +09:00
  60d9c358b8
• Refetch list of user favourites on every change to favourites

  Is this lazy? Sure it is. Friends and blocks do the same thing, though,
  and I'm not overthinking this any more than I already have.
  
  Being smarter here would likely mean being more invasive with respect to
  listening in on all outgoing API requests and silently updating
  favourites on that basis. Which is "smart" but also complicated.

  Bartłomiej Dach · 2025-10-24 08:41:52 +02:00
  6b56a0611b
• Make DrawableDate formatting localizable
  CloneWith · 2025-09-04 14:44:40 +08:00
  1c608e779d
• Merge branch 'master' into beatmapset-overlay-styling
  Salman Alshamrani · 2025-06-30 11:12:29 +03:00
  15e1b1c9f5
• Use MaximumSize to limit picker background width

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Alshamrani · 2025-06-30 11:10:51 +03:00
  d4a863d00a
• Flip storyboard/video icon order
  Salman Alshamrani · 2025-06-23 05:26:12 +03:00
  5436313c86
• Switch to IconPills, add storyboard icon
  StanR · 2025-06-22 13:45:07 +05:00
  25eb9914a4
• Bring BeatmapPicker styling closer to web
  StanR · 2025-06-22 02:06:37 +05:00
  3e3d984584
• Add beatmapset This beatmap contains video badge
  StanR · 2025-06-22 01:24:58 +05:00
  9b7c722d97
• Add TODO marking incompatible logic

  Chances are this will not be materially noticed anyway because I'm not
  even sure that unranked mod scores *can* show up on leaderboards.

  Bartłomiej Dach · 2025-05-26 13:22:18 +02:00
  bedac98e06
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Use localised strings for user/mapper tags on beatmap set overlay
  Bartłomiej Dach · 2025-05-08 08:19:55 +02:00
  eca9389f40
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay
  Joseph Madamba · 2025-04-09 11:41:20 -07:00
  bfc6d61e5d
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Fix overlapping placeholders in beatmap info leaderboard

  Closes https://github.com/ppy/osu/issues/32508.

  Dean Herbert · 2025-03-25 14:27:24 +09:00
  9630002a68
• Use link flow at a higher level to fix broken layout
  Bartłomiej Dach · 2025-03-17 13:04:57 +01:00
  87932f707d
• Make logic clearer & fix issues
  Bartłomiej Dach · 2025-03-17 12:36:05 +01:00
  e430619e0e
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Add helper methods to check whether beatmap leaderboard scope requires supporter
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  9af3c8351d
• Standardise sizing of placeholder messages on beatmap scores overlay
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  3e71d04bd0
• Adjust text flow usages to framework changes
  Bartłomiej Dach · 2025-03-11 10:43:35 +01:00
  e2e2383c50
• Disable button instead of hiding (and add tooltip)
  Dean Herbert · 2025-02-27 15:15:58 +09:00
  0b453772da
• maybe not a function
  cdwcgt · 2025-02-20 22:04:18 +08:00
  4fa0288a20
• update guest difficulty display to consistent with the web page
  cdwcgt · 2025-02-20 21:49:30 +08:00
  9d7b01bcd4
• Add drawable implementations of team logo
  Dean Herbert · 2025-02-14 17:39:21 +09:00
  303961d101
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Fix top score statistics section total score display being terminally broken

  Closes https://github.com/ppy/osu/issues/31038.
  
  If you don't realise why this does anything, realise this: the drawable
  creation callback runs for every created sprite text in the text flow.
  ANd the created sprite texts are split by whitespace. And Russian /
  Ukrainian / Polish etc. use spaces as thousands separators.
  So on those languages the first encountered part of the score would
  duplicate itself to the remaining parts.
  
  I'm actively convinced it was _more difficult_ to produce what was in
  place in `master` than to do it properly. Why did `TextColumn` even have
  `LocalisableString Text` and `Bindable<string> Current` next to each
  other?????

  Bartłomiej Dach · 2024-12-09 23:51:57 +09:00
  1febed66cf
• Also add source prefix
  Dan Balasescu · 2024-10-23 16:21:28 +09:00
  2bea1fe4a6
• Doubly quote strings

  Note the external-action case (currently used for tags) doesn't match
  osu!web but it doesn't matter because tags are single words
  anyway.

  Dan Balasescu · 2024-10-23 16:15:49 +09:00
  af7d35bfbf
• Quote source text when searching for it via click

  Addresses https://github.com/ppy/osu/discussions/30181.

  Dean Herbert · 2024-10-23 15:41:42 +09:00
  21351b1be4
• Remove unused using directive
  Bartłomiej Dach · 2024-10-21 13:52:17 +02:00
  0a15eec7de
• Change property type

  Nobody is supposed to be using `ColourInfo` directly, really.

  Bartłomiej Dach · 2024-10-21 12:47:41 +02:00
  a90ad63493
• Add blank line to TopScoreStatisticsSection.cs:238
  Wezwery · 2024-10-19 13:41:36 +03:00
  47936c7b02
• Add highlight to combo and accuracy when max.
  Wezwery · 2024-10-19 03:08:08 +03:00
  df90b726b9