521 Commits

• Unimplement legacy compatibility method (#36812)

  The spectator server invokes both legacy and non-legacy methods to keep
  compatibility with older clients:
  
  
  https://github.com/ppy/osu-server-spectator/blob/fe0dad324587c8a12a2f203fd8289ce64182c2d9/osu.Server.Spectator/Hubs/Multiplayer/Matchmaking/Queue/MatchmakingQueueBackgroundService.cs#L292-L299
  
  I thought that it'd be a good idea to implement the legacy method here,
  but it turns out to not be such a good idea because it means ranked-play
  clients will assume they're receiving a quick play invitation.

  Dan Balasescu · 2026-03-05 00:31:43 +09:00
  ae032622ac
• Add pool type to matchmaking room invited event (#36765)

  Rebase of https://github.com/smoogipoo/osu/pull/193
  
  Going forward, the client will have to know the type of pool being
  invited to so that it can enter the appropriate screen when clicking the
  notification.
  
  Unfortunately, SignalR does not support overloading methods, or even
  adding parameters to them, so this PR deprecates the
  `MatchmakingRoomInvited` event and adds its replacement
  `MatchmakingRoomInvitedWithParams` with a complex `invitation` parameter
  that we _can_ extend in the future if required (such as potentially
  adding the name of the pool).
  
  This also prepares the notification by extracting some code to a
  `Complete` method receiving said `invitation` parameter. This part of
  code will be further modified to enter the correct screen:
  
  
  https://github.com/smoogipoo/osu/blob/0a4018045b9d908f66c63dee65d0059d05b26e43/osu.Game/Screens/OnlinePlay/Matchmaking/Queue/QueueController.cs#L200
  
  In particular, I have tested that new clients continue to work with the
  old server (dev.ppy.sh) in quick play
  
  |         | Old Server           | New Server  |
  | ------------- |:-------------:| :-----:|
  | Old Client      | 🟢  | 🟢 |
  | New Client      | 🟢  | 🟢 |

  Dan Balasescu · 2026-02-28 00:42:44 +09:00
  c72b6412ea
• Add user role to MultiplayerRoomUser (#36652)

  - Related to https://github.com/ppy/osu-server-spectator/issues/406
  
  Adding this field to this model has several vague reasons that I can't
  fully formulate yet, but I can't really see myself going forward
  *without* this.
  
  - People were very excited about having referees displayed on the room
  participants' list, and so adding the referees as real
  `MultiplayerRoomUser`s helps this. Having the role could even be used
  client-side to show a special icon or other status on the participants
  list. (Which isn't done yet, could be as an aesthetic follow-up after
  the basics are in place.)
  - Server-side, having this field is convenient for things like
  permission checks or just plain logic, as with two hubs you just need to
  do different *stuff* on a `MultiplayerRoomUser`.

  Bartłomiej Dach · 2026-02-12 00:57:03 +09:00
  5afd6c6835
• Add info about damage dealt to ranked play user state (#36627)

  Adds a `DamageInfo` property to `RankedPlayDamageInfo` to be used by the
  result screen.
  
  The issue this is trying to solve is that once the result screen
  initializes, the HP value of each player has already been updated in the
  room state so the previous values are no longer accessible. Doing this
  without the state exposing it would require some kinda setup to keep the
  previous MatchState's HP values around on the client which would
  introduce a lot of unnecessary weirdness.

  maarvin · 2026-02-09 12:39:27 +09:00
  efd4d12c21
• Fix unobserved timeouts still showing to user

  As reported in https://osu.ppy.sh/community/forums/topics/2174881?n=1.

  Dean Herbert · 2026-01-30 15:37:01 +09:00
  cf09ed3e0d
• Apply default value changes from review
  Dan Balasescu · 2026-01-28 17:45:15 +09:00
  6d54d20943
• Add ranked play models
  Dan Balasescu · 2026-01-28 13:42:59 +09:00
  70321e2f89
• Add type parameter to pool retrieval method
  Dan Balasescu · 2026-01-28 13:42:58 +09:00
  c1fc1edd9c
• Add localisation support for some more notifications (#36353)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Denis Titovets · 2026-01-16 22:58:20 +09:00
  06b89919be
• Stop websocket handshake failures from being shown to users
  Dean Herbert · 2026-01-15 18:09:04 +09:00
  e8154080b3
• Remove mention of exception that doesn't exist
  Dan Balasescu · 2025-12-12 15:46:00 +09:00
  79151ae5b4
• Always perform leave room sequence
  Dan Balasescu · 2025-12-11 20:07:36 +09:00
  bbdd70c843
• Merge pull request #35909 from smoogipoo/fix-vote-to-skip

  Adjust vote-to-skip messaging flow to be explicit about states

  Bartłomiej Dach · 2025-12-09 08:59:53 +01:00
  0b06acb29d
• Merge pull request #35918 from smoogipoo/qp-fix-unsafe-schedules

  Fix potentially unsafe quick play event handling

  Bartłomiej Dach · 2025-12-09 08:32:56 +01:00
  b129837e57
• Consider abandon time for user placements
  Dan Balasescu · 2025-12-07 23:26:40 +09:00
  d6cd748d2a
• Fix potentially unsafe quick play event handling
  Dan Balasescu · 2025-12-07 02:11:26 +09:00
  c23d6b7fd1
• Adjust vote-to-skip to be explicit about states
  Dan Balasescu · 2025-12-06 13:23:16 +09:00
  2be50d917a
• Rename to GameplayItem + adjust documentation
  Dan Balasescu · 2025-11-21 15:34:58 +09:00
  871c0ebe3d
• Replace MatchmakingRoomState.CandidateType with MatchmakingRoomState.FinalItem
  marvin · 2025-11-21 15:34:41 +09:00
  6362cdb675
• Turn MatchmakingCandidateType into top level declaration
  marvin · 2025-11-17 07:46:05 +01:00
  fe56ba2921
• Combine random card reveal & panel roll animation into the same event
  marvin · 2025-11-17 07:37:56 +01:00
  1e05613859
• Merge branch 'master' into mp-vote-to-skip
  Dan Balasescu · 2025-11-05 16:53:44 +09:00
  e8db35a5c9
• Apply one more missed rename
  Bartłomiej Dach · 2025-11-04 12:56:03 +01:00
  f8331e0b28
• Add download progress bars to quick play users
  Dan Balasescu · 2025-11-04 11:37:12 +09:00
  23cb7f3b23
• Suffix introp methods with "Intro"
  Dan Balasescu · 2025-11-04 11:05:41 +09:00
  f4049c7ec1
• Move property reset into GameplayStarted()
  Dan Balasescu · 2025-10-31 21:40:40 +09:00
  6f94b1ab6d
• Add support for vote-to-skip in multiplayer
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  373162df02
• Add interop models
  Dan Balasescu · 2025-10-30 19:04:49 +09:00
  a435dfe93e
• Merge branch 'master' into qp-add-helpers
  Bartłomiej Dach · 2025-10-29 08:13:51 +01:00
  7203f419a2
• Replace indexers with GetOrAdd()

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2025-10-29 16:07:46 +09:00
  722cfb72d8
• Merge pull request #35482 from smoogipoo/qp-fix-initial-placement-display

  Ensure to never display "0th" placement

  Bartłomiej Dach · 2025-10-29 07:47:35 +01:00
  5da132cc2f
• Add quick play helpers to add users/rounds
  Dan Balasescu · 2025-10-29 14:49:22 +09:00
  bd912710f1
• Ensure all invocations of spectator server hub methods have their errors observed (#35488)

  Fell out when attempting
  https://github.com/ppy/osu-server-spectator/pull/346.
  
  Functionally, if a true non-`HubException` is produced via an invocation
  of a spectator server hub method, this doesn't really do much - the
  error will still log as 'unobserved' due to the default handler, it will
  still show up on sentry, etc. The only difference is that it'll get
  handled via the continuation installed in `FireAndForget()` rather than
  the `TaskScheduler.UnobservedTaskException` event.
  
  The only real case where this is relevant is when the server throws
  `HubException`s, which will now instead bubble up to a more
  human-readable form. Which is relevant to the aforementioned PR because
  that one makes any hub method potentially throw a `HubException` if the
  client version is too old.
  
  Obviously this does nothing for the existing old clients.

  Bartłomiej Dach · 2025-10-29 12:18:23 +09:00
  050c10cec2
• Make MachmakingUser.Placement nullable
  Dan Balasescu · 2025-10-28 20:39:09 +09:00
  c524bf5432
• Add ability to jump in quick play
  Dan Balasescu · 2025-09-30 18:38:30 +09:00
  e636a09e0f
• Add avatar action request/event models
  Dan Balasescu · 2025-09-30 18:32:04 +09:00
  3ebb72a20a
• Query for available pools for selection (#131)
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  e0c11504a2
• Join matchmaking rooms with password
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  3985596602
• Separate IMatchmakingClient and IMultiplayerClient

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  3786efaa5e
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Add matchmaking model types required for server-side deploy
  Dan Balasescu · 2025-09-04 18:26:56 +09:00
  815bf9c37b
• Eagerly clear the request queue on join
  Dan Balasescu · 2025-09-02 17:57:15 +09:00
  1519084f72
• Configure await calls
  Dan Balasescu · 2025-08-28 13:47:55 +09:00
  9ae6e509b7
• Fix potential loss of room events during join
  Dan Balasescu · 2025-08-28 13:20:02 +09:00
  b95573f97d
• Apply minor refactor to notification classes to be more flexible in usages
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  c2ace36348
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Add [JsonIgnore] to MultiplayerRoom.CurrentPlaylistItem

  The lack of this is currently failing a unit test on
  `osu-server-spectator` current master:
  
  https://github.com/ppy/osu-server-spectator/actions/runs/14193158383/job/39762243965#step:4:28
  
  I don't think the failure actually matters because I don't think we're
  using json serialisation on spectator server side anywhere (used to for
  iOS at least, but I don't think we do anymore?), but probably better to
  be safe than sorry.

  Bartłomiej Dach · 2025-04-03 10:03:06 +02:00
  9a4371a817
• Add helpers to MultiplayerRoom
  Dan Balasescu · 2025-03-19 15:24:50 +09:00
  165d40d06f
• Fix error message on invalid room password
  Dan Balasescu · 2025-03-09 10:20:11 +09:00
  7fdadbd852
• Merge pull request #32214 from smoogipoo/fix-multi-user-kick-threading

  Fix thread safety when kicking multiplayer users

  Bartłomiej Dach · 2025-03-04 09:24:08 +01:00
  28be0e31c2