3599 Commits

• Unimplement legacy compatibility method (#36812)

  The spectator server invokes both legacy and non-legacy methods to keep
  compatibility with older clients:
  
  
  https://github.com/ppy/osu-server-spectator/blob/fe0dad324587c8a12a2f203fd8289ce64182c2d9/osu.Server.Spectator/Hubs/Multiplayer/Matchmaking/Queue/MatchmakingQueueBackgroundService.cs#L292-L299
  
  I thought that it'd be a good idea to implement the legacy method here,
  but it turns out to not be such a good idea because it means ranked-play
  clients will assume they're receiving a quick play invitation.

  Dan Balasescu · 2026-03-05 00:31:43 +09:00
  ae032622ac
• Merge branch 'master' into tags-broken
  Dean Herbert · 2026-03-04 19:50:33 +09:00
  459d5e8a45
• Only show user tags above threshold by default
  Bartłomiej Dach · 2026-03-04 10:34:35 +01:00
  9b55e1dfdb
• Add bool flag for checking tag vote threshold & utilise as required

  Closes https://github.com/ppy/osu/issues/36453.
  
  My omission was in assuming that web was going to start filtering out
  the tags below the threshold from API responses, which is not the case.
  
  Whether or not the consumers want or not to display tags below threshold
  is subjective. I figured that the matchmaking card tooltip might want to
  display below threshold but I dunno.

  Bartłomiej Dach · 2026-03-03 13:03:33 +01:00
  d9e182230d
• Move constant closer to helper
  Bartłomiej Dach · 2026-03-03 13:03:33 +01:00
  65b49137ee
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Switch multiplayer to use song select v2 (#36747)

  Tests pass and seems to work. Need to do a bit more self-testing for
  higher confidence, but in theory..
  
  Closes https://github.com/ppy/osu/issues/34035.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-03 13:41:48 +09:00
  d27d0f40c1
• Add pool type to matchmaking room invited event (#36765)

  Rebase of https://github.com/smoogipoo/osu/pull/193
  
  Going forward, the client will have to know the type of pool being
  invited to so that it can enter the appropriate screen when clicking the
  notification.
  
  Unfortunately, SignalR does not support overloading methods, or even
  adding parameters to them, so this PR deprecates the
  `MatchmakingRoomInvited` event and adds its replacement
  `MatchmakingRoomInvitedWithParams` with a complex `invitation` parameter
  that we _can_ extend in the future if required (such as potentially
  adding the name of the pool).
  
  This also prepares the notification by extracting some code to a
  `Complete` method receiving said `invitation` parameter. This part of
  code will be further modified to enter the correct screen:
  
  
  https://github.com/smoogipoo/osu/blob/0a4018045b9d908f66c63dee65d0059d05b26e43/osu.Game/Screens/OnlinePlay/Matchmaking/Queue/QueueController.cs#L200
  
  In particular, I have tested that new clients continue to work with the
  old server (dev.ppy.sh) in quick play
  
  |         | Old Server           | New Server  |
  | ------------- |:-------------:| :-----:|
  | Old Client      | 🟢  | 🟢 |
  | New Client      | 🟢  | 🟢 |

  Dan Balasescu · 2026-02-28 00:42:44 +09:00
  c72b6412ea
• Add user role to MultiplayerRoomUser (#36652)

  - Related to https://github.com/ppy/osu-server-spectator/issues/406
  
  Adding this field to this model has several vague reasons that I can't
  fully formulate yet, but I can't really see myself going forward
  *without* this.
  
  - People were very excited about having referees displayed on the room
  participants' list, and so adding the referees as real
  `MultiplayerRoomUser`s helps this. Having the role could even be used
  client-side to show a special icon or other status on the participants
  list. (Which isn't done yet, could be as an aesthetic follow-up after
  the basics are in place.)
  - Server-side, having this field is convenient for things like
  permission checks or just plain logic, as with two hubs you just need to
  do different *stuff* on a `MultiplayerRoomUser`.

  Bartłomiej Dach · 2026-02-12 00:57:03 +09:00
  5afd6c6835
• Refactor UpdateableTeamFlag for use on team overlay (#36286)

  Part of #32584.
  
  Very much inspired by the respective component for displaying profile
  pictures on the user overlay
  
  * allow disabling interactivity/tooltips
  * add option to show placeholder on null team instead of hiding
  component entirely
  * move setting corner radius out to respective parent components to
  allow for easier overriding

  Krzysztof Gutkowski · 2026-02-10 23:18:36 +09:00
  50426eb3c8
• Update production endpoints in an attempt to fix Russian player connections
  Dean Herbert · 2026-02-09 13:29:21 +09:00
  cae8d3f4d4
• Add info about damage dealt to ranked play user state (#36627)

  Adds a `DamageInfo` property to `RankedPlayDamageInfo` to be used by the
  result screen.
  
  The issue this is trying to solve is that once the result screen
  initializes, the HP value of each player has already been updated in the
  room state so the previous values are no longer accessible. Doing this
  without the state exposing it would require some kinda setup to keep the
  previous MatchState's HP values around on the client which would
  introduce a lot of unnecessary weirdness.

  maarvin · 2026-02-09 12:39:27 +09:00
  efd4d12c21
• Improve handling of account registration errors (#36600)

  ## [Specify `Accept` header in registration
  request](https://github.com/ppy/osu/commit/28edb788f78723cda23281a8801acc2065592840)
  
  The lack of it meant that in specific scenarios web would respond with a
  chunk of HTML instead of JSON.
  
  ## [Allow showing registration error message even if no redirect is
  given](https://github.com/ppy/osu/commit/6ad49941ffd7cdf662ccd404836bb52fccec2142)
  
  There are scenarios where this can happen, and if it did, previously the
  strict requirement to have both would cause the specific message to be
  discarded and replaced with the generic "something happened" one.

  Bartłomiej Dach · 2026-02-09 00:51:31 +09:00
  7263551aa8
• Make grouped friend notifications Transient and not important (#36620)

  Grouped notifications for more than 1 person were added in
  https://github.com/ppy/osu/pull/36180 but it looks like they forgot to
  add the Transient and IsImportant flags, which means the grouped
  notifications would still stay in the notification list/flash the
  taskbar.
  
  Before:
  
  
  https://github.com/user-attachments/assets/8a34bbc0-2b5c-4086-b2ee-1daa6d1e6e10
  
  
  
  After:
  
  
  https://github.com/user-attachments/assets/03c25ba6-7c8e-464c-bbb1-688ab9da6bb6

  SupDos · 2026-02-08 23:16:39 +09:00
  5cdf07c7e1
• Fix unobserved timeouts still showing to user

  As reported in https://osu.ppy.sh/community/forums/topics/2174881?n=1.

  Dean Herbert · 2026-01-30 15:37:01 +09:00
  cf09ed3e0d
• Apply default value changes from review
  Dan Balasescu · 2026-01-28 17:45:15 +09:00
  6d54d20943
• Add comments
  Dan Balasescu · 2026-01-28 14:00:44 +09:00
  8202ad18d0
• Add ranked play match type
  Dan Balasescu · 2026-01-28 13:42:59 +09:00
  fa5a278cf3
• Add ranked play models
  Dan Balasescu · 2026-01-28 13:42:59 +09:00
  70321e2f89
• Add type parameter to pool retrieval method
  Dan Balasescu · 2026-01-28 13:42:58 +09:00
  c1fc1edd9c
• Add type to matchmaking pools
  Dan Balasescu · 2026-01-28 13:38:40 +09:00
  40e55ecb6e
• Add metadata endpoint to refresh friend listing (#36386)

  Alternative to / closes https://github.com/ppy/osu/pull/36341
  See also: https://github.com/ppy/osu-server-spectator/pull/415
  
  This is a simple solution by adding a spectator endpoint to refresh the
  friend listing. A more complicated form of this is to make
  adding/removing friends only via spectator, but that would require
  osu-web changes too.

  Dan Balasescu · 2026-01-19 18:34:00 +09:00
  e62a01cf77
• Add localisation support for some more notifications (#36353)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Denis Titovets · 2026-01-16 22:58:20 +09:00
  06b89919be
• Scope player handling to specific screens which have issues
  Dean Herbert · 2026-01-15 18:09:04 +09:00
  1313883394
• Stop websocket handshake failures from being shown to users
  Dean Herbert · 2026-01-15 18:09:04 +09:00
  e8154080b3
• Alert when spectator server disconnects during gameplay

  This can cause issues liek loss of replays, so it's worth notifying the
  user and keeping things visible.

  Dean Herbert · 2026-01-15 17:14:56 +09:00
  c646b4e5ec
• Use same message for multiplayer disconnects to simplify things further
  Dean Herbert · 2026-01-15 17:11:44 +09:00
  15cb3b7a27
• Adjust API disconnection text to be usable in more scenarios
  Dean Herbert · 2026-01-15 17:11:42 +09:00
  0551c75c6b
• Adjust friend notification logic to fix a few flaws (#36348)

  Just a couple of things I noticed in passing:
  
  - When changing the configuration setting, things were not reset.
  Likewise, if the setting was off the queues would still be added to but
  never flushed.
  - When the setting is toggled, a stale next notification time was still
  present due to the `??=` and lack of resetting. This should no longer be
  the case.

  Dean Herbert · 2026-01-15 16:31:15 +09:00
  2bf0dcf398
• Simplify proxy configuration

  More clean-up.

  Bartłomiej Dach · 2026-01-13 11:16:20 +01:00
  9c8d6e63a7
• Remove no longer needed header alias for version hash

  Clean-up from an old change (see
  https://github.com/ppy/osu/pull/28892#discussion_r1681136250).

  Bartłomiej Dach · 2026-01-13 11:12:03 +01:00
  5abc0f93fe
• Replace manual specification of Authorization header with SignalR-provided provider property

  The property used here is listed in SignalR documentation:
  
  	https://learn.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz?view=aspnetcore-10.0#bearer-token-authentication
  
  While in practice this probably has zero bearing on anything,
  theoretically the way proposed in this commit is more correct.
  As the documentation states, with some transports the token may need to
  be renewed if it expires, which providing it via a header as done
  previously would not achieve, while going through `API.AccessToken`
  every time will perform a token refresh if one is needed.

  Bartłomiej Dach · 2026-01-13 11:03:59 +01:00
  d5aa5b61ad
• Add support for global rank parsing in /users/ batch lookups

  See https://github.com/ppy/osu-web/pull/12651 for web-side
  implementation.
  To be used to fix
  https://github.com/ppy/osu/pull/33649/changes#diff-32784a778b34c671e1f72c00e1f4161a5e774e849aae5631ee71b31fc32e5d42R218
  (have tested this works there).
  
  Use simple set-get rather than transforming to `APIUser.Statistics`

  Dean Herbert · 2026-01-09 16:19:52 +09:00
  23c68cbfea
• Localise notifications in OnlineStatusNotifier (#36223)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Denis Titovets · 2026-01-05 16:15:01 +09:00
  ff3397b6b7
• Merge pull request #36198 from diquoks/localisation/friend-presence-notifications

  Localise friend presence notifications

  Dean Herbert · 2026-01-04 02:22:13 +09:00
  b6dc64668e
• Merge pull request #36160 from smoogipoo/qp-beatmap-attributes

  Add beatmap attributes to quick play panels

  Dean Herbert · 2026-01-02 23:05:02 +09:00
  e0c4592dc7
• Localise friend presence notifications
  Denis Titovets · 2026-01-01 21:26:48 +03:00
  212973bd63
• Small refactoring
  Denis Titovets · 2025-12-30 19:36:43 +03:00
  dad138223b
• Display an old-style notification if multiple users should be displayed
  Denis Titovets · 2025-12-30 18:54:28 +03:00
  a23024d80e
• Show vote count in tag tooltip
  Dan Balasescu · 2025-12-29 17:47:35 +09:00
  2e324fe856
• Move top user tags enumeration to helper
  Dan Balasescu · 2025-12-29 15:43:43 +09:00
  60d9c358b8
• Remove mention of exception that doesn't exist
  Dan Balasescu · 2025-12-12 15:46:00 +09:00
  79151ae5b4
• Always perform leave room sequence
  Dan Balasescu · 2025-12-11 20:07:36 +09:00
  bbdd70c843
• Filter out more exceptions from being sent to sentry

  More or less covers the first page of client sentry issues sorted by
  volume, all of which is pretty much useless for anything because it's
  client-specific-failure noise.

  Bartłomiej Dach · 2025-12-09 09:54:46 +01:00
  8bb885a0dc
• Merge pull request #35909 from smoogipoo/fix-vote-to-skip

  Adjust vote-to-skip messaging flow to be explicit about states

  Bartłomiej Dach · 2025-12-09 08:59:53 +01:00
  0b06acb29d
• Merge pull request #35918 from smoogipoo/qp-fix-unsafe-schedules

  Fix potentially unsafe quick play event handling

  Bartłomiej Dach · 2025-12-09 08:32:56 +01:00
  b129837e57
• Consider abandon time for user placements
  Dan Balasescu · 2025-12-07 23:26:40 +09:00
  d6cd748d2a
• Fix potentially unsafe quick play event handling
  Dan Balasescu · 2025-12-07 02:11:26 +09:00
  c23d6b7fd1
• Adjust vote-to-skip to be explicit about states
  Dan Balasescu · 2025-12-06 13:23:16 +09:00
  2be50d917a