1821 Commits

• Remove all song select v1 files

  This contains no code changes (that would need review), only file
  deletion and extraction where required in a few odd cases.

  Dean Herbert · 2026-03-03 16:45:14 +09:00
  1a8d2855d4
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Remove HoldForMenuButton player dependency
  Dan Balasescu · 2026-01-06 17:20:28 +09:00
  86220622fb
• Merge branch 'master' into legacy-pp-counter
  Dean Herbert · 2025-12-15 16:55:51 +09:00
  89d8b402af
• Fix skin editor sometimes dropping anchor/origin specification on paste (#35957)

  * Add failing test for copy->paste not being idempotent
  
  * Ensure all elements on default skins use fixed anchors
  
  `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
  manual anchor / origin specs on some drawables, this would get default
  skins into impossible states wherein a drawable would use "closest
  anchor" but also explicitly specify anchor / origin that aren't closest,
  which horribly fails on attempting to copy and paste.
  
  Frankly shocked this has gone unnoticed for this long, and I regret not
  vetoing this "feature" more every time I see its tentacles spread to
  produce breakage of levels yet unseen.
  
  Does this commit contain major levels of suck? For sure. Do I have any
  better ideas that wouldn't consist of a multi-day rewrite or deletion of
  this "feature"? No.
  
  * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor
  
  Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
  along with previous commit.

  Bartłomiej Dach · 2025-12-11 13:40:48 +09:00
  c4f7dee82b
• Add test coverage of weird storyboard sprite behaviour
  Dean Herbert · 2025-12-09 19:53:02 +09:00
  5c2df50714
• Fix gameplay leaderboard tracked player not using team colour (#35826)

  * Demonstrate colour problem in test
  
  * Fix gameplay leaderboard tracked player not using team colour
  
  Closes https://github.com/ppy/osu/issues/35806.

  Bartłomiej Dach · 2025-11-27 21:22:06 +09:00
  6bb25b2abe
• Add simple multiplayer skip overlay
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  b20a41c1e8
• Add a keycounter that has been actually used in Triangles skin (#35491)
  De4n · 2025-10-29 12:18:00 +09:00
  b4fd7ec10f
• Merge pull request #35400 from bdach/leaderboard-sometimes-incorrectly-partial

  Fix solo leaderboard sometimes not showing user position while it technically could

  Dean Herbert · 2025-10-24 14:36:14 +09:00
  4f478db056
• Extract all pieces of local user-related state to APIAccess subcomponent

  Something I've asked to be done for a long time. Relevant because I've
  complained about this on every addition of a new piece of user-local
  state: friends, blocks, and now favourite beatmaps.
  
  It's just so messy managing all this inside `APIAccess` next to
  everything else, IMO.

  Bartłomiej Dach · 2025-10-23 10:53:58 +02:00
  5eda9a0fd7
• Fix solo leaderboard sometimes not showing user position while it technically could

  The "partial" leaderboard logic in `SoloGameplayLeaderboardProvider`
  always assumed the online fetch would request 50 scores, which is no
  longer the case after https://github.com/ppy/osu/pull/33100.

  Bartłomiej Dach · 2025-10-23 08:53:29 +02:00
  ca8fc81a7e
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing test coverage for no score submission attempt on known locally modified beatmap
  Bartłomiej Dach · 2025-10-02 09:16:17 +02:00
  44a1a5ffc7
• Merge branch 'master' into legacy-pp-counter
  Du Yijie · 2025-09-15 14:41:45 +08:00
  b1bc5cae87
• Demonstrate failure in test
  Bartłomiej Dach · 2025-09-13 10:50:33 +09:00
  a9c021ce04
• Always show the same number of placeholder digits in argon judgement counter when it is vertical
  Bartłomiej Dach · 2025-09-03 13:42:17 +02:00
  98c3437174
• Fix abysmal code quality
  Bartłomiej Dach · 2025-09-03 13:23:12 +02:00
  a56f81a731
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Implement "legacy" pp counter

  There is no pp counter in osu!(stable). However, a "legacy" pp counter
  allows skinners to more easily fit a pp counter into their skin's theme.

  Du Yijie · 2025-08-27 11:07:53 +08:00
  ac21f8b960
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Merge pull request #34643 from frenzibyte/leaderboard-resize

  Fix leaderboard not resizing correctly

  Dean Herbert · 2025-08-21 13:33:24 +09:00
  41885c0fc0
• Add test for scores with long score/combo numbers
  Salman Alshamrani · 2025-08-18 13:46:51 +03:00
  bb5933ef80
• Merge pull request #34612 from frenzibyte/auto-beatmap-offset

  Add setting for adjusting beatmap offset automatically based on last play

  Dean Herbert · 2025-08-15 23:33:32 +09:00
  99dc2bb58f
• Merge pull request #34628 from bdach/show-results-on-failed-replay

  Show indicator in replay player once replay fails

  Dean Herbert · 2025-08-15 19:33:47 +09:00
  a14d7a23bd
• Merge pull request #34662 from bdach/refetch-leaderboard-on-retry

  Refetch leaderboard when (slow) retrying a beatmap

  Dean Herbert · 2025-08-15 18:29:17 +09:00
  46744c6f15
• Remove failing test

  Test was added in 5495c2090a to exercise a
  previous version of the hotfix-workaround of not allowing seeking back.
  Now that the hotfix-workaround also encompasses seeking *forward*, which
  breaks another 100 tests, thus requiring the hotfix-workaround to be
  turned off for tests, this situation is just completely out of
  control. So I'm just removing the test because ugh.

  Bartłomiej Dach · 2025-08-15 10:01:10 +02:00
  126d0c6bdb
• Add failing test
  Bartłomiej Dach · 2025-08-14 14:18:25 +02:00
  116a45c9cb
• Add failing test case
  Salman Alshamrani · 2025-08-14 13:47:58 +03:00
  69b6166e58
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Add ability to resize leaderboard in tests
  Salman Alshamrani · 2025-08-13 12:51:09 +03:00
  62803af1de
• Show indicator in replay player once replay fails

  This indicator allows the player to either rewind to an earlier part of
  the replay, or to proceed to results. It also plays a shortened variant
  of the failure animation SFX.

  Bartłomiej Dach · 2025-08-12 14:25:58 +02:00
  35a472ae39
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix test scene doing very weird things for (seemingly) no reason
  Bartłomiej Dach · 2025-08-12 13:21:16 +02:00
  e3f2ffe19c
• Update test coverage
  Salman Alshamrani · 2025-08-12 11:05:53 +03:00
  cd416214f2
• add extra test
  Hivie · 2025-08-11 14:13:05 +01:00
  2cab4350ca
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Add back comment regarding bad bindable casting
  Dean Herbert · 2025-08-11 20:57:01 +09:00
  9d6a0208f1
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• Add test coverage
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  b351f0187d
• refactor tests to use both UR counter variants
  Hivie · 2025-08-09 22:34:57 +01:00
  2af8066c4d
• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Rewrite gameplay leaderboard test scene to be usable

  At some point during the leaderboard data refactor, this test scene
  became completely unusable. This change rewrites it to use
  `SoloGameplayLeaderboardProvider` to be able to witness the user score
  being resorted and advancing through the leaderboard.

  Salman Alshamrani · 2025-07-22 23:58:06 +03:00
  84a36b1bfa
• Fix tests
  Bartłomiej Dach · 2025-07-22 10:11:16 +02:00
  b9bda61e27
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Track count of times gameplay was paused on ScoreInfo
  Bartłomiej Dach · 2025-07-07 11:00:30 +02:00
  f082b60c9b
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Merge pull request #33670 from bdach/ensure-replays-are-played-to-end

  Ensure partial failed replays are played to their end

  Dean Herbert · 2025-06-30 15:56:13 +09:00
  768d44596a