21 Commits

• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Fix metadata cache version queries failing hard if the image is corrupted

  This was not fatal but with this change it should recover in a slightly
  better way.
  
  Also incidentally fixes the cache refetch potentially being attempted
  twice by each of the two background population tasks that use it.

  Bartłomiej Dach · 2025-08-07 11:10:02 +02:00
  dac643121a
• Fix metadata cache refetches failing on windows

  Reported at
  https://discord.com/channels/188630481301012481/1097318920991559880/1402910684320108574
  among others.
  
  Only really visible on windows for reasons outlined in inline comment.

  Bartłomiej Dach · 2025-08-07 10:24:15 +02:00
  7da94c4010
• Only perform user tag backpopulation after the local metadata cache updates
  Bartłomiej Dach · 2025-07-29 11:50:41 +02:00
  8307947a10
• Add back-population operation for user tags
  Bartłomiej Dach · 2025-07-23 10:35:32 +02:00
  1709811458
• Add support for retrieving user tags from local metadata cache
  Bartłomiej Dach · 2025-07-23 10:26:31 +02:00
  05923d3b2b
• Add brackets to ensure correct lookups

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-03-11 18:17:18 +09:00
  914a230446
• Ensure only ranked/approved/loved lookups occur on local cached source
  Dean Herbert · 2025-03-11 16:37:46 +09:00
  8d83dfede7
• Remove previous version of local cache lookup handling
  Dean Herbert · 2025-03-11 16:29:47 +09:00
  5ef2479e24
• Adjust code again to avoid weird throw mishandling
  Dean Herbert · 2025-01-22 18:24:01 +09:00
  6ceb348cf6
• Adjust code style slightly
  Dean Herbert · 2025-01-22 17:03:01 +09:00
  910c0022e3
• Refetch local metadata cache if corruption is detected

  Addresses one of the points in https://github.com/ppy/osu/issues/31496.
  
  Not going to lie, this is mostly best-effort stuff (while the refetch is
  happening, metadata lookups using the local source *will* fail), but I
  see this as a marginal scenario anyways.

  Bartłomiej Dach · 2025-01-14 11:20:52 +01:00
  b0c0c98c5d
• Bring back matching by filename when performing online metadata lookups
  Bartłomiej Dach · 2024-10-30 10:25:20 +01:00
  7e3564cb4a
• Only use MD5 when performing metadata lookups

  Both online and offline using the cache.
  
  The rationale behind this change is that in the current state of
  affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be
  reconciled without this sort of change.
  
  The test exercises a scenario where the beatmap being imported has an
  online ID in the `.osu` file, but its hash does not match the online
  hash of the beatmap. This turns out to be a more frequent scenario than
  envisioned because of users doing stupid things with manual file editing
  rather than reporting issues properly.
  
  The scenario is realistic only because the behaviour of the endpoint
  responsible for looking up beatmaps is such that if multiple parameters
  are given (e.g. all three of beatmap MD5, online ID, and filename), it
  will try the three in succession:
  
  	https://github.com/ppy/osu-web/blob/f6b341813be270de59ec8f9698428aa6422bc8ae/app/Http/Controllers/BeatmapsController.php#L260-L266
  
  and the local metadata cache implementation reflected this
  implementation.
  
  Because online ID and filename are inherently unreliable in this
  scenario due to being directly manipulable by clueless or malicious
  users, neither should not be used as a fallback.

  Bartłomiej Dach · 2024-10-30 08:12:30 +01:00
  776fabd77c
• Backpopulate missing ranked/submitted dates using new local metadata cache

  People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix
  their databases (as stated in the PR, it didn't intend to), so this
  should do it for them.

  Bartłomiej Dach · 2024-09-13 16:00:49 +02:00
  a4f6d4a300
• Add support for retrieving submit/rank date from local metadata cache in version 2

  Closes https://github.com/ppy/osu/issues/22416.

  Bartłomiej Dach · 2024-08-21 15:42:22 +02:00
  5f88435d96
• Update local metadata lookup cache more often

  As proposed in
  https://github.com/ppy/osu/issues/27332#issuecomment-1962308306.

  Bartłomiej Dach · 2024-05-02 16:18:29 +02:00
  802666e621
• Move init method to bottom of file
  Dean Herbert · 2024-02-11 20:05:58 +08:00
  7dba21fdac
• Polish xmldocs
  Bartłomiej Dach · 2023-06-08 19:11:48 +02:00
  c930ec97d6
• Refactor again to fix test failures
  Bartłomiej Dach · 2023-06-08 19:11:48 +02:00
  29ce27098d
• Refactor metadata lookup to streamline online metadata application logic
  Bartłomiej Dach · 2023-06-08 19:11:48 +02:00
  7c8c6790d0