Bartłomiej Dach
c30f334cf9
Merge pull request #32197 from peppy/zoom-to-centre-always
...
Always zoom timeline to centre rather than focus point
2025-03-03 20:12:28 +01:00
Dean Herbert
6aaec144c8
Merge pull request #32162 from nekodex/kiai-sfx
...
Add SFX for kiai/star fountain activation
2025-03-03 19:05:05 +09:00
Dean Herbert
52860def6c
Always zoom timeline to centre rather than focus point
...
Closes https://github.com/ppy/osu/issues/32183 .
2025-03-03 18:53:41 +09:00
Bartłomiej Dach
8539745667
Merge pull request #32153 from peppy/carousel-design-fixes
...
Apply first wave blanket fixes to new beatmap carousel design
2025-03-03 08:13:43 +01:00
Jamie Taylor
881534eb7f
Add SFX for kiai/star fountain activation
2025-03-01 01:51:37 +09:00
Dean Herbert
38de3566b1
Adjust set panel display and animations slightly
2025-02-28 22:54:00 +09:00
Dean Herbert
4beac64bdb
Remove unused container level
2025-02-28 22:54:00 +09:00
Dean Herbert
29c35529d2
Fix activation flash being applied twice (and adjust duration)
2025-02-28 22:54:00 +09:00
Dean Herbert
8032b68932
Stop using padding for panel x offsets
2025-02-28 22:54:00 +09:00
Bartłomiej Dach
c4e37a1566
Merge pull request #32109 from smoogipoo/results-beatmap-lookup
...
Fix multiplayer results screen displaying same beatmap for all users
2025-02-28 12:36:28 +01:00
Dan Balasescu
993473c081
Pass through artist/title in beatmap transform
2025-02-28 18:40:54 +09:00
Dean Herbert
51cb0bea1c
Fix carousel taking up too much space on new song select implementation
2025-02-28 16:45:49 +09:00
Dean Herbert
1e46dc6b0a
Adjust animation duration to roughly match scroll operations
...
Previous value felt wrong when using keyboard selection for iteration.
2025-02-28 16:27:42 +09:00
Dean Herbert
a8fbac0f0d
Add better selection visibility via another tint layer
2025-02-28 16:27:18 +09:00
Dean Herbert
02b950223c
Adjust x offsets to work again for keyboard selection
2025-02-28 16:08:11 +09:00
Dean Herbert
e1723ec1bb
Adjust preview time display to not conflict with bookmarks
2025-02-28 14:05:49 +09:00
Dean Herbert
0b453772da
Disable button instead of hiding (and add tooltip)
2025-02-27 15:15:58 +09:00
Dan Balasescu
d3c4afe65d
Fix typo
2025-02-27 13:16:51 +09:00
Bartłomiej Dach
6b76b8ccdd
Do not allow adding more than 8 combo colours in editor
2025-02-26 11:24:06 +01:00
Dan Balasescu
c2875423ee
Cleanup score fetching a bit
2025-02-26 18:58:29 +09:00
Dan Balasescu
3dde024650
Replace error handling with logs
...
- Handling all errors matches master a little bit better. Logging
exceptions in any case.
- Not throwing when beatmaps are missing simplifies tests.
2025-02-26 18:02:13 +09:00
Dan Balasescu
c7fd7cf9cd
Add missing ConfigureAwait
2025-02-26 17:39:56 +09:00
Dean Herbert
abc12abded
Fix PlayerTeamFlag skinnable component not showing team details during replay
...
For now, let's fetch on demand.
Note that song select local leaderboard has the same issue. I feel we should be
doing a lot more cached lookups (probaly with persisting across game restarts).
Maybe even replacing the realm user storage. An issue for another day.
2025-02-26 16:48:18 +09:00
Dan Balasescu
b7d431fdde
Include author
2025-02-26 15:04:43 +09:00
Dan Balasescu
59cfcb3595
Prefer local models where available
2025-02-26 15:04:37 +09:00
Dan Balasescu
90290997a7
Fix score panel difficulty depending on local beatmap
...
This is a very special case where online beatmap/ruleset models are
being ferried via `ScoreInfo` in what appear to `BeatmapDifficultyCache`
as local `BeatmapInfo`/`RulesetInfo` models. Here, BDC will incorrectly
attempt to proceed with calculating true difficulty where it cannot, and
return 0.
This is fixed locally because `ScoreInfo` is a very weird model, and I'm
not sure whether BDC should contain logic to work around this.
2025-02-26 14:49:00 +09:00
Dan Balasescu
baf20d8484
Fix loading spinners not hiding correctly
2025-02-25 23:17:23 +09:00
Dan Balasescu
bb457ca8e2
Clean up completion handling
2025-02-25 23:17:02 +09:00
Dan Balasescu
116b5a335a
ConfigureAwait(false) everywhere
2025-02-25 22:56:38 +09:00
Dan Balasescu
3b5bf391da
Arrays instead of enumerables
2025-02-25 22:55:55 +09:00
Dan Balasescu
8a27b6689e
Replace virtual async method with better abstraction
2025-02-25 22:51:36 +09:00
Dan Balasescu
dfae11101f
Populate playlists results screen with online beatmaps
2025-02-25 22:37:12 +09:00
Dan Balasescu
13ca8c20f6
Make results screens use tasks to fetch scores
2025-02-25 21:54:16 +09:00
Bartłomiej Dach
0312467c88
Fix hash comparison being case sensitive when choosing files for partial beatmap submission
...
Noticed when investigating https://github.com/ppy/osu/issues/32059 , and
also a likely cause for user reports like
https://discord.com/channels/188630481301012481/1097318920991559880/1342962553101357066 .
Honestly I have no solid defence, Your Honour. I guess this just must
not have been tested on the client side, only relied on server-side
testing.
2025-02-24 12:30:37 +01:00
Dean Herbert
e9b8154090
Merge pull request #32005 from smoogipoo/fix-multi-leave-host-sound
...
Fix host change sounds playing when exiting multiplayer rooms
2025-02-24 00:23:39 +09:00
Bartłomiej Dach
a690b0bae9
Adjust rounding tolerance in distance snap grid ring colour logic
2025-02-21 12:05:23 +01:00
Dan Balasescu
f868f03e1b
Fix host change sounds playing when exiting multiplayer rooms
2025-02-21 16:38:55 +09:00
Dan Balasescu
49c192b173
Fix wrong beatmap attributes in multiplayer spectate
2025-02-21 16:19:05 +09:00
Dean Herbert
a75ec75a8f
Fix using
2025-02-20 23:48:21 +09:00
Dean Herbert
4f4d2b3b3f
Fix results screen applause playing too loud during multiplayer spectating
2025-02-20 23:42:32 +09:00
Dean Herbert
1e3d5d7d81
Remove left-over debug code
2025-02-20 23:05:47 +09:00
Dean Herbert
4c934dae51
Merge pull request #31774 from frenzibyte/carousel-v2-implement-designs
...
Implement designs for beatmap carousel v2
2025-02-20 17:56:40 +09:00
Dean Herbert
df5fe07995
Merge pull request #31941 from bdach/fix-multi-spectator-freestyle
...
Fix multiplayer spectator not working with freestyle
2025-02-20 16:25:09 +09:00
Dean Herbert
81b4f0d8ca
Add comments regarding jank
2025-02-20 15:49:40 +09:00
Dean Herbert
1c53d93a8f
Add disposal and pre-check before reloading audio track
2025-02-20 15:32:47 +09:00
Salman Alshamrani
092d80cf1b
Fix PanelBeatmapStandalone not handling selection state
2025-02-19 10:20:04 -05:00
Bartłomiej Dach
f9d91431fd
Fix multiplayer spectator not working with freestyle
...
It's no longer possible to just assume that using the ambient
`WorkingBeatmap` is gonna work.
Bit dodgy but seems to work and also I'd hope that `WorkingBeatmapCache`
makes this not overly taxing. If there are concerns this can probably be
an async load or something.
2025-02-19 15:15:21 +01:00
Bartłomiej Dach
687c9d6e17
Send "notify on discussion replies" setting value in beatmap creation request
2025-02-19 12:45:37 +01:00
Dean Herbert
66f7f92469
Merge pull request #31928 from bdach/perform-on-selection-is-weird
...
Fix nudging objects in catch editor not changing their hyperdash state
2025-02-18 21:17:10 +09:00
Bartłomiej Dach
e6174f195c
Ensure EditorBeatmap.PerformOnSelection() marks objects in selection as updated
...
Closes https://github.com/ppy/osu/issues/28791 .
The reason why nudging was not changing hyperdash state in catch was
that `EditorBeatmap.Update()` was not being called on the objects that
were being modified, therefore postprocessing was not performed,
therefore hyperdash state was not being recomputed.
Looking at the usage sites of `EditorBeatmap.PerformOnSelection()`,
about two-thirds of callers called `Update()` themselves on the objects
they mutated, and the rest didn't. I'd say that's the failure of the
abstraction and it should be `PerformOnSelection()`'s responsibility to
call `Update()` there. Yes in some of the cases here this will cause
extraneous calls that weren't done before, but the method is already
heavily disclaimed as 'expensive', so I'd say usability should come
first.
2025-02-18 12:06:42 +01:00
