Bartłomiej Dach
797109c05c
Enable NRT in KeyBindingRow
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
0b2b065383
Add xmldoc
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
7ac874d17a
Use init-only properties where applicable
2023-10-11 08:49:58 +02:00
Bartłomiej Dach
1acc02405e
Reorder KeyBindingRow members
2023-10-11 08:18:59 +02:00
Bartłomiej Dach
eeb5409733
Merge pull request #25081 from peppy/song-bar-less-black
...
Reduce black fill of song bar in tournament UI back to reasonable levels
2023-10-10 22:28:50 +02:00
Bartłomiej Dach
969c1b0812
Merge pull request #25074 from peppy/fix-argon-health-bar-flash
...
Fix argon health bar not completing flash animation correctly
2023-10-10 22:28:30 +02:00
Bartłomiej Dach
6f5f3a1ef4
Merge branch 'master' into fix-argon-health-bar-flash
2023-10-10 20:03:20 +02:00
Bartłomiej Dach
66c12e5269
Merge pull request #25083 from peppy/fix-preview-point-incorrect
...
Fix default preview point being incorrect on old beatmaps
2023-10-10 19:54:14 +02:00
Dean Herbert
b9dbc8139b
Merge branch 'master' into fix-argon-health-bar-flash
2023-10-11 00:20:08 +09:00
Bartłomiej Dach
d701e88a08
Merge pull request #25076 from peppy/fix-argon-health-bar-perf
...
Ensure health displays don't pile up transforms when off-screen
2023-10-10 16:33:32 +02:00
Bartłomiej Dach
0c64fe7eaa
Merge pull request #25079 from peppy/fix-player-startup-stop
...
Fix multiplayer not correctly pausing the track on initialisation
2023-10-10 16:30:35 +02:00
Dean Herbert
b9dadc52b7
Adjust comment to match current behaviour
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-10-10 22:54:19 +09:00
Dean Herbert
e2e28ef0ca
Remove comment regarding inlined delegate
2023-10-10 22:12:20 +09:00
Dean Herbert
682aa06acf
Remove JudgementResult from Miss/Flash as it is not used
2023-10-10 22:10:44 +09:00
Dan Balasescu
a1a46e58fc
Move validation to DHO.ApplyResult()
2023-10-10 21:42:37 +09:00
Dean Herbert
2781846147
Fix beatmaps with no preview point set getting incorrect default
...
Note that this will require a re-import to fix existing beatmaps
becuse.. it's stored to realm. Probably not worth worrying about for
now.
2023-10-10 19:13:16 +09:00
Dean Herbert
7220ca34f7
Add failing test coverage of incorrect default preview time
2023-10-10 19:13:16 +09:00
Dean Herbert
97e521acad
Reduce black fill of song bar
...
Closes https://github.com/ppy/osu/issues/24993 .
2023-10-10 18:47:20 +09:00
Dean Herbert
f0bd975393
Change GameplayClockContainer.Reset to directly call GameplayClock.Stop
...
The reasoning is explained in the inline comment, but basically this was
getting blocked by `isPaused` being in an initial `true` state (as it is
on construction), while the source clock was still `IsRunning`.
There's no real guarantee of sync between the source and the `isPaused`
bindable right now. Maybe there should be in the future, but to restore
sanity, let's ensure that a call to `Reset` can at least stop the track
as we expect.
2023-10-10 18:16:14 +09:00
Dean Herbert
100c0cf533
Fix MultiplayerPlayer never calling Reset on GameplayClockContainer
...
This call is responsible for ensuring the clock is in a stopped state.
2023-10-10 17:58:37 +09:00
Dean Herbert
eee7dc02da
Reduce severity of clock running check to avoid production crashes
2023-10-10 17:58:11 +09:00
Dean Herbert
4319b22db8
Add failing test coverage of player not pausing track correctly
2023-10-10 17:55:35 +09:00
Dean Herbert
1388f7240e
Merge pull request #25077 from bdach/fix-guest-score-lookup
...
Fix score importer looking up guest user by username online
2023-10-10 17:35:15 +09:00
Dean Herbert
a0bd91f3bb
Merge pull request #25070 from frenzibyte/fix-legacy-catcher-layout
...
Adjust legacy catcher display to match 1:1 with osu!(stable)
2023-10-10 17:31:10 +09:00
Dean Herbert
0ca05d986d
Merge pull request #25067 from bdach/approach-circle-cutoff
...
Adjust approach circle maximum size limits for backwards compatibility
2023-10-10 17:05:16 +09:00
Dan Balasescu
18d20cad8b
Adjust xmldoc for readability
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-10-10 17:04:21 +09:00
Dean Herbert
8dc9453d8d
Apply some xmldoc and structural changes
2023-10-10 16:59:25 +09:00
Dan Balasescu
94192644be
Fix tests
2023-10-10 16:54:24 +09:00
Bartłomiej Dach
ea400a9db7
Fix cross-test interference
...
`TestLastPlayedUpdated` was implicitly relying on running first.
`TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
causing the former test to fail if it didn't get to run first.
2023-10-10 09:30:51 +02:00
Bartłomiej Dach
24956588e9
Fix score importer looking up guest user by username online
2023-10-10 09:28:01 +02:00
Bartłomiej Dach
08b1a3cbe2
Add failing test case for guest user being looked up in API
2023-10-10 09:18:57 +02:00
Dean Herbert
4674f63655
Fix Scheduler.AddOnce not working in one location
2023-10-10 16:17:34 +09:00
Dean Herbert
7e68b64526
Avoid running finishInitialAnimation when already finished
2023-10-10 15:59:48 +09:00
Dean Herbert
1eb6c93916
Also debounce updatePathVertices to reduce overhead
2023-10-10 15:50:42 +09:00
Dean Herbert
6c346874d3
Add TODO mentioning that ArgonHealthDisplay is doing lerp wrong
2023-10-10 15:24:54 +09:00
Dean Herbert
57f588fa86
Ensure health displays don't pile up transforms when off-screen
2023-10-10 15:24:54 +09:00
Bartłomiej Dach
6b38600010
Merge pull request #25073 from peppy/mania-beat-snap-grid-fix
...
Fix osu!mania beat snap grid sometimes not displaying correctly
2023-10-10 08:21:43 +02:00
Dean Herbert
6ee958743e
Adjust glow animation specifics slightly
2023-10-10 15:10:42 +09:00
Dean Herbert
aeb579eb54
Syncrhonise initial colour of glowBar for sanity
2023-10-10 15:10:27 +09:00
Dean Herbert
8e26b3c405
Fix argon health bar not completing flash animation correctly
2023-10-10 15:09:33 +09:00
Dean Herbert
1a60d6ade5
Use a DrawablePool for mania's beat snap grid
...
I'm not sure what the cause of the issue is, but I'm also not sure why
it wasn't using `DrawablePool` (was it not around back then?).
Either way, switching to a proper pool fixes things just fine.
Resolves https://github.com/ppy/osu/issues/25009 .
2023-10-10 13:36:31 +09:00
Dan Balasescu
04ce223e66
Remove pairings that shouldn't be valid
2023-10-10 10:03:37 +09:00
Dan Balasescu
89a3be11cb
Add validation test
2023-10-10 09:56:35 +09:00
Dan Balasescu
594bcc2ab5
Apply suggestion to condense method
2023-10-10 09:56:26 +09:00
Salman Ahmed
6073f3e756
Refactor catch playfield size adjustment logic w.r.t. catcher position
2023-10-10 02:42:37 +03:00
Dan Balasescu
7211c88e83
Make combo assertion actually work as expected
2023-10-10 08:32:35 +09:00
Salman Ahmed
b2987caf7c
Adjust the catch playfield's position to match 1:1 with stable
2023-10-10 02:17:43 +03:00
Salman Ahmed
693b8d72db
Fix test catcher sprites in "special skin" incorrectly suffixed as being @2x
2023-10-10 01:26:59 +03:00
Salman Ahmed
fed0deac02
Add brief explaination of BASE_SIZE
2023-10-10 01:26:59 +03:00
Salman Ahmed
fc63ee43be
Fix legacy catcher sprites getting shrunk
2023-10-10 01:26:59 +03:00
