75808 Commits

This Branch

This Branch

All Branches

• Reduce abstractions of rounded button
  Dean Herbert · 2025-11-25 00:55:42 +09:00
  b0762fc8ec
• Add missing padding around countdown settings button
  Dean Herbert · 2025-11-25 00:55:22 +09:00
  d59e9572d2
• Move export logs to quick actions (to sit with report issue button)
  Dean Herbert · 2025-11-21 16:40:38 +09:00
  56ce955e0c
• Move quick actions to top
  Dean Herbert · 2025-11-21 16:35:10 +09:00
  73349ab182
• Only show update settings if the game can be updated
  Dean Herbert · 2025-11-21 16:35:09 +09:00
  a6a98fc078
• Move installation settings into own subsection
  Dean Herbert · 2025-11-21 16:35:09 +09:00
  a8594f1c08
• Move quick action settings into own subsection
  Dean Herbert · 2025-11-21 16:25:04 +09:00
  908a950cd2
• Adjust tablet settings layout to feel a touch nicer
  Dean Herbert · 2025-11-21 16:24:10 +09:00
  df79269e6f
• Update rounded button to be less rounded

  Intended to match the rest of the UI which is less rounded these days.
  See inline comment for reason for not matching `FormControl` corner
  radius just yet.

  Dean Herbert · 2025-11-21 16:23:53 +09:00
  34146b8bcb
• Merge pull request #35673 from bdach/report-issue-button

  Add "Report an issue" button to general settings

  Dean Herbert · 2025-11-21 15:55:17 +09:00
  08ed2844b4
• Adjust button colour and don't show warning
  Dean Herbert · 2025-11-21 15:33:14 +09:00
  8e78f4dac4
• Merge pull request #31057 from rikimasan/rikimasan/rank-alternate-mod

  Rank the Alternate and Single Tap mods

  Dean Herbert · 2025-11-21 14:19:42 +09:00
  d465bee0ab
• Merge branch 'master' into rikimasan/rank-alternate-mod
  Dean Herbert · 2025-11-21 14:00:18 +09:00
  721ba8aeba
• Merge pull request #35740 from bdach/dont-nuke-all-channels-in-tourney-client

  Avoid nuking logged in user's joined channels on showing match chat in tournament client

  Dean Herbert · 2025-11-21 10:20:47 +09:00
  a873f2be65
• Adjust code structure slightly to simplify logic
  Dean Herbert · 2025-11-20 18:22:16 +09:00
  c7e1a5770d
• Fix test failure due to channel not being joined
  Dean Herbert · 2025-11-20 18:19:30 +09:00
  a8ac82aa1f
• Do not overwrite website state of 'hide online presence' toggle (#35741)

  Closes https://github.com/ppy/osu/issues/35735.

  Bartłomiej Dach · 2025-11-20 11:10:12 +09:00
  be77257ddb
• Avoid nuking logged in user's joined channels on showing match chat in tournament client

  Closes https://github.com/ppy/osu/issues/35721.
  
  I worry that straight up removing the nuke and not adding any channel
  leave calls in exchange is going to leave tourney client users
  with the *inverse* problem of being joined into a gorillion channels
  from multiplayer matches they broadcasted, so this attempts to strike a
  reasonable balance.

  Bartłomiej Dach · 2025-11-19 11:50:02 +01:00
  603c77e3e9
• Merge pull request #35691 from Kawaritai/fix/window-sizing-dropdown

  Add window sizes in dropdown menu options

  Bartłomiej Dach · 2025-11-19 10:55:24 +01:00
  f284864f96
• Merge branch 'master' into fix/window-sizing-dropdown
  Bartłomiej Dach · 2025-11-19 09:52:31 +01:00
  fa1bf7bd96
• Fix song select crashing when selecting random beatmap and changing star rating filter simultaneously (#35730)

  Closes https://github.com/ppy/osu/issues/35728.

  Bartłomiej Dach · 2025-11-19 16:29:55 +09:00
  ef4408a73e
• Change windowed resolutions filtering. Add comment about borders logic.
  Kawaritai · 2025-11-19 09:18:07 +11:00
  6f7f9802bd
• Merge pull request #35726 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2025-11-18 14:19:47 +01:00
  2025.1119.0-tachyon 80474565fc
• Update framework
  Dean Herbert · 2025-11-18 18:45:38 +09:00
  89f2c7160d
• Fix cursor incorrectly flashing red after a rewind in replays with Alternate mod active (#35725)

  * Fix red cursor with alt mod when rewind
  
  * Change rewind detection in input blocking

  Urantij · 2025-11-18 09:52:37 +01:00
  f0ca079fe6
• Update framework
  Bartłomiej Dach · 2025-11-18 09:50:42 +01:00
  fbd83cb048
• Merge branch 'master' into fix/window-sizing-dropdown
  Bartłomiej Dach · 2025-11-18 09:50:35 +01:00
  843c318ec1
• Clarify target branch requirements in CONTRIBUTING.md

  Because it appears to be a point of confusion to new contributors
  (https://github.com/ppy/osu/pull/35725#issuecomment-3545734262).

  Bartłomiej Dach · 2025-11-18 09:39:06 +01:00
  19b6761697
• Clamp sizing
  Kawaritai · 2025-11-18 14:38:34 +11:00
  0c341c1f3e
• Center window within usable bounds
  Kawaritai · 2025-11-18 14:10:18 +11:00
  ae5584bd88
• Merge pull request #35718 from bdach/smoke-pooling

  Add pooling support to smoke segments

  Dean Herbert · 2025-11-18 11:37:13 +09:00
  edf08b176a
• Fix test
  Bartłomiej Dach · 2025-11-17 13:55:53 +01:00
  7b952b83bf
• Fix bad localisation reuse in pause overlay (#35717)

  Closes https://github.com/ppy/osu-resources/issues/393.
  
  Matches break overlay:
  
  https://github.com/ppy/osu/blob/5dc44fbdf9dfaff573f596b0085a954c6f420e07/osu.Game/Screens/Play/Break/BreakInfo.cs#L48

  Bartłomiej Dach · 2025-11-17 20:01:27 +09:00
  214122f633
• Add pooling support to smoke segments

  - Closes https://github.com/ppy/osu/issues/35703
  - Supersedes / closes https://github.com/ppy/osu/pull/35711
  
  Can test using something dumb like
  
  diff --git a/osu.Game/Skinning/LegacySkin.cs b/osu.Game/Skinning/LegacySkin.cs
  index 11b3b5c71d..e21d8389ef 100644
  --- a/osu.Game/Skinning/LegacySkin.cs
  +++ b/osu.Game/Skinning/LegacySkin.cs
  @@ -8,6 +8,7 @@
   using System.Globalization;
   using System.IO;
   using System.Linq;
  +using System.Threading;
   using JetBrains.Annotations;
   using osu.Framework.Audio.Sample;
   using osu.Framework.Bindables;
  @@ -540,6 +541,10 @@ protected override void ParseConfigurationStream(Stream stream)
                   case "Menu/fountain-star":
                       componentName = "star2";
                       break;
  +
  +                case "cursor-smoke":
  +                    Thread.Sleep(500);
  +                    break;
               }
  
               Texture? texture = null;

  Bartłomiej Dach · 2025-11-17 11:58:28 +01:00
  76c0bd4750
• Merge pull request #35714 from smoogipoo/fix-preview-track-owners

  Fix various screens not registering themselves as `IPreviewTrackOwner`

  Bartłomiej Dach · 2025-11-17 08:52:43 +01:00
  4bf3d9397f
• Split quickplay beatmap & "random" panel into separate classes (V2) (#35701)

  * Load all beatmaps in bulk for SubScreenBeatmapSelect
  
  * Fix tests no longer working due to drawable changes
  
  * Remove test that no longer makes sense
  
  * Split matchmaking panel into subclasses for each panel type
  
  * Adjust tests to match new structure
  
  * Add `ConfigureAwait`
  
  * Display loading spinner while beatmaps are being fetched
  
  * Fix test failure
  
  * Load playlist items directly in `LoadComplete`
  
  * Convert `MatchmakingSelectPanel` card content classes into nested classes
  
  * Wait for panels to be loaded before operating on them
  
  * Add ConfigureAwait()
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  maarvin · 2025-11-17 14:11:07 +09:00
  8b778e8106
• Fix various screens not registering themselves as IPreviewTrackOwner
  Dan Balasescu · 2025-11-17 13:34:02 +09:00
  ce5e54c9d2
• Merge pull request #35702 from nekodex/matchmaking-random-reveal-sfx

  Add SFX to the matchmaking roulette random reveal

  Dean Herbert · 2025-11-16 21:23:57 +09:00
  45e8df7af2
• Update resources
  Dean Herbert · 2025-11-16 20:22:21 +09:00
  1c30cb8371
• Fix several issues with incorrect sample playback (#35685)

  * Add failing test coverage for layered hit samples not playing in mania when beatmap is converted
  
  Adding the `osu.Game.Rulesets.Osu` reference to the mania test project
  is required so that `HitObjectSampleTest` base logic doesn't die on
  
  https://github.com/ppy/osu/blob/f0aeeeea966f06add12cf2bca3dd48dac8573e82/osu.Game/Tests/Beatmaps/HitObjectSampleTest.cs#L88-L91
  
  * Fix layered hit sounds not playing on converted beatmaps in mania
  
  Compare
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/HitObject.cs#L476-L477.
  
  In case of converted beatmaps, the last condition there
  (`BeatmapManager.Current.PlayMode != PlayModes.OsuMania`) fails,
  and thus layered hitsounds are allowed to play.
  
  * Add failing test coverage for mania beatmap conversion assigning wrong samples to spinners
  
  * Fix mania beatmap conversion assigning wrong samples to spinners
  
  A spinner is never `IHasRepeats`. It was a dead condition, leading to
  the hitobject generating fallback `NodeSamples`, which in particular
  feature a silent tail which stable doesn't do.
  
  Noticeably, stable also appears to force the head of the generated hold
  note to have no addition sounds:
  
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/Mania/SpinnerMania.cs#L86-L89
  
  * Add failing test coverage for file hit sample not falling back to plain samples if file missing
  
  * Allow `FileHitSampleInfo` to fall back to standard samples if the file is not found (or not allowed to be looked up)
  
  I'm honestly not 100% as to how closely this matches stable because I
  reached the point wherein I'd rather not look at stable code anymore, so
  as long as this passes tests I'm fine to wait for someone else to report
  new breakage.
  
  * Use alternative workaround for lack of osu! ruleset assembly in mania test project
  
  * Fix encode stability test failures

  Bartłomiej Dach · 2025-11-15 16:19:08 +09:00
  bd4ed49c06
• Separate bindables and centering logic for windowed resolution changes.
  Kawaritai · 2025-11-15 05:43:22 +11:00
  1e91dde92e
• Merge pull request #35682 from bdach/nom-nom-tasty-exceptions
  Dean Herbert · 2025-11-14 19:36:09 +09:00
  a593a40429
• Add SFX to the matchmaking roulette random reveal
  Jamie Taylor · 2025-11-14 19:20:56 +09:00
  02b88de76e
• Separate fullscreen/windowed dropdowns. Center window on size change.
  Kawaritai · 2025-11-14 09:48:32 +11:00
  435cd272ea
• Alleviate song select post-filter update thread hitches by caching a model-to-carousel-item mapping (#35628)
  Bartłomiej Dach · 2025-11-13 23:21:14 +09:00
  b64abbf1f5
• Improve loading time of collection grouping mode (#35693)

  Supersedes / closes https://github.com/ppy/osu/pull/35687.
  
  Implements idea from
  https://github.com/ppy/osu/pull/35687#issuecomment-3520613982, except
  without the additional record, because there's no need for it.
  
  Co-authored-by: WitherFlower <maxime.barniaudy@gmail.com>

  Bartłomiej Dach · 2025-11-13 14:10:24 +09:00
  4265e72180
• Add window sizes in dropdown menu options
  Kawaritai · 2025-11-12 06:51:55 +11:00
  72507b80c7
• Move realm collection writes off of update thread (#35681)

  Probably closes https://github.com/ppy/osu/issues/35650.
  
  Realm slow, episode 23894. I can't reproduce freezes as big as the video
  in the issue is showing but 'realm slow' is 99% the culprit, because
  affected user's database is not small.

  Bartłomiej Dach · 2025-11-11 20:29:39 +09:00
  cb9d9734d6
• Fix skin layout deserialisation eating exceptions without logging

  Because I just wasted 30 minutes trying to debug why a skin provided by
  a user in an issue thread was failing to deserialise, only to realise
  halfway through that the deserialisation error I was seeing was *from
  the fallback path and thus a complete red herring*.

  Bartłomiej Dach · 2025-11-11 10:24:30 +01:00
  5763b7dbe9
• Update framework
  Dean Herbert · 2025-11-11 18:00:15 +09:00
  e1baa03622