1178 Commits

• Fix code quality
  Bartłomiej Dach · 2025-04-24 08:54:10 +02:00
  72dd3513fc
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Add global screen margin for new screen designs
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  1cca936e28
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Hook up LocalConfig functions in OsuGameBase to make work in tests
  Dean Herbert · 2025-04-08 14:15:42 +09:00
  5fc80dbddb
• Tidy up flow for retrieving key binding representations
  Dean Herbert · 2025-04-08 14:12:58 +09:00
  4b038c3762
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Rename parameter
  GAMIS65 · 2025-03-14 10:06:28 +01:00
  c31fcb946b
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Simplify code and don't set title if already correct
  Dean Herbert · 2025-03-06 15:48:36 +09:00
  975f4e4c7d
• Update window title changes to match osu! stable

  It shows beatmap metadata during gameplay, spectating, and watching replays but shows beatmap filename during editng

  Zihad · 2025-03-06 01:36:59 +06:00
  02d19eaa55
• Skip updating window title for protected mapsets
  Zihad · 2025-03-05 22:47:39 +06:00
  d33a8dfc3b
• Remove unnecessary comment
  Zihad · 2025-03-05 21:41:11 +06:00
  4ae5f239cb
• Revert "Update window title in input thread"

  This reverts commit 14b5c0bf10.
  This is not necessary as the title update is already scheduled on the correct thread by the framework.

  Zihad · 2025-03-05 21:40:29 +06:00
  5feddae6c7
• Skip updating window title in headless mode
  Zihad · 2025-03-04 20:36:53 +06:00
  8ce6003a3e
• Update window title in input thread
  Zihad · 2025-03-04 19:56:48 +06:00
  14b5c0bf10
• Skip window title update for dummy beatmap
  Zihad · 2025-03-04 18:28:03 +06:00
  2abe75629e
• Show current beatmap info in window title
  Zihad · 2025-03-04 17:15:35 +06:00
  b5696f97a0
• Publicise base draw size property
  Salman Alshamrani · 2025-02-20 09:29:18 -05:00
  b4d270045b
• Change how values are applied to (hopefully) simplify things
  Dean Herbert · 2025-02-14 18:35:27 +09:00
  4e043e7cab
• Merge branch 'master' into ios-ui-scale
  Dean Herbert · 2025-02-14 18:22:47 +09:00
  74eae3cda3
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Remove OrientationManager and the entire mobile namespace
  Salman Alshamrani · 2025-01-25 20:01:18 -05:00
  c18128e974
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-24 17:03:00 +09:00
  56a611b47e
• Enable sentry caching to avoid sentry writing outside of game directory

  See https://github.com/ppy/osu/discussions/31412. Probably safe enough.

  Dean Herbert · 2025-01-20 23:45:39 +09:00
  6b524aba60
• Move bindables to OsuConfigManager & SessionStatics
  Dan Balasescu · 2025-01-16 19:33:42 +09:00
  8400726887
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-16 18:08:46 +09:00
  42e5cb58b7
• Merge pull request #31444 from smoogipoo/friend-presence-2

  Add notifications for when friends go online or offline

  Dean Herbert · 2025-01-14 18:58:19 +09:00
  b4d054fdc0
• Allow landscape orientation on tablet devices in osu!mania
  Salman Alshamrani · 2025-01-12 02:34:36 -05:00
  f718696102
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Display notification on friend presence changes
  Dan Balasescu · 2025-01-07 19:12:33 +09:00
  51b62a6d8e
• Always show dialog when clicking supporter icon before opening browser

  I managed to do this by accident three times today while testing using
  the dashboard display, so it's time to action on it.
  
  Touched on in
  https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996.
  Was also mentioned recently in discord or another discussion explicitly
  but I can't find that.

  Dean Herbert · 2025-01-06 17:51:04 +09:00
  4f1a6b4688
• Improve UI scale on iOS devices
  Salman Alshamrani · 2025-01-01 02:06:26 -05:00
  c221a0c9f9
• Allow locking orientation on iOS in certain circumstances
  Salman Alshamrani · 2024-12-29 22:15:21 -05:00
  7563a18c7f
• Remove duplicated block
  Dean Herbert · 2024-12-27 21:36:07 +09:00
  a9a5bb2c6a
• Fix volume adjust key repeat not working as expected

  Regressed in https://github.com/ppy/osu/pull/31146.
  
  Closes part of https://github.com/ppy/osu/issues/31267.

  Dean Herbert · 2024-12-26 15:05:59 +09:00
  e752531aec
• Merge pull request #31226 from frenzibyte/fix-raw-input-mobile

  Add `Hidden` cursor state flag on non-desktop platforms as well

  Dean Herbert · 2024-12-24 21:35:50 +09:00
  df3b300fff
• Merge pull request #31238 from frenzibyte/make-featured-artist-setting

  Save "featured artists" filter to user settings and disable toggling on iOS

  Dean Herbert · 2024-12-24 14:07:20 +09:00
  85f5234880
• Use virtual property rather than inline iOS conditional
  Dean Herbert · 2024-12-23 14:39:07 +09:00
  1a7feeb4ed
• Rename variable and adjust commentary
  Dean Herbert · 2024-12-22 23:58:35 +09:00
  0aed625bb8
• Remove redundant && true

  Co-authored-by: Susko3 <Susko3@protonmail.com>

  Dean Herbert · 2024-12-22 22:57:17 +09:00
  e716919a07
• Disable ability to toggle "featured artists" beatmap listing filter in iOS
  Salman Alshamrani · 2024-12-22 07:50:08 -05:00
  589e187a80
• Add Hidden cursor state flag on all platforms
  Salman Alshamrani · 2024-12-21 14:03:20 -05:00
  1c48fdb235
• Merge branch 'master' into christmas
  Dean Herbert · 2024-12-20 20:07:48 +09:00
  c16bfa010b
• Fix backwards repeat check
  Bartłomiej Dach · 2024-12-20 09:50:58 +01:00
  25373c3f9c
• Subclass osu logo instead of adding much code to it
  Dean Herbert · 2024-12-20 15:28:24 +09:00
  e5dbf9ce45
• Move "global" scroll-adjusts-volume to a per-screen component-based implementation
  Dean Herbert · 2024-12-16 15:21:07 +09:00
  bdd417c1a1