3481 Commits

• Merge pull request #32915 from peppy/carousel-update-handling

  Add basic support for beatmap updates in `BeatmapCarousel`

  Bartłomiej Dach · 2025-04-23 13:10:25 +02:00
  7cf8207e6e
• Merge pull request #32909 from bdach/fix-daily-challenge-marker

  Fix daily challenge marker text spacing

  Dean Herbert · 2025-04-23 18:24:56 +09:00
  0adda23988
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Fix increased spacing on fps counter tooltip
  Bartłomiej Dach · 2025-04-23 08:55:41 +02:00
  3f98dd93ed
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Merge pull request #32841 from frenzibyte/song-select-v2-shear-aligning-wrapper

  Add shear-aligning drawable wrapper

  Dean Herbert · 2025-04-22 16:43:35 +09:00
  4bc6b9b3a2
• Merge pull request #32840 from frenzibyte/song-select-v2-constants

  Prerequisite changes for song select v2 design work

  Dean Herbert · 2025-04-22 16:39:05 +09:00
  a0698be6c2
• Merge pull request #32839 from frenzibyte/song-select-v2-panel-metrics

  Use new font specifications in beatmap panels and apply minor adjustments

  Dean Herbert · 2025-04-22 16:35:11 +09:00
  3ba3f3ace7
• Merge pull request #32838 from peppy/carousel-group-counts

  Add accounting of nested group items for group panel display purposes

  Bartłomiej Dach · 2025-04-21 14:05:21 +02:00
  930c56e713
• Fix slider tooltip text not updating with current value
  schiavoanto · 2025-04-20 09:43:45 +02:00
  267dccdd9a
• Add drawable wrapper for shear alignment purposes
  Salman Alshamrani · 2025-04-18 06:32:00 -04:00
  f480765bf4
• Add accounting of nested group items for group panel display purposes
  Dean Herbert · 2025-04-18 19:07:44 +09:00
  b80ea26475
• Merge pull request #32820 from peppy/global-audio-offset-control-fixes

  Fix global offset adjust control showing adjustment available when it shouldn't

  Dean Herbert · 2025-04-18 18:04:18 +09:00
  21fd4e857f
• Move number formatting to extension method and reuse for AudioOffsetAdjustmentControl

  Also adds some basic test coverage.

  Dean Herbert · 2025-04-18 17:30:31 +09:00
  e44b134552
• Update framework
  Dean Herbert · 2025-04-18 16:26:37 +09:00
  b02ff0f95c
• Adjust sheared dropdown menu padding
  Salman Alshamrani · 2025-04-17 08:54:43 -04:00
  f93e731a55
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Disable masking of Carousel

  The default for carousels should be unmasked as their usage generally
  sees them overflowing outside their main usage area (see `bleed`
  variables).

  Dean Herbert · 2025-04-16 19:41:49 +09:00
  376b4e8929
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Merge pull request #32759 from peppy/status-pill-improvements

  Allow showing "unknown" state on status pill

  Bartłomiej Dach · 2025-04-14 09:03:12 +02:00
  cd3aa18213
• Remove conditional in difficulty spectrum retrieval function

  Wiil be handled locally instead using the diff in https://github.com/ppy/osu/pull/32764#discussion_r2039384833

  Salman Alshamrani · 2025-04-11 07:45:10 -04:00
  08c17bdf9e
• Define standard font sizes
  Salman Alshamrani · 2025-04-11 20:13:53 +09:00
  74227e7b79
• Update difficulty spectrum retrieval function
  Dean Herbert · 2025-04-11 17:58:27 +09:00
  c52dc9ffe8
• Add specifications for new song select icons
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  36a11d4bf7
• Add DarkOrange colour set
  Salman Alshamrani · 2025-04-11 02:25:12 +09:00
  55dc64e5b6
• Allow displaying "unknown" status in status pill
  Dean Herbert · 2025-04-10 23:42:29 +09:00
  57033fc180
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Adjust mouse down animation in a better way (and apply to small tag buttons too)
  Dean Herbert · 2025-04-03 19:19:06 +09:00
  2a3241fd48
• Fix chevron alignment in dropdown menu items
  Salman Alshamrani · 2025-03-27 23:11:15 -04:00
  0eb89f94f8
• Merge pull request #32532 from frenzibyte/sheared-dropdown

  Implement sheared dropdowns

  Dean Herbert · 2025-03-24 16:34:42 +09:00
  5b191dad8f
• Apply shearing to dropdown menu as well

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-03-24 02:18:11 -04:00
  4cd631f9f9
• Apply better fix for background bleeding

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Alshamrani · 2025-03-23 22:27:51 -04:00
  b2c9a572fa
• Fix images embedded in comments not displaying
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  655c799c58
• Add sheared dropdown
  Salman Alshamrani · 2025-03-22 22:49:34 -04:00
  25e404c734
• Merge pull request #32475 from peppy/fix-editor-toolbox-lag

  Fix lag when scrolling right-hand toolboxes in editor during long edit session

  Bartłomiej Dach · 2025-03-20 09:03:39 +01:00
  bd59078671
• Merge pull request #30866 from frenzibyte/image-proxying

  Fix some image attachments in comments not loading in game

  Dean Herbert · 2025-03-20 16:00:22 +09:00
  5183078801
• Avoid Triangles draw node invalidation when nothing is changing

  Basically only helps when time is paused. ie in the editor.

  Dean Herbert · 2025-03-20 15:51:13 +09:00
  b1131ffd23
• Merge pull request #32366 from GAMIS65/add-copy-version-button

  Allow copying version via right click in settings footer

  Dean Herbert · 2025-03-19 00:22:14 +09:00
  c9c60424a1
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Fix baseline misalignment in drawable comment link section

  `CommentReportButton` is pretty cursed but I guess I can see why it is
  like it is. Short of inlining it into `DrawableComment` this is probably
  the best escape hatch (which I wouldn't be against doing, by the way,
  just not sure it's the most productive use of time unless review
  feedback comes in saying that would be a better path forward).

  Bartłomiej Dach · 2025-03-17 08:53:53 +01:00
  3954d8f3be
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Merge branch 'master' into image-proxying
  Dean Herbert · 2025-03-13 12:33:36 +09:00
  80c896a895
• Fix OsuTextFlowContainer.AddArbitraryDrawable() not aligning the drawable correctly

  Closes https://github.com/ppy/osu/issues/32348.

  Bartłomiej Dach · 2025-03-12 13:21:04 +01:00
  17f964dc6b
• Adjust text flow usages to framework changes
  Bartłomiej Dach · 2025-03-11 10:43:35 +01:00
  e2e2383c50
• Disable button instead of hiding (and add tooltip)
  Dean Herbert · 2025-02-27 15:15:58 +09:00
  0b453772da
• Do not allow adding more than 8 combo colours in editor
  Bartłomiej Dach · 2025-02-26 11:24:06 +01:00
  6b76b8ccdd
• Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

  - Closes https://github.com/ppy/osu/issues/31888
  - Supersedes / closes https://github.com/ppy/osu/pull/32060

  Bartłomiej Dach · 2025-02-25 07:40:55 +01:00
  1f562ab47d
• Fix kiai fountains sometimes not displaying when they should

  The previous logic was very wrong, as the check would only occur on each
  beat. But that's not how kiai sections work – they can be placed at any
  timestamp, even if that doesn't align with a beat.
  
  In addition, the rate limiting has been removed because it didn't exist
  on stable and causes some fountains to be missed. Overlap scenarios are
  already handled internally by the `StarFountain` class.
  
  Closes https://github.com/ppy/osu/issues/31855.

  Dean Herbert · 2025-02-18 14:12:16 +09:00
  8e25c94452