1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-22 02:49:56 +08:00
Commit Graph

2 Commits

  • Convert gameplay leaderboard to skinnable component
    This PR converts the leaderboard into a full-fledged skinnable component
    that can be manipulated by users at will.
    
    Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
    be fixed - although it's a very mixed bag, for several reasons:
    
    - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
      keeping stable behaviours related to aspect ratio treatment, I have to
      assume the worst case scenario, which means than on typical
      resolutions like 16:9 (or even worse, 4:3), the leaderboard will
      likely not occupy as much vertical space as it probably could.
    
    - Additionally, there's the problem of where to put the spectator list.
      I settled on putting it to the right of the leaderboard, but that's
      kind of janky, because the leaderboard sometimes collapses and
      sometimes fully hides, leading to a very awkward space left behind. If
      we had the capability to anchor elements to other elements, maybe this
      could be resolved, but for now, I'm not sure what to do. I think if
      some users are bothered by it they can move it where they want it. Or
      delete it.
  • Add test scene coverage of HUD layouts on various ruleset/skin combinations
    As time goes on, default skin layouts are getting more and more
    complicated because of per-ruleset overrides. This was already sort of
    apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
    it worse, so before I do, this is a test scene that is supposed to make
    it easier to check all possible combinations at a glance.